[SSSD] [sssd PR#49][+Changes requested] Try to match multiple results from an AD initgroups request against domain's search bases, too

2016-10-27 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/49 Title: #49: Try to match multiple results from an AD initgroups request against domain's search bases, too Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To

[SSSD] [sssd PR#67][comment] UTIL: Unset O_NONBLOCK for ldap connection

2016-10-27 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/67 Title: #67: UTIL: Unset O_NONBLOCK for ldap connection lslebodn commented: """ > Thank you for digging into this and finding the connection to gnutls. Do you > think this is an issue which should be solved in OpenLDAP or gnutls as well, > or is it

[SSSD] [sssd PR#60][comment] Document ad_access_filter search for nested groups

2016-10-27 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/60 Title: #60: Document ad_access_filter search for nested groups sumit-bose commented: """ Just a small nitpick. Can you put the URL into a element like e.g. in https://github.com/SSSD/sssd/blob/master/src/man/sssd-ldap.5.xml#L1047 ? This will make

[SSSD] Re: Help : Tickets suitable for newcomers

2016-10-27 Thread Amit Kumar
Hey Fabiano, Thanks for update.. I have posted detailed steps for: 1. Getting source Code 2. Doing Code Changes 3. Running Integration Tests... on [https://github.com/SSSD/sssd/pull/60] if we can integrate them on contribute-link. That may help 1st timers in builiding, Running Integration

[SSSD] [sssd PR#67][comment] UTIL: Unset O_NONBLOCK for ldap connection

2016-10-27 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/67 Title: #67: UTIL: Unset O_NONBLOCK for ldap connection sumit-bose commented: """ Thank you for digging into this and finding the connection to gnutls. Do you think this is an issue which should be solved in OpenLDAP or gnutls as well, or is it really

[SSSD] [sssd PR#57][comment] LDAP/AD: resolve domain local groups for remote users

2016-10-27 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/57 Title: #57: LDAP/AD: resolve domain local groups for remote users jhrozek commented: """ Thank you, this version reads better to me and still works fine (adding and removing the global group as well..) So far ACK, I will push the patch once I'm able

[SSSD] [sssd PR#57][+Accepted] LDAP/AD: resolve domain local groups for remote users

2016-10-27 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/57 Title: #57: LDAP/AD: resolve domain local groups for remote users Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#60][comment] Document ad_access_filter search for nested groups

2016-10-27 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/60 Title: #60: Document ad_access_filter search for nested groups amitkumar50 commented: """ Thanks Islebodn . Conflicts are resolved.. Posting What I did may help some one. Steps for 1. Getting source Code 2. Doing Code Changes 3. Running

[SSSD] [sssd PR#62][comment] PAM: add pam_response_filter option

2016-10-27 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/62 Title: #62: PAM: add pam_response_filter option jhrozek commented: """ retest this please """ See the full comment at https://github.com/SSSD/sssd/pull/62#issuecomment-256572973 ___ sssd-devel mailing list

[SSSD] [sssd PR#67][comment] UTIL: Unset O_NONBLOCK for ldap connection

2016-10-27 Thread nmav
URL: https://github.com/SSSD/sssd/pull/67 Title: #67: UTIL: Unset O_NONBLOCK for ldap connection nmav commented: """ I don't quite understand what the fix is about nor how it relates to gnutls. Is it about wrong handling of the client socket? To know whether the issue is on the gnutls server,

[SSSD] [sssd PR#60][comment] Document ad_access_filter search for nested groups

2016-10-27 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/60 Title: #60: Document ad_access_filter search for nested groups jhrozek commented: """ The documentation now looks correct, I just wonder why did you remove the example paragraph in the last iteration of the patch? IMO it would be useful.. """ See the

[SSSD] [sssd PR#67][comment] UTIL: Unset O_NONBLOCK for ldap connection

2016-10-27 Thread nmav
URL: https://github.com/SSSD/sssd/pull/67 Title: #67: UTIL: Unset O_NONBLOCK for ldap connection nmav commented: """ I think from the above is clear that there must be some issue in the non-blocking support of libldap with gnutls, or that you are not using it properly. If you know you are

[SSSD] [sssd PR#39][comment] RESPONDER: Enable sudoRule in case insen. domains (1.13)

2016-10-27 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/39 Title: #39: RESPONDER: Enable sudoRule in case insen. domains (1.13) pbrezina commented: """ The patch looks good to me. I'd feel better if we somehow managed to backport patch that solves the fully qualified issue in 1.14 though. I'm not that sure

[SSSD] [sssd PR#48][closed] sssctl: Flags for commadn initialization

2016-10-27 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/48 Author: mzidek-rh Title: #48: sssctl: Flags for commadn initialization Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/48/head:pr48 git checkout pr48

[SSSD] [sssd PR#67][comment] UTIL: Unset O_NONBLOCK for ldap connection

2016-10-27 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/67 Title: #67: UTIL: Unset O_NONBLOCK for ldap connection lslebodn commented: """ > Could you explain what is the interaction between sssd and gnutls? Do you > pass the fd (which was set to non-blocking) or so to gnutls? There is not direct

[SSSD] Re: Help : Tickets suitable for newcomers

2016-10-27 Thread Pavel Březina
On 10/27/2016 08:31 AM, Amit Kumar wrote: Hey Fabiano, Thanks for update.. I have posted detailed steps for: 1. Getting source Code 2. Doing Code Changes 3. Running Integration Tests... Feel free to also checkout [1] and just run 'rebuild' when you want to build sssd. [1]

[SSSD] [sssd PR#67][comment] UTIL: Unset O_NONBLOCK for ldap connection

2016-10-27 Thread nmav
URL: https://github.com/SSSD/sssd/pull/67 Title: #67: UTIL: Unset O_NONBLOCK for ldap connection nmav commented: """ Could you explain what is the interaction between sssd and gnutls? Do you pass the fd (which was set to non-blocking) or so? """ See the full comment at

[SSSD] [sssd PR#67][comment] UTIL: Unset O_NONBLOCK for ldap connection

2016-10-27 Thread nmav
URL: https://github.com/SSSD/sssd/pull/67 Title: #67: UTIL: Unset O_NONBLOCK for ldap connection nmav commented: """ Could you explain what is the interaction between sssd and gnutls? Do you pass the fd (which was set to non-blocking) or so to gnutls? """ See the full comment at

[SSSD] [sssd PR#67][comment] UTIL: Unset O_NONBLOCK for ldap connection

2016-10-27 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/67 Title: #67: UTIL: Unset O_NONBLOCK for ldap connection lslebodn commented: """ and client + gnutls debug without O_NONBLOCK ``` (Thu Oct 27 11:37:03 2016) [sssd[be[LDAP]]] [simple_bind_send] (0x0100): Executing simple bind as:

[SSSD] [sssd PR#67][comment] UTIL: Unset O_NONBLOCK for ldap connection

2016-10-27 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/67 Title: #67: UTIL: Unset O_NONBLOCK for ldap connection lslebodn commented: """ client log + gnutls debug ``` (Thu Oct 27 11:20:35 2016) [sssd[be[LDAP]]] [simple_bind_send] (0x0100): Executing simple bind as: uid=mof_user1,dc=example,dc=com gnutls[5]:

[SSSD] [sssd PR#67][comment] UTIL: Unset O_NONBLOCK for ldap connection

2016-10-27 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/67 Title: #67: UTIL: Unset O_NONBLOCK for ldap connection lslebodn commented: """ client log + gnutls debug ``` (Thu Oct 27 11:49:01 2016) [sssd[be[LDAP]]] [simple_bind_send] (0x0100): Executing simple bind as: uid=mof_user1,dc=example,dc=com gnutls[5]:

[SSSD] [sssd PR#48][+Pushed] sssctl: Flags for commadn initialization

2016-10-27 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/48 Title: #48: sssctl: Flags for commadn initialization Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#46][comment] sss_client: Defer thread cancellation until completion of nss/pam operations

2016-10-27 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/46 Title: #46: sss_client: Defer thread cancellation until completion of nss/pam operations sumit-bose commented: """ Here is the original reproducer/test program from https://fedorahosted.org/sssd/ticket/1460 written by Fedora user werkt (I had to

[SSSD] [sssd PR#46][comment] sss_client: Defer thread cancellation until completion of nss/pam operations

2016-10-27 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/46 Title: #46: sss_client: Defer thread cancellation until completion of nss/pam operations sumit-bose commented: """ Here is the original reproducer/test program from https://fedorahosted.org/sssd/ticket/1460 written by Fedora user werkt (I had to

[SSSD] [sssd PR#48][comment] sssctl: Flags for commadn initialization

2016-10-27 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/48 Title: #48: sssctl: Flags for commadn initialization lslebodn commented: """ ACK """ See the full comment at https://github.com/SSSD/sssd/pull/48#issuecomment-256677906 ___ sssd-devel mailing list --

[SSSD] [sssd PR#67][comment] UTIL: Unset O_NONBLOCK for ldap connection

2016-10-27 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/67 Title: #67: UTIL: Unset O_NONBLOCK for ldap connection lslebodn commented: """ On (27/10/16 02:03), Nikos Mavrogiannopoulos wrote: >I don't quite understand what the fix is about nor how it relates to gnutls. >Is it about wrong handling of the client

[SSSD] [sssd PR#65][comment] Fixing of nitpicks

2016-10-27 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/65 Title: #65: Fixing of nitpicks jhrozek commented: """ On Tue, Oct 25, 2016 at 09:28:27AM -0700, lslebodn wrote: > lslebodn commented on this pull request. > > > > > @@ -1104,7 +1104,6 @@ bool sss_krb5_realm_has_proxy(const char *realm) > >

[SSSD] [sssd PR#48][comment] sssctl: Flags for commadn initialization

2016-10-27 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/48 Title: #48: sssctl: Flags for commadn initialization lslebodn commented: """ master: * cbee11e912bb391ba254b0bac8c1159c1f634533 sssd-1-14: * ec1829de7cd529c2c68b4bdb9b6d43ac6bb545d3 LS """ See the full comment at

[SSSD] [sssd PR#60][comment] Document ad_access_filter search for nested groups

2016-10-27 Thread taupehat
URL: https://github.com/SSSD/sssd/pull/60 Title: #60: Document ad_access_filter search for nested groups taupehat commented: """ @jhrozek I did not intend to remove anything from the last iteration. It's possible that I used the editor wrong. Do I need to delete the prior pull request and

[SSSD] [sssd PR#43][comment] RESPONDER: Enable sudoRule in case insen. domains​ (1.15)

2016-10-27 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/43 Title: #43: RESPONDER: Enable sudoRule in case insen. domains​ (1.15) jhrozek commented: """ On Thu, Oct 27, 2016 at 03:56:21AM -0700, Pavel Březina wrote: > pbrezina requested changes on this pull request. > > Hi, there is one indentation which can be

[SSSD] [sssd PR#68][comment] MAN: Document different defaults for AD provider

2016-10-27 Thread centos-ci
URL: https://github.com/SSSD/sssd/pull/68 Title: #68: MAN: Document different defaults for AD provider centos-ci commented: """ Can one of the admins verify this patch? """ See the full comment at https://github.com/SSSD/sssd/pull/68#issuecomment-256778566

[SSSD] [sssd PR#68][opened] MAN: Document different defaults for AD provider

2016-10-27 Thread justin-stephenson
URL: https://github.com/SSSD/sssd/pull/68 Author: justin-stephenson Title: #68: MAN: Document different defaults for AD provider Action: opened PR body: """ Update man pages for any AD provider config options that differ from ldap/krb5 provider back-end defaults. Resolves:

[SSSD] [sssd PR#68][comment] MAN: Document different defaults for AD provider

2016-10-27 Thread centos-ci
URL: https://github.com/SSSD/sssd/pull/68 Title: #68: MAN: Document different defaults for AD provider centos-ci commented: """ Can one of the admins verify this patch? """ See the full comment at https://github.com/SSSD/sssd/pull/68#issuecomment-256778568

[SSSD] Re: fedorahosted.org sunset

2016-10-27 Thread Jakub Hrozek
On Fri, Sep 16, 2016 at 12:21:40PM +0200, Lukas Slebodnik wrote: > +1 I can help with transition to Pagure. > git hosting is not a problem and Nikolai voluntered to > convert wiki to markdown in git Sorry to restart an old thread, but.. I bought the sssd.io domain name. The intent is to have a

[SSSD] Should we use VMs or containers for (some) tests?

2016-10-27 Thread Jakub Hrozek
Hi, I'm currently working on integration tests for the 'files' provider and during this work I started to feel we are pushing the boundaries around our test infrastructure already quite a bit. When SSSD talks over network to a server, then we're more or less okay, but for some parts of SSSD, like