[SSSD] [sssd PR#484][comment] SDAP: skip builtin AD groups in sdap_save_grpmem()

URL: https://github.com/SSSD/sssd/pull/484 Title: #484: SDAP: skip builtin AD groups in sdap_save_grpmem() fidencio commented: """ @sumit-bose, is it only visible with direct AD integration or can I use an IPA-AD trust setup to test it? """ See the full comment at

[SSSD] Re: Every PR should come with a test.

On Wed, Jan 10, 2018 at 10:04:49AM +0100, Fabiano Fidêncio wrote: > People, > > Ideally every PR should come with a test (unit, integration, ...), but > unfortunately we're a little bit far from the ideal situation. Thus, I'd > like to ask whether we have documented somewhere (apart from our code

[SSSD] Re: Every PR should come with a test.

On Wed, Jan 10, 2018 at 02:51:26PM +0100, Fabiano Fidêncio wrote: > On Wed, Jan 10, 2018 at 2:28 PM, Jakub Hrozek wrote: > > > On Wed, Jan 10, 2018 at 10:52:56AM +0100, Sumit Bose wrote: > > > On Wed, Jan 10, 2018 at 10:04:49AM +0100, Fabiano Fidêncio wrote: > > > > People, >

[SSSD] [sssd PR#470][closed] IPA: Enable periodic subdomains refresh only after responder-induced refresh finishes

URL: https://github.com/SSSD/sssd/pull/470 Author: jhrozek Title: #470: IPA: Enable periodic subdomains refresh only after responder-induced refresh finishes Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/470/head:pr470

[SSSD] [sssd PR#484][+Pushed] SDAP: skip builtin AD groups in sdap_save_grpmem()

URL: https://github.com/SSSD/sssd/pull/484 Title: #484: SDAP: skip builtin AD groups in sdap_save_grpmem() Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#484][comment] SDAP: skip builtin AD groups in sdap_save_grpmem()

URL: https://github.com/SSSD/sssd/pull/484 Title: #484: SDAP: skip builtin AD groups in sdap_save_grpmem() lslebodn commented: """ master: * c36a66b7fb77cff29400c751b363a342923e122e """ See the full comment at https://github.com/SSSD/sssd/pull/484#issuecomment-356685388

[SSSD] [sssd PR#485][comment] Support alternative sources for the files provider

URL: https://github.com/SSSD/sssd/pull/485 Title: #485: Support alternative sources for the files provider pbrezina commented: """ The option names should drop the `alt` prefix since they default to `/etc/passwd` and `/etc/group` which are not default at all. So it should rather be called

[SSSD] [sssd PR#476][comment] IPA: Handle empty nisDomainName

URL: https://github.com/SSSD/sssd/pull/476 Title: #476: IPA: Handle empty nisDomainName fidencio commented: """ > I wonder here if @lslebodn could not have asked about unit/integration tests > as the first thing saving thus the time of other reviewers. I'm sorry, because I did **not** express

[SSSD] [sssd PR#470][+Accepted] IPA: Enable periodic subdomains refresh only after responder-induced refresh finishes

URL: https://github.com/SSSD/sssd/pull/470 Title: #470: IPA: Enable periodic subdomains refresh only after responder-induced refresh finishes Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an

[SSSD] [sssd PR#484][comment] SDAP: skip builtin AD groups in sdap_save_grpmem()

URL: https://github.com/SSSD/sssd/pull/484 Title: #484: SDAP: skip builtin AD groups in sdap_save_grpmem() sumit-bose commented: """ @fidencio, iirc the issue was found with direct integration but it should be visible on an IPA server as well. """ See the full comment at

[SSSD] [sssd PR#470][comment] IPA: Enable periodic subdomains refresh only after responder-induced refresh finishes

URL: https://github.com/SSSD/sssd/pull/470 Title: #470: IPA: Enable periodic subdomains refresh only after responder-induced refresh finishes mzidek-rh commented: """ I checked the coding guidelines if there is something about upper-cased constants and did not find anything, so I guess it was

[SSSD] [sssd PR#484][comment] SDAP: skip builtin AD groups in sdap_save_grpmem()

URL: https://github.com/SSSD/sssd/pull/484 Title: #484: SDAP: skip builtin AD groups in sdap_save_grpmem() fidencio commented: """ Okay, I've been able to reproduce it with the direct AD integration by doing: - AD side: - Create an AD group (its Group scope is set as "Global" and its Group

[SSSD] [sssd PR#484][+Accepted] SDAP: skip builtin AD groups in sdap_save_grpmem()

URL: https://github.com/SSSD/sssd/pull/484 Title: #484: SDAP: skip builtin AD groups in sdap_save_grpmem() Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] Re: Every PR should come with a test.

On Wed, Jan 10, 2018 at 2:28 PM, Jakub Hrozek wrote: > On Wed, Jan 10, 2018 at 10:52:56AM +0100, Sumit Bose wrote: > > On Wed, Jan 10, 2018 at 10:04:49AM +0100, Fabiano Fidêncio wrote: > > > People, > > > > > > Ideally every PR should come with a test (unit, integration,

[SSSD] [sssd PR#476][-Changes requested] IPA: Handle empty nisDomainName

URL: https://github.com/SSSD/sssd/pull/476 Title: #476: IPA: Handle empty nisDomainName Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#476][comment] IPA: Handle empty nisDomainName

URL: https://github.com/SSSD/sssd/pull/476 Title: #476: IPA: Handle empty nisDomainName lslebodn commented: """ I did not require any changes in PR. I only asked trivial question because I do not know the answer. Therefore removing label changed requested """ See the full comment at

[SSSD] [sssd PR#484][comment] SDAP: skip builtin AD groups in sdap_save_grpmem()

URL: https://github.com/SSSD/sssd/pull/484 Title: #484: SDAP: skip builtin AD groups in sdap_save_grpmem() fidencio commented: """ Just a note ... I'm not sure if the test I've done is the right one, but that was the way I've managed to reproduce the issue. Weirdly I can't see the debug

[SSSD] [sssd PR#489][opened] libnfsidmap: Use public plugin header file if available

URL: https://github.com/SSSD/sssd/pull/489 Author: lslebodn Title: #489: libnfsidmap: Use public plugin header file if available Action: opened PR body: """ libnfsidmap was merged with nfs-utils in 2.1.2-rc7. We used private internal interface but required internal functions were dropped in

[SSSD] Re: Every PR should come with a test.

On Wed, Jan 10, 2018 at 10:52:56AM +0100, Sumit Bose wrote: > On Wed, Jan 10, 2018 at 10:04:49AM +0100, Fabiano Fidêncio wrote: > > People, > > > > Ideally every PR should come with a test (unit, integration, ...), but > > unfortunately we're a little bit far from the ideal situation. Thus, I'd >

[SSSD] [sssd PR#487][comment] SYSDB: Fix sysdb_search_by_name() for looking up groups in MPG domains

URL: https://github.com/SSSD/sssd/pull/487 Title: #487: SYSDB: Fix sysdb_search_by_name() for looking up groups in MPG domains pbrezina commented: """ LGTM. A comment in the if would be nice. Also having `sysdb_domain_base_dn` similar to what we have for user/group would be nicer. """ See

[SSSD] [sssd PR#484][comment] SDAP: skip builtin AD groups in sdap_save_grpmem()

URL: https://github.com/SSSD/sssd/pull/484 Title: #484: SDAP: skip builtin AD groups in sdap_save_grpmem() fidencio commented: """ > Just a note ... I'm not sure if the test I've done is the right one, but that > was the way I've managed to reproduce the issue. Weirdly I can't see the > debug

[SSSD] Re: Design page: Automatic private group creation for the LDAP provider

On Sat, Oct 21, 2017 at 11:30:16PM +0200, Jakub Hrozek wrote: > On Tue, Oct 10, 2017 at 09:42:16PM +0200, Jakub Hrozek wrote: > > Hi, > > > > I wrote a design page about exposing the functionality that creates the > > user private groups based on the user entry only: > > > >

[SSSD] [sssd PR#476][comment] IPA: Handle empty nisDomainName

URL: https://github.com/SSSD/sssd/pull/476 Title: #476: IPA: Handle empty nisDomainName fidencio commented: """ Adding the "Changes Requested" label as per @lslebodn's review. I wonder here if @lslebodn could not have asked about unit/integration tests as the first thing saving thus the time

[SSSD] [sssd PR#484][comment] SDAP: skip builtin AD groups in sdap_save_grpmem()

URL: https://github.com/SSSD/sssd/pull/484 Title: #484: SDAP: skip builtin AD groups in sdap_save_grpmem() sumit-bose commented: """ @fidencio, on the AD side you have to add a group from the BUILTIN domain, e.g. 'Users' or 'Administrators', to a normal security group which can be read by