URL: https://github.com/SSSD/sssd/pull/898
Author: alexey-tikhonov
Title: #898: util/server: amended close_low_fds()
Action: opened
PR body:
"""
Rewrote close_low_fds() to use freopen() as it fits better here
and some flags passed to open() previously didn't make a sense.
Also fixed a number
URL: https://github.com/SSSD/sssd/pull/860
Title: #860: Prepare for multiple enumeration providers
pbrezina commented:
"""
Ack. Thank you.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/860#issuecomment-541011207
___
sssd-devel mailing
URL: https://github.com/SSSD/sssd/pull/860
Title: #860: Prepare for multiple enumeration providers
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
URL: https://github.com/SSSD/sssd/pull/860
Title: #860: Prepare for multiple enumeration providers
Label: +Ready to push
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahoste
URL: https://github.com/SSSD/sssd/pull/860
Title: #860: Prepare for multiple enumeration providers
Label: -Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorah
URL: https://github.com/SSSD/sssd/pull/578
Title: #578: proxy: proxy_child hardening
alexey-tikhonov commented:
"""
Hi @amitkumar50,
I am not sure if you are still interested in this PR.
But if so:
1) please see comments I have left inline
2) don't you mind to update commit message please? It
URL: https://github.com/SSSD/sssd/pull/578
Title: #578: proxy: proxy_child hardening
alexey-tikhonov commented:
"""
Hi @amitkumar50,
I am not sure if you are still interested in this PR.
But if so:
1) please see comments I have left inline
2) don't you mind to update commit message please? It
URL: https://github.com/SSSD/sssd/pull/889
Title: #889: Improves `sssd_nss` debug (#4080)
Label: -Waiting for review
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.or
URL: https://github.com/SSSD/sssd/pull/889
Title: #889: Improves `sssd_nss` debug (#4080)
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora C
URL: https://github.com/SSSD/sssd/pull/897
Title: #897: db: fix potential memory leak in sysdb_store_selinux_config
alexey-tikhonov commented:
"""
Nitpick:
IMO, it would be slightly better performance-wise to simply move
```
if (!order) {
DEBUG(SSSDBG_CRIT_FAILURE, "The SELinux order is miss
URL: https://github.com/SSSD/sssd/pull/897
Title: #897: db: fix potential memory leak in sysdb_store_selinux_config
Label: -Waiting for review
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-l
URL: https://github.com/SSSD/sssd/pull/897
Title: #897: db: fix potential memory leak in sysdb_store_selinux_config
alexey-tikhonov commented:
"""
Covscan is fine as well.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/897#issuecomment-541087953
_
URL: https://github.com/SSSD/sssd/pull/891
Title: #891: IPA: Utilize new protocol in IPA extdom plugin
Label: +Waiting for review
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fe
URL: https://github.com/SSSD/sssd/pull/883
Author: alexey-tikhonov
Title: #883: Minor fixes to util/sss_krb5
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/883/head:pr883
git checkout pr883
From b3139657d13a6bdf6555f0
URL: https://github.com/SSSD/sssd/pull/851
Title: #851: Update __init__.py.in
alexal commented:
"""
@pbrezina ,
Just wondering if you had a chance to review the code?
Thanks!
"""
See the full comment at
https://github.com/SSSD/sssd/pull/851#issuecomment-541138115
URL: https://github.com/SSSD/sssd/pull/883
Title: #883: Minor fixes to util/sss_krb5
alexey-tikhonov commented:
"""
Hi @sumit-bose,
please take a look at another attempt.
To address your second remark I have introduced `sss_printable_keytab_name()`
helper.
If its impl is ok then I think we sh
URL: https://github.com/SSSD/sssd/pull/883
Title: #883: Minor fixes to util/sss_krb5
Label: +Waiting for review
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fed
URL: https://github.com/SSSD/sssd/pull/883
Title: #883: Minor fixes to util/sss_krb5
Label: -Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedo
URL: https://github.com/SSSD/sssd/pull/883
Title: #883: Minor fixes to util/sss_krb5
alexey-tikhonov commented:
"""
I also think it is possible to stop trying different `primary`&`realm` after
first fatal (i.e. not KRB5_KT_NOTFOUND) error returned by
`find_principal_in_keytab()`.
But not sure
19 matches
Mail list logo
