URL: https://github.com/SSSD/sssd/pull/334
Title: #334: Print a warning when enumeration is requested but disabled
lslebodn commented:
"""
master:
* c33fa33065b1211dba5ea2909bac62843a72e8b5
"""
See the full comment at
https://github.com/SSSD/sssd/pull/334#issuecomment-331867769
___
URL: https://github.com/SSSD/sssd/pull/334
Title: #334: Print a warning when enumeration is requested but disabled
lslebodn commented:
"""
Following coding style issue fixed before push:
```
diff --git a/src/confdb/confdb.c b/src/confdb/confdb.c
index 4d55b38a1..b01306ab6 100644
--- a/src/confdb
URL: https://github.com/SSSD/sssd/pull/334
Title: #334: Print a warning when enumeration is requested but disabled
jhrozek commented:
"""
This works fine. I just noticed a missing space after opening `(` but I don't
think it's worth requesting another patch version:
```
if(cr->rctx->enumeration
URL: https://github.com/SSSD/sssd/pull/334
Title: #334: Print a warning when enumeration is requested but disabled
amitkumar50 commented:
"""
@jhrozek Done rebase, squash, push -f.
Thanks
"""
See the full comment at
https://github.com/SSSD/sssd/pull/334#issuecomment-330823636
_
URL: https://github.com/SSSD/sssd/pull/334
Title: #334: Print a warning when enumeration is requested but disabled
jhrozek commented:
"""
The patches now look good, but please squash the three commits into a single
one so I can push a single patch.
You can run `git rebase -i origin/master` in
URL: https://github.com/SSSD/sssd/pull/334
Title: #334: Print a warning when enumeration is requested but disabled
amitkumar50 commented:
"""
@jhrozek Done changes thanks.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/334#issuecomment-330189578
_
URL: https://github.com/SSSD/sssd/pull/334
Title: #334: Print a warning when enumeration is requested but disabled
jhrozek commented:
"""
after the call to sss_log and before the call you check if it had been already
set, if it was, don't log another time.
"""
See the full comment at
https://
URL: https://github.com/SSSD/sssd/pull/334
Title: #334: Print a warning when enumeration is requested but disabled
amitkumar50 commented:
"""
@jhrozek
./src/responder/common/responder.h
struct resp_ctx {
..
bool enumeration_warn_logged;
};
./src/responder/common/cache_req/cac
URL: https://github.com/SSSD/sssd/pull/334
Title: #334: Print a warning when enumeration is requested but disabled
amitkumar50 commented:
"""
@jhrozek
./src/responder/common/responder.h
struct resp_ctx {
..
bool enumeration_warn_logged;
};
./src/responder/common/cache_req/cac
URL: https://github.com/SSSD/sssd/pull/334
Title: #334: Print a warning when enumeration is requested but disabled
amitkumar50 commented:
"""
@jhrozek Working on this..
"""
See the full comment at
https://github.com/SSSD/sssd/pull/334#issuecomment-327140877
URL: https://github.com/SSSD/sssd/pull/334
Title: #334: Print a warning when enumeration is requested but disabled
jhrozek commented:
"""
Hi @amitkumar50 do you need any help with this PR?
"""
See the full comment at
https://github.com/SSSD/sssd/pull/334#issuecomment-326985500
URL: https://github.com/SSSD/sssd/pull/334
Title: #334: Print a warning when enumeration is requested but disabled
jhrozek commented:
"""
Here's how I would go about the warning:
- add a boolean into struct rctx, something like 'enumeration_warn_logged"
- when the code reaches `cache_req_valid
URL: https://github.com/SSSD/sssd/pull/334
Title: #334: Print a warning when enumeration is requested but disabled
amitkumar50 commented:
"""
@jhrozek Can you please review this PR as well and provide your suggestions?
"""
See the full comment at
https://github.com/SSSD/sssd/pull/334#issuecomm
URL: https://github.com/SSSD/sssd/pull/334
Title: #334: Print a warning when enumeration is requested but disabled
amitkumar50 commented:
"""
@lslebodn I believe you want to log message on return path when Backend says
Nss responder to write data in Memcache.
Something this is there in domain-l
URL: https://github.com/SSSD/sssd/pull/334
Title: #334: Print a warning when enumeration is requested but disabled
lslebodn commented:
"""
On (07/08/17 10:55), AmitKumar wrote:
>@lslebodn Thanks for information
>>src/responder/common/cache_req/plugins/cache_req_enum_users.c
>>src/responder/commo
URL: https://github.com/SSSD/sssd/pull/334
Title: #334: Print a warning when enumeration is requested but disabled
amitkumar50 commented:
"""
@lslebodn Thanks for information
>src/responder/common/cache_req/plugins/cache_req_enum_users.c
>src/responder/common/cache_req/plugins/cache_req_enum_gro
URL: https://github.com/SSSD/sssd/pull/334
Title: #334: Print a warning when enumeration is requested but disabled
lslebodn commented:
"""
On (03/08/17 12:43), AmitKumar wrote:
>@lslebodn
>In that case will it be good to add this `DEBUG` inside
>`sss_nss_make_request()`
>But IMHO I believe thi
URL: https://github.com/SSSD/sssd/pull/334
Title: #334: Print a warning when enumeration is requested but disabled
fidencio commented:
"""
@amitkumar50, @lslebodn is a more experienced developer than I am and he knows
better this part of the code than I do.
I sincerely would NOT take my previo
URL: https://github.com/SSSD/sssd/pull/334
Title: #334: Print a warning when enumeration is requested but disabled
amitkumar50 commented:
"""
@lslebodn
In that case will it be good to add this `DEBUG` inside `sss_nss_make_request()`
But IMHO I believe this would not satisfy
> fidencio's statem
URL: https://github.com/SSSD/sssd/pull/334
Title: #334: Print a warning when enumeration is requested but disabled
lslebodn commented:
"""
On (31/07/17 10:56), AmitKumar wrote:
>@lslebodn @fidencio
>> log the message in the code path triggered by getent passwd
>
>1. On Ticket dpal suggested "Th
URL: https://github.com/SSSD/sssd/pull/334
Title: #334: Print a warning when enumeration is requested but disabled
amitkumar50 commented:
"""
@lslebodn @fidencio
> log the message in the code path triggered by getent passwd
1. On Ticket dpal suggested "The message should be logged once at the
URL: https://github.com/SSSD/sssd/pull/334
Title: #334: Print a warning when enumeration is requested but disabled
fidencio commented:
"""
@amitkumar50, I guess you misunderstood @lslebodn's comment and I have to agree
with him.
You're logging the message when SSSD is started. In other words,
URL: https://github.com/SSSD/sssd/pull/334
Title: #334: Print a warning when enumeration is requested but disabled
amitkumar50 commented:
"""
@lslebodn
About your comment
> And message is not logged when "enumeration is requested" but when "sssd is
> started".
Why I believe logging this when "
URL: https://github.com/SSSD/sssd/pull/334
Title: #334: Print a warning when enumeration is requested but disabled
amitkumar50 commented:
"""
@lslebodn
About your comment
> And message is not logged when "enumeration is requested" but when "sssd is
> started".
Why I believe logging this when
URL: https://github.com/SSSD/sssd/pull/334
Title: #334: Print a warning when enumeration is requested but disabled
lslebodn commented:
"""
> Patch looks good to me and also addresses @lslebodn's comment.
Maybe partially.
I am still not persuaded that it is the best solution for ticket
https:/
URL: https://github.com/SSSD/sssd/pull/334
Title: #334: Print a warning when enumeration is requested but disabled
lslebodn commented:
"""
> Patch looks good to me and also addresses @lslebodn's comment.
Maybe partially.
I am still not persuaded that it is the best solution for ticket
https:/
URL: https://github.com/SSSD/sssd/pull/334
Title: #334: Print a warning when enumeration is requested but disabled
fidencio commented:
"""
Patch looks good to me and also addresses @lslebodn's comment.
ACK!
"""
See the full comment at
https://github.com/SSSD/sssd/pull/334#issuecomment-31875125
URL: https://github.com/SSSD/sssd/pull/334
Title: #334: Print a warning when enumeration is requested but disabled
amitkumar50 commented:
"""
@fidencio Done
"""
See the full comment at
https://github.com/SSSD/sssd/pull/334#issuecomment-318613367
___
URL: https://github.com/SSSD/sssd/pull/334
Title: #334: Print a warning when enumeration is requested but disabled
fidencio commented:
"""
@amitkumar50, please, mind the indentation.
I've mentioned that in a few other reviews, already. Seems to me you're using
tabs for indentation while we do
URL: https://github.com/SSSD/sssd/pull/334
Title: #334: Print a warning when enumeration is requested but disabled
amitkumar50 commented:
"""
@fidencio Changes Done.. Thanks for Comments!!
"""
See the full comment at
https://github.com/SSSD/sssd/pull/334#issuecomment-318596965
URL: https://github.com/SSSD/sssd/pull/334
Title: #334: Print a warning when enumeration is requested but disabled
amitkumar50 commented:
"""
> "Please, note that when enumeration is disabled getent passwd does not
> return all users by design. See sssd.conf man page for more detailed
> infor
URL: https://github.com/SSSD/sssd/pull/334
Title: #334: Print a warning when enumeration is requested but disabled
fidencio commented:
"""
I basically agree with @lslebodn here. 'SSSDBG_CONF_SETTINGS' seems the
appropriate debug level to use.
Also, a review about the commit short-log and the c
URL: https://github.com/SSSD/sssd/pull/334
Title: #334: Print a warning when enumeration is requested but disabled
lslebodn commented:
"""
On (24/07/17 11:02), AmitKumar wrote:
>@lslebodn ...Ok... my point to lower the debug level was to print the message
>in most cases to prevent user from rai
URL: https://github.com/SSSD/sssd/pull/334
Title: #334: Print a warning when enumeration is requested but disabled
amitkumar50 commented:
"""
@fidencio Can you please kindly review..
"""
See the full comment at
https://github.com/SSSD/sssd/pull/334#issuecomment-317399829
__
URL: https://github.com/SSSD/sssd/pull/334
Title: #334: Print a warning when enumeration is requested but disabled
amitkumar50 commented:
"""
@lslebodn ...Ok... my point to lower the debug level was to print the message
in most cases to prevent user from raising an Bug.
But Then .. Will SSSDBG_
URL: https://github.com/SSSD/sssd/pull/334
Title: #334: Print a warning when enumeration is requested but disabled
lslebodn commented:
"""
On (24/07/17 10:25), AmitKumar wrote:
>Purpose of this PR is to add an explanatory message to be logged once at the
>start-up explaning that if enumeration
URL: https://github.com/SSSD/sssd/pull/334
Title: #334: Print a warning when enumeration is requested but disabled
centos-ci commented:
"""
Can one of the admins verify this patch?
"""
See the full comment at
https://github.com/SSSD/sssd/pull/334#issuecomment-317381737
URL: https://github.com/SSSD/sssd/pull/334
Title: #334: Print a warning when enumeration is requested but disabled
centos-ci commented:
"""
Can one of the admins verify this patch?
"""
See the full comment at
https://github.com/SSSD/sssd/pull/334#issuecomment-317381742
38 matches
Mail list logo
