[SSSD] [sssd PR#470][comment] IPA: Enable periodic subdomains refresh only after responder-induced refresh finishes

2018-01-10 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/470 Title: #470: IPA: Enable periodic subdomains refresh only after responder-induced refresh finishes mzidek-rh commented: """ I checked the coding guidelines if there is something about upper-cased constants and did not find anything, so I guess it was

[SSSD] [sssd PR#470][comment] IPA: Enable periodic subdomains refresh only after responder-induced refresh finishes

2018-01-09 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/470 Title: #470: IPA: Enable periodic subdomains refresh only after responder-induced refresh finishes jhrozek commented: """ On Tue, Jan 09, 2018 at 02:02:58PM +, sumit-bose wrote: > Thank you for the patch, it is working as expected. Without the

[SSSD] [sssd PR#470][comment] IPA: Enable periodic subdomains refresh only after responder-induced refresh finishes

2018-01-09 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/470 Title: #470: IPA: Enable periodic subdomains refresh only after responder-induced refresh finishes mzidek-rh commented: """ > I personally think 'const' is better then #define if we do not need to put > the constant into a header file. Sorry, I

[SSSD] [sssd PR#470][comment] IPA: Enable periodic subdomains refresh only after responder-induced refresh finishes

2018-01-09 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/470 Title: #470: IPA: Enable periodic subdomains refresh only after responder-induced refresh finishes mzidek-rh commented: """ Hi! I personally think 'const' is better then #define if we do not need to put the constant into a header file. Simply

[SSSD] [sssd PR#470][comment] IPA: Enable periodic subdomains refresh only after responder-induced refresh finishes

2018-01-09 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/470 Title: #470: IPA: Enable periodic subdomains refresh only after responder-induced refresh finishes sumit-bose commented: """ Thank you for the patch, it is working as expected. Without the patch 5 of 10 restart with immediate getent passwd

[SSSD] [sssd PR#470][comment] IPA: Enable periodic subdomains refresh only after responder-induced refresh finishes

2018-01-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/470 Title: #470: IPA: Enable periodic subdomains refresh only after responder-induced refresh finishes jhrozek commented: """ Sorry about the holiday delay. I pushed a new version which is much simpler because it just delays the first ptask. """ See the

[SSSD] [sssd PR#470][comment] IPA: Enable periodic subdomains refresh only after responder-induced refresh finishes

2017-12-14 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/470 Title: #470: IPA: Enable periodic subdomains refresh only after responder-induced refresh finishes jhrozek commented: """ Yes, a delay was another option I was considering. I just wasn't sure if this would maybe provide a race between the delayed

[SSSD] [sssd PR#470][comment] IPA: Enable periodic subdomains refresh only after responder-induced refresh finishes

2017-12-14 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/470 Title: #470: IPA: Enable periodic subdomains refresh only after responder-induced refresh finishes pbrezina commented: """ Ah, it is about a case when a trust was establish during sssd runtime. Discard my previous comment. Delay may work here. """

[SSSD] [sssd PR#470][comment] IPA: Enable periodic subdomains refresh only after responder-induced refresh finishes

2017-12-14 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/470 Title: #470: IPA: Enable periodic subdomains refresh only after responder-induced refresh finishes pbrezina commented: """ But responders perform GetDomains call on initial start up regardless whether a user have been requested or not. So if this is

[SSSD] [sssd PR#470][comment] IPA: Enable periodic subdomains refresh only after responder-induced refresh finishes

2017-12-14 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/470 Title: #470: IPA: Enable periodic subdomains refresh only after responder-induced refresh finishes pbrezina commented: """ @sumit-bose Do you remember why do we have periodic subdomain refresh in backend? Responders keep refreshing it anyway. """

[SSSD] [sssd PR#470][comment] IPA: Enable periodic subdomains refresh only after responder-induced refresh finishes

2017-12-13 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/470 Title: #470: IPA: Enable periodic subdomains refresh only after responder-induced refresh finishes jhrozek commented: """ On Wed, Dec 13, 2017 at 12:20:58PM +, mzidek-rh wrote: > I have a training today, so I am not sure if I will be able to

[SSSD] [sssd PR#470][comment] IPA: Enable periodic subdomains refresh only after responder-induced refresh finishes

2017-12-13 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/470 Title: #470: IPA: Enable periodic subdomains refresh only after responder-induced refresh finishes mzidek-rh commented: """ I have a training today, so I am not sure if I will be able to review and test this patch today or tomorrow, but I scrolled