[SSSD] [sssd PR#476][comment] IPA: Handle empty nisDomainName
URL: https://github.com/SSSD/sssd/pull/476 Title: #476: IPA: Handle empty nisDomainName jhrozek commented: """ The fix itself was pushed as 67645557dc0301e7ea66bba15c4ff3fb11f9540e and Sumit's test was pushed as 0f8add07b8257fcce9f62ad80d24e79b8013ae42. I filed a ticket about the python3 issue. """ See the full comment at https://github.com/SSSD/sssd/pull/476#issuecomment-372056009 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#476][comment] IPA: Handle empty nisDomainName
URL: https://github.com/SSSD/sssd/pull/476 Title: #476: IPA: Handle empty nisDomainName lslebodn commented: """ @sumit-bose, thank you very much for increasing test coverage. Initially I though that it could be included in sssd git using our internal python-multihost `src/tests/python/`. But it is not related where is the test but that such test exist. Test is ready so please push this PR. > https://pagure.io/fork/sbose/SSSD/sssd/c/859ab248be719eef5d84dbbed27f146f2aa162e8?branch=netgroup_tests That can be reviewed as a separate PR because that one is IPA specific. I know it is a little bit unrelated but I have few tips to your netgroup test. It can be simplified a little bit + such version would not work with python3 (because 'str' object has no attribute 'decode') please create separate pr and I'll add comments there. """ See the full comment at https://github.com/SSSD/sssd/pull/476#issuecomment-371296550 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#476][comment] IPA: Handle empty nisDomainName
URL: https://github.com/SSSD/sssd/pull/476 Title: #476: IPA: Handle empty nisDomainName lslebodn commented: """ @sumit-bose, thank you very much for increasing test coverage. Initially I though that it could be included in sssd git using our internal python-multihost `src/tests/python/`. But it is not related where is the test but that such test exist. Test is ready so please push this PR. > https://pagure.io/fork/sbose/SSSD/sssd/c/859ab248be719eef5d84dbbed27f146f2aa162e8?branch=netgroup_tests Thank can be safely created as a separate PR because that one is IPA specific. I know it is a little bit unrelated but I have few tips to your netgroup test. It can be simplified a little bit + such version would not work with python3 (because 'str' object has no attribute 'decode') please create separate pr and i'll add comments there. """ See the full comment at https://github.com/SSSD/sssd/pull/476#issuecomment-371296550 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#476][comment] IPA: Handle empty nisDomainName
URL: https://github.com/SSSD/sssd/pull/476 Title: #476: IPA: Handle empty nisDomainName sumit-bose commented: """ @jhrozek, please find some additional integration tests for netgroups where some components like the NIS domain name are missing at https://pagure.io/fork/sbose/SSSD/sssd/c/859ab248be719eef5d84dbbed27f146f2aa162e8?branch=netgroup_tests. Feel free to add it to your patch set. Since the original issue is in the IPA provider which is currently not used in the SSSD integration tests I prepared a patch for the IPA integration tests at https://pagure.io/fork/sbose/freeipa/c/9a2789ed643b9ec20aef7373ebb51342317af341?branch=netgroups_test. If the fixes are commited to SSSD I'll prepare an IPA PR with the patch. """ See the full comment at https://github.com/SSSD/sssd/pull/476#issuecomment-371144195 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#476][comment] IPA: Handle empty nisDomainName
URL: https://github.com/SSSD/sssd/pull/476 Title: #476: IPA: Handle empty nisDomainName sumit-bose commented: """ @jhrozek, please find some additional integration tests for netgroups where some components like the NIS domain name are missing at https://pagure.io/fork/sbose/SSSD/sssd/c/859ab248be719eef5d84dbbed27f146f2aa162e8?branch=netgroup_tests. Since the original issue is in the IPA provider which is currently not used in the SSSD integration tests I prepared a patch for the IPA integration tests at https://pagure.io/fork/sbose/freeipa/c/9a2789ed643b9ec20aef7373ebb51342317af341?branch=netgroups_test. If the fixes are commited to SSSD I'll prepare an IPA PR with the patch. """ See the full comment at https://github.com/SSSD/sssd/pull/476#issuecomment-371144195 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#476][comment] IPA: Handle empty nisDomainName
URL: https://github.com/SSSD/sssd/pull/476 Title: #476: IPA: Handle empty nisDomainName fidencio commented: """ @lslebodn, please, I've asked you before, please, **move on**. You have already caused enough damage by deliberately blocking my work (or anything I've tried to do in the project), offending me publicly in PRs ... I sincerely don't understand why a person who's **not** a maintainer of the project **nor** part of the team has the rights to be adding/removing labels. """ See the full comment at https://github.com/SSSD/sssd/pull/476#issuecomment-370954252 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#476][comment] IPA: Handle empty nisDomainName
URL: https://github.com/SSSD/sssd/pull/476 Title: #476: IPA: Handle empty nisDomainName lslebodn commented: """ I did not require any changes in PR. I only asked trivial question because I do not know the answer. Therefore removing label changed requested """ See the full comment at https://github.com/SSSD/sssd/pull/476#issuecomment-356595745 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#476][comment] IPA: Handle empty nisDomainName
URL: https://github.com/SSSD/sssd/pull/476 Title: #476: IPA: Handle empty nisDomainName fidencio commented: """ > I wonder here if @lslebodn could not have asked about unit/integration tests > as the first thing saving thus the time of other reviewers. I'm sorry, because I did **not** express my self in the proper way here. I've dropped an email to SSSD devel list about the subject [0] and hopefully we can keep the discussion there. [0]: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org/message/J63UKSULDPV4RIUSI3W7GQO4UFQGQ4DE/ """ See the full comment at https://github.com/SSSD/sssd/pull/476#issuecomment-356545022 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#476][comment] IPA: Handle empty nisDomainName
URL: https://github.com/SSSD/sssd/pull/476 Title: #476: IPA: Handle empty nisDomainName fidencio commented: """ Adding the "Changes Requested" label as per @lslebodn's review. I wonder here if @lslebodn could not have asked about unit/integration tests as the first thing saving thus the time of other reviewers. """ See the full comment at https://github.com/SSSD/sssd/pull/476#issuecomment-356530674 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#476][comment] IPA: Handle empty nisDomainName
URL: https://github.com/SSSD/sssd/pull/476 Title: #476: IPA: Handle empty nisDomainName lslebodn commented: """ There is neither unit test nor integration test in this PR and moreover upstream ticket is not linked to any downstream BZ? May I know who will write a regression test? """ See the full comment at https://github.com/SSSD/sssd/pull/476#issuecomment-356505076 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#476][comment] IPA: Handle empty nisDomainName
URL: https://github.com/SSSD/sssd/pull/476
Title: #476: IPA: Handle empty nisDomainName
fidencio commented:
"""
CI:http://vm-031.${abc}/logs/job/82/90/summary.html
"""
See the full comment at
https://github.com/SSSD/sssd/pull/476#issuecomment-356434161
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#476][comment] IPA: Handle empty nisDomainName
URL: https://github.com/SSSD/sssd/pull/476 Title: #476: IPA: Handle empty nisDomainName fidencio commented: """ Works as expected, no issues found by coverity and internal CI is running. In order to do thing by the booj, I'll add the "Accepted" label as soon as I get the results. """ See the full comment at https://github.com/SSSD/sssd/pull/476#issuecomment-356415156 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#476][comment] IPA: Handle empty nisDomainName
URL: https://github.com/SSSD/sssd/pull/476 Title: #476: IPA: Handle empty nisDomainName jhrozek commented: """ I described the steps to reproduce in the commit message, does that work for you? """ See the full comment at https://github.com/SSSD/sssd/pull/476#issuecomment-356090663 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#476][comment] IPA: Handle empty nisDomainName
URL: https://github.com/SSSD/sssd/pull/476 Title: #476: IPA: Handle empty nisDomainName fidencio commented: """ Patch looks good, although I don't know how to reproduce the issue. Would be possible to add steps to reproduce (either here or in the pagure issue)? ps: I'm not adding myself as a reviewer as I don't want to block someone else who knows how to reproduce the issue and can give a quicker ACK. I'm firing internal CI, coverity and so on. """ See the full comment at https://github.com/SSSD/sssd/pull/476#issuecomment-354714759 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
