[SSSD] Re: Every PR should come with a test.

2018-01-10 Thread Jakub Hrozek
On Wed, Jan 10, 2018 at 02:51:26PM +0100, Fabiano Fidêncio wrote: > On Wed, Jan 10, 2018 at 2:28 PM, Jakub Hrozek wrote: > > > On Wed, Jan 10, 2018 at 10:52:56AM +0100, Sumit Bose wrote: > > > On Wed, Jan 10, 2018 at 10:04:49AM +0100, Fabiano Fidêncio wrote: > > > > People, >

[SSSD] Re: Every PR should come with a test.

2018-01-10 Thread Fabiano Fidêncio
On Wed, Jan 10, 2018 at 2:28 PM, Jakub Hrozek wrote: > On Wed, Jan 10, 2018 at 10:52:56AM +0100, Sumit Bose wrote: > > On Wed, Jan 10, 2018 at 10:04:49AM +0100, Fabiano Fidêncio wrote: > > > People, > > > > > > Ideally every PR should come with a test (unit, integration,

[SSSD] Re: Every PR should come with a test.

2018-01-10 Thread Jakub Hrozek
On Wed, Jan 10, 2018 at 10:52:56AM +0100, Sumit Bose wrote: > On Wed, Jan 10, 2018 at 10:04:49AM +0100, Fabiano Fidêncio wrote: > > People, > > > > Ideally every PR should come with a test (unit, integration, ...), but > > unfortunately we're a little bit far from the ideal situation. Thus, I'd >

[SSSD] Re: Every PR should come with a test.

2018-01-10 Thread Sumit Bose
On Wed, Jan 10, 2018 at 10:04:49AM +0100, Fabiano Fidêncio wrote: > People, > > Ideally every PR should come with a test (unit, integration, ...), but > unfortunately we're a little bit far from the ideal situation. Thus, I'd > like to ask whether we have documented somewhere (apart from our code