Re: [Standards] Incorrect example in XEP-0198?
On Tue, 18 May 2021 at 20:38, Peter Saint-Andre wrote: > +1. Example 6 looks like a copy-paste error. Who wrote these specs?!? > > Thankfully, for years we either couldn't, or at least normally didn't, commit directly to the XEP repository ourselves, and left it to the Editor to actually commit the changes. Nobody will ever know it was probably me. Dave. ___ Standards mailing list Info: https://mail.jabber.org/mailman/listinfo/standards Unsubscribe: standards-unsubscr...@xmpp.org ___
Re: [Standards] Incorrect example in XEP-0198?
On 5/7/21 7:33 AM, Edwin Mons wrote: > On 07/05/2021 14:33, Kevin Smith wrote: >> On 7 May 2021, at 13:30, Matthew Wild wrote: >>> On Fri, 7 May 2021 at 12:10, Edwin Mons wrote: Hi all, I was looking at XEP-0198, and noticed something odd in Example 6. Shouldn't that have been a stream error instead, as the text above states? If so, will send out a PR. >>> Which is correct? The text or the example? While I was originally >>> inclined to agree that this should be a stream error, it should be >>> noted that section 6 "Error Handling" states: >>> >>> "If an error occurs with regard to an or >>> element, the server MUST return a element." >>> >>> and >>> >>> "Stream management errors SHOULD be considered recoverable; however, >>> misuse of stream management MAY result in termination of the stream." >>> >>> It's relevant in the context that a stream error will terminate the >>> session (such that it can't be resumed). >>> >>> I don't feel strongly either way. >> The text in question mentions wanting the connection terminated, which >> suggests stream error is right (which also seems logically sound to me). >> >> "If a server receives a second element it SHOULD respond with a >> stream error, thus terminating the client connection.” > > This was indeed how I interpreted the text and am inclined to implement. +1. Example 6 looks like a copy-paste error. Who wrote these specs?!? /psa ___ Standards mailing list Info: https://mail.jabber.org/mailman/listinfo/standards Unsubscribe: standards-unsubscr...@xmpp.org ___
Re: [Standards] Incorrect example in XEP-0198?
On Fri, 7 May 2021 at 14:34, Edwin Mons wrote: > On 07/05/2021 14:33, Kevin Smith wrote: > > The text in question mentions wanting the connection terminated, which > suggests stream error is right (which also seems logically sound to me). > > > > "If a server receives a second element it SHOULD respond with > a stream error, thus terminating the client connection.” > > This was indeed how I interpreted the text and am inclined to implement. > Yes, I think that you want to emit a stream error here. Rationale: A client sending a second is unambiguously broken. There's three possible outcomes here: * The server responds , and the client accepts its second has failed but its first is still in effect. * The server responds , and the client turns off stream management entirely. * The server responds with a stream error, and the client goes away. The server cannot know which of the first two a client might do if it sends , and moreover, even if we tried to specify that, the client is unambiguously demonstrating it's broken anyway, so we still wouldn't know. Therefore the only safe thing is to issue a stream error explaining the situation and disconnect. Any opinions on what stream error to send? I think we may be in to territory; nothing else seems to fit. Dave. ___ Standards mailing list Info: https://mail.jabber.org/mailman/listinfo/standards Unsubscribe: standards-unsubscr...@xmpp.org ___
Re: [Standards] Incorrect example in XEP-0198?
On 07/05/2021 14:33, Kevin Smith wrote: > On 7 May 2021, at 13:30, Matthew Wild wrote: >> On Fri, 7 May 2021 at 12:10, Edwin Mons wrote: >>> Hi all, >>> >>> I was looking at XEP-0198, and noticed something odd in Example 6. >>> Shouldn't that have been a stream error instead, as the text above >>> states? If so, will send out a PR. >> Which is correct? The text or the example? While I was originally >> inclined to agree that this should be a stream error, it should be >> noted that section 6 "Error Handling" states: >> >> "If an error occurs with regard to an or >> element, the server MUST return a element." >> >> and >> >> "Stream management errors SHOULD be considered recoverable; however, >> misuse of stream management MAY result in termination of the stream." >> >> It's relevant in the context that a stream error will terminate the >> session (such that it can't be resumed). >> >> I don't feel strongly either way. > The text in question mentions wanting the connection terminated, which > suggests stream error is right (which also seems logically sound to me). > > "If a server receives a second element it SHOULD respond with a > stream error, thus terminating the client connection.” This was indeed how I interpreted the text and am inclined to implement. Edwin ___ Standards mailing list Info: https://mail.jabber.org/mailman/listinfo/standards Unsubscribe: standards-unsubscr...@xmpp.org ___
Re: [Standards] Incorrect example in XEP-0198?
On 7 May 2021, at 13:30, Matthew Wild wrote: > > On Fri, 7 May 2021 at 12:10, Edwin Mons wrote: >> >> Hi all, >> >> I was looking at XEP-0198, and noticed something odd in Example 6. >> Shouldn't that have been a stream error instead, as the text above >> states? If so, will send out a PR. > > Which is correct? The text or the example? While I was originally > inclined to agree that this should be a stream error, it should be > noted that section 6 "Error Handling" states: > > "If an error occurs with regard to an or > element, the server MUST return a element." > > and > > "Stream management errors SHOULD be considered recoverable; however, > misuse of stream management MAY result in termination of the stream." > > It's relevant in the context that a stream error will terminate the > session (such that it can't be resumed). > > I don't feel strongly either way. The text in question mentions wanting the connection terminated, which suggests stream error is right (which also seems logically sound to me). "If a server receives a second element it SHOULD respond with a stream error, thus terminating the client connection.” /K ___ Standards mailing list Info: https://mail.jabber.org/mailman/listinfo/standards Unsubscribe: standards-unsubscr...@xmpp.org ___
Re: [Standards] Incorrect example in XEP-0198?
On Fri, 7 May 2021 at 12:10, Edwin Mons wrote: > > Hi all, > > I was looking at XEP-0198, and noticed something odd in Example 6. > Shouldn't that have been a stream error instead, as the text above > states? If so, will send out a PR. Which is correct? The text or the example? While I was originally inclined to agree that this should be a stream error, it should be noted that section 6 "Error Handling" states: "If an error occurs with regard to an or element, the server MUST return a element." and "Stream management errors SHOULD be considered recoverable; however, misuse of stream management MAY result in termination of the stream." It's relevant in the context that a stream error will terminate the session (such that it can't be resumed). I don't feel strongly either way. Regards, Matthew ___ Standards mailing list Info: https://mail.jabber.org/mailman/listinfo/standards Unsubscribe: standards-unsubscr...@xmpp.org ___
[Standards] Incorrect example in XEP-0198?
Hi all, I was looking at XEP-0198, and noticed something odd in Example 6. Shouldn't that have been a stream error instead, as the text above states? If so, will send out a PR. Edwin ___ Standards mailing list Info: https://mail.jabber.org/mailman/listinfo/standards Unsubscribe: standards-unsubscr...@xmpp.org ___
