Re: [PATCH 3/4] Introduce syscall fault injection feature

2016-11-15 Thread Dmitry V. Levin
Hi, On Sat, Aug 20, 2016 at 02:44:55AM +0200, Nahim El Atmani wrote: > On Fri, 29 Jul 2016 17:57:33 +0300, Dmitry V. Levin wrote: > > On Fri, Jul 29, 2016 at 03:06:50PM +0200, Gabriel Laskar wrote: > > > On Fri, 29 Jul 2016 04:04:02 +0300, Dmitry V. Levin wrote: > > > > On Wed, Jul 27, 2016 at 08:

Re: [PATCH 3/4] Introduce syscall fault injection feature

2016-08-19 Thread Nahim El Atmani
Hi, On Fri, 29 Jul 2016 17:57:33 +0300, Dmitry V. Levin wrote: > Date: Fri, 29 Jul 2016 17:57:33 +0300 > From: "Dmitry V. Levin" > To: strace-devel@lists.sourceforge.net > Subject: Re: [PATCH 3/4] Introduce syscall fault injection feature > Message-ID: <2016072914573

Re: [PATCH 3/4] Introduce syscall fault injection feature

2016-08-16 Thread Nahim El Atmani
Hello, On Thu, 11 Aug 2016 23:50:28 +0300, Dmitry V. Levin wrote: > Date: Thu, 11 Aug 2016 23:50:28 +0300 > From: "Dmitry V. Levin" > To: strace-devel@lists.sourceforge.net > Subject: Re: [PATCH 3/4] Introduce syscall fault injection feature > Message-ID: <201608

Re: [PATCH 3/4] Introduce syscall fault injection feature

2016-08-11 Thread Dmitry V. Levin
On Thu, Aug 11, 2016 at 05:51:07PM +0200, Nahim El Atmani wrote: [...] > Ok, let's take a small example to see why neither letting the accounting > information in a global scope nor letting the flag as it in the tcp does work. > If we have two tracees, and we want to cancel the second write *each*

Re: [PATCH 3/4] Introduce syscall fault injection feature

2016-08-11 Thread Nahim El Atmani
On Thu, 11 Aug 2016 17:57:27 +0300, Dmitry V. Levin wrote: > Date: Thu, 11 Aug 2016 17:57:27 +0300 > From: "Dmitry V. Levin" > To: strace-devel@lists.sourceforge.net > Subject: Re: [PATCH 3/4] Introduce syscall fault injection feature > Message-ID: <20160811145727.gb30

Re: [PATCH 3/4] Introduce syscall fault injection feature

2016-08-11 Thread Dmitry V. Levin
On Thu, Aug 11, 2016 at 04:40:31PM +0200, Nahim El Atmani wrote: [...] > > > The thing is this time I need a copy of the global sparse array by tcb. I > > > was > > > I don't see why one may need a sparse array by tcb. > > > There has to be a global sparse array that fully describes fault inject

Re: [PATCH 3/4] Introduce syscall fault injection feature

2016-08-11 Thread Nahim El Atmani
On Thu, 11 Aug 2016 17:32:51 +0300, Dmitry V. Levin wrote: > Date: Thu, 11 Aug 2016 17:32:51 +0300 > From: "Dmitry V. Levin" > To: strace-devel@lists.sourceforge.net > Subject: Re: [PATCH 3/4] Introduce syscall fault injection feature > Message-ID: <20160811143251.ga30

Re: [PATCH 3/4] Introduce syscall fault injection feature

2016-08-11 Thread Dmitry V. Levin
On Thu, Aug 11, 2016 at 04:17:41PM +0200, Nahim El Atmani wrote: > On Thu, 11 Aug 2016 05:42:52 +0300, Dmitry V. Levin wrote: [...] > > > > > --- a/syscall.c > > > > > +++ b/syscall.c > > > > > @@ -266,6 +266,14 @@ enum { > > > > > MIN_QUALS = MAX_NSYSCALLS > 255 ? MAX_NSYSCALLS : 255 > > > >

Re: [PATCH 3/4] Introduce syscall fault injection feature

2016-08-11 Thread Nahim El Atmani
On Thu, 11 Aug 2016 05:42:52 +0300, Dmitry V. Levin wrote: > Date: Thu, 11 Aug 2016 05:42:52 +0300 > From: "Dmitry V. Levin" > To: strace-devel@lists.sourceforge.net > Subject: Re: [PATCH 3/4] Introduce syscall fault injection feature > Message-ID: <20160811024252.ge22

Re: [PATCH 3/4] Introduce syscall fault injection feature

2016-08-10 Thread Dmitry V. Levin
On Wed, Aug 10, 2016 at 10:31:48PM +0200, Nahim El Atmani wrote: [...] > > > * Concerning the struct qual_options, the name 'fault' and short name 'f' > > > are > > > not fixed, feel free to comment if something better comes to your mind. > > > * Regarding the error number checks in qual_fault()

Re: [PATCH 3/4] Introduce syscall fault injection feature

2016-08-10 Thread Nahim El Atmani
; > To: strace-devel@lists.sourceforge.net > Subject: Re: [PATCH 3/4] Introduce syscall fault injection feature > Message-ID: <20160729010402.gc16...@altlinux.org> > In-Reply-To: <20160727184117.20233-4-nahim+...@naam.me> > List-Id: strace development list > > > * Concerning th

Re: [PATCH 3/4] Introduce syscall fault injection feature

2016-07-29 Thread Dmitry V. Levin
On Fri, Jul 29, 2016 at 03:02:57PM +0200, Gabriel Laskar wrote: > On Wed, Jul 27, 2016 at 08:41:16PM +0200, Nahim El Atmani wrote: [...] > > + negative = 0; > > + if (*ss == '-') { > > + negative = 1; > > + ++ss; > > + } > > + > > + if (*ss >= '0' && *ss <= '9') { > > W

Re: [PATCH 3/4] Introduce syscall fault injection feature

2016-07-29 Thread Dmitry V. Levin
On Fri, Jul 29, 2016 at 03:06:50PM +0200, Gabriel Laskar wrote: > On Fri, 29 Jul 2016 04:04:02 +0300, Dmitry V. Levin wrote: > > On Wed, Jul 27, 2016 at 08:41:16PM +0200, Nahim El Atmani wrote: [...] > > > new configure flag have been created (--enable-fault-injection) > > > to keep the build cle

Re: [PATCH 3/4] Introduce syscall fault injection feature

2016-07-29 Thread Gabriel Laskar
On Fri, 29 Jul 2016 04:04:02 +0300 "Dmitry V. Levin" wrote: > On Wed, Jul 27, 2016 at 08:41:16PM +0200, Nahim El Atmani wrote: > > From: Nahim El Atmani > > > > From: Nahim El Atmani > > > > * defs.h: Add new qualifier and struct fault_opts > > * linux/x86_64/fault.h: New file. > > (fault_s

Re: [PATCH 3/4] Introduce syscall fault injection feature

2016-07-29 Thread Gabriel Laskar
On Wed, Jul 27, 2016 at 08:41:16PM +0200, Nahim El Atmani wrote: > From: Nahim El Atmani > > From: Nahim El Atmani > > * defs.h: Add new qualifier and struct fault_opts > * linux/x86_64/fault.h: New file. > (fault_set_sc_err): New function. > (fault_discard_sc): Likewise. > * Makefile.am: A

Re: [PATCH 3/4] Introduce syscall fault injection feature

2016-07-28 Thread Dmitry V. Levin
On Wed, Jul 27, 2016 at 08:41:16PM +0200, Nahim El Atmani wrote: > From: Nahim El Atmani > > From: Nahim El Atmani > > * defs.h: Add new qualifier and struct fault_opts > * linux/x86_64/fault.h: New file. > (fault_set_sc_err): New function. > (fault_discard_sc): Likewise. > * Makefile.am: A

[PATCH 3/4] Introduce syscall fault injection feature

2016-07-27 Thread Nahim El Atmani
From: Nahim El Atmani From: Nahim El Atmani * defs.h: Add new qualifier and struct fault_opts * linux/x86_64/fault.h: New file. (fault_set_sc_err): New function. (fault_discard_sc): Likewise. * Makefile.am: Add it. * syscall.c (reallocate_fault): New function. (qualify_one): Also extend t