Re: [PATCH] Decode paths associated with file descriptors returned by syscalls

2014-05-30 Thread Dmitry V. Levin
On Fri, May 30, 2014 at 08:15:12PM +0400, Dmitry V. Levin wrote: On Fri, May 30, 2014 at 12:27:21PM +0530, zubin.mit...@gmail.com wrote: From: Zubin Mithra zubin.mit...@gmail.com * defs.h (returns_fd): New prototype. * util.c (returns_fd): New function that checks if the tcb refers

Re: [PATCH] generate xlat structs

2014-05-30 Thread Dmitry V. Levin
On Sat, Apr 26, 2014 at 11:58:35PM +0400, Dmitry V. Levin wrote: On Fri, Apr 18, 2014 at 02:46:25AM +0400, Dmitry V. Levin wrote: On Mon, Feb 17, 2014 at 07:08:52PM +0400, Dmitry V. Levin wrote: On Mon, Feb 17, 2014 at 03:18:44AM -0500, Mike Frysinger wrote: On Monday, February 17, 2014

Re: [PATCH v4 00/37] ldv/unwind: improve stacktrace feature

2014-05-30 Thread Dmitry V. Levin
On Wed, May 14, 2014 at 03:58:22AM +0400, Dmitry V. Levin wrote: On Wed, Apr 16, 2014 at 03:32:58PM +0900, Masatake YAMATO wrote: [...] Commit messages of this patchset do not meet our commit log requirements described in README-hacking; either commit messages have to be corrected

Re: [PATCH] Convert relative to absolute paths in printpathn

2014-05-30 Thread Dmitry V. Levin
On Thu, May 29, 2014 at 07:46:35PM +0530, zubin.mit...@gmail.com wrote: From: Zubin Mithra zubin.mit...@gmail.com * util.c (print_abspath): New function that converts a relative to an absolute path. * util.c (get_tracee_cwd): New function that finds the current working directory of the

Re: [GSOC 2014][JSON] refactor the output code to support JSON format

2014-05-30 Thread Dmitry V. Levin
On Fri, May 30, 2014 at 12:36:25AM +0800, yangmin zhu wrote: Hi everyone, I learned a lot about git from the great book [1] and I had cleared my repository in github[2]. YangMin, please enable pre-commit hook on your side, it will stop whitespace errors that make all your commits look red: $

Re: Pathnames followed by ... when printed using printpathn

2014-05-30 Thread Dmitry V. Levin
On Thu, May 29, 2014 at 07:50:14PM +0530, Zubin Mithra wrote: Hey Dmitry, First, printing absolute paths is not the same as printing canonicalized paths. The first is straightforward, the second is more complicated and may produce unexpected results. For example, do you really want to

Re: [PATCH] v4l2.c: a new (incomplete) decoder for Video4Linux ioctls args

2014-05-30 Thread Dmitry V. Levin
On Fri, May 30, 2014 at 11:44:41AM +0200, Philippe De Muyter wrote: * v4l2.c: new file. * ioctl.c, defs.h, Makefile.am: hook v4l2.o:v4l2_ioctl into strace. * NEWS: spread the news :) I've just pushed pending xlat changes to master branch. You can convert your code to the new form, e.g. using $

Re: [PATCH] Decode paths associated with file descriptors returned by syscalls

2014-06-02 Thread Dmitry V. Levin
On Mon, Jun 02, 2014 at 07:35:55PM +0530, Zubin Mithra wrote: Hey Dmitry, $ strace -yeclose cat /dev/null close(3/etc/ld.so.cache) = 0/dev/pts/1 close(3/lib64/libc-2.19.so) = 0/dev/pts/1 close(3/dev/null) = 0/dev/pts/1 close(1/dev/pts/1)

Re: [PATCH] v4l2.c: a new (incomplete) decoder for Video4Linux ioctls args

2014-06-02 Thread Dmitry V. Levin
On Mon, Jun 02, 2014 at 05:08:55PM +0200, Philippe De Muyter wrote: On Sat, May 31, 2014 at 04:51:24AM +0400, Dmitry V. Levin wrote: On Fri, May 30, 2014 at 11:44:41AM +0200, Philippe De Muyter wrote: * v4l2.c: new file. * ioctl.c, defs.h, Makefile.am: hook v4l2.o:v4l2_ioctl into strace

Re: [GSOC] multiarch support

2014-06-02 Thread Dmitry V. Levin
Hi Edson, On Mon, Jun 02, 2014 at 09:23:39AM -0500, Edson Ticona wrote: Hi I am working on the multiarchitecture support. I have forked strace to my repo [1]. I found a project [2] which generates a table for the syscalls, although it works only for 2.6.x I modified it for the 3.10 based

Re: [PATCH v2] Decode paths associated with file descriptors returned by syscalls

2014-06-03 Thread Dmitry V. Levin
On Tue, Jun 03, 2014 at 09:02:39AM +0530, zubin.mit...@gmail.com wrote: From: Zubin Mithra zubin.mit...@gmail.com * defs.h (RVAL_FD): New macro. * defs.h (RVAL_MASK, RVAL_STR, RVAL_NONE): Macro values modified. * desc.c (sys_dup): New function. * desc.c (sys_delete_module): New function. *

Re: [PATCH v2] Decode paths associated with file descriptors returned by syscalls

2014-06-03 Thread Dmitry V. Levin
On Tue, Jun 03, 2014 at 08:21:06PM +0530, Zubin Mithra wrote: Same here, lets change decode_open to return RVAL_FD instead. +int sys_delete_module(struct tcb *tcp) +{ return decode_open(tcp, 0); } btw, it's not right for sys_delete_module to use decode_open, but that's a

Re: [PATCH v3] Decode paths associated with file descriptors returned by syscalls

2014-06-03 Thread Dmitry V. Levin
On Tue, Jun 03, 2014 at 09:08:23PM +0530, zubin.mit...@gmail.com wrote: [...] --- a/file.c +++ b/file.c @@ -309,6 +309,12 @@ decode_open(struct tcb *tcp, int offset) int sys_open(struct tcb *tcp) { + decode_open(tcp, 0); + return RVAL_FD; +} + +int sys_delete_module(struct

Re: [PATCH v4] Decode paths associated with file descriptors returned by syscalls

2014-06-04 Thread Dmitry V. Levin
Hi Zubin, On Wed, Jun 04, 2014 at 08:30:41AM +0530, zubin.mit...@gmail.com wrote: From: Zubin Mithra zubin.mit...@gmail.com * defs.h (RVAL_FD): New macro. * defs.h (RVAL_MASK, RVAL_STR, RVAL_NONE): Macro values modified. * desc.c (sys_dup): New function. * desc.c (sys_delete_module): New

Re: [PATCH] unwind: disable stack trace with multiple personalities

2014-06-09 Thread Dmitry V. Levin
On Sun, Jun 08, 2014 at 09:29:23PM -0700, Luca Clementi wrote: * unwind.c: disable stack tracing when tracing multiple personalities --- unwind.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/unwind.c b/unwind.c index ba7b579..99bfbe9 100644

Re: [PATCH] Print absolute paths in printpathn when -yy is used

2014-06-10 Thread Dmitry V. Levin
Hi Zubin, On Thu, Jun 05, 2014 at 04:49:02PM +0530, zubin.mit...@gmail.com wrote: [...] @@ -646,6 +646,8 @@ extern const char *signame(int); extern void pathtrace_select(const char *); extern int pathtrace_match(struct tcb *); extern int getfdpath(struct tcb *, int, char *, unsigned);

Re: [PATCH 1/2] unwind: accept fake files like [vdso] as map entries

2014-06-12 Thread Dmitry V. Levin
On Thu, Jun 12, 2014 at 03:44:53AM +0900, Masatake YAMATO wrote: For making caches for process memory mapping, /proc/$pid/maps files are scanned. When scanning an entry which file name is started from `[' was ignore as fake files. As the result a system call using [vdso] causes

Re: [PATCH v4 11/37] unwind: report expected backtracing error

2014-06-12 Thread Dmitry V. Levin
On Wed, Apr 16, 2014 at 03:33:09PM +0900, Masatake YAMATO wrote: When a file mmap'ed to the target process is unlink'ed, backtracing the stack is failed. Current implementation reports it as backtracing_error. To reduce bug reports, this patch changes the message to expected_backtracing_error.

Re: [PATCH v2] Print absolute paths in printpathn when -yy is used

2014-06-12 Thread Dmitry V. Levin
On Thu, Jun 12, 2014 at 03:35:10PM +0530, zubin.mit...@gmail.com wrote: From: Zubin Mithra zubin.mit...@gmail.com * defs.h (show_fd_path): Change type to unsigned int. * strace.c (show_fd_path): Update usage to count y flag. * util.c (print_tracee_cwd): New function. (printpathn): Update to

Re: [PATCH v2] Print absolute paths in printpathn when -yy is used

2014-06-14 Thread Dmitry V. Levin
On Fri, Jun 13, 2014 at 01:22:30PM +0530, Zubin Mithra wrote: util.c: In function 'printpathn': util.c:595:4: error: implicit declaration of function 'print_tracee_cwd' [-Werror=implicit-function-declaration] Yes, I configure strace build using --enable-gcc-Werror, and I recommend

Re: [PATCH 2/2] unwind: relax the pass condition of strace-k.test test case

2014-06-16 Thread Dmitry V. Levin
On Mon, Jun 16, 2014 at 12:07:32PM +0900, Masatake YAMATO wrote: How about x86_64? I guess testing on x86_64 is failed, too. No, on x86_64 the test always succeeds. On armv7hl it is unreliable: sometimes it succeeds (e.g. https://koji.fedoraproject.org/koji/taskinfo?taskID=7043723),

Re: [PATCH v3] Print absolute paths in printpathn when -yy is used

2014-06-16 Thread Dmitry V. Levin
Hi Zubin, On Sun, Jun 15, 2014 at 09:14:05AM +0530, zubin.mit...@gmail.com wrote: --- a/defs.h +++ b/defs.h @@ -641,6 +641,7 @@ extern long getrval2(struct tcb *); */ extern int setbpt(struct tcb *); extern int clearbpt(struct tcb *); +int print_tracee_cwd(struct tcb *); I still think

Re: [PATCH v3] Print absolute paths in printpathn when -yy is used

2014-06-17 Thread Dmitry V. Levin
On Mon, Jun 16, 2014 at 10:47:05PM -0400, Mike Frysinger wrote: On Sun 15 Jun 2014 09:14:05 zubin.mit...@gmail.com wrote: From: Zubin Mithra zubin.mit...@gmail.com [...] + ssize_t n; + + snprintf(linkpath, link_size, /proc/%u/cwd, tcp-pid); + n = readlink(linkpath, cwd,

Re: [PATCH] xtensa: sort values in struct_user_offsets

2014-06-18 Thread Dmitry V. Levin
On Wed, Jun 18, 2014 at 06:04:06AM +0400, Max Filippov wrote: Otherwise ptrace syscall argument decoding is wrong: ptrace(PTRACE_PEEKUSER, 296, syscall_nr, [0x4048eb]) = 0 ptrace(PTRACE_PEEKUSER, 296, syscall_nr, [0x3fa6cd30]) = 0 ptrace(PTRACE_PEEKUSER, 296, syscall_nr, [0x8040676d]) =

Re: preparing for the next release

2014-06-18 Thread Dmitry V. Levin
On Wed, Apr 02, 2014 at 08:12:43PM +0400, Dmitry V. Levin wrote: There is quite enough good stuff accumulated in strace.git since v4.8 to release a new version. If you have pending patches to include before the release, please submit them. Looks like this new -k option is not going to produce

Re: [GSOC 2014][JSON] Current work of Yangmin for JSON output

2014-06-18 Thread Dmitry V. Levin
Hi YangMin, On Wed, Jun 11, 2014 at 11:10:18PM +0800, yangmin zhu wrote: [...] As Google says; Mentors and students can begin submitting mid-term evaluations. in [2], I'm not sure what should I do or prepare for the mid-term evaluations? There seems to be nothing special, just a list of

Re: [PATCH v4] Print absolute paths in printpathn when -yy is used

2014-06-26 Thread Dmitry V. Levin
Hi Zubin, On Fri, Jun 20, 2014 at 11:04:15AM +0530, zubin.mit...@gmail.com wrote: --- a/util.c +++ b/util.c @@ -563,6 +563,42 @@ string_quote(const char *instr, char *outstr, long len, int size) return 0; } + +/* + * Print the current working directory of the tracee process +

Re: [GSOC 2014] Multiarch support

2014-06-26 Thread Dmitry V. Levin
Hi Edson, On Thu, Jun 26, 2014 at 01:27:24PM -0500, Edson Ticona wrote: Hi I am refactoring in such a way that functions relaying on specific personalities are isolated on its own file. The patch has the concrete case of printllval function which relies on different architectures types; I

Re: [GSOC 2014][PATCH 3/4] JSON: Add basic support for syscalls in io.c

2014-06-26 Thread Dmitry V. Levin
Hi YangMin, On Thu, Jun 19, 2014 at 12:29:49AM +0800, Zhu YangMin wrote: The basic means that all the arguments are simply wrapped in a string value even for those complicated arguments printed by specific functions such as printflags(). We need to do more work to change those functions to be

Re: [GSOC 2014][PATCH 3/4] JSON: Add basic support for syscalls in io.c

2014-06-30 Thread Dmitry V. Levin
Hi YangMin, On Sun, Jun 29, 2014 at 09:23:12PM +0800, yangmin zhu wrote: [...] 1) I had ever thought about to hide all JSON related details from syscall parsers, such as to use functions like print_arg_fd(tcp-u_arg[0]); and I even implemented a simple framework for that. But I changed not to

Re: debugging strace-k on i[3-6]86

2014-06-30 Thread Dmitry V. Levin
On Mon, Jun 30, 2014 at 12:57:43AM +0900, Masatake YAMATO wrote: I would like to inspect the failure on x86. Could you the test binary somewhere I can download? I would like to fix it till v4.9. Locally I have no problems with strace-k.test on x86, the test fails on fedora koji and the latter

Re: [GSOC 2014] Multiarch: runtime error

2014-06-30 Thread Dmitry V. Levin
Hi Edson, On Mon, Jun 30, 2014 at 06:34:28PM -0500, Edson Ticona wrote: Hi I could convert i386 binary to x86_64 by using: objcopy -O elf64-x86-64 sigaltstack-i386.i sigaltstack-x86_64.i Conversion of an elf32-i386 format object to an elf64-x86-64 format object doesn't convert x86 code to

Re: preparing for the next release

2014-06-30 Thread Dmitry V. Levin
On Wed, Jun 18, 2014 at 08:58:20PM +0400, Dmitry V. Levin wrote: On Wed, Apr 02, 2014 at 08:12:43PM +0400, Dmitry V. Levin wrote: There is quite enough good stuff accumulated in strace.git since v4.8 to release a new version. If you have pending patches to include before the release

Re: [PATCH] x32: update io_{setup,submit} syscalls

2014-08-01 Thread Dmitry V. Levin
On Fri, Aug 01, 2014 at 07:00:24AM -0400, Mike Frysinger wrote: Starting in 3.16, these two syscalls have gotten their own entry point for x32. See 7fd44dacdd803c0bbf38bf478d51d280902bb0f1. * linux/x32/syscallent.h: Change existing io_{setup,submit} to 64bit, and add new entry points for

Re: preparing for the next release

2014-08-06 Thread Dmitry V. Levin
On Tue, Aug 05, 2014 at 08:45:14PM -0400, Mike Frysinger wrote: On Tue 01 Jul 2014 04:49:49 Dmitry V. Levin wrote: On Wed, Jun 18, 2014 at 08:58:20PM +0400, Dmitry V. Levin wrote: On Wed, Apr 02, 2014 at 08:12:43PM +0400, Dmitry V. Levin wrote: There is quite enough good stuff

Re: IP and port associated with a socket fd

2014-08-06 Thread Dmitry V. Levin
On Tue, Aug 05, 2014 at 11:58:35PM -0400, Mike Frysinger wrote: On Wed 06 Aug 2014 12:31:36 Masatake YAMATO wrote: [...] A problem is that many libraries wrapping netlink interface are distributed under term of GPL or LGPL. I'm not sure the code using the library is acceptable to strace

Re: preparing for the next release

2014-08-06 Thread Dmitry V. Levin
On Wed, Aug 06, 2014 at 06:49:04PM -0400, Mike Frysinger wrote: On Wed 06 Aug 2014 17:05:04 Dmitry V. Levin wrote: On Tue, Aug 05, 2014 at 08:45:14PM -0400, Mike Frysinger wrote: testing commit 1cd3f5f844d58b1ced8d3f6dc431688ed94d008e $ git describe

Re: preparing for the next release

2014-08-07 Thread Dmitry V. Levin
On Wed, Aug 06, 2014 at 11:43:49PM -0400, Mike Frysinger wrote: I've just pushed commit 3c49b02e98af0aabfffd20fd8b34b1f71b8cffb9 that should fix this: $ grep -l '^FAIL: uio' tests/remote-test.*.log tests/remote-test.hake.log tests/remote-test.lgentoo3.log tests/remote-test.ppc.log

Re: [PATCH v5] Print absolute paths in printpathn when -yy is used

2014-08-08 Thread Dmitry V. Levin
On Tue, Jul 01, 2014 at 03:13:21PM +0530, zubin.mit...@gmail.com wrote: * defs.h (show_fd_path): Change type to unsigned int. * strace.c (show_fd_path): Update usage to count y flag. (usage): Update to add -yy option. * util.c (print_tracee_cwd): New function. (printpathn): Update to use

Re: [PATCH v5] Print absolute paths in printpathn when -yy is used

2014-08-09 Thread Dmitry V. Levin
Hi Zubin, On Sat, Aug 09, 2014 at 09:46:42AM +0530, Zubin Mithra wrote: On Sat, Aug 9, 2014 at 5:05 AM, Dmitry V. Levin l...@altlinux.org wrote: On Tue, Jul 01, 2014 at 03:13:21PM +0530, zubin.mit...@gmail.com wrote: * defs.h (show_fd_path): Change type to unsigned int. * strace.c

Re: preparing for the next release

2014-08-09 Thread Dmitry V. Levin
On Sat, Aug 09, 2014 at 09:36:41AM -0400, Mike Frysinger wrote: On Wed 06 Aug 2014 23:43:49 Mike Frysinger wrote: On Thu 07 Aug 2014 05:04:33 Dmitry V. Levin wrote: These seem to be real rt_sigaction decoding bugs that remain to be fixed: $ grep '^FAIL: sigaction' tests/remote-test.*.log

Re: [PATCH] signal: fix thinko in sa_restorer

2014-08-10 Thread Dmitry V. Levin
On Sat, Aug 09, 2014 at 10:12:55PM -0400, Mike Frysinger wrote: Previous commit here re-added the bugs trying to be fixed due to a logic thinko. The patches were tested in isolation and hand merged later. Oops. * signal.c (struct new_sigaction): Change || to . Applied. Do alpha and hppa

Re: [PATCH] tests: fix uio building w/out preadv/pwritev

2014-08-11 Thread Dmitry V. Levin
On Mon, Aug 11, 2014 at 02:52:08AM -0400, Mike Frysinger wrote: [...] -./uio || - fail_ 'uio failed' +./uio || { + if [ $? -eq 77 ]; then + framework_skip_ Note that framework_skip_ takes an argument. I've corrected this and applied. Thanks! -- ldv

Re: preparing for the next release

2014-08-11 Thread Dmitry V. Levin
On Mon, Aug 11, 2014 at 01:38:42AM -0400, Mike Frysinger wrote: [...] empty logs were due to bugs in the test scripts themselves :) Looks like I haven't tested these scripts with a shell that doesn't disable set -e in the caller scope of a function that disables set -e. with the fixes i

Re: preparing for the next release

2014-08-14 Thread Dmitry V. Levin
On Thu, Aug 14, 2014 at 04:07:07AM -0400, Mike Frysinger wrote: On Thu 14 Aug 2014 01:04:47 Mike Frysinger wrote: i noticed that some new syscalls have been added to linux that we don't yet handle -- sched_setattr/sched_getattr/renameat2. the first two we prob want to stop now w/printargs,

Re: Fw: [PATCH] Add a function for dumping iovec in msghdr used in sendmsg and recvmsg

2014-08-14 Thread Dmitry V. Levin
On Mon, Aug 11, 2014 at 01:22:34PM +0900, Masatake YAMATO wrote: It seems that newer version will be released in soon. Yes, I hope to release 4.9 this week. Is newer patch still acceptable in this stage? I'd rather not add non-trivial code at this stage. If yes, could you look at the

strace 4.9 released

2014-08-15 Thread Dmitry V. Levin
On Fri, Aug 15, 2014 at 12:30:49AM -0400, Mike Frysinger wrote: On Fri 15 Aug 2014 04:50:56 Dmitry V. Levin wrote: [...] Please retest. :) looks shippable! Thanks! strace 4.9 is tagged and uploaded. I'd like to use this opportunity to thank all who contributed to this release. $ git log

Re: [PATCH v5] Print absolute paths in printpathn when -yy is used

2014-08-20 Thread Dmitry V. Levin
Hi, On Mon, Aug 11, 2014 at 08:50:54AM +0530, Zubin Mithra wrote: When descriptors decoding is enabled, descriptors passed to *at syscalls are decoded anyway, so we could use this information to decode relative paths passed to *at syscalls. Sounds good -- however the sys_symlinkat

Re: [PATCH v5] Print absolute paths in printpathn when -yy is used

2014-08-20 Thread Dmitry V. Levin
On Mon, Aug 11, 2014 at 09:31:25AM +0530, Zubin Mithra wrote: [...] Currently this is how I've implemented it(this is a portion of the diff minus the usage/documentation/variable declaration/print_tracee_cwd function for brevity). diff --git a/util.c b/util.c index c78e962..57ea9fe 100644

Re: [PATCH v5] Print ip and port associated with descriptor with -yy

2014-08-20 Thread Dmitry V. Levin
On Mon, Aug 11, 2014 at 02:21:01PM +0530, zubin.mit...@gmail.com wrote: [...] diff --git a/configure.ac b/configure.ac index 9aeb3a6..21dcc0e 100644 --- a/configure.ac +++ b/configure.ac @@ -228,8 +228,11 @@ AC_CHECK_HEADERS(m4_normalize([ inttypes.h ioctls.h

Re: [PATCH v5] Print ip and port associated with descriptor with -yy

2014-08-20 Thread Dmitry V. Levin
On Thu, Aug 21, 2014 at 02:53:46AM +0400, Dmitry V. Levin wrote: [...] + else if (nlh-nlmsg_type == NLMSG_ERROR) + return -1; I tested this patch on a x86_64 system with a fresh kernel. It always returns NLMSG_ERROR. I suppose something

Re: [PATCH v5] Print ip and port associated with descriptor with -yy

2014-08-20 Thread Dmitry V. Levin
On Thu, Aug 21, 2014 at 02:53:46AM +0400, Dmitry V. Levin wrote: On Mon, Aug 11, 2014 at 02:21:01PM +0530, zubin.mit...@gmail.com wrote: [...] if (!inet_ntop(diag_msg-idiag_family, diag_msg-id.idiag_dst, remote_addr_buf, size) || !remote_addr_buf[0

Re: [PATCH v5] Print absolute paths in printpathn when -yy is used

2014-08-25 Thread Dmitry V. Levin
Hi Zubin, On Sun, Aug 24, 2014 at 09:22:12PM +0200, Zubin Mithra wrote: [...] --- a/defs.h +++ b/defs.h @@ -679,7 +679,9 @@ extern void printstr(struct tcb *, long, long); extern void printnum(struct tcb *, long, const char *); extern void printnum_int(struct tcb *, long, const char *);

Re: [PATCH v5] Print ip and port associated with descriptor with -yy

2014-08-25 Thread Dmitry V. Levin
On Sun, Aug 24, 2014 at 04:44:23PM +0200, Zubin Mithra wrote: On 21-Aug-2014, at 4:27, Dmitry V. Levin l...@altlinux.org wrote: On Thu, Aug 21, 2014 at 02:53:46AM +0400, Dmitry V. Levin wrote: On Mon, Aug 11, 2014 at 02:21:01PM +0530, zubin.mit...@gmail.com wrote: [...] if (!inet_ntop

Re: [PATCH v5] Print ip and port associated with descriptor with -yy

2014-08-25 Thread Dmitry V. Levin
On Sun, Aug 24, 2014 at 04:38:51PM +0200, Zubin Mithra wrote: Hi Dmitry, Actually, it is quite linux specific: SOCK_DIAG_BY_FAMILY needs tcp_diag kernel module to handle IPPROTO_TCP, and udp_diag - for IPPROTO_UDP sockets. I’m not sure I understand the problem here — could you tell me

Re: [PATCH v5] Print ip and port associated with descriptor with -yy

2014-08-26 Thread Dmitry V. Levin
On Tue, Aug 26, 2014 at 06:30:10PM +0200, Zubin Mithra wrote: Hi Dmitry, Actually, it is quite linux specific: SOCK_DIAG_BY_FAMILY needs tcp_diag kernel module to handle IPPROTO_TCP, and udp_diag - for IPPROTO_UDP sockets. I’m not sure I understand the problem here — could you tell

Re: sendmsg data truncated

2014-09-05 Thread Dmitry V. Levin
Hi, On Fri, Sep 05, 2014 at 03:10:30PM -0500, Travis Emmert wrote: Hi All, I apologize if this is a topic thats been discussed at length, if so, please point me to any previous discussions and I will educate myself. Is there a way to get strace to not truncate the data within a sendmsg

Re: [PATCH v2] Add bounds checking to sys_getdents, sys_getdents64

2014-09-10 Thread Dmitry V. Levin
On Mon, Aug 04, 2014 at 07:42:57AM +0530, Zubin Mithra wrote: * file.c (sys_getdents): Add d_reclen check. (sys_getdents64): Add d_reclen check. Signed-off-by: Zubin Mithra zubin.mit...@gmail.com --- file.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git

Re: merge request to fix a sa_restorer issue

2014-09-11 Thread Dmitry V. Levin
Hi, On Thu, Sep 11, 2014 at 01:41:34PM +0100, Vicente Olivert Riera wrote: Hello, could you please take a look to this merge request? https://sourceforge.net/p/strace/code/merge-requests/2/ There are few more places in signal.c where sa_restorer field is used, they have to be ifdef'ed as

Re: [PATCH v2] Add bounds checking to sys_getdents, sys_getdents64

2014-09-17 Thread Dmitry V. Levin
On Thu, Sep 11, 2014 at 05:29:04AM +0400, Dmitry V. Levin wrote: On Mon, Aug 04, 2014 at 07:42:57AM +0530, Zubin Mithra wrote: * file.c (sys_getdents): Add d_reclen check. (sys_getdents64): Add d_reclen check. Signed-off-by: Zubin Mithra zubin.mit...@gmail.com --- file.c | 11

Re: [PATCH v5] Print ip and port associated with descriptor with -yy

2014-09-23 Thread Dmitry V. Levin
On Thu, Sep 18, 2014 at 01:33:54AM +0400, Dmitry V. Levin wrote: Hi Zubin, On Tue, Aug 26, 2014 at 06:28:46PM +0200, Zubin Mithra wrote: I think it would be less confusing to print both src and dst address:port when dst address:port is non-zero, for example: accept(30.0.0.0:7171

Re: Fix compile with musl libc

2014-09-29 Thread Dmitry V. Levin
On Sun, Sep 28, 2014 at 02:44:58PM +0100, Steven Honeyman wrote: Using the latest git sources for musl libc and strace, there's just one thing missing preventing it from working out of the box. To fix this. would it be possible to add the sys/sysinfo.h header in, as below: ---

Re: [PATCH] fix open flag decoding on 32-bit Android

2014-10-03 Thread Dmitry V. Levin
On Tue, Sep 23, 2014 at 07:09:50PM -0700, enh wrote: commit d2bed27b663096f8771df824a85f3815a0c7d7da Author: Elliott Hughes e...@google.com Date: Tue Sep 23 18:49:19 2014 -0700 Don't risk truncating open flags by using mode_t. On Android, 32-bit arm and x86 use __kernel_mode_t

Re: [PATCH] sock: clean up handling of ifr_name/ifr_newname

2014-10-21 Thread Dmitry V. Levin
On Sat, Oct 18, 2014 at 10:36:00PM -0400, Mike Frysinger wrote: The ifr name fields of the ifreq structure might not be NUL terminated. If the user makes an ioctl call where they aren't, then strace ends up reading random content from its own stack. Instead, let's create a local buffer of

Re: Abspath printing with -A

2014-10-24 Thread Dmitry V. Levin
Hi Zubin, On Fri, Oct 10, 2014 at 10:14:50AM +0200, Zubin Mithra wrote: On Wed, Sep 24, 2014 at 11:05 AM, Zubin Mithra zubin.mit...@gmail.com wrote: Hello, Please find below a diff that implements the abspath feature. Using the -A flag now resolves the relative paths to absolute ones.

Re: [RESEND PATCH] Dump details for Bluetooth socket operations

2014-10-31 Thread Dmitry V. Levin
Hi, On Fri, Oct 03, 2014 at 11:40:28AM +0200, Lubomir Rintel wrote: * net.c: Dump details for AF_BLUETOOTH sockets Signed-off-by: Lubomir Rintel lkund...@v3.sk --- Hi, this is essentially an updated resend of a patch that I've been using for years and apparently has been in review

Re: [PATCH v2] sock: clean up handling of ifr_name/ifr_newname

2014-10-31 Thread Dmitry V. Levin
Hi, On Tue, Oct 21, 2014 at 08:34:08AM -0400, Mike Frysinger wrote: The ifr name fields of the ifreq structure might not be NUL terminated. If the user makes an ioctl call where they aren't, then strace ends up reading random content from its own stack. Limit the printf lengths. Further,

Re: [PATCH] Include linux/ptrace.h also if sys/reg.h exists

2014-10-31 Thread Dmitry V. Levin
Hi, On Mon, Oct 20, 2014 at 01:02:48AM +0200, Maarten ter Huurne wrote: This fixes compilation with musl libc. This approach was already used in process.c, so I assume it is safe. Thanks, applied with hope it's safe. -- ldv pgpvznhhhS8R7.pgp Description: PGP signature

Re: [PATCH] Look for ioctl definitions in the kernel build tree

2014-10-31 Thread Dmitry V. Levin
Hi, On Thu, Oct 16, 2014 at 12:05:43PM +0200, Lubomir Rintel wrote: The kernel's headers are not installed into /usr/include, nor are the Kbuild files. Howerver, if linux/ioctlent.sh doesn't see the Kbuild file, it wrongly assumes we just have an old tree and happily proceeds, leaving many

Re: [PATCH] Add a function for dumping iovec in msghdr used in sendmsg and recvmsg

2014-10-31 Thread Dmitry V. Levin
Hi, On Wed, Oct 15, 2014 at 10:11:43PM +0900, Masatake YAMATO wrote: * syscall.c (dumpio): Call dumpiov_in_msghdr if the target function is recvmsg or sendmsg. * net.c (extractmsghdr): New function derived from `printmsghdr'. (printmsghdr): Use `extractmsghdr'. (dumpiov_in_msghdr): New

Re: [PATCH v6] v4l2.c: a decoder for Video4Linux video-input ioctls args

2014-11-01 Thread Dmitry V. Levin
Hi, On Fri, Oct 10, 2014 at 01:15:23PM +0200, Philippe De Muyter wrote: * v4l2.c, xlat/v4l2_*.in: new files. * configure.ac: check for availabilty of v4l2 enum constants. * ioctl.c, defs.h, Makefile.am: hook v4l2.o:v4l2_ioctl into strace. * NEWS: spread the news :) Introduce v4l2.c, a

Re: [PATCH] Look for ioctl definitions in the kernel build tree

2014-11-03 Thread Dmitry V. Levin
On Mon, Nov 03, 2014 at 02:51:42PM +0100, Lubomir Rintel wrote: On Sat, 2014-11-01 at 04:02 +0300, Dmitry V. Levin wrote: Hi, On Thu, Oct 16, 2014 at 12:05:43PM +0200, Lubomir Rintel wrote: The kernel's headers are not installed into /usr/include, nor are the Kbuild files

Re: [PATCH v7] v4l2.c: a decoder for Video4Linux video-input ioctls args

2014-11-04 Thread Dmitry V. Levin
On Mon, Nov 03, 2014 at 09:27:40PM +0100, Philippe De Muyter wrote: * v4l2.c, xlat/v4l2_*.in: new files. * configure.ac: check for availabilty of v4l2 enum constants. * ioctl.c, defs.h, Makefile.am: hook v4l2.o:v4l2_ioctl into strace. * NEWS: spread the news :) Introduce v4l2.c, a decoder

Re: [RESEND PATCH] Dump details for Bluetooth socket operations

2014-11-04 Thread Dmitry V. Levin
On Sat, Nov 01, 2014 at 03:44:23AM +0300, Dmitry V. Levin wrote: On Fri, Oct 03, 2014 at 11:40:28AM +0200, Lubomir Rintel wrote: * net.c: Dump details for AF_BLUETOOTH sockets Signed-off-by: Lubomir Rintel lkund...@v3.sk --- Hi, this is essentially an updated resend of a patch

Re: [PATCH 3/4] Add functions for dumping iovecs in mmsghdr used in sendmmsg and recvmmsg

2014-11-06 Thread Dmitry V. Levin
On Fri, Nov 07, 2014 at 01:23:26AM +0900, Masatake YAMATO wrote: This patch is similar to what I did in commit 02f9f6b386741a52f58e1b31ad4e7fff60781ef8. The commit was for sendmsg and recvmsg system calls. This one is for sendmmsg and recvmmsg system calls. [...] --- a/net.c +++ b/net.c @@

Re: [PATCHv2 2/4] Use the definition of struct mmsghdr if it is defined in build environment

2014-11-06 Thread Dmitry V. Levin
On Fri, Nov 07, 2014 at 11:38:20AM +0900, Masatake YAMATO wrote: mmsghrd structure type is defined locally in printmmsghdr function. However, more functions will refer the definition in modifications for supporting -e write=all and -e read=all option for sendmmsg and recvmmsg system calls.

Re: [PATCHv2 3/4] Add functions for dumping iovecs in mmsghdr used in sendmmsg and recvmmsg

2014-11-06 Thread Dmitry V. Levin
On Fri, Nov 07, 2014 at 11:38:21AM +0900, Masatake YAMATO wrote: [...] +void +dumpiov_in_mmsghdr(struct tcb *tcp, long addr) +{ + unsigned int len = tcp-u_rval; + unsigned int i; + struct mmsghdr mmsg; + + for (i = 0; i len; ++i) + { + if

Re: [PATCHv2 4/4] Add a test case for -e write=all option for sendmmsg system call

2014-11-06 Thread Dmitry V. Levin
On Fri, Nov 07, 2014 at 11:38:22AM +0900, Masatake YAMATO wrote: * tests/Makefile.am: Add mmsg to CHECK_PROGRAMS. Add mmsg.test to TESTS. * tests/mmsg.test: New file. * tests/mmsg.c: New target program to be traced by testes strace. Do not forget to add new executables to tests/.gitignore.

Re: [PATCHv3 2/2] Add a test case for -e write=n -e read=m option for sendmmsg/recvmsg system calls

2014-11-07 Thread Dmitry V. Levin
On Fri, Nov 07, 2014 at 08:16:03PM +0900, Masatake YAMATO wrote: [...] --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -4,6 +4,7 @@ AM_CFLAGS = $(WARN_CFLAGS) check_PROGRAMS = \ inet-accept-connect-send-recv \ + mmsg \ net-accept-connect \ netlink_inet_diag \

Re: dumping iovecs in mmsghdr patch series

2014-11-11 Thread Dmitry V. Levin
Masatake, Thanks for the patch series (and especially for the test), I've merged them now. -- ldv pgpRbXWfcpqbO.pgp Description: PGP signature -- Comprehensive Server Monitoring with Site24x7. Monitor 10 servers for

Re: [PATCH 1/2] stack trace support: fix check on symbol name presence

2014-11-11 Thread Dmitry V. Levin
On Fri, Nov 07, 2014 at 01:32:18AM +0900, Masatake YAMATO wrote: Acked-by: Masatake YAMATO yam...@redhat.com Applied, thanks. -- ldv pgpcvlY36jLw2.pgp Description: PGP signature -- Comprehensive Server Monitoring

Re: [PATCH] update error codes and signal numbers for hppa/parisc architecture

2014-11-11 Thread Dmitry V. Levin
On Sat, Nov 08, 2014 at 10:52:44PM +0100, Helge Deller wrote: Dear strace developers, can you please apply this patch to strace in git? It updates some error codes and signal numbers for the hppa (parisc) architecture. There are two important changes in here: 1. EWOULDBLOCK has been up

Re: [PATCH 2/2] stack trace support: print full instruction pointer in addition to offset

2014-11-11 Thread Dmitry V. Levin
Hi, On Fri, Nov 07, 2014 at 02:07:40PM +0900, Masatake YAMATO wrote: On Thu, 6 Nov 2014 21:07:52 +0100, Thomas De Schampheleire patrickdeping...@gmail.com wrote: How do you think one of following format? /bin/busybox() [0x10062c60|0x62c60] /bin/busybox() [0x10062c60/0x62c60]

Re: [PATCH] Print protocol name of socket descriptors with -yy option

2014-11-19 Thread Dmitry V. Levin
On Wed, Nov 19, 2014 at 11:32:32PM +0900, Masatake YAMATO wrote: When -yy option is specified other than inet socket were printed as socket:[INODE]. e.g. # ./strace -e recvmsg -yy ping 127.0.0.1 /dev/null ... recvmsg(3socket:[43222052], ... ... This patch makes

Re: [PATCH] decode open's O_TMPFILE

2014-11-19 Thread Dmitry V. Levin
On Wed, Nov 19, 2014 at 04:36:42PM -0500, Mike Frysinger wrote: * xlat/open_mode_flags.in: Add O_TMPFILE definition. O_TMPFILE is too recent to include without ifdefs. --- xlat/open_mode_flags.in | 2 ++ 1 file changed, 2 insertions(+) diff --git a/xlat/open_mode_flags.in

Re: [PATCH] decode FIFREEZE/FITHAW/FITRIM ioctls

2014-11-21 Thread Dmitry V. Levin
On Fri, Nov 21, 2014 at 04:13:16PM -0500, Mike Frysinger wrote: The freeze/thaw ones are simple, but the trim is an interesting struct. Merged, thanks. -- ldv pgpDGX0kJuP_v.pgp Description: PGP signature -- Download

Re: [PATCH 1/3] Use the protocol name of a socket as a hint for peer address resolution

2014-12-08 Thread Dmitry V. Levin
On Sun, Dec 07, 2014 at 06:56:13AM +0900, Masatake YAMATO wrote: [...] --- a/socketutils.c +++ b/socketutils.c @@ -138,33 +138,56 @@ receive_responses(const int fd, const unsigned long inode) } } +static bool +inet_print(int fd, int family, int protocol, const unsigned long

Re: [PATCH 2/3] Support unix sockets in -yy option

2014-12-08 Thread Dmitry V. Levin
On Sun, Dec 07, 2014 at 06:56:14AM +0900, Masatake YAMATO wrote: This patch extends -yy option; the peer address of a unix socket can be printed like an inet socket. About a listening socket, its socket path and socket inode are printed. About an accepted socket, its socket path, socket

Re: [PATCH 2/3] Support unix sockets in -yy option

2014-12-09 Thread Dmitry V. Levin
On Tue, Dec 09, 2014 at 12:33:23PM +0900, Masatake YAMATO wrote: BTW, * linux/unix_diag.h: New file. * linux/rtnetlink.h: New file. Should I bundle linux/unix_diag.h and linux/rtnetlink.h in my changes? (I included the shrunk version of them in my changes.) I'm not sure the criteria

Re: [PATCHv2 1/3] Use the protocol name of a socket as a hint for peer address resolution

2014-12-17 Thread Dmitry V. Levin
On Wed, Dec 10, 2014 at 12:55:06PM +0900, Masatake YAMATO wrote: For resolving the peer address of socket, all combinations of families (AF_INET, AF_INET6) and protocols(IPPROTO_TCP, IPPROTO_UDP) were tried. This patch utilizes the protocol name, getting via getxattr, to specify the

Re: [PATCHv2 2/3] Support unix sockets in -yy option

2014-12-17 Thread Dmitry V. Levin
On Wed, Dec 10, 2014 at 12:55:07PM +0900, Masatake YAMATO wrote: This patch extends -yy option; the peer address of a unix socket can be printed like an inet socket. It works perfectly well, but there are several minor issues with the patch I'd like to have fixed before applying. [...] ---

Re: Inserting arbitrary messages into strace output

2014-12-22 Thread Dmitry V. Levin
On Mon, Dec 22, 2014 at 04:52:22PM -0500, Justin Dearing wrote: On Thu, Dec 18, 2014 at 11:04 PM, Dmitry V. Levin wrote: Unlike -42, which is treated as unsigned int (i.e. 2^32-42) by the kernel, -1 is never a valid file descriptor. Ok that makes sense. So how about a command line switch

Re: [PATCHv4 1/2] Support unix sockets in -yy option

2014-12-27 Thread Dmitry V. Levin
On Wed, Dec 24, 2014 at 08:59:31PM +0900, Masatake YAMATO wrote: This patch extends -yy option; the peer address of a unix socket can be printed like an inet socket. [...] +static bool +unix_parse_response(const void *data, int data_len, const unsigned long inode) +{ + const struct

Re: [PATCH] fix UTIME_NOW/UTIME_OMIT

2014-12-27 Thread Dmitry V. Levin
On Tue, Dec 23, 2014 at 10:42:40AM -0800, Elliott Hughes wrote: The kernel doesn't actually care what tv_sec is set to --- it only checks tv_nsec when looking for the special values. Yes. Applied, thanks. -- ldv pgpY0pNJHYEjP.pgp Description: PGP signature

Re: [PATCHv4 2/2] tests: add a test for decoding the address of unix socket

2014-12-27 Thread Dmitry V. Levin
On Wed, Dec 24, 2014 at 08:59:32PM +0900, Masatake YAMATO wrote: * tests/Makefile.am: Add unix-yy.test to TESTS. Add unix-yy-accept.awk and unix-yy-connect.awk to EXTRA_DIST. * tests/unix-yy-accept.awk: New file. * tests/unix-yy-connect.awk: New file. * tests/unix-yy.test: New file.

Re: [PATCHv4 2/2] tests: add a test for decoding the address of unix socket

2014-12-28 Thread Dmitry V. Levin
On Mon, Dec 29, 2014 at 11:49:30AM +0900, Masatake YAMATO wrote: On Wed, Dec 24, 2014 at 08:59:32PM +0900, Masatake YAMATO wrote: * tests/Makefile.am: Add unix-yy.test to TESTS. Add unix-yy-accept.awk and unix-yy-connect.awk to EXTRA_DIST. * tests/unix-yy-accept.awk: New file. *

Re: [PATCH v2] scsi: Add bsg support

2015-01-23 Thread Dmitry V. Levin
On Fri, Jan 23, 2015 at 04:27:53PM +0100, Bart Van Assche wrote: The Linux kernel supports two different versions of the SG_IO API, namely v3 and v4. This patch adds support for version 4 of this API. At least the sg3_utils package supports version 4 of this API. Version 4 of this API is used

Re: [PATCH] fix typo for sys_getpeername on hppa/parisc architecture

2015-01-24 Thread Dmitry V. Levin
Hi, On Sat, Jan 24, 2015 at 04:51:27PM +0100, Helge Deller wrote: Dear strace developers, can you please apply this trivial patch to strace in git? It fixes an obvious typo which prints lock instead of getpeername for the getpeername syscall. Applied, thanks. There were two more typos in

Re: [PATCH 1/2] Decode setsockopt() multicast arguments

2015-02-07 Thread Dmitry V. Levin
On Sat, Feb 07, 2015 at 06:05:56PM +0100, Ben Noordhuis wrote: On Sat, Feb 7, 2015 at 12:55 AM, Dmitry V. Levin l...@altlinux.org wrote: On Thu, Feb 05, 2015 at 07:28:45PM +0100, Ben Noordhuis wrote: +#ifdef IP_ADD_MEMBERSHIP +static void +print_mreq(struct tcb *tcp, long addr, int len

Re: [PATCH v3 1/2] scsi: Add iovec support

2015-02-07 Thread Dmitry V. Levin
On Fri, Feb 06, 2015 at 01:36:26PM +0100, Bart Van Assche wrote: Changes: - Add support for decoding iovecs passed via the SG I/O v3 interface. - Decode the data in and data out buffers in hex instead of in ASCII. - Make print_sg_io_buffer() print square brackets instead of its caller. -

<    1   2   3   4   5   6   7   8   9   10   >