Re: cvs commit: jakarta-struts/src/share/org/apache/struts/action Action.java

2003-09-09 Thread Robert Leland
[EMAIL PROTECTED] wrote: David, I thought you were going to back this out ? -Rob dgraham 2003/08/19 16:20:46 Modified:src/share/org/apache/struts/action Action.java Log: Added version of saveMessages() that saves them into the session instead of the request. Revision Changes

Re: cvs commit: jakarta-struts/src/share/org/apache/struts/action Action.java

2003-09-09 Thread David Graham
--- Robert Leland [EMAIL PROTECTED] wrote: [EMAIL PROTECTED] wrote: David, I thought you were going to back this out ? The conversation was left with me proposing a solution and asking for Martin's thoughts on it. He hasn't responded so I haven't backed it out. Saving messages in the

Re: cvs commit: jakarta-struts/src/share/org/apache/struts/action Action.java

2003-09-09 Thread Robert Leland
David Graham wrote: --- Robert Leland [EMAIL PROTECTED] wrote: [EMAIL PROTECTED] wrote: David, I thought you were going to back this out ? The conversation was left with me proposing a solution and asking for Martin's thoughts on it. He hasn't responded so I haven't backed it out.

Re: cvs commit: jakarta-struts/src/share/org/apache/struts/action Action.java

2003-09-09 Thread David Graham
--- Robert Leland [EMAIL PROTECTED] wrote: David Graham wrote: --- Robert Leland [EMAIL PROTECTED] wrote: [EMAIL PROTECTED] wrote: David, I thought you were going to back this out ? The conversation was left with me proposing a solution and asking for Martin's

Re: cvs commit: jakarta-struts/src/share/org/apache/struts/action Action.java

2003-09-09 Thread Robert Leland
David Graham wrote: --- Robert Leland [EMAIL PROTECTED] wrote: David Graham wrote: --- Robert Leland [EMAIL PROTECTED] wrote: [EMAIL PROTECTED] wrote: David, I thought you were going to back this out ? The conversation was left with me proposing a solution and

Re: cvs commit: jakarta-struts/src/share/org/apache/struts/action Action.java

2003-08-20 Thread David Graham
--- Martin Cooper [EMAIL PROTECTED] wrote: David, Perhaps you missed my -1 on providing a means of saving errors in session scope unless an *automatic* means of removing them at the appropriate time can also be provided. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21408 Indeed,

RE: cvs commit: jakarta-struts/src/share/org/apache/struts/action Action.java

2002-07-01 Thread James Mitchell
Are you changing all references from struts:whatever to html:whatever? Also, do you care about fixing the javadoc comments to reflect correct parameter names or is it a non-issue for now? (I know you're trying to get 1.1 ready) James Mitchell Software Engineer\Struts Evangelist Struts-Atlanta,

RE: cvs commit: jakarta-struts/src/share/org/apache/struts/action Action.java ActionForm.java

2001-05-11 Thread SCHACHTER,MICHAEL (HP-NewJersey,ex2)
: cvs commit: jakarta-struts/src/share/org/apache/struts/action Action.java ActionForm.java Doesn't the Struts framework need to call this new method somewhere? The application code can't call the isCancelled method because the Action class code will never be called. If Struts ActionServlet calls

RE: cvs commit: jakarta-struts/src/share/org/apache/struts/action Action.java ActionForm.java

2001-05-11 Thread Deadman, Hal
-Original Message- From: SCHACHTER,MICHAEL (HP-NewJersey,ex2) [mailto:[EMAIL PROTECTED]] Sent: Friday, May 11, 2001 1:29 PM To: '[EMAIL PROTECTED]' Subject: RE: cvs commit: jakarta-struts/src/share/org/apache/struts/action Action.java ActionForm.java Hal, It was my understanding

RE: cvs commit: jakarta-struts/src/share/org/apache/struts/action Action.java ActionForm.java

2001-05-11 Thread SCHACHTER,MICHAEL (HP-NewJersey,ex2)
, May 11, 2001 1:24 PM To: [EMAIL PROTECTED] Subject: RE: cvs commit: jakarta-struts/src/share/org/apache/struts/action Action.java ActionForm.java Doesn't the Struts framework need to call this new method somewhere? The application code can't call the isCancelled method because the Action class code

RE: cvs commit: jakarta-struts/src/share/org/apache/struts/action Action.java ActionForm.java

2001-05-11 Thread Craig R. McClanahan
]' Subject: RE: cvs commit: jakarta-struts/src/share/org/apache/struts/action Action.java ActionForm.java Hal, It was my understanding that since isCancelled is a protected method in the Action class, that it was the Action developer's job to call the method. -Original Message- From