cvs commit: jakarta-struts/src/share/org/apache/struts/taglib/html SelectTag.java
martinc 2003/11/27 23:25:55
Modified:src/share/org/apache/struts/taglib/html SelectTag.java
Log:
Clear out the saved body content after use, so that it's not used again
inadvertently when the tag handler instance is reused.
PR: 24573
Submitted by: hurle at gmx.de
Revision ChangesPath
1.19 +5 -4
jakarta-struts/src/share/org/apache/struts/taglib/html/SelectTag.java
Index: SelectTag.java
===
RCS file:
/home/cvs/jakarta-struts/src/share/org/apache/struts/taglib/html/SelectTag.java,v
retrieving revision 1.18
retrieving revision 1.19
diff -u -r1.18 -r1.19
--- SelectTag.java31 Jul 2003 00:19:04 - 1.18
+++ SelectTag.java28 Nov 2003 07:25:55 - 1.19
@@ -367,6 +367,7 @@
StringBuffer results = new StringBuffer();
if (saveBody != null) {
results.append(saveBody);
+saveBody = null;
}
results.append(/select);
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 24573] - html:select uses options from previous select
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24573. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24573 html:select uses options from previous select [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2003-11-28 07:26 --- Fixed in the 20031128 nightly build. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: Legacy APIs - Short Term Plan
eh? Arent they in some kind of wierd xml format? takes another look/ hmmm. No they arent, and the javadocs are there too. :-) Oops. Ignore my previous post. It seems Im talking nonsense. Sorry. -Original Message- From: James Mitchell [mailto:[EMAIL PROTECTED] Sent: Friday, 28 November 2003 14:56 To: Struts Developers List; [EMAIL PROTECTED] Subject: RE: Legacy APIs - Short Term Plan On Fri, 28 Nov 2003, Andrew Hill wrote: While your at it how about actually including the javadocs in the distribution (or the source dist). A static html version of the other struts docs that doesnt require you to crank up a servlet container everytime you want to check something would also be very nice. You don't need a container to unzip a file. -Original Message- From: Ted Husted [mailto:[EMAIL PROTECTED] Sent: Friday, 28 November 2003 10:32 To: Struts Developers List Subject: Re: Legacy APIs - Short Term Plan David Graham wrote: By API do you mean javadocs? I've found it useful to compare Sun's JDK javadocs between versions and I imagine some people would like to compare Struts versions. People who wish to do this can maintain their own local copies (and save some of the bandwidth people kindly contribute to us). Maintaining them through our web site just confuses people. It made sense when there was a big gap between releases, but, hopefully, those days are past. -Ted. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- James Mitchell Software Developer / Struts Evangelist http://www.struts-atlanta.org - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 25064] New: - Struts should not ignors response.isCommitted() tag
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25064. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25064 Struts should not ignors response.isCommitted() tag Summary: Struts should not ignors response.isCommitted() tag Product: Struts Version: 1.1 Final Platform: PC OS/Version: Windows NT/2K Status: NEW Severity: Normal Priority: Other Component: Standard Actions AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] I’m using a FilterServlet to do some permission check. If user send a request not allowed, the filter will invoke response.sendError(401), that will cancel the request before it reaches the requested resource. My filter does well if I request a JSP page, except I request an Action. In the Action case, the client side still got the 401 error page, but the action was invoked also at the server side. I set a breakpoint at the action’s execute method, no matter response.isCommitted() return true or false, it continue executing… I’m also wondering why it not throw an exception when response.isCommitted() is true? Thanks. wuliang - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: Maven test run
I'm also getting a failure on TestActionConfigMatcher (using Ant build): Name isn't correct junit.framework.AssertionFailedError: Name isn't correct at org.apache.struts.config.TestActionConfigMatcher.testCheckSubstitutionsM atch(TestActionConfigMatcher.java:202) ... cfg.getName() is returning 'name2', but the test expects 'name' fConfigs contains: [0] = name2 [1] = name The problem seems to be that the test relies on the order of the array elements but ActionConfig stores the configs in a HashMap which does not return its values collection in a guaranteed order. I would have expected the failure to be intermittent, but it fails consistently for me. Maybe in practice the order is consistent for a platform, JDK, day of the week etc. etc. :-) As an experiment, I changed the HashMap to a TreeMap, and the tests pass. I don't know if this would have any knock on effects elsewhere though. Might be better to rethink the test so it doesn't rely on the ordering. Or even just drop that section since it's really only testing findForwardConfigs(), not the matcher. Steve -Original Message- From: Don Brown [mailto:[EMAIL PROTECTED] Sent: November 27, 2003 9:36 PM To: Struts Developers List Subject: Re: Maven test run Hmmm...I just updated, uncommented those two lines, and ran ant test.junit - all tests passed. Anyone else? Don On Thu, 27 Nov 2003, Ted Husted wrote: When I run the maven jar target, the upload tests fail (MultipartTestSuite). But, when I run the ant test.junit test, only the TestActionConfigMatcher test fails. Is it me, or do others share this experience? If so, any ideas as to why this would be? -Ted. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: Legacy APIs - Short Term Plan
Not in struts-documentation.war :-) Steve -Original Message- From: Andrew Hill [mailto:[EMAIL PROTECTED] Sent: November 27, 2003 11:40 PM To: Struts-Dev Subject: RE: Legacy APIs - Short Term Plan eh? Arent they in some kind of wierd xml format? takes another look/ hmmm. No they arent, and the javadocs are there too. :-) Oops. Ignore my previous post. It seems Im talking nonsense. Sorry. -Original Message- From: James Mitchell [mailto:[EMAIL PROTECTED] Sent: Friday, 28 November 2003 14:56 To: Struts Developers List; [EMAIL PROTECTED] Subject: RE: Legacy APIs - Short Term Plan On Fri, 28 Nov 2003, Andrew Hill wrote: While your at it how about actually including the javadocs in the distribution (or the source dist). A static html version of the other struts docs that doesnt require you to crank up a servlet container everytime you want to check something would also be very nice. You don't need a container to unzip a file. -Original Message- From: Ted Husted [mailto:[EMAIL PROTECTED] Sent: Friday, 28 November 2003 10:32 To: Struts Developers List Subject: Re: Legacy APIs - Short Term Plan David Graham wrote: By API do you mean javadocs? I've found it useful to compare Sun's JDK javadocs between versions and I imagine some people would like to compare Struts versions. People who wish to do this can maintain their own local copies (and save some of the bandwidth people kindly contribute to us). Maintaining them through our web site just confuses people. It made sense when there was a big gap between releases, but, hopefully, those days are past. -Ted. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- James Mitchell Software Developer / Struts Evangelist http://www.struts-atlanta.org - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Maven test run
After copying my local Validator build to Maven's repo, I get the same as you do - no tests to run. Doing the Ant test.junit thing, I get the TestActionConfigMatcher failure, but it looks like Steve has tracked that one down. -- Martin Cooper On Thu, 27 Nov 2003, James Mitchell wrote: On Thu, 27 Nov 2003, Ted Husted wrote: When I run the maven jar target, the upload tests fail (MultipartTestSuite). On a fresh copy ofwelleverything (maven 1.0-rc1, jakarta-struts, etc, etc) I cannot do anything with maven. The attempt to download validator SNAPSHOT fails. When I change project.xml to use 1.0.1 or 1.0.2, it downloads, but the compile fails complaining about missing ValidatorUtils. I downloaded a nightly, moved it to ~/.maven/repository/commons-validator/jars/. Then changed SNAPSHOT to nightly in project.xml. Then this: [EMAIL PROTECTED] jakarta-struts]$ maven jar __ __ | \/ |__ _Apache__ ___ | |\/| / _` \ V / -_) ' \ ~ intelligent projects ~ |_| |_\__,_|\_/\___|_||_| v. 1.0-rc1-SNAPSHOT java:prepare-filesystem: java:compile: [echo] Compiling to m-target/classes [javac] Compiling 266 source files to /home/jmitchell/cvs/jakarta-struts/m-target/classes /home/jmitchell/cvs/jakarta-struts/src/share/org/apache/struts/tiles/actions/DefinitionDispatcherAction.java:78: warning: org.apache.struts.tiles.DefinitionsUtil in org.apache.struts.tiles has been deprecated import org.apache.struts.tiles.DefinitionsUtil; ^ huge-snip/ /home/jmitchell/cvs/jakarta-struts/src/share/org/apache/struts/validator/ValidatorPlugIn.java:264: warning: org.apache.commons.validator.ValidatorResourcesInitializer in org.apache.commons.validator has been deprecated ValidatorResourcesInitializer.initialize(resources, bis, false); ^ 41 warnings java:jar-resources: Copying 15 files to /home/jmitchell/cvs/jakarta-struts/m-target/classes test:prepare-filesystem: [mkdir] Created dir: /home/jmitchell/cvs/jakarta-struts/m-target/test-classes [mkdir] Created dir: /home/jmitchell/cvs/jakarta-struts/m-target/test-reports test:test-resources: test:compile: [echo] No test source files to compile. test:test: [echo] No tests to run. jar:jar: [jar] Building jar: /home/jmitchell/cvs/jakarta-struts/m-target/struts-1.2.0.jar BUILD SUCCESSFUL Total time: 26 seconds Finished at: Fri Nov 28 01:40:35 EST 2003 No tests to runAm I missing something here? But, when I run the ant test.junit test, only the TestActionConfigMatcher test fails. Is it me, or do others share this experience? If so, any ideas as to why this would be? -Ted. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-struts/src/test/org/apache/struts/config TestActionConfigMatcher.java
mrdon 2003/11/28 00:48:29
Modified:src/test/org/apache/struts/config
TestActionConfigMatcher.java
Log:
Fixed test to not depend on HashMap order for ForwardConfig's
Revision ChangesPath
1.4 +14 -8
jakarta-struts/src/test/org/apache/struts/config/TestActionConfigMatcher.java
Index: TestActionConfigMatcher.java
===
RCS file:
/home/cvs/jakarta-struts/src/test/org/apache/struts/config/TestActionConfigMatcher.java,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- TestActionConfigMatcher.java 28 Nov 2003 02:25:47 - 1.3
+++ TestActionConfigMatcher.java 28 Nov 2003 08:48:29 - 1.4
@@ -183,10 +183,16 @@
assertTrue(Input hasn't been replaced, input,Bar.equals(m.getInput()));
ForwardConfig[] fConfigs = m.findForwardConfigs();
-ForwardConfig cfg = fConfigs[0];
-assertTrue(ContextRelative isn't correct, cfg.getContextRelative());
-// :FIXME: assertTrue(Name isn't correct, name.equals(cfg.getName()));
-// :FIXME: assertTrue(Path hasn't been replaced,
path,Bar.equals(cfg.getPath()));
+boolean found = false;
+for (int x=0; xfConfigs.length; x++) {
+ForwardConfig cfg = fConfigs[x];
+if (name.equals(cfg.getName())) {
+found = true;
+assertTrue(ContextRelative isn't correct,
cfg.getContextRelative());
+assertTrue(Path hasn't been replaced,
path,Bar.equals(cfg.getPath()));
+}
+}
+assertTrue(The forward config 'name' cannot be found, found);
}
private ActionConfig buildActionConfig(String path) {
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
RE: Maven test run
Good point, thanks for solving the mystery. I've updated the test to not depend on the hashmap order. Don I'm also getting a failure on TestActionConfigMatcher (using Ant build): Name isn't correct junit.framework.AssertionFailedError: Name isn't correct at org.apache.struts.config.TestActionConfigMatcher.testCheckSubstitutionsM atch(TestActionConfigMatcher.java:202) ... cfg.getName() is returning 'name2', but the test expects 'name' fConfigs contains: [0] = name2 [1] = name The problem seems to be that the test relies on the order of the array elements but ActionConfig stores the configs in a HashMap which does not return its values collection in a guaranteed order. I would have expected the failure to be intermittent, but it fails consistently for me. Maybe in practice the order is consistent for a platform, JDK, day of the week etc. etc. :-) As an experiment, I changed the HashMap to a TreeMap, and the tests pass. I don't know if this would have any knock on effects elsewhere though. Might be better to rethink the test so it doesn't rely on the ordering. Or even just drop that section since it's really only testing findForwardConfigs(), not the matcher. Steve -Original Message- From: Don Brown [mailto:[EMAIL PROTECTED] Sent: November 27, 2003 9:36 PM To: Struts Developers List Subject: Re: Maven test run Hmmm...I just updated, uncommented those two lines, and ran ant test.junit - all tests passed. Anyone else? Don On Thu, 27 Nov 2003, Ted Husted wrote: When I run the maven jar target, the upload tests fail (MultipartTestSuite). But, when I run the ant test.junit test, only the TestActionConfigMatcher test fails. Is it me, or do others share this experience? If so, any ideas as to why this would be? -Ted. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: Maven test run
On Thu, 27 Nov 2003 [EMAIL PROTECTED] wrote: Good point, thanks for solving the mystery. I've updated the test to not depend on the hashmap order. Cool. Works for me. :-) -- Martin Cooper Don I'm also getting a failure on TestActionConfigMatcher (using Ant build): Name isn't correct junit.framework.AssertionFailedError: Name isn't correct at org.apache.struts.config.TestActionConfigMatcher.testCheckSubstitutionsM atch(TestActionConfigMatcher.java:202) ... cfg.getName() is returning 'name2', but the test expects 'name' fConfigs contains: [0] = name2 [1] = name The problem seems to be that the test relies on the order of the array elements but ActionConfig stores the configs in a HashMap which does not return its values collection in a guaranteed order. I would have expected the failure to be intermittent, but it fails consistently for me. Maybe in practice the order is consistent for a platform, JDK, day of the week etc. etc. :-) As an experiment, I changed the HashMap to a TreeMap, and the tests pass. I don't know if this would have any knock on effects elsewhere though. Might be better to rethink the test so it doesn't rely on the ordering. Or even just drop that section since it's really only testing findForwardConfigs(), not the matcher. Steve -Original Message- From: Don Brown [mailto:[EMAIL PROTECTED] Sent: November 27, 2003 9:36 PM To: Struts Developers List Subject: Re: Maven test run Hmmm...I just updated, uncommented those two lines, and ran ant test.junit - all tests passed. Anyone else? Don On Thu, 27 Nov 2003, Ted Husted wrote: When I run the maven jar target, the upload tests fail (MultipartTestSuite). But, when I run the ant test.junit test, only the TestActionConfigMatcher test fails. Is it me, or do others share this experience? If so, any ideas as to why this would be? -Ted. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-struts project.xml
sraeburn2003/11/28 01:07:13 Modified:.project.xml Log: Update Validator dependency to 1.1.1 Enable some JUnit tests Revision ChangesPath 1.12 +14 -6 jakarta-struts/project.xml Index: project.xml === RCS file: /home/cvs/jakarta-struts/project.xml,v retrieving revision 1.11 retrieving revision 1.12 diff -u -r1.11 -r1.12 --- project.xml 27 Nov 2003 19:28:13 - 1.11 +++ project.xml 28 Nov 2003 09:07:13 - 1.12 @@ -222,11 +222,19 @@ urlhttp://jakarta.apache.org/commons/logging.html/url /dependency + !-- dependency idcommons-validator/id versionSNAPSHOT/version urlhttp://jakarta.apache.org/commons/validator.html/url /dependency +-- + +dependency + idcommons-validator/id + version1.1.1-dev/version + urlhttp://jakarta.apache.org/commons/validator.html/url +/dependency dependency idoro/id @@ -286,7 +294,7 @@ sourceDirectorysrc/share/sourceDirectory - !-- Unit test cases + !-- Unit test cases -- unitTestSourceDirectorysrc/test/unitTestSourceDirectory integrationUnitTestSourceDirectory/ @@ -294,13 +302,13 @@ unitTest includes -include**/*Test.java/include +includeorg/apache/struts/action/TestDynaActionForm.java/include +includeorg/apache/struts/action/TestDynaActionFormClass.java/include +includeorg/apache/struts/config/TestModuleConfig.java/include +includeorg/apache/struts/config/TestActionConfigMatcher.java/include +includeorg/apache/struts/util/Test*.java/include /includes - excludes -exclude**/RepositoryTest.java/exclude - /excludes /unitTest --- !-- J A R R E S O U R C E S -- !-- Resources that are packaged up inside the JAR file -- - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: Maven test run
I've updated project.xml to reference the validator 1.1.1 jar. You need to manually download it from http://www.apache.org/~rleland/ and place it in your local repository. .maven plugins repository ... commons-validator -- you may need to create directories below here jars commons-validator-1.1.1-dev.jar maven jar then works (at least for me :-)) There were no tests found because the test section was commented out! (and the example include pattern doesn't match our naming convention). I've enabled the JUnit tests. Using Cactus with Maven is beyond me, for now :-) When Maven runs the tests, TestModuleConfig is throwing a NullPointerException that doesn't show up when running from Ant. I'm inclined to believe that the Maven configuration requires more work rather that it actually being a problem with ModuleConfig. The Maven build remains HIGHLY experimental!! Steve -Original Message- From: Martin Cooper [mailto:[EMAIL PROTECTED] Sent: November 28, 2003 12:05 AM To: Struts Developers List Subject: Re: Maven test run After copying my local Validator build to Maven's repo, I get the same as you do - no tests to run. Doing the Ant test.junit thing, I get the TestActionConfigMatcher failure, but it looks like Steve has tracked that one down. -- Martin Cooper On Thu, 27 Nov 2003, James Mitchell wrote: On Thu, 27 Nov 2003, Ted Husted wrote: When I run the maven jar target, the upload tests fail (MultipartTestSuite). On a fresh copy ofwelleverything (maven 1.0-rc1, jakarta-struts, etc, etc) I cannot do anything with maven. The attempt to download validator SNAPSHOT fails. When I change project.xml to use 1.0.1 or 1.0.2, it downloads, but the compile fails complaining about missing ValidatorUtils. I downloaded a nightly, moved it to ~/.maven/repository/commons-validator/jars/. Then changed SNAPSHOT to nightly in project.xml. Then this: [EMAIL PROTECTED] jakarta-struts]$ maven jar __ __ | \/ |__ _Apache__ ___ | |\/| / _` \ V / -_) ' \ ~ intelligent projects ~ |_| |_\__,_|\_/\___|_||_| v. 1.0-rc1-SNAPSHOT java:prepare-filesystem: java:compile: [echo] Compiling to m-target/classes [javac] Compiling 266 source files to /home/jmitchell/cvs/jakarta-struts/m-target/classes /home/jmitchell/cvs/jakarta-struts/src/share/org/apache/struts /tiles/actions/DefinitionDispatcherAction.java:78: warning: org.apache.struts.tiles.DefinitionsUtil in org.apache.struts.tiles has been deprecated import org.apache.struts.tiles.DefinitionsUtil; ^ huge-snip/ /home/jmitchell/cvs/jakarta-struts/src/share/org/apache/struts /validator/ValidatorPlugIn.java:264: warning: org.apache.commons.validator.ValidatorResourcesInitializer in org.apache.commons.validator has been deprecated ValidatorResourcesInitializer.initialize(resources, bis, false); ^ 41 warnings java:jar-resources: Copying 15 files to /home/jmitchell/cvs/jakarta-struts/m-target/classes test:prepare-filesystem: [mkdir] Created dir: /home/jmitchell/cvs/jakarta-struts/m-target/test-classes [mkdir] Created dir: /home/jmitchell/cvs/jakarta-struts/m-target/test-reports test:test-resources: test:compile: [echo] No test source files to compile. test:test: [echo] No tests to run. jar:jar: [jar] Building jar: /home/jmitchell/cvs/jakarta-struts/m-target/struts-1.2.0.jar BUILD SUCCESSFUL Total time: 26 seconds Finished at: Fri Nov 28 01:40:35 EST 2003 No tests to runAm I missing something here? But, when I run the ant test.junit test, only the TestActionConfigMatcher test fails. Is it me, or do others share this experience? If so, any ideas as to why this would be? -Ted. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: Maven test run
Me too! Steve -Original Message- From: Martin Cooper [mailto:[EMAIL PROTECTED] Sent: November 28, 2003 12:56 AM To: Struts Developers List Subject: RE: Maven test run On Thu, 27 Nov 2003 [EMAIL PROTECTED] wrote: Good point, thanks for solving the mystery. I've updated the test to not depend on the hashmap order. Cool. Works for me. :-) -- Martin Cooper - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Legacy APIs - Short Term Plan
The current Javadocs are bundled with the documentation, in the struts-documentation.war. :) Andrew Hill wrote: While your at it how about actually including the javadocs in the distribution (or the source dist). A static html version of the other struts docs that doesnt require you to crank up a servlet container everytime you want to check something would also be very nice. -Original Message- From: Ted Husted [mailto:[EMAIL PROTECTED] Sent: Friday, 28 November 2003 10:32 To: Struts Developers List Subject: Re: Legacy APIs - Short Term Plan David Graham wrote: By API do you mean javadocs? I've found it useful to compare Sun's JDK javadocs between versions and I imagine some people would like to compare Struts versions. People who wish to do this can maintain their own local copies (and save some of the bandwidth people kindly contribute to us). Maintaining them through our web site just confuses people. It made sense when there was a big gap between releases, but, hopefully, those days are past. -Ted. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- Ted Husted, Junit in Action - http://www.manning.com/massol/, Struts in Action - http://husted.com/struts/book.html, JSP Site Design - http://www.amazon.com/exec/obidos/ISBN=1861005512. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Maven test run
Steve Raeburn wrote: There were no tests found because the test section was commented out! (and the example include pattern doesn't match our naming convention). I've enabled the JUnit tests. Using Cactus with Maven is beyond me, for now :-) Mea culpa on the comment block. I did that to see if I could get the rest of it to run, and then committed it accidentally. head-slap/ When Maven runs the tests, TestModuleConfig is throwing a NullPointerException that doesn't show up when running from Ant. I'm inclined to believe that the Maven configuration requires more work rather that it actually being a problem with ModuleConfig. The Maven build remains HIGHLY experimental!! I wonder if we could try a compromise? Could we have a Maven build that just downloaded the dependencies into the central repository, and a build.properties that got everything from there. This would save us from going back to a struts-library distribution. I also wonder if it be possible to wrap our existing Ant build as Maven goals? The user guide says that any Ant task can be used in the maven.xml. http://maven.apache.org/reference/user-guide.html#Sample%20maven.xml Another stepping-stone might be to provide Maven projects for the examples applications, especially the blank application. I'm thinking the cannonical approach here would be to have a master webapp-project.xml that we then extended for each application artifact. http://maven.apache.org/reference/user-guide.html#POM%20Inheritance I'm working on a changelog system now but will come back to this later, if no one beats me to it. [Please do, if you can :)] -Ted. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-struts project.properties
husted 2003/11/28 09:26:00
Modified:.project.properties
Log:
Remove legacy directory from Maven site build
Revision ChangesPath
1.2 +3 -4 jakarta-struts/project.properties
Index: project.properties
===
RCS file: /home/cvs/jakarta-struts/project.properties,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- project.properties23 Aug 2003 03:01:24 - 1.1
+++ project.properties28 Nov 2003 17:26:00 - 1.2
@@ -21,13 +21,12 @@
#keep ant maven directories seperate.
maven.build.dir=m-target
-# Include legacy javadoc in build
-maven.html2xdoc.dir = legacy
-
# display the date on the site
maven.xdoc.date = left
# Display the version the web site is documenting
maven.xdoc.version = ${pom.currentVersion}
+#
+maven.changelog.range=180
compile.debug = on
compile.optimize = off
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-struts/doc/reports - New directory
husted 2003/11/28 09:26:15 jakarta-struts/doc/reports - New directory - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-struts/doc/reports changelog-report.xml cvs-usage.xml dependencies.xml file-activity-report.xml index.xml project.xml
husted 2003/11/28 09:27:28 Added: doc/reports changelog-report.xml cvs-usage.xml dependencies.xml file-activity-report.xml index.xml project.xml Log: Add some Maven-generated reports to current website build. Revision ChangesPath 1.1 jakarta-struts/doc/reports/changelog-report.xml http://cvs.apache.org/viewcvs/jakarta-struts/doc/reports/changelog-report.xml?rev=1.1 1.1 jakarta-struts/doc/reports/cvs-usage.xml http://cvs.apache.org/viewcvs/jakarta-struts/doc/reports/cvs-usage.xml?rev=1.1 1.1 jakarta-struts/doc/reports/dependencies.xml http://cvs.apache.org/viewcvs/jakarta-struts/doc/reports/dependencies.xml?rev=1.1 1.1 jakarta-struts/doc/reports/file-activity-report.xml http://cvs.apache.org/viewcvs/jakarta-struts/doc/reports/file-activity-report.xml?rev=1.1 1.1 jakarta-struts/doc/reports/index.xml http://cvs.apache.org/viewcvs/jakarta-struts/doc/reports/index.xml?rev=1.1 1.1 jakarta-struts/doc/reports/project.xml http://cvs.apache.org/viewcvs/jakarta-struts/doc/reports/project.xml?rev=1.1 - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-struts/doc project.xml
husted 2003/11/28 09:30:01 Modified:doc project.xml Log: Add some Maven-generated reports to current website build. Revision ChangesPath 1.43 +58 -60jakarta-struts/doc/project.xml Index: project.xml === RCS file: /home/cvs/jakarta-struts/doc/project.xml,v retrieving revision 1.42 retrieving revision 1.43 diff -u -r1.42 -r1.43 --- project.xml 27 Nov 2003 04:06:51 - 1.42 +++ project.xml 28 Nov 2003 17:30:01 - 1.43 @@ -1,104 +1,102 @@ ?xml version=1.0 encoding=ISO-8859-1? project - name=Struts Framework +name=Struts Framework href=http://jakarta.apache.org/struts; image=images/struts.gif title - Apache Struts Web Application Framework +Apache Struts Web Application Framework /title menu name=Struts item - name=Welcome - href=index.html - / -item - name=Learning - href=learning.html - / -item - name=Acquiring - href=acquiring.html - / -item - name=Using - href=using.html - / -item - name=Who We Are - href=volunteers.html - / +name=Welcome +href=index.html +/ +item +name=Learning +href=learning.html +/ +item +name=Acquiring +href=acquiring.html +/ +item +name=Using +href=using.html +/ item - name=Announcements +name=Who We Are +href=volunteers.html +/ +item +name=Announcements href=announce.html / /menu menu name=Documentation item - name=User and Developer Guides +name=User and Developer Guides href=userGuide/index.html / item - name=Javadoc +name=Javadoc href=api/index.html / item - name=FAQs and Howtos - href=faqs/index.html - / +name=FAQs and Howtos +href=faqs/index.html +/ /menu menu name=Community item - name=Known Issues (Bugzilla) - href=http://jakarta.apache.org/site/bugs.html; - / -item - name=Wiki Pages - href=http://nagoya.apache.org/wiki/apachewiki.cgi?StrutsProjectPages; - / -item - name=List Archive - href=http://nagoya.apache.org/eyebrowse/SummarizeList?listId=42; - / -item - name=Resource Directory - href=http://struts.sf.net/community/index.html; - / +name=Known Issues (Bugzilla) +href=http://jakarta.apache.org/site/bugs.html; +/ +item +name=Wiki Pages +href=http://nagoya.apache.org/wiki/apachewiki.cgi?StrutsProjectPages; +/ +item +name=List Archive +href=http://nagoya.apache.org/eyebrowse/SummarizeList?listId=42; +/ +item +name=Resource Directory +href=http://struts.sf.net/community/index.html; +/ /menu menu name=Download item - name=Binaries - href=http://jakarta.apache.org/site/binindex.cgi; - / -item - name=Source Code - href=http://jakarta.apache.org/site/sourceindex.cgi; - / +name=Binaries +href=http://jakarta.apache.org/site/binindex.cgi; +/ +item +name=Source Code +href=http://jakarta.apache.org/site/sourceindex.cgi; +/ /menu menu name=Development +item name=CVS Access href=reports/cvs-usage.html/ item - name=CVS Repository - href=http://cvs.apache.org/viewcvs/jakarta-struts/; - / +name=CVS Repository +href=http://cvs.apache.org/viewcvs/jakarta-struts/; +/ +item name=CVS Changelog href=reports/changelog-report.html/ +item name=File Activity
cvs commit: jakarta-struts/doc releases.xml
husted 2003/11/28 09:33:30 Modified:doc releases.xml Log: Add note to alert PMC. Revision ChangesPath 1.4 +8 -6 jakarta-struts/doc/releases.xml Index: releases.xml === RCS file: /home/cvs/jakarta-struts/doc/releases.xml,v retrieving revision 1.3 retrieving revision 1.4 diff -u -r1.3 -r1.4 --- releases.xml 11 Sep 2003 23:08:12 - 1.3 +++ releases.xml 28 Nov 2003 17:33:30 - 1.4 @@ -65,11 +65,6 @@ ul li -Remember to update the a href=news/index.htmlStatus section of the News page/a when cutting any -milestone. -For a final release, also update the /doc/project.xml with the current release number. -/li -li The release process can seem daunting when you review it for the first time. But, essentially, it breaks down into three phases of just a few steps each: ul @@ -105,7 +100,7 @@ to take advantage of all available compiler enhancements. /li li -Before building the final release, run the JUnit and Cactus tests using the same +Before building the release, run the JUnit and Cactus tests using the same configuration used that will be used to build the Release distribution. /li li @@ -113,6 +108,13 @@ Before uploading the release, extract the sample web applications and deploy the WARs under each of the supported containers. Play test each application under each container to be sure they operate nominally. +/li +li +Be sure to copy the [EMAIL PROTECTED] list on any release announcement. +/li +li +Remember to update the a href=status.htmlStatus section of the Roadmap page/a +once a release is available. /li li By the way, the nightly builds are being created on a machine of Craig McClanahan's. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: When is the next release?
Craig R. McClanahan wrote: Another thing Remy does for Tomcat (which I *really* appreciate) is keeps a running change log (summary, not detailed) in the release notes for each version. That way, everyone can get a quick summary of what's changed. Ted Husted wrote: So, I'm working on one of these now for 1.1-1.2.0. I pulled the CVS log messages down in XML via Ant (with Don Brown's help), and I'm now looking at munging that into the format Tomcat is using. I used Maven to generate a six-month changelog, snagged a couple of other likely suspects, and integrated the XML doc into our own build. Huge hack, but it seemed like the shortest route to get a summary changelog up for this release. The six-month changelog is huge, so I'm not going to post it to the site right now. But, it's in CVS if anyone wants to check it out. We should probably do the log in monthly chunks and hyperlink them together. Next, I'll review this to see if we caught all the high-points in the release notes. -Ted. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 25064] - Struts should not ignors response.isCommitted() tag
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25064. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25064 Struts should not ignors response.isCommitted() tag [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Additional Comments From [EMAIL PROTECTED] 2003-11-28 18:03 --- Your filter should not pass the request down the chain after it sends the error message if you don't want your action to execute. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Should Validator use a .js file script?
Hello guys, I'm wondering why does the Validator tag html:javascript/ prints out all the validation scripts instead of only the required javascript functions. This could be ever better: there could be a .js file with all the scripts for avoiding sending the validation scripts at each page, enabling the browser to cache its content. When talking about a high scale application, this *does* matter. Thank you guys, and continue the great work! Stutz - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: Maven test run
I submitted a patch recently for the maven build. Sorry I didn't get a chance to (aka.. Just been lazy) attach it to a formal bugzilla report as Rob had suggested that I do. The maven test currently fail because the resources are not provided (look at my past post for reference). Unfortunately, even after including the source there are still test failures. I posted a sniplet of one of the errors before. I never bothered to find out if those test failures were due to the maven build or because of incorrectly written tests. Either way, I'll try to find some time to fix the maven build if anyone is interested. Tim Chen [EMAIL PROTECTED] -Original Message- From: Ted Husted [mailto:[EMAIL PROTECTED] Sent: Friday, November 28, 2003 8:50 AM To: Struts Developers List Subject: Re: Maven test run Steve Raeburn wrote: There were no tests found because the test section was commented out! (and the example include pattern doesn't match our naming convention). I've enabled the JUnit tests. Using Cactus with Maven is beyond me, for now :-) Mea culpa on the comment block. I did that to see if I could get the rest of it to run, and then committed it accidentally. head-slap/ When Maven runs the tests, TestModuleConfig is throwing a NullPointerException that doesn't show up when running from Ant. I'm inclined to believe that the Maven configuration requires more work rather that it actually being a problem with ModuleConfig. The Maven build remains HIGHLY experimental!! I wonder if we could try a compromise? Could we have a Maven build that just downloaded the dependencies into the central repository, and a build.properties that got everything from there. This would save us from going back to a struts-library distribution. I also wonder if it be possible to wrap our existing Ant build as Maven goals? The user guide says that any Ant task can be used in the maven.xml. http://maven.apache.org/reference/user-guide.html#Sample%20maven.xml Another stepping-stone might be to provide Maven projects for the examples applications, especially the blank application. I'm thinking the cannonical approach here would be to have a master webapp-project.xml that we then extended for each application artifact. http://maven.apache.org/reference/user-guide.html#POM%20Inheritance I'm working on a changelog system now but will come back to this later, if no one beats me to it. [Please do, if you can :)] -Ted. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Should Validator use a .js file script?
Yes, you're right. :) See the staticJavascript property to generate the suite of scripts. For a usage example, see the Struts Mailreader Example (struts-example.war) in the binary distribution. [EMAIL PROTECTED] wrote: Hello guys, I'm wondering why does the Validator tag html:javascript/ prints out all the validation scripts instead of only the required javascript functions. This could be ever better: there could be a .js file with all the scripts for avoiding sending the validation scripts at each page, enabling the browser to cache its content. When talking about a high scale application, this *does* matter. Thank you guys, and continue the great work! Stutz - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- Ted Husted, Junit in Action - http://www.manning.com/massol/, Struts in Action - http://husted.com/struts/book.html, JSP Site Design - http://www.amazon.com/exec/obidos/ISBN=1861005512. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[Fwd: Re: Maven test run]
And, for extra credit, if anyone were interested in trying it, a Mavenized version of Martin's very cool release target would be very useful. It wraps up both the source and binary distributions in both .zip and .gz format, ready for upload. Something like this should probably be a Maven plugin, since its something all the Jakarta projects need to do. -Ted. Original Message Subject: Re: Maven test run Date: Fri, 28 Nov 2003 13:55:44 -0500 From: Ted Husted [EMAIL PROTECTED] Reply-To: Struts Developers List [EMAIL PROTECTED] Organization: Apache Software Foundation - Jakarta Project To: Struts Developers List [EMAIL PROTECTED] References: [EMAIL PROTECTED] We are interested in fixing the Maven build. The tests seem to run under the conventional build, which would imply that the issue may be in the Maven setup. Along with the core, we would also need a strategy for building the various example web applications. I'm thinking we may need a master webapps-projects.xml that each application artifact could extend. -Ted. Tim Chen wrote: I submitted a patch recently for the maven build. Sorry I didn't get a chance to (aka.. Just been lazy) attach it to a formal bugzilla report as Rob had suggested that I do. The maven test currently fail because the resources are not provided (look at my past post for reference). Unfortunately, even after including the source there are still test failures. I posted a sniplet of one of the errors before. I never bothered to find out if those test failures were due to the maven build or because of incorrectly written tests. Either way, I'll try to find some time to fix the maven build if anyone is interested. Tim Chen [EMAIL PROTECTED] -Original Message- From: Ted Husted [mailto:[EMAIL PROTECTED] Sent: Friday, November 28, 2003 8:50 AM To: Struts Developers List Subject: Re: Maven test run Steve Raeburn wrote: There were no tests found because the test section was commented out! (and the example include pattern doesn't match our naming convention). I've enabled the JUnit tests. Using Cactus with Maven is beyond me, for now :-) Mea culpa on the comment block. I did that to see if I could get the rest of it to run, and then committed it accidentally. head-slap/ When Maven runs the tests, TestModuleConfig is throwing a NullPointerException that doesn't show up when running from Ant. I'm inclined to believe that the Maven configuration requires more work rather that it actually being a problem with ModuleConfig. The Maven build remains HIGHLY experimental!! I wonder if we could try a compromise? Could we have a Maven build that just downloaded the dependencies into the central repository, and a build.properties that got everything from there. This would save us from going back to a struts-library distribution. I also wonder if it be possible to wrap our existing Ant build as Maven goals? The user guide says that any Ant task can be used in the maven.xml. http://maven.apache.org/reference/user-guide.html#Sample%20maven.xml Another stepping-stone might be to provide Maven projects for the examples applications, especially the blank application. I'm thinking the cannonical approach here would be to have a master webapp-project.xml that we then extended for each application artifact. http://maven.apache.org/reference/user-guide.html#POM%20Inheritance I'm working on a changelog system now but will come back to this later, if no one beats me to it. [Please do, if you can :)] -Ted. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- Ted Husted, Junit in Action - http://www.manning.com/massol/, Struts in Action - http://husted.com/struts/book.html, JSP Site Design - http://www.amazon.com/exec/obidos/ISBN=1861005512. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- Ted Husted, Junit in Action - http://www.manning.com/massol/, Struts in Action - http://husted.com/struts/book.html, JSP Site Design - http://www.amazon.com/exec/obidos/ISBN=1861005512. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Should Validator use a .js file script?
Thanks!!! Yes, you're right. :) See the staticJavascript property to generate the suite of scripts. For a usage example, see the Struts Mailreader Example (struts-example.war) in the binary distribution. [EMAIL PROTECTED] wrote: Hello guys, I'm wondering why does the Validator tag html:javascript/ prints out all the validation scripts instead of only the required javascript functions. This could be ever better: there could be a .js file with all the scripts for avoiding sending the validation scripts at each page, enabling the browser to cache its content. When talking about a high scale application, this *does* matter. Thank you guys, and continue the great work! Stutz - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- Ted Husted, Junit in Action - http://www.manning.com/massol/, Struts in Action - http://husted.com/struts/book.html, JSP Site Design - http://www.amazon.com/exec/obidos/ISBN=1861005512. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [Fwd: Re: Maven test run]
On Fri, 28 Nov 2003, Ted Husted wrote: And, for extra credit, if anyone were interested in trying it, a Mavenized version of Martin's very cool release target would be very useful. It wraps up both the source and binary distributions in both .zip and .gz format, ready for upload. Something like this should probably be a Maven plugin, since its something all the Jakarta projects need to do. The maven-dist plugin does this for regular Maven projects. I don't know what it would take to get it to do the right thing for Struts, though, since I'm not much of a Maven maven myself. -- Martin Cooper -Ted. Original Message Subject: Re: Maven test run Date: Fri, 28 Nov 2003 13:55:44 -0500 From: Ted Husted [EMAIL PROTECTED] Reply-To: Struts Developers List [EMAIL PROTECTED] Organization: Apache Software Foundation - Jakarta Project To: Struts Developers List [EMAIL PROTECTED] References: [EMAIL PROTECTED] We are interested in fixing the Maven build. The tests seem to run under the conventional build, which would imply that the issue may be in the Maven setup. Along with the core, we would also need a strategy for building the various example web applications. I'm thinking we may need a master webapps-projects.xml that each application artifact could extend. -Ted. Tim Chen wrote: I submitted a patch recently for the maven build. Sorry I didn't get a chance to (aka.. Just been lazy) attach it to a formal bugzilla report as Rob had suggested that I do. The maven test currently fail because the resources are not provided (look at my past post for reference). Unfortunately, even after including the source there are still test failures. I posted a sniplet of one of the errors before. I never bothered to find out if those test failures were due to the maven build or because of incorrectly written tests. Either way, I'll try to find some time to fix the maven build if anyone is interested. Tim Chen [EMAIL PROTECTED] -Original Message- From: Ted Husted [mailto:[EMAIL PROTECTED] Sent: Friday, November 28, 2003 8:50 AM To: Struts Developers List Subject: Re: Maven test run Steve Raeburn wrote: There were no tests found because the test section was commented out! (and the example include pattern doesn't match our naming convention). I've enabled the JUnit tests. Using Cactus with Maven is beyond me, for now :-) Mea culpa on the comment block. I did that to see if I could get the rest of it to run, and then committed it accidentally. head-slap/ When Maven runs the tests, TestModuleConfig is throwing a NullPointerException that doesn't show up when running from Ant. I'm inclined to believe that the Maven configuration requires more work rather that it actually being a problem with ModuleConfig. The Maven build remains HIGHLY experimental!! I wonder if we could try a compromise? Could we have a Maven build that just downloaded the dependencies into the central repository, and a build.properties that got everything from there. This would save us from going back to a struts-library distribution. I also wonder if it be possible to wrap our existing Ant build as Maven goals? The user guide says that any Ant task can be used in the maven.xml. http://maven.apache.org/reference/user-guide.html#Sample%20maven.xml Another stepping-stone might be to provide Maven projects for the examples applications, especially the blank application. I'm thinking the cannonical approach here would be to have a master webapp-project.xml that we then extended for each application artifact. http://maven.apache.org/reference/user-guide.html#POM%20Inheritance I'm working on a changelog system now but will come back to this later, if no one beats me to it. [Please do, if you can :)] -Ted. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 25075] New: - maven build fails on tests
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25075. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25075 maven build fails on tests Summary: maven build fails on tests Product: Struts Version: Nightly Build Platform: All OS/Version: All Status: NEW Severity: Enhancement Priority: Other Component: Test AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] maven fails to build Struts due to test failures. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 25076] New: - maven build should build bin and src distributions
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25076. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25076 maven build should build bin and src distributions Summary: maven build should build bin and src distributions Product: Struts Version: Nightly Build Platform: All OS/Version: All Status: NEW Severity: Enhancement Priority: Other Component: Unknown AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] Per Ted: And, for extra credit, if anyone were interested in trying it, a Mavenized version of Martin's very cool release target would be very useful. It wraps up both the source and binary distributions in both .zip and .gz format, ready for upload. Something like this should probably be a Maven plugin, since its something all the Jakarta projects need to do. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 25076] - maven build should build bin and src distributions
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25076. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25076 maven build should build bin and src distributions --- Additional Comments From [EMAIL PROTECTED] 2003-11-28 21:24 --- Created an attachment (id=9328) Fixed maven.xml to do bin and src distributions - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 25076] - maven build should build bin and src distributions
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25076. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25076 maven build should build bin and src distributions --- Additional Comments From [EMAIL PROTECTED] 2003-11-28 21:27 --- I attached my patch to maven.xml to do a full distribution build (currently tar.gz and zip for both bin and src) I included the dtds and xmls in folder conf for both bin and src. Please let me know if anything else should be included Build simply by typing maven (tested with maven 1.0-rc1) - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 25075] - maven build fails on tests
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25075. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25075 maven build fails on tests --- Additional Comments From [EMAIL PROTECTED] 2003-11-28 21:28 --- I attached my fix to project.xml to allow building of struts without test failures. Build simply by typing maven (tested with maven 1.0-rc1) - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: [Fwd: Re: Maven test run]
Patches have been submitted to bugzilla for both project.xml and maven.xml. I am able to build struts from a clean download now by using just: maven Attached is a combined patch file. Tim Chen [EMAIL PROTECTED] -Original Message- From: Martin Cooper [mailto:[EMAIL PROTECTED] Sent: Friday, November 28, 2003 3:30 PM To: Struts Developers List Subject: Re: [Fwd: Re: Maven test run] On Fri, 28 Nov 2003, Ted Husted wrote: And, for extra credit, if anyone were interested in trying it, a Mavenized version of Martin's very cool release target would be very useful. It wraps up both the source and binary distributions in both .zip and .gz format, ready for upload. Something like this should probably be a Maven plugin, since its something all the Jakarta projects need to do. The maven-dist plugin does this for regular Maven projects. I don't know what it would take to get it to do the right thing for Struts, though, since I'm not much of a Maven maven myself. -- Martin Cooper -Ted. Original Message Subject: Re: Maven test run Date: Fri, 28 Nov 2003 13:55:44 -0500 From: Ted Husted [EMAIL PROTECTED] Reply-To: Struts Developers List [EMAIL PROTECTED] Organization: Apache Software Foundation - Jakarta Project To: Struts Developers List [EMAIL PROTECTED] References: [EMAIL PROTECTED] We are interested in fixing the Maven build. The tests seem to run under the conventional build, which would imply that the issue may be in the Maven setup. Along with the core, we would also need a strategy for building the various example web applications. I'm thinking we may need a master webapps-projects.xml that each application artifact could extend. -Ted. Tim Chen wrote: I submitted a patch recently for the maven build. Sorry I didn't get a chance to (aka.. Just been lazy) attach it to a formal bugzilla report as Rob had suggested that I do. The maven test currently fail because the resources are not provided (look at my past post for reference). Unfortunately, even after including the source there are still test failures. I posted a sniplet of one of the errors before. I never bothered to find out if those test failures were due to the maven build or because of incorrectly written tests. Either way, I'll try to find some time to fix the maven build if anyone is interested. Tim Chen [EMAIL PROTECTED] -Original Message- From: Ted Husted [mailto:[EMAIL PROTECTED] Sent: Friday, November 28, 2003 8:50 AM To: Struts Developers List Subject: Re: Maven test run Steve Raeburn wrote: There were no tests found because the test section was commented out! (and the example include pattern doesn't match our naming convention). I've enabled the JUnit tests. Using Cactus with Maven is beyond me, for now :-) Mea culpa on the comment block. I did that to see if I could get the rest of it to run, and then committed it accidentally. head-slap/ When Maven runs the tests, TestModuleConfig is throwing a NullPointerException that doesn't show up when running from Ant. I'm inclined to believe that the Maven configuration requires more work rather that it actually being a problem with ModuleConfig. The Maven build remains HIGHLY experimental!! I wonder if we could try a compromise? Could we have a Maven build that just downloaded the dependencies into the central repository, and a build.properties that got everything from there. This would save us from going back to a struts-library distribution. I also wonder if it be possible to wrap our existing Ant build as Maven goals? The user guide says that any Ant task can be used in the maven.xml. http://maven.apache.org/reference/user-guide.html#Sample%20maven.xml Another stepping-stone might be to provide Maven projects for the examples applications, especially the blank application. I'm thinking the cannonical approach here would be to have a master webapp-project.xml that we then extended for each application artifact. http://maven.apache.org/reference/user-guide.html#POM%20Inheritance I'm working on a changelog system now but will come back to this later, if no one beats me to it. [Please do, if you can :)] -Ted. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] Index: project.xml === RCS file: /home/cvspublic/jakarta-struts/project.xml,v
DO NOT REPLY [Bug 25076] - maven build should build bin and src distributions
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25076. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25076 maven build should build bin and src distributions --- Additional Comments From [EMAIL PROTECTED] 2003-11-28 21:58 --- It wraps up both the source and binary distributions in both .zip and .gz format, ready for upload. Something like this should probably be a Maven plugin Maven already does this by default; you just have to say maven dist and Maven does the rest. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 25075] - maven build fails on tests
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25075. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25075 maven build fails on tests [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2003-11-28 22:05 --- Thanks Tim! - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-struts project.xml
husted 2003/11/28 14:05:55
Modified:.project.xml
Log:
Apply Tim Chen's patch (#25075) to fix the Maven build.
Revision ChangesPath
1.13 +16 -0 jakarta-struts/project.xml
Index: project.xml
===
RCS file: /home/cvs/jakarta-struts/project.xml,v
retrieving revision 1.12
retrieving revision 1.13
diff -u -r1.12 -r1.13
--- project.xml 28 Nov 2003 09:07:13 - 1.12
+++ project.xml 28 Nov 2003 22:05:55 - 1.13
@@ -308,6 +308,22 @@
includeorg/apache/struts/config/TestActionConfigMatcher.java/include
includeorg/apache/struts/util/Test*.java/include
/includes
+ resources
+resource
+ directory${basedir}/conf/share/directory
+ targetPathorg/apache/struts/resources/targetPath
+ includes
+ include**/*.xml/include
+ include**/*.dtd/include
+ /includes
+ /resource
+ resource
+ directory${basedir}/src/test/directory
+ includes
+ include**/*.xml/include
+ /includes
+ /resource
+ /resources
/unitTest
!-- J A R R E S O U R C E S --
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 25076] - maven build should build bin and src distributions
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25076. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25076 maven build should build bin and src distributions --- Additional Comments From [EMAIL PROTECTED] 2003-11-28 22:09 --- Unfortunately the default dist misses alot of the files that I think should be distributed with struts (dtds and xmls). These cannot be added with a simple change to project.properties. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Maven test run
OK, the Maven build is looking good. Thanks ever so much, Tim! Now the next question on this front is what to do about the various web applications? We had been rolling these into the binary distribution as WARS. The default Maven dist target seems fine for core, but it may be hard to extend to do exactly what we did before. I believe the cannonical Maven answer would be to have another distribution for the web applications, or perhaps a distribution for each. Thoughts? Experiences? Wild ideas? At this point, I'm neither suggesting nor assuming that we would want to distribute 1.2.0 via Maven. Though, it's now becoming a possibility. I'm taking a close look at the site build now. -Ted. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-struts/src/share/org/apache/struts/taglib/html JavascriptValidatorTag.java
dgraham 2003/11/28 14:55:36
Modified:src/share/org/apache/struts/taglib/html
JavascriptValidatorTag.java
Log:
Removed getNextVar() and replaceChar() methods and use
a simpler javascript identifier naming scheme. All variables
with be named a0, a1, etc. to prevent using reserved words
as variable names. PR# 24516
Revision ChangesPath
1.40 +9 -58
jakarta-struts/src/share/org/apache/struts/taglib/html/JavascriptValidatorTag.java
Index: JavascriptValidatorTag.java
===
RCS file:
/home/cvs/jakarta-struts/src/share/org/apache/struts/taglib/html/JavascriptValidatorTag.java,v
retrieving revision 1.39
retrieving revision 1.40
diff -u -r1.39 -r1.40
--- JavascriptValidatorTag.java 28 Sep 2003 17:02:51 - 1.39
+++ JavascriptValidatorTag.java 28 Nov 2003 22:55:36 - 1.40
@@ -7,7 +7,7 @@
*
* The Apache Software License, Version 1.1
*
- * Copyright (c) 1999-2003 The Apache Software Foundation. All rights
+ * Copyright (c) 2001-2003 The Apache Software Foundation. All rights
* reserved.
*
* Redistribution and use in source and binary forms, with or without
@@ -423,7 +423,7 @@
for (Iterator i = actions.iterator(); i.hasNext();) {
ValidatorAction va = (ValidatorAction) i.next();
-String jscriptVar = null;
+int jscriptVar = 0;
String functionName = null;
if (va.getJsFunctionName() != null
@@ -450,11 +450,10 @@
message = (message != null) ? message : ;
-jscriptVar = this.getNextVar(jscriptVar);
-
+// prefix variable with 'a' to make it a legal identifier
results.append(
- this.
-+ jscriptVar
+ this.a
++ jscriptVar++
+ = new Array(\
+ field.getKey()
+ \, \
@@ -724,54 +723,6 @@
sb.append(/script\n\n);
return sb.toString();
-}
-
-/**
- * The value codenull/code will be returned at the end of the sequence.
- * nbsp;nbsp;nbsp; ex: zz will return codenull/code
- */
-private String getNextVar(String input) {
-if (input == null) {
-return aa;
-}
-
-input = input.toLowerCase();
-
-for (int i = input.length(); i 0; i--) {
-int pos = i - 1;
-
-char c = input.charAt(pos);
-c++;
-
-if (c = 'z') {
-if (i == 0) {
-return c + input.substring(pos, input.length());
-} else if (i == input.length()) {
-return input.substring(0, pos) + c;
-} else {
-return input.substring(0, pos) + c + input.substring(pos,
input.length() - 1);
-}
-} else {
-input = replaceChar(input, pos, 'a');
-}
-
-}
-
-return null;
-
-}
-
-/**
- * Replaces a single character in a codeString/code
- */
-private String replaceChar(String input, int pos, char c) {
-if (pos == 0) {
-return c + input.substring(pos, input.length());
-} else if (pos == input.length()) {
-return input.substring(0, pos) + c;
-} else {
-return input.substring(0, pos) + c + input.substring(pos,
input.length() - 1);
-}
}
/**
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 24516] - excessive input and javascript 'do' keyword
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24516. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24516 excessive input and javascript 'do' keyword [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2003-11-28 22:56 --- Fixed. Removed getNextVar() and replaceChar() and use a simpler naming scheme of a1, a2, a3, etc. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: BUG fix for org.apache.struts.taglib.html.JavascriptValidatorTag
Thanks for the fix idea. It would have been better if you posted this
directly to the bugzilla ticket though.
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24516
David
--- Igor Marchenko [EMAIL PROTECTED] wrote:
Hello all.
BUG
---
I use Struts's ValidatorPlagin in client validation manner. It generates
an
JavaScript Array of field checks to made. Example:
function validatorRuleName () {
this.aa = new Array(...));
this.ab = new Array(...));
this.ac = new Array(...));
this.ad = new Array(...));
this.ae = new Array(...));
...
this.do = new Array(...));
...
this.in = new Array(...));
...
}
But do and in is JavaScript reserved words. Therefore if there is
quite
a few field who need validation this.do and this.in appears (this is
syntax error).
FAST FIX
Override org.apache.struts.taglib.html.JavascriptValidatorTag#getNextVar
method as here:
private String getNextVar(String input) {
return _+(input==null?0:(Integer.parseInt(input.substring(1))+1));
}
DEEPER FIX
--
It's clear,
org.apache.struts.taglib.html.JavascriptValidatorTag#getNextVar
method is not needed. Remove them at all and correct
org.apache.struts.taglib.html.JavascriptValidatorTag#doStartTag method
correspondingly.
Replace next lines
String jscriptVar = null;
jscriptVar = this.getNextVar(jscriptVar);
results.append(
this.
+ jscriptVar
+ = new Array(\
+ field.getKey()
+ \, \
+ message
+ \, );
with
int jscriptVar = 0;
results.append( this.)
.append(jscriptVar++)
.append( = new Array(\)
.append(field.getKey())
.append(\, \)
.append(message)
.append(\, );
OTHER WORDS
---
I check both fix ways with big number (more than 100) of checks on one
page.
Big thanx for all Struts developers.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
__
Do you Yahoo!?
Free Pop-Up Blocker - Get it now
http://companion.yahoo.com/
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 24158] - Cannot find global ActionForward for name
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24158. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24158 Cannot find global ActionForward for name [EMAIL PROTECTED] changed: What|Removed |Added Severity|Blocker |Normal Status|NEW |RESOLVED Resolution||INVALID --- Additional Comments From [EMAIL PROTECTED] 2003-11-28 23:05 --- We need much more info to solve this issue (if it is indeed a Struts error). Reopen this ticket with more info after asking for help on the struts-user mailing list. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Maven test run
Steve, would it be possible to merge what you started here with the current Maven build? -Ted. Steve Raeburn wrote: In the spirit of rolling up sleeves, this is the result of a very quick look at Maven: http://www.apache.org/~sraeburn/maven/index.html I'll keep playing with this for now, because it's not fit to be checked in yet and I've only built the core /src/share files. There's also more work to do in configuring the various reports. Don't expect all the links to work, or any of the reports to be correct (though already, some of them look useful). Steve - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- Ted Husted, Junit in Action - http://www.manning.com/massol/, Struts in Action - http://husted.com/struts/book.html, JSP Site Design - http://www.amazon.com/exec/obidos/ISBN=1861005512. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 10027] - Locked file struts.jar after Tomcat manager/stop and manager/remove
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10027. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10027 Locked file struts.jar after Tomcat manager/stop and manager/remove [EMAIL PROTECTED] changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution||INVALID --- Additional Comments From [EMAIL PROTECTED] 2003-11-28 23:12 --- Closing this ticket because there are comments in Tomcat bug #10026 that indicate this is an XML parser issue and has been fixed in early versions of Tomcat 5. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 16783] - stop and start ( restart) application
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16783. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16783 stop and start ( restart) application This bug depends on bug 10027, which changed state: What|Old Value |New Value Status|REOPENED|RESOLVED Resolution||INVALID - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 16783] - stop and start ( restart) application
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16783. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16783 stop and start ( restart) application [EMAIL PROTECTED] changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution||INVALID --- Additional Comments From [EMAIL PROTECTED] 2003-11-28 23:13 --- Closing this ticket because there are comments in Tomcat bug #10026 that indicate this is an XML parser issue and has been fixed in early versions of Tomcat 5. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 22878] - LookupDispatchAction throws NullPointerException during first execution
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22878. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22878 LookupDispatchAction throws NullPointerException during first execution [EMAIL PROTECTED] changed: What|Removed |Added Severity|Normal |Enhancement Summary|LookupDispatchAction throws |LookupDispatchAction throws |NullPointerException during |NullPointerException during |first execute after tomcat |first execution |start | - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 23605] - Add prefix servlet mapping support for modules
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=23605. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=23605 Add prefix servlet mapping support for modules [EMAIL PROTECTED] changed: What|Removed |Added Severity|Normal |Enhancement Summary|sub-applications and prefix |Add prefix servlet mapping |servlet-mapping do not work |support for modules - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 24356] - html:form should not require form bean or should use better warning
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24356. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24356 html:form should not require form bean or should use better warning [EMAIL PROTECTED] changed: What|Removed |Added Severity|Normal |Enhancement Component|Unknown |Custom Tags Summary|Cannot retrieve definition |html:form should not |for form bean null warning |require form bean or should |too late and not precise or |use better warning |unnecessary altogether? | - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: Maven test run
Sure, I'll have a go at it this evening. I'm not sure how far different they are anyway. Steve -Original Message- From: Ted Husted [mailto:[EMAIL PROTECTED] Sent: November 28, 2003 3:10 PM To: Struts Developers List Subject: Re: Maven test run Steve, would it be possible to merge what you started here with the current Maven build? -Ted. Steve Raeburn wrote: In the spirit of rolling up sleeves, this is the result of a very quick look at Maven: http://www.apache.org/~sraeburn/maven/index.html I'll keep playing with this for now, because it's not fit to be checked in yet and I've only built the core /src/share files. There's also more work to do in configuring the various reports. Don't expect all the links to work, or any of the reports to be correct (though already, some of them look useful). Steve - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- Ted Husted, Junit in Action - http://www.manning.com/massol/, Struts in Action - http://husted.com/struts/book.html, JSP Site Design - http://www.amazon.com/exec/obidos/ISBN=1861005512. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 24917] - match struts-config.mapping with the exits in the *Action.java files and warn about inconsistencies
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24917. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24917 match struts-config.mapping with the exits in the *Action.java files and warn about inconsistencies [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Additional Comments From [EMAIL PROTECTED] 2003-11-28 23:38 --- Struts can't read your .java files. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 18289] - Dynamic Message Resources
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18289. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18289 Dynamic Message Resources [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Keywords|PatchAvailable | Resolution||WONTFIX --- Additional Comments From [EMAIL PROTECTED] 2003-11-28 23:41 --- Even if your MessageResources could refresh the rest of your app (ie. .class files) wouldn't. A better solution to this problem is to reload your app which takes about 3 seconds in Tomcat. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 24477] - notrequiredif
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24477. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24477 notrequiredif [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||WONTFIX --- Additional Comments From [EMAIL PROTECTED] 2003-11-28 23:44 --- This is covered by the more flexible proposal in bug #22743. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 24119] - warn if form values initialized
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24119. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24119 warn if form values initialized [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||WONTFIX --- Additional Comments From [EMAIL PROTECTED] 2003-11-28 23:50 --- http://jakarta.apache.org/struts/faqs/newbie.html#checkbox - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 24000] - Cannot find bean under name org.apache.struts.taglib.html.BEAN (forgot to put the name in a multibox)
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24000. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24000 Cannot find bean under name org.apache.struts.taglib.html.BEAN (forgot to put the name in a multibox) [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Additional Comments From [EMAIL PROTECTED] 2003-11-28 23:57 --- The docs for the html:multibox name attribute say, The attribute name of the bean whose properties are consulted when rendering the current value of this input field. If not specified, the bean associated with the form tag we are nested within is utilized. http://jakarta.apache.org/struts/userGuide/struts-html.html#multibox Since you didn't specify a name it tried to use the default and still failed, which is what the message is telling you. Struts can't do anything about the line number issue. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 23776] - Add webhost to http://jakarta.apache.org/struts/resources/hosts.html
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=23776. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=23776 Add webhost to http://jakarta.apache.org/struts/resources/hosts.html [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||WONTFIX --- Additional Comments From [EMAIL PROTECTED] 2003-11-29 00:02 --- We no longer maintain a list of hosts. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
