digester parse error handling

2001-03-29 Thread Deadman, Hal
I was surprised to see that the Digester ignores parsing errors by overriding fatalError(), error() and warning() and just logging the parse exception without re-throwing it. The default behavior for the HandlerBase fatalError() method is to re-throw the exception so it seems like Digester should

RE: struts-config_1_0.dtd location when not connected to internet

2001-03-30 Thread Deadman, Hal
It's important the public identifier part of the DOCTYPE matches the one used when registering the local dtd. The part in quotes after PUBLIC and before the URL is used when registering the local DTD. !DOCTYPE struts-config PUBLIC "-//Apache Software Foundation//DTD Struts Configuration

RE: PropertyUtils.java

2001-04-03 Thread Deadman, Hal
I would recommend submitting your fix as a bug report on bugzilla. http://nagoya.apache.org/bugzilla/ It's much more likely to get dealt with if you submit it there. Hal -Original Message- From: Rashid Desai [mailto:[EMAIL PROTECTED]] Sent: Tuesday, April 03, 2001 3:05 PM To:

RE: cvs commit: jakarta-struts/src/share/org/apache/struts/action Action.java ActionForm.java

2001-05-11 Thread Deadman, Hal
that since isCancelled is a protected method in the Action class, that it was the Action developer's job to call the method. -Original Message- From: Deadman, Hal [mailto:[EMAIL PROTECTED]] Sent: Friday, May 11, 2001 1:24 PM To: [EMAIL PROTECTED] Subject: RE: cvs commit: jakarta

RE: RE-2: cvs commit: jakarta-struts/src/share/org/apache/struts/acti on Action.java ActionForm.java

2001-05-11 Thread Deadman, Hal
: cvs commit: jakarta-struts/src/share/org/apache/struts/action Action.java ActionForm.java Hal, It was my understanding that since isCancelled is a protected method in the Action class, that it was the Action developer's job to call the method. -Original Message- From: Deadman

RE: cvs commit: jakarta-struts/src/share/org/apache/struts/util RequestUtils.java

2001-05-15 Thread Deadman, Hal
What's the plan regarding forwarding the orignal request instead of the wrapped request? Form submissions don't work in the current Struts build, at least not on Weblogic 6.0. If ActionServlet is changed to unwrap the request before fowarding, Cedric Dumoulin will need to change his Components

RE: cvs commit: jakarta-struts/src/share/org/apache/struts/util R equestUtils.java

2001-05-17 Thread Deadman, Hal
? -Original Message- From: Deadman, Hal [mailto:[EMAIL PROTECTED]] Sent: Tuesday, May 15, 2001 5:21 PM To: [EMAIL PROTECTED] Cc: 'Cedric Dumoulin' Subject: RE: cvs commit: jakarta-struts/src/share/org/apache/struts/util RequestUtils.java What's the plan regarding forwarding

RE: cvs commit: jakarta-struts/src/share/org/apache/struts/util RequestUtils.java

2001-06-01 Thread Deadman, Hal
Does this change mean that there will be a link generated that looks like this: some.jsp?test=1amp;test=2 instead of some.jsp?test=1test=2 If so, I don't think that will work. It doesn't work on Weblogic 6.0. Calling getParameterValues() only sees the first value. Hal -Original

RE: Bugzilla #1879 (Connection Pool handling of Stale Connections)

2001-06-01 Thread Deadman, Hal
I agree, isClosed() won't work. An option for a testing a connection with a do-nothing SQL statement is needed. This is pretty standard for most connection pools that I have seen. -Original Message- From: Craig R. McClanahan [mailto:[EMAIL PROTECTED]] Sent: Friday, June 01, 2001 5:41

RE: cvs commit: jakarta-struts/src/share/org/apache/struts/util RequestUtils.java

2001-06-01 Thread Deadman, Hal
RequestUtils.java On Fri, 1 Jun 2001, Deadman, Hal wrote: Does this change mean that there will be a link generated that looks like this: some.jsp?test=1amp;test=2 instead of some.jsp?test=1test=2 Yes, in the generated HTML code of the page (i.e. when you do a view source

RE: Client/Server Side Validation for Struts 1.1

2001-06-04 Thread Deadman, Hal
Forcing a phone number or zip code to match some regular expression doesn't really make it valid. The only way to validate that kind of thing is to interface with an address verification system and that is only available in relatively few countries. It's in a users best interest to enter a valid

RE: Hot to get the iterated objects ?

2001-07-23 Thread Deadman, Hal
I am looking forward to the seeing indexed tags in the nightly build. Has a commiter signed up to incorporate the indexed tag changes? As for feedback on the code, I don't think it's appropriate to blow off the whole tag without comment if the tag with indexed=true is not nested in an iterate

RE: findForward and Errors

2001-08-14 Thread Deadman, Hal
You can put an entry in the property files like this: error.message=Error {0} or error.message={0} and then you can do something like this: ...new ActionError(error.message, e.getMessage())... or whatever it is that allows you to pass substitution arguments to a message. -Original

RE: Enhanced errors tag

2001-08-15 Thread Deadman, Hal
I think a new tag that allows you to not put HTML in your resource file already exists in post 1.0 Struts in the form of the html:messsage(s) tag. It can be used in place of html:errors. The errors class is now a subclass of a message class. -Original Message- From: Martin D Bayly

RE: Role-Based Actions

2001-10-25 Thread Deadman, Hal
If this is added, I'm willing to modify the struts-example to use roles and form-based authentication. I figured out a trick last week (using javascript and cookies) to show the user loginForm again on the form-error page and allow them to login from there. I can add this to the sample

RE: Type Date is a problem.

2001-10-25 Thread Deadman, Hal
Make a get/set that accepts a String for each of your form date fields. Parse the string into a Date in your validate method. If it doesn't parse correctly then use report an error to the user. Use a method like this to parse your Dates. A null return value indicates an invalid date.

RE: Declarative exception handling for Action classes

2001-11-01 Thread Deadman, Hal
I think this is a good idea. I also have similar repetative exception handling in all of my action classes. Having global exceptions to handle general system errors would be helpful. I might prefer to handle some expected exceptions in my action class just to make the code easier to read but I

RE: Converting struts-html tags to be XHTML-compliant

2001-11-12 Thread Deadman, Hal
I would think request scope would be better than pageContext so the attribute will be available inside jsp:include or template/component includes. -Original Message- From: Matt Raible [mailto:[EMAIL PROTECTED]] Sent: Monday, November 12, 2001 12:01 AM To: [EMAIL PROTECTED] Subject:

RE: Arrrg...

2001-10-17 Thread Deadman, Hal
I was getting similar errors trying to use struts post 1.0 on Weblogic 6.0 which uses jaxp 1.0. Struts 1.1 requires a server with a jaxp 1.1 xml parser. Maybe that's the problem? -Original Message- From: Craig Tataryn [mailto:[EMAIL PROTECTED]] Sent: Wednesday, October 17, 2001 4:13 PM

bean:write format attribute changes bean:write default behavior

2001-12-03 Thread Deadman, Hal
I have some code that uses bean:write and the datetime:format tag from taglibs project. I use it like this: datetime:format pattern=MM/dd/bean:write name=contractinfo property=beginDate.time//datetime:format The bean:write used to print out the number of milliseconds returned by

RE: bean:write format attribute changes bean:write default behavior

2001-12-06 Thread Deadman, Hal
bean:write default behavior Oleg, I'm sorry, but I'm not at all clear as to what you are saying here. Could you please restate it? Will - Original Message - From: Oleg V Alexeev [EMAIL PROTECTED] To: Struts Developers List [EMAIL PROTECTED]; Deadman, Hal [EMAIL PROTECTED] Sent: Wednesday

using digester and struts in an EAR file

2001-12-11 Thread Deadman, Hal
I have a web app and ejb jar files combined in an ear file. If I want to use struts in the war file and the digester in some of the ejbs, I have a problem because the war classloader is a child of the ejb classloader (at least in Weblogic 6.1) which means classes loaded by the ejb class loader

RE: using digester and struts in an EAR file

2001-12-11 Thread Deadman, Hal
the ActionServlet to call setUseContextClassLoader? Hal -Original Message- From: craigmcc@localhost [mailto:craigmcc@localhost]On Behalf Of Craig R. McClanahan Sent: Tuesday, December 11, 2001 3:05 PM To: Struts Developers List; Deadman, Hal Subject: Re: using digester and struts in an EAR

RE: Bad classloading, why does Struts continue to use Class.forName()?

2002-01-15 Thread Deadman, Hal
I filed a bug report for this same problem. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5774 -Original Message- From: Colin Sampaleanu [mailto:[EMAIL PROTECTED]] Sent: Tuesday, January 15, 2002 1:47 PM To: [EMAIL PROTECTED] Subject: Bad classloading, why does Struts continue to

RE: [PROPOSAL] Modular Applications (the BIG checkin) [LONG]

2002-02-19 Thread Deadman, Hal
I assume there will be at least one beta release of Struts 1.1 and a release candidate after that. That will provide ample time to identify any specific incompatibilities and address them. At least we will be able to identify the exact cause of the incompatibility and then we can discuss a

RE: Build errors - templates library

2002-03-11 Thread Deadman, Hal
The JSPException with a constructor that takes a throwable is a JSP 1.2 feature. -Original Message- From: Oleg V Alexeev [mailto:[EMAIL PROTECTED]] Sent: Monday, March 11, 2002 6:27 AM To: Struts Developers List Subject: Build errors - templates library Hello Struts, Now I

RE: Re[2]: Build errors - templates library

2002-03-11 Thread Deadman, Hal
think that's because I am not using templates right now so my tag errors aren't as deeply nested and less likely to get trampled on by outer tags. -Original Message- From: Oleg V Alexeev [mailto:[EMAIL PROTECTED]] Sent: Monday, March 11, 2002 9:27 AM To: Struts Developers List; Deadman, Hal

use of pluggable converters in ConvertUtils changes Struts behavior for primitive wrapper properties

2002-03-26 Thread Deadman, Hal
I think the addition of pluggable converters in ConvertUtils on 3/18 has changed the way Struts handles empty form fields that map to primitive Wrapper bean properties. The default IntegerConverter uses a default value of Integer(0) instead of null. This is a fairly significant problem because

re-post: use of pluggable converters in ConvertUtils changes Struts behavior for primitive wrapper properties

2002-04-04 Thread Deadman, Hal
Is the change I describe below to way beanutils does primitive wrapper conversions going to be permanent? The addition of pluggable converters in ConvertUtils on 3/18 has changed the way Struts handles empty form fields that map to primitive Wrapper bean properties. For example, the default

RE: Branch Restriction error due to struts..

2002-04-05 Thread Deadman, Hal
I think it has to do with the size of the method in the JSP's servlet exceeding some JVM/java limit. You can try breaking the JSP up using jsp:include or using fewer tags. Could you generate the form fields inside an iterate tag? That would reduce the size of the generated java code.

Re: use of pluggable converters in ConvertUtils changes Struts behavior for primitive wrapper properties

2002-04-07 Thread Deadman, Hal
. McClanahan [EMAIL PROTECTED] To: Struts Developers List [EMAIL PROTECTED]; Deadman, Hal [EMAIL PROTECTED] Sent: Saturday, April 06, 2002 8:08 PM Subject: Re: use of pluggable converters in ConvertUtils changes Struts behavior for primitive wrapper properties Grumble grumble ... I would sure argue

RE: multipart/form-data (bug?) or intended behavior?

2002-04-19 Thread Deadman, Hal
Can't this multi-part request forward problem be fixed by unwrapping the request before doing RequestDispatcher.forward/include? All the methods in RequestProcessor get the real request object from within the MultipartRequestWrapper before calling doForward() or doInclude() except for

RE: Wildcard-matched actions (again)

2003-08-14 Thread Deadman, Hal
Doesn't the last email from Don imply there is no penalty (if the person isn't using wildcards)? -- extract from Don's last email You still wouldn't see any performance hit as since you aren't using any action mappings with wildcards, there would be no pattern matching. It can only match a URI

RE: cvs commit: veto

2003-11-14 Thread Deadman, Hal
If Craig doesn't want to associate with a project if certain individuals are involved, I think his wishes as a committer should be respected. The policy for posting links should be to allow all links that committers are willing to add and exclude links that any committer finds repugnant in any