Re: latest master

2014-02-18 Thread Tomaz Canabrava
I think this happened because of the patch that transformed mainwindow to have an ::instance() method, but didn`t fully fixed the rest of the code. On Tue, Feb 18, 2014 at 9:47 PM, Thiago Macieira wrote: > Em ter 18 fev 2014, às 16:30:01, Dirk Hohndel escreveu: > > > Can someone verify whether t

[PATCH] Add an assertion to prevent MainWindow from being recreated

2014-02-18 Thread Thiago Macieira
Signed-off-by: Thiago Macieira --- qt-ui/mainwindow.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/qt-ui/mainwindow.cpp b/qt-ui/mainwindow.cpp index 42b07fb..7609bff 100644 --- a/qt-ui/mainwindow.cpp +++ b/qt-ui/mainwindow.cpp @@ -46,6 +46,7 @@ MainWindow::MainWindow() : QMainWindow(),

Re: latest master

2014-02-18 Thread Thiago Macieira
Em ter 18 fev 2014, às 16:30:01, Dirk Hohndel escreveu: > > Can someone verify whether the pointer was null? It looks unlikely though. > > Definitely not null. And adding qDebug() to the lastUsedImageDir() > function I was able to see that it got called. But something in that > process destroyed t

Re: latest master

2014-02-18 Thread Dirk Hohndel
On Tue, 2014-02-18 at 16:25 -0800, Thiago Macieira wrote: > Em ter 18 fev 2014, às 16:16:10, Dirk Hohndel escreveu: > > On Feb 18, 2014, at 3:47 PM, Tomaz Canabrava wrote: > > > dirk, can you test the patch? I couldn`t really understand why it crashed > > > if not static, since we should always ha

Re: latest master

2014-02-18 Thread Thiago Macieira
Em ter 18 fev 2014, às 16:16:10, Dirk Hohndel escreveu: > On Feb 18, 2014, at 3:47 PM, Tomaz Canabrava wrote: > > dirk, can you test the patch? I couldn`t really understand why it crashed > > if not static, since we should always have that object. saing that - the > > correct way to handle that sh

Re: latest master

2014-02-18 Thread Dirk Hohndel
On Feb 18, 2014, at 3:47 PM, Tomaz Canabrava wrote: > dirk, can you test the patch? I couldn`t really understand why it crashed if > not static, since we should always have that object. > saing that - the correct way to handle that should be from the Settings, no? The patch does indeed fix thi

Re: latest master

2014-02-18 Thread Tomaz Canabrava
dirk, can you test the patch? I couldn`t really understand why it crashed if not static, since we should always have that object. saing that - the correct way to handle that should be from the Settings, no? QSettings s; s.value("lastUsedImageDirectory").toString() or something On Tue, Feb 18, 20

Re: latest master

2014-02-18 Thread Robert C. Helling
On 17 Feb 2014, at 23:57, Dirk Hohndel wrote: > > This does not include the promised whitespace overhaul. > Instead I added a few outstanding patches and went down the rabbit hole > of trying to track down a crash with Robert's image shift patches. > > Here's how I can reliably reproduce this.

minor bug in the mac version of subsurface 4.0.3

2014-02-18 Thread Thomas 'Mike' Michlmayr
hi! i've upgraded from subsurface 3.0.2 to 4.0.3 on my macbook. i tried to open my existing logbook, but failed. the old logbook is stored in ~/Library/Application Support/Subsurface/mike.xml (default from 3.x), but ~/Library does not show up in the "open logbook" dialogue. ~/Library does show up

Patch: Update to manual (Style and grammar)

2014-02-18 Thread Willem Ferguson
This update to the manual is mostly style and grammar. The section about download from dive computers has been expanded to include all controls in the download panel and to make absolutely sure that the libdivecomputer log and dump are not accidentally activated. Kind regards, willemf >From c1