On Sat, 2014-04-05 at 15:48 -0700, Linus Torvalds wrote:
> On Sat, Apr 5, 2014 at 1:40 PM, Dirk Hohndel wrote:
> >
> > May I make up a commit message (I'll add some curse words to make it
> > sound more authentic) and add you SOB?
>
> I was thinking you'd just credit it as a small change to Gehad
On Sat, Apr 5, 2014 at 1:40 PM, Dirk Hohndel wrote:
>
> May I make up a commit message (I'll add some curse words to make it
> sound more authentic) and add you SOB?
I was thinking you'd just credit it as a small change to Gehad's
version, but whatever you want to do with it is good by me.
The removal of the planner menu entry was erroneously commented out.
Other parts of the code rely on ENABLE_PLANNER to know if the planner is
enabled or not so rely on it here to.
Signed-off-by: Anton Lundin
---
qt-ui/mainwindow.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --g
On Sat, 2014-04-05 at 18:35 +0200, Willem Ferguson wrote:
> On 05/04/2014 16:38, Dirk Hohndel wrote:
> > On Sat, 2014-04-05 at 07:35 +0200, Willem Ferguson wrote:
> >> I am updating the material for the user manual. Here are a few things I
> >> struggle to understand about the UI:
> >>
> >> 1) Expo
On Sat, 2014-04-05 at 13:01 -0700, Linus Torvalds wrote:
> On Sat, Apr 5, 2014 at 1:00 PM, Linus Torvalds
> wrote:
> >
> > Which would make the patch something like this (untested, but it compiles).
>
> .. and by that I meant *this*.
You will be as surprised as I am to learn that your patch work
On Sat, 2014-04-05 at 21:29 +0530, Venkatesh Shukla wrote:
> I have attached the updated patch which includes correct explanation
> of error.
Please note the change I made to the commit message :-)
It really helps me if people get in the habit of correctly referencing
trac bugs.
/D
__
On 05 Apr 2014, at 16:10, Willem Ferguson
wrote:
Willem,
could you tell me what kind of dive you tried to enter in detail (time and
depth and gases)?
> Appears to work better if deep stops are not enforced.
With decent gradient factor settings (in particular GFlow) the algorithm should
pro
On Sat, Apr 5, 2014 at 1:00 PM, Linus Torvalds
wrote:
>
> Which would make the patch something like this (untested, but it compiles).
.. and by that I meant *this*.
Linus
membuffer.c | 12
membuffer.h | 1 +
save-git.c | 17 ++---
worldmap-save
On Sat, Apr 5, 2014 at 12:03 PM, Gehad wrote:
>
> I was ignorant of the %f problem.
> I fixed the patch, Is this right ?
Looks ok to me, although I would do it by just making the
"put_degrees()" function one of the exported membuffer interfaces, and
make it match the other "put_type()" ones with
On 2014-04-05 20:17, Linus Torvalds wrote:
Oh. Please don't do that. Just fix the printing of the
latitude/longitude. %f is wrong, wrong, wrong, for this and other
reasons. We try to avoid floating point in subsurface for a reason.
See (for example) save-git.c: put_degrees()/show_gps() on how t
On Sat, Apr 5, 2014 at 11:04 AM, Gehad wrote:
> The attached patch fixes willemf's problem.
> it set the default locale to the Minimal c locale which prevent
> put_formate() from replacing the decimal point with a comma in floating
> point numbers.
Oh. Please don't do that. Just fix the printing
The attached patch fixes willemf's problem.
it set the default locale to the Minimal c locale which prevent
put_formate() from replacing the decimal point with a comma in floating
point numbers.
--
Regards,
Gehad Elrobey
>From 6e4965fbb447510ba76992d3495e28bfb7c17401 Mon Sep 17 00:00:00 2001
On 5 April 2014 18:24, Thiago Macieira wrote:
> Em sáb 05 abr 2014, às 12:20:25, Lubomir I. Ivanov escreveu:
>> the argument swap is my fault which originates back to the GTK version.
>> was not caught because we didn't use streamsize and only checked if
>> fread() succeeds.
>
> And I've never car
It seems that while exporting the floating point number of the coordinates
the decimal point is replaced with a comma which caused the js to fail.
I don't know why put_format() would put a comma instead of a decimal point,
is it an operating system settings ?
Regards,
Gehad elrobey
___
On Sat, Apr 5, 2014 at 10:41 AM, Dirk Hohndel wrote:
> Sorry for top post.
> I meant to remove the option from preferences and always show the temperature
> units in the add dive mode.
>
Attached patch does the job as per the suggestion.
Thank you,
Lakshman
From 7433e91b10e7e8b859a964c67a9013294
On Sat, Apr 5, 2014 at 9:03 PM, Linus Torvalds <
torva...@linux-foundation.org> wrote:
>
> On Apr 5, 2014 1:45 AM, "Venkatesh Shukla" <
> venkatesh.shukla.ee...@iitbhu.ac.in> wrote:
> >
> > Arguments 2 and 3 in fread() seemed to be exchanged because of which
> > only one character was read into th
Sorry for top post.
I meant to remove the option from preferences and always show the temperature
units in the add dive mode.
/D
---
>From my phone
Lakshman wrote:
>> > 2) The Preferences Units panel, the checkbox at the bottom 'Show units
>> > in text labels'. This does not appear to produce
On Apr 5, 2014 1:45 AM, "Venkatesh Shukla" <
venkatesh.shukla.ee...@iitbhu.ac.in> wrote:
>
> Arguments 2 and 3 in fread() seemed to be exchanged because of which
> only one character was read into the temp xml file.
This explanation confused me, because the order of arguments ends up being
totally
Em sáb 05 abr 2014, às 12:34:10, Gehad escreveu:
> The attached patch fixes the character set encoding of the exported HTML,
> To be able to support multi-languages.
Nice catch! Thanks.
--
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
Software Architect - Intel Open Source
Em sáb 05 abr 2014, às 12:20:25, Lubomir I. Ivanov escreveu:
> the argument swap is my fault which originates back to the GTK version.
> was not caught because we didn't use streamsize and only checked if
> fread() succeeds.
And I've never cared about the order. If you're trying to read N elements
On Sat, Apr 5, 2014 at 8:16 PM, Dirk Hohndel wrote:
> On Sat, 2014-04-05 at 14:15 +0530, Venkatesh Shukla wrote:
> > Arguments 2 and 3 in fread() seemed to be exchanged because of which
> > only one character was read into the temp xml file.
> > Fixed it by exchange and replacing 1 by sizeof(char
> > 2) The Preferences Units panel, the checkbox at the bottom 'Show units
> > in text labels'. This does not appear to produce any noticeable effect
> > in any of the panels. What does this option do?
>
> IIRC that only makes a difference when manually adding a dive.
> We should simply remove the
On Sat, 2014-04-05 at 14:15 +0530, Venkatesh Shukla wrote:
> Arguments 2 and 3 in fread() seemed to be exchanged because of which
> only one character was read into the temp xml file.
> Fixed it by exchange and replacing 1 by sizeof(char) to be sure.
>
>
> Signed-off-by: Venkatesh Shukla
> ---
>
On Sat, 2014-04-05 at 07:35 +0200, Willem Ferguson wrote:
> I am updating the material for the user manual. Here are a few things I
> struggle to understand about the UI:
>
> 1) Export HTML Word Map on File item of main menu. This generates an
> HTML world map with no information superimposed on
The attached patch fixes the character set encoding of the exported HTML,
To be able to support multi-languages.
--
Regards,
Gehad Elrobey
>From 72e04d14f5eb457fb271a9ac0a5a2fa8115ef710 Mon Sep 17 00:00:00 2001
From: Gehad elrobey
Date: Sat, 5 Apr 2014 12:17:39 +0200
Subject: [PATCH] defining t
On 5 April 2014 11:45, Venkatesh Shukla
wrote:
> Arguments 2 and 3 in fread() seemed to be exchanged because of which
> only one character was read into the temp xml file.
> Fixed it by exchange and replacing 1 by sizeof(char) to be sure.
>
> Signed-off-by: Venkatesh Shukla
> ---
> qt-ui/subsurf
Arguments 2 and 3 in fread() seemed to be exchanged because of which
only one character was read into the temp xml file.
Fixed it by exchange and replacing 1 by sizeof(char) to be sure.
Signed-off-by: Venkatesh Shukla
---
qt-ui/subsurfacewebservices.cpp | 2 +-
1 file changed, 1 insertion(+), 1
27 matches
Mail list logo
