Re: [PATCH] Template for subsurface android package

On 25 June, 2014 - Dirk Hohndel wrote: On Tue, Jun 24, 2014 at 10:41:45PM +0200, Anton Lundin wrote: On 24 June, 2014 - Dirk Hohndel wrote: Just like I asked Miika - I would prefer to get these with SOB's from your mentor. Andton, would you be able to do that? This way I know

[PATCH 1/2] Fix typo in connecting ui.descRate to setDescRate

Qt didn't find the right function without the type there. This also gets rid of the warning about that. Signed-off-by: Anton Lundin gla...@acc.umu.se --- qt-ui/diveplanner.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qt-ui/diveplanner.cpp b/qt-ui/diveplanner.cpp index

Re: status update

points? (Yea, it makes sense, but it will be a bit more messy to build) I took the simple path and only controlled the first decent way point, because this covers the case i use it for. //Anton -- Anton Lundin+46702-161604 ___ subsurface mailing

Re: [PATCH] Drop like a stone mode in planner

On 26 June, 2014 - Robert C. Helling wrote: On 23 Jun 2014, at 19:21, Anton Lundin gla...@acc.umu.se wrote: Anton, Most of my dives i plan i know it will just be full speed down a line in the beginning and thus the planner can figure out that leg of the plan by it self. I think

[PATCH] Care about drop_stone_mode in createSimpleDive

waypoint in createSimpleDive when drop_stone_mode is enabled and lets that add a implicit first waypoint. Signed-off-by: Anton Lundin gla...@acc.umu.se --- qt-ui/diveplanner.cpp | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/qt-ui/diveplanner.cpp b/qt-ui/diveplanner.cpp

Re: Proxy support in Subsurface

or rename it so the auto-connect does the right thingtm. //Anton -- Anton Lundin+46702-161604 ___ subsurface mailing list subsurface@hohndel.org http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface

Warning from PlannerSettingsWidget

, but someone of our qt-experts might know. //Anton -- Anton Lundin+46702-161604 ___ subsurface mailing list subsurface@hohndel.org http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface

Re: [Planner] gas consumption calculation broken after 5b5a25d.

On 28 June, 2014 - Anton Lundin wrote: On 27 June, 2014 - Dirk Hohndel wrote: On Fri, Jun 27, 2014 at 09:19:15PM +0200, Joakim Bygdell wrote: After 5b5a25d calculations of gas consumption doesn’t work. Can you say a bit more? What exactly doesn't work anymore? In which context

[PATCH] Surface pressure is in mbar, not bar

Signed-off-by: Anton Lundin gla...@acc.umu.se --- qt-ui/diveplanner.ui | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qt-ui/diveplanner.ui b/qt-ui/diveplanner.ui index afed678..ce9b56e 100644 --- a/qt-ui/diveplanner.ui +++ b/qt-ui/diveplanner.ui @@ -148,7 +148,7

[PATCH] Calculate approx gas bill on dives

This uses a bit naive gas computations to figure out how much of different base gases you used up on the dives he statistics is done for. Its quite useful to get a minimum line about how big your gas bill is going to be after a dive trip. Signed-off-by: Anton Lundin gla...@acc.umu.se --- qt-ui

Re: [PATCH] Use gas_mod helper instead of local version

the different po2-values we keep in the prefs, so i didn't change that right now. //Anton -- Anton Lundin+46702-161604 ___ subsurface mailing list subsurface@hohndel.org http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface

Re: Bugfixes

that the calendar widget is still there in the planner. //Anton -- Anton Lundin+46702-161604 ___ subsurface mailing list subsurface@hohndel.org http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface

[PATCH] Clarify the gaschange icon

This removes the white circle in the backround of the gaschange icon. This makes it stand out a bit less but looks better to me. This also fills in the black part on the cylinder neck. Signed-off-by: Anton Lundin gla...@acc.umu.se --- icons/gaschange.png | Bin 3344 - 3215 bytes 1 file changed

Re: Trying to use Subsurface

it connected to the cable when you plug in the cable, its a 99% failure rate. //Anton -- Anton Lundin+46702-161604 ___ subsurface mailing list subsurface@hohndel.org http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface

Re: Bugfixes

On 01 July, 2014 - Dirk Hohndel wrote: On Tue, Jul 01, 2014 at 09:31:56AM +0200, Anton Lundin wrote: On 30 June, 2014 - Tomaz Canabrava wrote: I did the calendar widget fixes even tougth I changed the calendar widget because I will use that in the future. I just noted

Re: Date picker: V4.2

, and in the planner they are on the middle left... I have no clear idea here, but i have bin looking for those buttons more than once in the wrong place. //Anton -- Anton Lundin+46702-161604 ___ subsurface mailing list subsurface@hohndel.org http

[PATCH] Clear out old events in create_dive_from_plan

Previous code where accumulating events from each iteration of the planning. This code clears the old ones before adding new ones. Signed-off-by: Anton Lundin gla...@acc.umu.se --- planner.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/planner.c b/planner.c index 026581d..b0da873

Re: [PATCH v2] Clear out old events in create_dive_from_plan

On 04 July, 2014 - Dirk Hohndel wrote: On Fri, Jul 04, 2014 at 08:25:21PM +0200, Anton Lundin wrote: Previous code where accumulating events from each iteration of the planning. This code clears the old ones before adding new ones. I had already pushed a somewhat modified version

[PATCH] Don't try to set a layout on PlannerSettingsWidget

It already got one from its ui-file, and this causes a warning when starting the application. Signed-off-by: Anton Lundin gla...@acc.umu.se --- qt-ui/mainwindow.ui | 20 +--- 1 file changed, 1 insertion(+), 19 deletions(-) diff --git a/qt-ui/mainwindow.ui b/qt-ui/mainwindow.ui

[RFC PATCH] WIP: add a SpinBoxDelegate for DivePlannerPointsModel

This is something to show what we need to do for the DivePlannerPointsModel, to fix entering of negative values there. --- qt-ui/diveplanner.cpp| 6 ++ qt-ui/modeldelegates.cpp | 43 +++ qt-ui/modeldelegates.h | 16 3 files

Re: Seabear dive computer integration in subsurface

-- Anton Lundin+46702-161604 ___ subsurface mailing list subsurface@hohndel.org http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface

[PATCH 1/4] Add support divecomputer based TTS

Since earlier have we had support for our own calculated TTS. This adds support for holding TTS values reported by a dive computer. Signed-off-by: Anton Lundin gla...@acc.umu.se --- dive.h | 1 + load-git.c | 4 parse-xml.c | 2 ++ profile.c | 2 ++ profile.h | 1 + save-git.c

[PATCH 2/4] Add support for importing NDL from CSV files

Signed-off-by: Anton Lundin gla...@acc.umu.se --- dive.h| 2 +- file.c| 10 +++--- qt-ui/divelogimportdialog.cpp | 14 +- qt-ui/divelogimportdialog.h | 1 + qt-ui/divelogimportdialog.ui | 28 +--- xslt

[PATCH 4/4] Add quirk for Seabear CSV NDL/TTS in minutes

In the Seabear CSV the NDL and TTS fields are in minutes, not seconds as there time field. This is a ugly quirk but it gets the job done. Signed-off-by: Anton Lundin gla...@acc.umu.se --- qt-ui/divelogimportdialog.cpp | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git

[PATCH] Add quirk for Seabear CSV settings

The Seabear software stores its settings as two csv-rows in the same file as its samples. These settings got read as two bogus samples in the beginning of the dive. This kills those off and repairs the temperature damage they done. Signed-off-by: Anton Lundin gla...@acc.umu.se --- qt-ui

[PATCH] Move drop_stone_mode setting to prefs

There is no reason to treat drop_stone_mode different from the rest of the planner settings, so move it to our prefs structure. Signed-off-by: Anton Lundin gla...@acc.umu.se --- pref.h| 1 + qt-ui/diveplanner.cpp | 10 +- qt-ui/diveplanner.h | 1 - subsurfacestartup.c

[PATCH] Fix bug in Seabear Quirks

By mistake i used memcpy to fix the samples, but the sample list was overlapping so i needed to use memmove. Signed-off-by: Anton Lundin gla...@acc.umu.se --- qt-ui/divelogimportdialog.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qt-ui/divelogimportdialog.cpp b/qt-ui

Re: towards 4.2

On 10 July, 2014 - Robert Helling wrote: On 09.07.2014, at 23:43, Anton Lundin gla...@acc.umu.se wrote: Another thing i just noted is that we store none of our planner preferences in the persistent preferences system. That might be a nice ting to do. That is not entirely true: Note

Re: Bug with Dive log from Suunto( without attachment)

function that is trying to strip spaces doesn't handle the data as utf8 =( //Anton -- Anton Lundin+46702-161604 ___ subsurface mailing list subsurface@hohndel.org http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface

Re: paches for Tags and Picture handling on the profile

doo2breaks; bool drop_stone_mode; + bool show_pictures_in_planner; Why name it _in_planner? As far as i understood it got nothing with the planner to do. Maybe call it show_pictures_in_profile? //Anton -- Anton Lundin+46702-161604

[OT] Diving sites in scandinavia

=) Anyhow, thats for another time. Next planned diving trip goes to Narvik and if everything goes as planned, Erich Giese =) //Anton -- Anton Lundin+46702-161604 ___ subsurface mailing list subsurface@hohndel.org http://lists.hohndel.org/cgi-bin

[PATCH 2/2] Add quirks for Seabear CSV settings for pressure

This adds the settings quirk workaround for the pressure import from the Seabear CSV file. Signed-off-by: Anton Lundin gla...@acc.umu.se --- qt-ui/divelogimportdialog.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/qt-ui/divelogimportdialog.cpp b/qt-ui/divelogimportdialog.cpp index

[PATCH 1/2] Add support for importing pressure from CSV files

Signed-off-by: Anton Lundin gla...@acc.umu.se --- dive.h| 2 +- file.c| 10 +++--- qt-ui/divelogimportdialog.cpp | 14 +- qt-ui/divelogimportdialog.h | 1 + qt-ui/divelogimportdialog.ui | 20 xslt

[PATCH] Don't trust isspace() unless isascii() approves

character, something isspace() knows how to handle Signed-off-by: Anton Lundin gla...@acc.umu.se --- save-xml.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/save-xml.c b/save-xml.c index 9c802b8..0a76753 100644 --- a/save-xml.c +++ b/save-xml.c @@ -35,12 +35,15 @@ static

[PATCH 4/5] Remove unnecessary get_gasidx call

Signed-off-by: Anton Lundin gla...@acc.umu.se --- planner.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/planner.c b/planner.c index 16152b1..785db4d 100644 --- a/planner.c +++ b/planner.c @@ -575,7 +575,7 @@ static void add_plan_to_notes(struct diveplan *diveplan, struct

[PATCH 1/5] Fix potential leak of newdc in make_first_dc()

Signed-off-by: Anton Lundin gla...@acc.umu.se --- dive.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dive.c b/dive.c index 349bc10..683fbb8 100644 --- a/dive.c +++ b/dive.c @@ -2466,6 +2466,7 @@ void make_first_dc() while (dc dc-next != cur_dc) dc = dc-next

[PATCH 5/5] Limit the scope of gasidx in add_plan_to_notes

Signed-off-by: Anton Lundin gla...@acc.umu.se --- planner.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/planner.c b/planner.c index 785db4d..5cd9ba9 100644 --- a/planner.c +++ b/planner.c @@ -518,7 +518,7 @@ static unsigned int *sort_stops(int *dstops, int dnr, struct

Re: [PATCH 5/5] Limit the scope of gasidx in add_plan_to_notes

On 10 July, 2014 - Dirk Hohndel wrote: On Thu, Jul 10, 2014 at 10:11:46PM +0200, Anton Lundin wrote: Signed-off-by: Anton Lundin gla...@acc.umu.se --- planner.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/planner.c b/planner.c index 785db4d..5cd9ba9

Re: paches for Tags and Picture handling on the profile

, Tomaz Canabrava tcanabr...@kde.org wrote: my mistake. :) On Thu, Jul 10, 2014 at 3:04 PM, Anton Lundin gla...@acc.umu.se wrote: On 10 July, 2014 - Tomaz Canabrava wrote: I still need to hoock the toggle on the image button to actually hide / show the pictures. From

Re: [PATCH 5/5] Limit the scope of gasidx in add_plan_to_notes

On 11 July, 2014 - Jef Driesen wrote: On 2014-07-10 22:36, Dirk Hohndel wrote: On Thu, Jul 10, 2014 at 10:34:24PM +0200, Anton Lundin wrote: On 10 July, 2014 - Dirk Hohndel wrote: IIRC we don't want to use this in C files because some older C compilers throw up with it... I checked

Re: [PATCH 5/5] Limit the scope of gasidx in add_plan_to_notes

On 11 July, 2014 - Lubomir I. Ivanov wrote: On 11 July 2014 10:13, Anton Lundin gla...@acc.umu.se wrote: glance for (int i=0;i3;i++) ? for that to work on older versions e.g. MSVC 2003, /Tp has to be used (like jeff mentioned, we can mark the input to be C++) and then extern C wrapping

Re: Subsurface should display reason for red background in Planner

violation event there? //Anton -- Anton Lundin+46702-161604 ___ subsurface mailing list subsurface@hohndel.org http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface

[PATCH] Add a SpinBoxDelegate's for DivePlannerPointsModel

This adds some delegates to fixup the editor SpinBox'es in the DivePlannerPointsModel, to prevent user from entering negative values. Fixes #609 Signed-off-by: Anton Lundin gla...@acc.umu.se --- qt-ui/diveplanner.cpp| 6 + qt-ui/modeldelegates.cpp | 64

Re: [PATCH] Add a SpinBoxDelegate's for DivePlannerPointsModel

On 11 July, 2014 - Tomaz Canabrava wrote: hold on :) Glance, take a look on my answer to the trac and try to do that - saner code. :) Bah. Everybody knows I'm the expert of both Qt and spellings =) //Anton - Who is about equally good at spelling as Qt -- Anton Lundin+46702-161604

[PATCH] planner: Correct pO2 comparison

Don't compare pO2 with a bool, compare it with the result of the ?: expression instead. Signed-off-by: Anton Lundin gla...@acc.umu.se --- planner.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/planner.c b/planner.c index 4620301..630a554 100644 --- a/planner.c +++ b

Re: [PATCH 2/2] Add type for gaschange events, if missing

. Are you sure they are of type GASCHANGE2, aka with He? I would guess they where of type GASCHANGE , aka the ones without any He info. //Anton -- Anton Lundin+46702-161604 ___ subsurface mailing list subsurface@hohndel.org http://lists.hohndel.org

Re: [PATCH 2/2] Add type for gaschange events, if missing

On 12 July, 2014 - Miika Turkia wrote: On Sat, Jul 12, 2014 at 2:24 PM, Anton Lundin gla...@acc.umu.se wrote: On 12 July, 2014 - Miika Turkia wrote: Subsurface has saved gas change events without type attribute at some point. Thus we need to add the type when reading in log files

[PATCH 1/4] Don't round range for DoubleSpinBoxDelegate to int

This fixes simple copy-paste error that the DoubleSpinBoxDelegate range was stored as int, thus rounding min value from 0.2 to 0. Signed-off-by: Anton Lundin gla...@acc.umu.se --- qt-ui/modeldelegates.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qt-ui

[PATCH 2/4] Use doubles in DoubleSpinBoxDelegate

The previous code used qreals, but it feels clearer to use doubles when the name of the class contains the word double. The performance loss of using doubles instead of floats on arm is non-existent in this case. Signed-off-by: Anton Lundin gla...@acc.umu.se --- qt-ui/modeldelegates.cpp | 2

[PATCH 4/4] Lower CCR setpoint min value in planner to 0

bailout plan. Signed-off-by: Anton Lundin gla...@acc.umu.se --- qt-ui/diveplanner.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qt-ui/diveplanner.cpp b/qt-ui/diveplanner.cpp index d98ac59..1d0b278 100644 --- a/qt-ui/diveplanner.cpp +++ b/qt-ui/diveplanner.cpp @@ -293,7

[PATCH 3/4] Add step size in our SpinBox delegates

For the Set point spinbox, it was kinda hard just stepping by the default 1.0, so setting it to step by 0.1 makes much more sense. The int SpinBox got a step size parameter for consistency. Signed-off-by: Anton Lundin gla...@acc.umu.se --- qt-ui/diveplanner.cpp| 8 qt-ui

[PATCH] usersurvey: Add : for consistency

All the other statements there had : in them. Signed-off-by: Anton Lundin gla...@acc.umu.se --- qt-ui/usersurvey.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qt-ui/usersurvey.cpp b/qt-ui/usersurvey.cpp index b98f1d6..3177886 100644 --- a/qt-ui/usersurvey.cpp +++ b/qt

[PATCH] profile2: remove unused varable diveComputer

Signed-off-by: Anton Lundin gla...@acc.umu.se --- qt-ui/profile/profilewidget2.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/qt-ui/profile/profilewidget2.cpp b/qt-ui/profile/profilewidget2.cpp index 6c1991a..7863679 100644 --- a/qt-ui/profile/profilewidget2.cpp +++ b/qt-ui/profile

[PATCH] Remove unused menu Filter

The filter menu wasn't connected to anything other than a debug print. This removes that menu. Signed-off-by: Anton Lundin gla...@acc.umu.se --- qt-ui/mainwindow.cpp | 10 -- qt-ui/mainwindow.h | 2 -- qt-ui/mainwindow.ui | 16 3 files changed, 28 deletions(-) diff

Re: XML preamble in CSV export

the xml header and call a membuffer to file dumper. xmlDocDumpMemory looks like a good candidate to write to a membuffer. //Anton - Who partly brain dumps so me or someone else can pick this up -- Anton Lundin+46702-161604 ___ subsurface mailing list

Re: My progress in HTML export.

@hohndel.org http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface -- Anton Lundin+46702-161604 ___ subsurface mailing list subsurface@hohndel.org http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface

Usage of gaschange event data

at whats in the event and start only looking at what gas is mapped to different times in the dive. We can't do both, and mix and match them. //Anton -- Anton Lundin+46702-161604 ___ subsurface mailing list subsurface@hohndel.org http

[PATCH] Use plot_data cylinderindex instead of event data

For the info box, we can't use the event data, because its not 1:1 mapped to whats in the cylinder and what we actually switched to. Use the plot_data here we already calculated what we are switching to. Signed-off-by: Anton Lundin gla...@acc.umu.se --- qt-ui/profile/diveeventitem.cpp | 10

Re: [PATCH] Use plot_data cylinderindex instead of event data

On 16 July, 2014 - Dirk Hohndel wrote: On Thu, Jul 17, 2014 at 12:26:46AM +0200, Anton Lundin wrote: For the info box, we can't use the event data, because its not 1:1 mapped to whats in the cylinder and what we actually switched to. Use the plot_data here we already calculated what we

Re: Usage of gaschange event data

On 16 July, 2014 - Dirk Hohndel wrote: On Wed, Jul 16, 2014 at 11:22:32PM +0200, Anton Lundin wrote: This started out yesterday with me looking at dives/test20.xml and saw that the gasname text in the info box is wrong there. It uses the gaschange event data via get_gasmix_from_event

[PATCH] Add missing struct keyword in DivePlotDataModel

Signed-off-by: Anton Lundin gla...@acc.umu.se --- qt-ui/profile/diveplotdatamodel.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qt-ui/profile/diveplotdatamodel.h b/qt-ui/profile/diveplotdatamodel.h index bb0c641..9db4a07 100644 --- a/qt-ui/profile/diveplotdatamodel.h

[PATCH 2/2] Hide gachange events in the first 30 seconds

Back in 4.0 we hide all gaschange events during the first 30 seconds, not just gaschange events on second 0. Eg, the OSTC3 emits its gaschange event on the first sample, which can be 2, 10 or 30 seconds into the dive. Signed-off-by: Anton Lundin gla...@acc.umu.se --- qt-ui/profile

[PATCH 1/2] Use get_cylinder_index instead of get_gasidx

Replace get_gasmix_from_event and get_gasidx with get_cylinder_index. get_cylinder_index actually knows about both types of gaschange events and the difference between them. Signed-off-by: Anton Lundin gla...@acc.umu.se --- qt-ui/profile/diveeventitem.cpp | 3 +-- 1 file changed, 1 insertion

Re: [PATCH 2/2] Add type for gaschange events, if missing

On 12 July, 2014 - Miika Turkia wrote: On Sat, Jul 12, 2014 at 3:21 PM, Anton Lundin gla...@acc.umu.se wrote: On 12 July, 2014 - Miika Turkia wrote: On Sat, Jul 12, 2014 at 2:24 PM, Anton Lundin gla...@acc.umu.se wrote: On 12 July, 2014 - Miika Turkia wrote: Subsurface

[PATCH 2/2] Replace cylinder_is_used with is_cylinder_used

is_cylinder_used uses get_cylinder_index as underlaying function that does the right thing with with respect on how to find the closest matching cylinder, and handles both types of gaschange events correctly. Signed-off-by: Anton Lundin gla...@acc.umu.se --- dive.c | 2 +- dive.h

[PATCH 1/2] Rename is_gas_used to is_gas_used

This function operates on cylinder ids, so its actually about cylinders not gases. Signed-off-by: Anton Lundin gla...@acc.umu.se --- statistics.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/statistics.c b/statistics.c index 6b79830..68b9cdd 100644 --- a/statistics.c

[PATCH 3/3] Use get_gas_at_time in active_o2

get_gas_at_time is now just a wrapper to return the o2 part of the active gas at a certain time. Signed-off-by: Anton Lundin gla...@acc.umu.se --- divelist.c | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/divelist.c b/divelist.c index 1a2111f..45a78f3 100644

[PATCH 2/3] Convert get_gas_from_events to get_gas_at_time

This converts the get_gas_from_events to a get_gas_at_time function that actually maps our events to what cylinder and thus gas we are breathing at that time. Signed-off-by: Anton Lundin gla...@acc.umu.se --- planner.c | 22 ++ planner.h | 2 +- qt-ui

More cleanup on how we handle gaschanges

This cleans up a couple of other unsafe usages of get_gasmix_from_event and get_gasidx. The only ones that now is left is related to planning or adding dives, and in those cases we can trust that the event actually contains the right info. //Anton ___

Re: [PATCH v2 3/3] Use get_gas_at_time in active_o2

Haha. Didn't even see that one =) //Anton - whom just started his summer vacation On July 18, 2014 7:04:44 PM CEST, Dirk Hohndel d...@hohndel.org wrote: And even in v2 the commit message is still wrong :-) (I fixed that for you) On Fri, Jul 18, 2014 at 08:39:53AM +0200, Anton Lundin wrote

[PATCH] De-duplicate planner default settings

settings. Signed-off-by: Anton Lundin gla...@acc.umu.se --- qt-ui/diveplanner.cpp | 22 +++--- subsurfacestartup.c | 4 ++-- 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/qt-ui/diveplanner.cpp b/qt-ui/diveplanner.cpp index 2853472..4ecf7a9 100644 --- a/qt-ui

Re: Toggle between multiple computers in profile view

is that we have seen non-working keyboard shortcuts on qt5 5.2.1 ubuntu packaged, and on Mac, don't know which qt version Dirk tested on the Mac. See: http://trac.hohndel.org/ticket/581 //Anton -- Anton Lundin+46702-161604 ___ subsurface mailing list

[no subject]

This cleans up some naming that calls our dive gas nitrox or O2% in different places. Only the first one is really 4.2-beta material but the other two are cleanup in the same areas and just renames things so they are low-inpact things, and pritty safe to be merged now.

[PATCH 1/3] Rename list column from O2% to Gas

In the dive list, calling the column O2% is kinda wrong, because in at least my dive list there are both air and trimix showing up, so this renames that column to Gas. Signed-off-by: Anton Lundin gla...@acc.umu.se --- qt-ui/models.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 2/3] Rename the model column from NITROX to GAS

The column isn't just about NITROX, there might be air and trimix in there too. Signed-off-by: Anton Lundin gla...@acc.umu.se --- qt-ui/divelistview.cpp | 2 +- qt-ui/models.cpp | 6 +++--- qt-ui/models.h | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/qt

[PATCH 3/3] Rename dive gas function and defines for clarity

This renames the dive gas functions to not talk about just nitrox, and to instead talk about gas. Signed-off-by: Anton Lundin gla...@acc.umu.se --- divelist.c | 12 ++-- divelist.h | 2 +- qt-ui/models.cpp | 2 +- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git

Segment duration in planner

of that column we should do it before the release. Otherwise i would cook up a patch that introduces enough checkboxes to produce this behavior. Which part sounds like a desirable behavior? Other ideas from the other folks that do decompression planning? //Anton -- Anton Lundin+46702-161604 From

Re: GSOC project updates

On 28 July, 2014 - Lubomir I. Ivanov wrote: On 28 July 2014 19:03, Anton Lundin gla...@acc.umu.se wrote: Just a note here from how we thought. The scope of this GSOC project is to produce a usable downloader app for android and one pre-req for that is a usable touch friendly ui

Re: GSOC project updates

. Remember, were not talking about porting the whole subsurface ui from qt to Android here, were only talking about porting the download from divecomputer dialog. //Anton -- Anton Lundin+46702-161604 ___ subsurface mailing list subsurface@hohndel.org

[PATCH 1/3] Rename list column from O2% to Gas

In the dive list, calling the column O2% is kinda wrong, because in at least my dive list there are both air and trimix showing up, so this renames that column to Gas. Signed-off-by: Anton Lundin gla...@acc.umu.se --- qt-ui/models.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 2/3] Rename the model column from NITROX to GAS

The column isn't just about NITROX, there might be air and trimix in there too. Signed-off-by: Anton Lundin gla...@acc.umu.se --- qt-ui/divelistview.cpp | 2 +- qt-ui/models.cpp | 6 +++--- qt-ui/models.h | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/qt

[PATCH 3/3] Rename dive gas function and defines for clarity

This renames the dive gas functions to not talk about just nitrox, and to instead talk about gas. Signed-off-by: Anton Lundin gla...@acc.umu.se --- divelist.c | 12 ++-- divelist.h | 2 +- qt-ui/models.cpp | 2 +- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git

Re: GSOC final week

of the different patches is one of the highest priority things. //Anton -- Anton Lundin+46702-161604 ___ subsurface mailing list subsurface@hohndel.org http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface

Re: [PATCH] Print nice names for nitrox mixes in the divelist

*gasmix) ? //Anton -- Anton Lundin+46702-161604 ___ subsurface mailing list subsurface@hohndel.org http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface

[PATCH 1/2] Import NDL form UDDF files

Signed-off-by: Anton Lundin gla...@acc.umu.se --- xslt/uddf.xslt | 10 ++ 1 file changed, 10 insertions(+) diff --git a/xslt/uddf.xslt b/xslt/uddf.xslt index c4911c5..1508fb3 100644 --- a/xslt/uddf.xslt +++ b/xslt/uddf.xslt @@ -467,6 +467,16 @@ /xsl:call-template

Re: leftover after clean

when you build out of a git source tree and another when you build out from a package. In the case of building from a package, the ssrf-version.h file is generated by qmake, not by the later build. I took a stab at rewriting that case into a target, but qmake won against me. //Anton -- Anton

[PATCH] Fix NO_USERMANUAL building for android

Signed-off-by: Anton Lundin gla...@acc.umu.se --- qt-ui/mainwindow.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/qt-ui/mainwindow.cpp b/qt-ui/mainwindow.cpp index 4c70f5c..af8bc70 100644 --- a/qt-ui/mainwindow.cpp +++ b/qt-ui/mainwindow.cpp @@ -903,10 +903,12 @@ void MainWindow

[PATCH] Fix android font config

In e893f6bd9db696a1d647b796138233152ca290fa (Use the Windows default font on Windows 7 and 8/8.1) font config was changed, but the android font config wasn't changed. This updates the android font config to match the new way. Signed-off-by: Anton Lundin gla...@acc.umu.se --- android.cpp | 8

Re: [CCR PATCH] Add Poseidon MKVI dive log to dives directory

internally so 300kb in the checkout is nothing. Better to keep the file in the exact format that you get the divelog from the divecomputer/software. //Anton -- Anton Lundin+46702-161604 ___ subsurface mailing list subsurface@hohndel.org http

[PATCH] Switch some columns to right alignment in divelist

Some columns in the dive list makes more sense to have right aligned than left aligned. This switches the numeric columns to right alignment so they is more easily compared visually. Signed-off-by: Anton Lundin gla...@acc.umu.se --- qt-ui/models.cpp | 21 - 1 file changed, 20

Re: [PATCH] Switch some columns to right alignment in divelist

On 03 September, 2014 - Tomaz Canabrava wrote: Em 03/09/2014 17:24, Anton Lundin gla...@acc.umu.se escreveu: Some columns in the dive list makes more sense to have right aligned than left aligned. This switches the numeric columns to right alignment so they is more easily compared

Re: [PATCH] Switch some columns to right alignment in divelist

On 03 September, 2014 - Tomaz Canabrava wrote: Em 03/09/2014 17:34, Anton Lundin gla...@acc.umu.se escreveu: On 03 September, 2014 - Tomaz Canabrava wrote: Em 03/09/2014 17:24, Anton Lundin gla...@acc.umu.se escreveu: Some columns in the dive list makes more sense to have right

English version of the homepage in half-Italian?

I had a quick look at http://subsurface.hohndel.org/download/ today, and the English version have turned into halv-Italian. Have someone translated the wrong page or have something in WP gone mad? //Anton -- Anton Lundin+46702-161604

Re: [PATCH] Switch some columns to right alignment in divelist

would rather see all the dive numbers on the same visual alignment and have some other sort of end-of-trip-marker, but i get the reason for this. So, a compromize might be to leave the NR-column left-aligned and move the rest of our numeric columns to be right-aligned? //Anton -- Anton Lundin

[PATCH v2] Switch some columns to right alignment in divelist

-by: Anton Lundin gla...@acc.umu.se --- qt-ui/models.cpp | 33 - 1 file changed, 32 insertions(+), 1 deletion(-) diff --git a/qt-ui/models.cpp b/qt-ui/models.cpp index 5266130..ce0f864 100644 --- a/qt-ui/models.cpp +++ b/qt-ui/models.cpp @@ -1063,6 +1063,34 @@ static

Re: Dive Info Stats tabs

, but thats a whole other question ) //Anton 1. https://play.google.com/store/apps/details?id=com.hhssoftware.multideco ( Actually quite nice software for mixing. The dive planning is trail-ware but the mixing part is free ) -- Anton Lundin+46702-161604

Re: Dive Info Stats tabs

On 16 September, 2014 - Davide DB wrote: Il 16/set/2014 17:36 Anton Lundin gla...@acc.umu.se ha scritto: On 16 September, 2014 - Davide DB wrote: Maybe it was already explained. Why SAC should be different between these two tabs if just one dive is selected? See attachment

Re: Dive Info Stats tabs

On 17 September, 2014 - Davide DB wrote: On Tue, Sep 16, 2014 at 8:32 PM, Anton Lundin gla...@acc.umu.se wrote: ... Why SAC should be different between these two tabs if just one dive is selected? See attachment (its' a PSCR dive). They are different, because one is per gas and one

Re: Started doing the Multi - Filter component for dives.

here. //Anton -- Anton Lundin+46702-161604 ___ subsurface mailing list subsurface@hohndel.org http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface

Re: Started doing the Multi - Filter component for dives.

of ideas what to start digging into here, but haven't had the time to do that properly. //Anton -- Anton Lundin+46702-161604 ___ subsurface mailing list subsurface@hohndel.org http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface

<    1   2   3   >