Re: Location, location, location

2015-07-15 Thread Henrik Brautaset Aronsen
On Wed, Jul 15, 2015 at 1:45 AM, Dirk H dir...@gmail.com wrote: So now I have Blu which completes to Blue Corner, Blue Grotto or Blue Hole. You also see an example of a dive site with no GPS data in that list. If you were to pick that site, we will add the GPS data in your current dive to

Re: [GSoC] Week 3 (Native Bluetooth support)

2015-07-15 Thread Jef Driesen
Dirk, Sorry for the slow response. Been busy with real life. On 2015-06-17 16:45, Dirk Hohndel wrote: I don't know which other apps use libdivecomputer, but the ones that I know about... Subsurface: happy to implement a Bluetooth backend, happy to use the existing libdivecomputer

Re: Location, location, location

2015-07-15 Thread Henrik Brautaset Aronsen
On Wed, Jul 15, 2015 at 3:43 PM, Dirk Hohndel d...@hohndel.org wrote: On Wed, Jul 15, 2015 at 03:15:20PM +0200, Henrik Brautaset Aronsen wrote: I think Blu - Create dive site with this name is *very* useful: it's a nice, unambiguous and readable way to explicitly create a new dive site,

Re: Location, location, location

2015-07-15 Thread Tomaz Canabrava
That's an auto complete feature, it you don't auto complete, the name you input is used, if you auto complete, the auto complete is used. We can make it a bit more explicit (maybe creating yet another entry on the drop-down with the current text, but I really think that auto complete for the

Re: Location, location, location

2015-07-15 Thread Henrik Brautaset Aronsen
On Wed, Jul 15, 2015 at 1:09 PM, Tomaz Canabrava tcanabr...@kde.org wrote: To create a dive site named Blu, you just doesn't select anything from the drop down. Is there a create button for that? If not, it's somewhat confusing. I would rather have the first entry say Blu - Create dive site

Re: Location, location, location

2015-07-15 Thread Davide DB
On Wed, Jul 15, 2015 at 1:45 AM, Dirk H dir...@gmail.com wrote: So this is what Tomaz and I have come up with so far... there are a couple minor issues with the current code so it isn't in master, yet, but I think we are making progress. I like it. Just one question. How the two ways of

Re: Location, location, location

2015-07-15 Thread Linus Torvalds
On Wed, Jul 15, 2015 at 11:43 AM, Henrik Brautaset Aronsen subsurf...@henrik.synth.no wrote: I mean, *really*. Think about it. How often do you create a new site with the exact same name as another one? It's a one-in-thousand occurance. Compared to a pretty useful and descriptive entry with

Re: Location, location, location

2015-07-15 Thread Rodrigo Severo
On Wed, Jul 15, 2015 at 2:56 PM, Linus Torvalds torva...@linux-foundation.org wrote: On Wed, Jul 15, 2015 at 6:38 AM, Rick Walsh rickmwa...@gmail.com wrote: I see the benefit of the autocomplete to create a new site with the same name as an existing site isn't so much that it saves a few

Re: Linus rants [was: Re: Location, location, location]

2015-07-15 Thread Henrik Brautaset Aronsen
On 15 Jul 2015 21:31, Linus Torvalds torva...@linux-foundation.org wrote: On Wed, Jul 15, 2015 at 12:29 PM, Henrik Brautaset Aronsen subsurf...@henrik.synth.no wrote: So do I. About the same percentages as well. Of course I would like to find existing dive sites autocompleted. I'm

Re: Location, location, location

2015-07-15 Thread Linus Torvalds
On Wed, Jul 15, 2015 at 12:16 PM, Henrik Brautaset Aronsen subsurf...@henrik.synth.no wrote: If something is needed once in a thousand times it should not occupy such a prime position in our UI. Guys, FUCK YOU. I have used subsurface with the companion app probably more than anybody on this

Linus rants [was: Re: Location, location, location]

2015-07-15 Thread Henrik Brautaset Aronsen
On 15 Jul 2015 21:21, Linus Torvalds torva...@linux-foundation.org wrote: On Wed, Jul 15, 2015 at 12:16 PM, Henrik Brautaset Aronsen subsurf...@henrik.synth.no wrote: If something is needed once in a thousand times it should not occupy such a prime position in our UI. Guys, FUCK YOU.

Re: Location, location, location

2015-07-15 Thread Dirk Hohndel
On Jul 15, 2015, at 11:43, Henrik Brautaset Aronsen subsurf...@henrik.synth.no wrote: On Wed, Jul 15, 2015 at 3:43 PM, Dirk Hohndel d...@hohndel.org wrote: On Wed, Jul 15, 2015 at 03:15:20PM +0200, Henrik Brautaset Aronsen wrote: I think Blu - Create dive site with this name is *very*

adjusting the way we interact

2015-07-15 Thread Dirk Hohndel
On Wed, Jul 15, 2015 at 12:21:05PM -0700, Linus Torvalds wrote: On Wed, Jul 15, 2015 at 12:16 PM, Henrik Brautaset Aronsen subsurf...@henrik.synth.no wrote: If something is needed once in a thousand times it should not occupy such a prime position in our UI. Guys, FUCK YOU. Linus, you

Re: Linus rants [was: Re: Location, location, location]

2015-07-15 Thread Linus Torvalds
On Wed, Jul 15, 2015 at 12:29 PM, Henrik Brautaset Aronsen subsurf...@henrik.synth.no wrote: So do I. About the same percentages as well. Of course I would like to find existing dive sites autocompleted. I'm talking about creating new sites, not the obvious use case of re-using old ones. But

Re: [PATCH] Bluetooth support for Android

2015-07-15 Thread Claudiu Olteanu
Hi Thiago, Is this method supposed to work elsewhere too? Is there a reason not to use it everywhere? This method should work on every supported platforms but I cannot obtain the correct result using it on Linux. I mentioned before that I believe there is a bug on the QtBluetooth library

Re: Location, location, location

2015-07-15 Thread Henrik Brautaset Aronsen
On 15 Jul 2015 20:54, Dirk Hohndel d...@hohndel.org wrote: On Jul 15, 2015, at 11:43, Henrik Brautaset Aronsen subsurf...@henrik.synth.no wrote: On Wed, Jul 15, 2015 at 3:43 PM, Dirk Hohndel d...@hohndel.org wrote: On Wed, Jul 15, 2015 at 03:15:20PM +0200, Henrik Brautaset Aronsen wrote:

Re: [PATCH] Bluetooth support for Android

2015-07-15 Thread Thiago Macieira
On Wednesday 15 July 2015 22:08:48 Claudiu Olteanu wrote: This method should work on every supported platforms but I cannot obtain the correct result using it on Linux. I mentioned before that I believe there is a bug on the QtBluetooth library because when I start a full SDP discovery

Re: [PATCH] Bluetooth support for Android

2015-07-15 Thread Rick Walsh
On 16 Jul 2015 8:32 am, Claudiu Olteanu olteanu.vasilica.clau...@gmail.com wrote: I can test on my Galaxy s6, which apparently run on Android 5.02. Well I could test it if I knew how. It will be a great help. First you should pair the devices manually. And that's where it went wrong. They

[PATCH 3/5] Fix libssh libssl linker order for Android

2015-07-15 Thread Anton Lundin
We need to link things in the correct order, even on android. Signed-off-by: Anton Lundin gla...@acc.umu.se --- CMakeLists.txt | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 5b94d13..123714b 100644 --- a/CMakeLists.txt +++

[PATCH 5/5] Use a different package for the mobile app

2015-07-15 Thread Anton Lundin
Now we produce two different android apps, and to be able to have both installed at once, we need to put them in different packages. Signed-off-by: Anton Lundin gla...@acc.umu.se --- android-mobile/AndroidManifest.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 1/5] Sanitize openssl building for android

2015-07-15 Thread Anton Lundin
The openssl build step polluted the variable space, and overrode the CC env, thus breaking the build if you did build openssl in the same session. Signed-off-by: Anton Lundin gla...@acc.umu.se --- packaging/android/build.sh | 23 ++- 1 file changed, 10 insertions(+), 13

[PATCH 2/5] Build openssl without legacy protocols.

2015-07-15 Thread Anton Lundin
SSL2 and SSL3 are deprecated, and we can gladly leave them out of our build. Signed-off-by: Anton Lundin gla...@acc.umu.se --- packaging/android/build.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packaging/android/build.sh b/packaging/android/build.sh index

[PATCH 4/5] Build libssh for android

2015-07-15 Thread Anton Lundin
Now when we build openssl for https support, its easy to add libssh2 to get ssh support to, so this does that. Signed-off-by: Anton Lundin gla...@acc.umu.se --- packaging/android/build.sh | 23 +-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --git

Re: Location, location, location

2015-07-15 Thread Linus Torvalds
On Wed, Jul 15, 2015 at 6:38 AM, Rick Walsh rickmwa...@gmail.com wrote: I see the benefit of the autocomplete to create a new site with the same name as an existing site isn't so much that it saves a few keystrokes, but that it is explicitly either creating a new site or assigning a dive to an

Re: [PATCH] Bluetooth support for Android

2015-07-15 Thread Claudiu Olteanu
It's July. Alex may be on his 4-week vacation. Ping him again next week to see if he's back. Ok, thanks for the info! Then I will wait for Alex to finish his vacation and I will welcome him with some potential bugs on QtBluetooth library:-). ___

Re: [PATCH] Bluetooth support for Android

2015-07-15 Thread Rick Walsh
Hi Claudiu, On 16 Jul 2015 5:09 am, Claudiu Olteanu olteanu.vasilica.clau...@gmail.com wrote: Hi Thiago, Is this method supposed to work elsewhere too? Is there a reason not to use it everywhere? This method should work on every supported platforms but I cannot obtain the correct

Re: Location, location, location

2015-07-15 Thread Tomaz Canabrava
To create a dive site named Blu, you just doesn't select anything from the drop down. On Wed, Jul 15, 2015, 05:11 Henrik Brautaset Aronsen subsurf...@henrik.synth.no wrote: On Wed, Jul 15, 2015 at 1:45 AM, Dirk H dir...@gmail.com wrote: So now I have Blu which completes to Blue Corner, Blue

Re: Location, location, location

2015-07-15 Thread Rodrigo Severo
On Wed, Jul 15, 2015 at 10:45 AM, Dirk Hohndel d...@hohndel.org wrote: On Wed, Jul 15, 2015 at 10:27:16AM -0300, Rodrigo Severo wrote: On Wed, Jul 15, 2015 at 10:15 AM, Henrik Brautaset Aronsen subsurf...@henrik.synth.no wrote: The autocompleted Blue Corner - Create dive site with this name

Re: Location, location, location

2015-07-15 Thread Davide DB
On Wed, Jul 15, 2015 at 4:06 PM, Rodrigo Severo rodr...@fabricadeideias.com wrote: On Wed, Jul 15, 2015 at 10:45 AM, Dirk Hohndel d...@hohndel.org wrote: I completely agree. If the user wants to create a new site, just type it in. If they want to use an existing site, pick it from the auto

Re: Location, location, location

2015-07-15 Thread Dirk Hohndel
On Wed, Jul 15, 2015 at 10:10:42AM +0200, Henrik Brautaset Aronsen wrote: On Wed, Jul 15, 2015 at 1:45 AM, Dirk H dir...@gmail.com wrote: So now I have Blu which completes to Blue Corner, Blue Grotto or Blue Hole. You also see an example of a dive site with no GPS data in that list.

Re: Location, location, location

2015-07-15 Thread Dirk Hohndel
On Wed, Jul 15, 2015 at 02:09:02PM +0200, Davide DB wrote: On Wed, Jul 15, 2015 at 1:45 AM, Dirk H dir...@gmail.com wrote: So this is what Tomaz and I have come up with so far... there are a couple minor issues with the current code so it isn't in master, yet, but I think we are making

Re: GSoC Status - Week 7 (VPM-B)

2015-07-15 Thread Jan Darowski
Hi, thanks for verification. 2015-07-15 14:49 GMT+02:00 Rick Walsh rickmwa...@gmail.com: Jan, I was curious and had a peek at your github. I hope you don't mind. Robert's feedback is what you should be most interested in, but I'll give mine anyway. https://github.com/Slagvi/subsurface

Re: GSoC Status - Week 7 (VPM-B)

2015-07-15 Thread Rick Walsh
On 15 Jul 2015 11:38 pm, Jan Darowski jan.darow...@gmail.com wrote: Hi, thanks for verification. 2015-07-15 14:49 GMT+02:00 Rick Walsh rickmwa...@gmail.com: Jan, I was curious and had a peek at your github. I hope you don't mind. Robert's feedback is what you should be most interested

Re: Location, location, location

2015-07-15 Thread Henrik Brautaset Aronsen
On Wed, Jul 15, 2015 at 2:05 PM, Tomaz Canabrava tcanabr...@kde.org wrote: That's an auto complete feature, it you don't auto complete, the name you input is used, if you auto complete, the auto complete is used. We can make it a bit more explicit (maybe creating yet another entry on the

Re: [GSoC] Week 3 (Native Bluetooth support)

2015-07-15 Thread Dirk Hohndel
On Wed, Jul 15, 2015 at 08:57:22AM +0200, Jef Driesen wrote: Sorry for the slow response. Been busy with real life. I know that feeling well. On 2015-06-17 16:45, Dirk Hohndel wrote: I don't know which other apps use libdivecomputer, but the ones that I know about... Subsurface: happy

Re: Location, location, location

2015-07-15 Thread Rick Walsh
On 15 Jul 2015 11:27 pm, Rodrigo Severo rodr...@fabricadeideias.com wrote: On Wed, Jul 15, 2015 at 10:15 AM, Henrik Brautaset Aronsen subsurf...@henrik.synth.no wrote: The autocompleted Blue Corner - Create dive site with this name is not useful IMHO. How often would you create a new

Re: Location, location, location

2015-07-15 Thread Davide DB
On Wed, Jul 15, 2015 at 3:36 PM, Dirk Hohndel d...@hohndel.org wrote: But of course the new design is much more useful if you download the GPS data first. Because then it will show you sites nearby and will make it even easier to figure out the correct information. It shows you distances to

Re: Location, location, location

2015-07-15 Thread Dirk Hohndel
On Wed, Jul 15, 2015 at 03:15:20PM +0200, Henrik Brautaset Aronsen wrote: On Wed, Jul 15, 2015 at 2:05 PM, Tomaz Canabrava tcanabr...@kde.org wrote: That's an auto complete feature, it you don't auto complete, the name you input is used, if you auto complete, the auto complete is used. We

Re: Location, location, location

2015-07-15 Thread Dirk Hohndel
On Wed, Jul 15, 2015 at 10:27:16AM -0300, Rodrigo Severo wrote: On Wed, Jul 15, 2015 at 10:15 AM, Henrik Brautaset Aronsen subsurf...@henrik.synth.no wrote: The autocompleted Blue Corner - Create dive site with this name is not useful IMHO. How often would you create a new site with the