Bluetooth interface questions and a UI suggestion

2015-09-10 Thread Willem Ferguson
I have a question about the Bluetooth download interface. When selecting import -> Import from dive computer, there are two possibilities: 1) In the MountPoint textbox of the Download panel, the address of the Bluetooth device is shown. It looks like this happens automatically when

cloud storage progress bar testing

2015-09-10 Thread Lubomir I. Ivanov
at least i can do some testing here. i'm able to show the progress bar it if i add this explicitly in MainWindow::showProgressBar(): progressDialog->show(); but it stays at zero when doing "Open cloud storage". looking at git-access.c: USE_LIBGIT23_API is set. the lines setting the callback

Re: cloud storage progress bar testing

2015-09-10 Thread Dirk Hohndel
On Thu, Sep 10, 2015 at 12:49:14PM +0300, Lubomir I. Ivanov wrote: > at least i can do some testing here. > > i'm able to show the progress bar it if i add this explicitly in > MainWindow::showProgressBar(): > progressDialog->show(); > but it stays at zero when doing "Open cloud storage". Just

Re: cloud storage progress bar testing

2015-09-10 Thread Dirk Hohndel
On Thu, Sep 10, 2015 at 06:57:26PM +0300, Lubomir I. Ivanov wrote: > On 10 September 2015 at 18:33, Dirk Hohndel wrote: > > On Thu, Sep 10, 2015 at 12:49:14PM +0300, Lubomir I. Ivanov wrote: > >> at least i can do some testing here. > >> > >> i'm able to show the progress bar it

Re: [PATCH] Save settings in closeEvent, not destructor

2015-09-10 Thread Dirk Hohndel
That patch is missing the corresponding change to the .h file... I'll add it :-) /D On Thu, Sep 10, 2015 at 07:30:39AM +0200, Anton Lundin wrote: > This switches to use the closeEvent to save settings and cleanup instead > of the destructor. > > Signed-off-by: Anton Lundin >

Re: [PATCH] Save settings in closeEvent, not destructor

2015-09-10 Thread Anton Lundin
On 10 September, 2015 - Dirk Hohndel wrote: > That patch is missing the corresponding change to the .h file... > I'll add it :-) > Thanks. I broke this one out of some other WIP-patches i was working on, and obviously i didn't break out the .h changes. //Anton -- Anton Lundin

Re: cloud storage progress bar testing

2015-09-10 Thread Dirk Hohndel
On Thu, Sep 10, 2015 at 07:13:14PM +0300, Lubomir I. Ivanov wrote: > On 10 September 2015 at 19:09, Dirk Hohndel wrote: > > On Thu, Sep 10, 2015 at 06:57:26PM +0300, Lubomir I. Ivanov wrote: > >> On 10 September 2015 at 18:33, Dirk Hohndel wrote: > >> > On

RE: cloud storage progress bar testing

2015-09-10 Thread Sander M. Kleijwegt
I have tested it on windows 7 (I don't own 10) and am _not_ seeing the spinner with the following steps: Using 4.5 beta 1 1) add bogus password to subsurface cloud settings 2) delete C:\Users\\AppData\Local\Subsurface\Subsurface\* 3) restart subsurface 4) add correct password to subsurface cloud

Re: cloud storage progress bar testing

2015-09-10 Thread Lubomir I. Ivanov
On 10 September 2015 at 19:09, Dirk Hohndel wrote: > On Thu, Sep 10, 2015 at 06:57:26PM +0300, Lubomir I. Ivanov wrote: >> On 10 September 2015 at 18:33, Dirk Hohndel wrote: >> > On Thu, Sep 10, 2015 at 12:49:14PM +0300, Lubomir I. Ivanov wrote: >> >> at least

Re: cloud storage progress bar testing

2015-09-10 Thread Dirk Hohndel
On Thu, Sep 10, 2015 at 04:49:52PM +, Sander M. Kleijwegt wrote: > I have tested it on windows 7 (I don't own 10) and am _not_ seeing the > spinner > with the following steps: > > Using 4.5 beta 1 Yes, Beta 1 had the spinner that I have given up on and that apparently fails for Windows. >

Re: cloud storage progress bar testing

2015-09-10 Thread Lubomir I. Ivanov
On 10 September 2015 at 18:33, Dirk Hohndel wrote: > On Thu, Sep 10, 2015 at 12:49:14PM +0300, Lubomir I. Ivanov wrote: >> at least i can do some testing here. >> >> i'm able to show the progress bar it if i add this explicitly in >> MainWindow::showProgressBar(): >>

Uemis Patches

2015-09-10 Thread Guido Lerch
I am done with my first round of Uemis patches. I am new to this so please forgive me if I still don't get this 100% correct. Dirk advised me to commit as much as possible but I still struggle to make a commit if the commit would not end up in something that is executable. Advise appreciated.

Uemis Patch 0010

2015-09-10 Thread Guido Lerch
fixeds a bug in uemis_set_location whereas I had cases where DS was NULL -- Best regards, Guido From 4274b51be390e6bcfc1811313d16ef21a52e153a Mon Sep 17 00:00:00 2001 From: glerch Date: Thu, 10 Sep 2015 20:54:03 +0200 Subject: [PATCH 10/10] Uemis - bug fix in uemis set

Patch: Uemis fixing whitespace issues

2015-09-10 Thread Guido Lerch
-- Best regards, Guido From 56bed33f185afdde0d24f48a8180d0ab507063c6 Mon Sep 17 00:00:00 2001 From: glerch Date: Thu, 10 Sep 2015 19:56:58 +0200 Subject: [PATCH 9/9] Uemis - fixing white spaces no code changes, just fixing white space and an empty line Signed-off-by:

Re: VPM-B oddity

2015-09-10 Thread Robert Helling
Rick, > On 10 Sep 2015, at 20:26, Rick Walsh wrote: > > The model assumes that deco starts at the last input point. This is ok for a > square profile dive. But for a multi-level dive, especially with a deep > bouncing, it doesn't make much sense. I think a better

Re: cloud storage progress bar testing

2015-09-10 Thread Benjamin
In my case it was a clean install. The computer hadn't had Subsurface on it before. Benjamin ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

[PATCH] Fix spelling of First

2015-09-10 Thread Anton Lundin
Signed-off-by: Anton Lundin --- qt-ui/configuredivecomputerdialog.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qt-ui/configuredivecomputerdialog.cpp b/qt-ui/configuredivecomputerdialog.cpp index e04dcc3..95225bd 100644 ---

[PATCH] Add delegates for setpoint configuration

2015-09-10 Thread Anton Lundin
This adds delegates to simplify configuration of setpoint values in the OSTC's. Signed-off-by: Anton Lundin --- qt-ui/configuredivecomputerdialog.cpp | 10 +- qt-ui/configuredivecomputerdialog.h | 1 + qt-ui/configuredivecomputerdialog.ui | 8 3 files

[PATCH] Access table data the same way as its set

2015-09-10 Thread Anton Lundin
The table data is set via role, so retrieve the data via role too. Signed-off-by: Anton Lundin --- qt-ui/configuredivecomputerdialog.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qt-ui/configuredivecomputerdialog.cpp

[PATCH] Be compatible with libgit2 0.22 again

2015-09-10 Thread Anton Lundin
The callback function was introduced in 0.23, so put it behind that ifdef. Signed-off-by: Anton Lundin --- git-access.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/git-access.c b/git-access.c index a9e411e..b133a76 100644 --- a/git-access.c +++

Re: Uemis Patches

2015-09-10 Thread Dirk Hohndel
Hi Guido. This was an excellent series of patches. Well done. I ended up rephrasing the commit messages a but, especially the commit titles, but that's something that I do a lot for other people as well. I may be a bit over zealous there, but I think the result makes it easier to track what's

Re: Patch: Uemis fixing whitespace issues

2015-09-10 Thread Dirk Hohndel
Hmm, I don't know about all of these :-) Is there a bug in the QtCreator settings I gave you? I thought QtCreator got the continuation lines right... > @@ -71,8 +71,8 @@ static void uemis_ts(char *buffer, void *_when) > > memset(, 0, sizeof(tm)); > sscanf(buffer,

Re: Uemis Patches

2015-09-10 Thread Dirk Hohndel
Hi Guido, I mentioned this before, please don't mark comments with "glerch " If someone wants't to know who wrote this and when, they can use "git blame" /D On Thu, Sep 10, 2015 at 07:54:29PM +0200, Guido Lerch wrote: > From a10c9b8877a708157f52e335d4009bb9a22d33c5 Mon Sep 17 00:00:00 2001 >

Re: Bluetooth interface questions and a UI suggestion

2015-09-10 Thread Claudiu Olteanu
Hi there > I have a question about the Bluetooth download interface. > > When selecting import -> Import from dive computer, there are two > possibilities: > > 1) In the MountPoint textbox of the Download panel, the address of the > Bluetooth device is shown. It looks like this happens

Re: Uemis Patches

2015-09-10 Thread Guido Lerch
Thanks Dirk, I have a at least one more code optimisation. How would I get the last master and merge my commits that I have not formatted to patches. I was reading the documentation about merge vs. rebase and frankly I don't get it at this point in time. 2015-09-10 21:38 GMT+02:00 Dirk Hohndel

Re: [PATCH] Exit with failure if dc_open method fails

2015-09-10 Thread Anton Lundin
On 09 September, 2015 - Claudiu Olteanu wrote: > If the dc_serial_*_open method fails then we should exit with > an error and don't try to open the device using the native > implementation. > > Currently if the local Bluetooth adapter doesn't connect successfully > to a dive computer it tries to

Re: VPM-B oddity

2015-09-10 Thread Rick Walsh
Hi Robert, On 11 Sep 2015 01:32, "Robert Helling" wrote: > > Hi, > > inspired by some discussion on a diving forum, I tried the following: > > Use VPM-B to plan a dive to 43m for 35min with air and EAN50 and EAN100 as deco gases. Without conservatism and with last stop at 6m this

Re: VPM-B oddity

2015-09-10 Thread Rick Walsh
On 11 Sep 2015 04:29, "Robert Helling" wrote: > > Rick, > >> On 10 Sep 2015, at 20:26, Rick Walsh wrote: >> >> The model assumes that deco starts at the last input point. This is ok for a square profile dive. But for a multi-level dive, especially with a