Re: [PATCH 1/3] QML-UI: Rearrange the DiveDetails page

2016-01-26 Thread Joakim Bygdell
On 26 January 2016 at 12:21, Rick Walsh wrote: > > > On 26 January 2016 at 21:54, Rick Walsh wrote: > >> Jocke, >> >> On 26 January 2016 at 04:44, Joakim Bygdell wrote: >> >>> After adding "Cylinder" to the DiveDetails page the

Re: [PATCH 1/3] QML-UI: Rearrange the DiveDetails page

2016-01-26 Thread David Tillotson
On 26 January 2016 11:37:31 GMT+00:00, Rick Walsh wrote: >On 26 January 2016 at 22:22, David Tillotson >wrote: > >> On 26 January 2016 10:54:36 GMT+00:00, Rick Walsh > >> wrote: >> >Forget about cylinders and weights (just

Re: [PATCH 1/3] QML-UI: Rearrange the DiveDetails page

2016-01-26 Thread Joakim Bygdell
On 26 January 2016 at 12:52, Rick Walsh wrote: > > > On 26 January 2016 at 22:47, Joakim Bygdell wrote: > >> >> >> On 26 January 2016 at 12:37, Rick Walsh wrote: >> >>> >>> >>> On 26 January 2016 at 22:22, David Tillotson

Re: [PATCH 1/3] QML-UI: Rearrange the DiveDetails page

2016-01-26 Thread Rick Walsh
On 26 January 2016 at 22:47, Joakim Bygdell wrote: > > > On 26 January 2016 at 12:37, Rick Walsh wrote: > >> >> >> On 26 January 2016 at 22:22, David Tillotson >> wrote: >> >> I can't reproduce the crashes that I saw, but have

Re: [PATCH 1/3] QML-UI: Rearrange the DiveDetails page

2016-01-26 Thread Rick Walsh
Jocke, On 26 January 2016 at 04:44, Joakim Bygdell wrote: > After adding "Cylinder" to the DiveDetails page the objects had to be > rearranged > in order to better utilise the space. > To get a cleaner look on smaller screens the left side is left aligned and > the > right

Re: [PATCH 1/3] QML-UI: Rearrange the DiveDetails page

2016-01-26 Thread Rick Walsh
On 26 January 2016 at 21:54, Rick Walsh wrote: > Jocke, > > On 26 January 2016 at 04:44, Joakim Bygdell wrote: > >> After adding "Cylinder" to the DiveDetails page the objects had to be >> rearranged >> in order to better utilise the space. >> To get a

Re: [PATCH 1/3] QML-UI: Rearrange the DiveDetails page

2016-01-26 Thread Sebastian Kügler
On Monday, January 25, 2016 06:44:50 PM Joakim Bygdell wrote: > After adding "Cylinder" to the DiveDetails page the objects had to be > rearranged in order to better utilise the space. > To get a cleaner look on smaller screens the left side is left aligned and > the right side is right aligend.

Re: [PATCH 1/3] QML-UI: Rearrange the DiveDetails page

2016-01-25 Thread Dirk Hohndel
On Mon, Jan 25, 2016 at 08:35:47PM +0100, Jan Mulder wrote: > On 25-01-16 20:17, Dirk Hohndel wrote: > >On Mon, Jan 25, 2016 at 06:44:50PM +0100, Joakim Bygdell wrote: > >>After adding "Cylinder" to the DiveDetails page the objects had to be > >>rearranged > >>in order to better utilise the

Re: [PATCH 1/3] QML-UI: Rearrange the DiveDetails page

2016-01-25 Thread Dirk Hohndel
On Mon, Jan 25, 2016 at 08:50:07PM +0100, Joakim Bygdell wrote: > > > > Sure - but there needs to be some visual acknowledgement that there's more > > than one cylinder. > > Should be simple enough to fix. :-) > > On the weights this can simply be the sum of all weights. But then... what > >

Re: [PATCH 1/3] QML-UI: Rearrange the DiveDetails page

2016-01-25 Thread Jan Mulder
On 25-01-16 20:17, Dirk Hohndel wrote: On Mon, Jan 25, 2016 at 06:44:50PM +0100, Joakim Bygdell wrote: After adding "Cylinder" to the DiveDetails page the objects had to be rearranged in order to better utilise the space. To get a cleaner look on smaller screens the left side is left aligned

Re: [PATCH 1/3] QML-UI: Rearrange the DiveDetails page

2016-01-25 Thread Joakim Bygdell
> On 25 Jan 2016, at 20:40, Dirk Hohndel wrote: > > On Mon, Jan 25, 2016 at 08:38:37PM +0100, Joakim Bygdell wrote: >> >>> On 25 Jan 2016, at 20:35, Jan Mulder wrote: >>> >>> On 25-01-16 20:17, Dirk Hohndel wrote: On Mon, Jan 25, 2016 at 06:44:50PM

Re: [PATCH 1/3] QML-UI: Rearrange the DiveDetails page

2016-01-25 Thread Joakim Bygdell
> On 25 Jan 2016, at 21:10, Dirk Hohndel wrote: > > On Mon, Jan 25, 2016 at 08:50:07PM +0100, Joakim Bygdell wrote: >>> >>> Sure - but there needs to be some visual acknowledgement that there's more >>> than one cylinder. >> >> Should be simple enough to fix. > > :-) > >>>

Re: [PATCH 1/3] QML-UI: Rearrange the DiveDetails page

2016-01-25 Thread Dirk Hohndel
On Mon, Jan 25, 2016 at 06:44:50PM +0100, Joakim Bygdell wrote: > After adding "Cylinder" to the DiveDetails page the objects had to be > rearranged > in order to better utilise the space. > To get a cleaner look on smaller screens the left side is left aligned and the > right side is right

Re: [PATCH 1/3] QML-UI: Rearrange the DiveDetails page

2016-01-25 Thread Dirk Hohndel
On Mon, Jan 25, 2016 at 08:38:37PM +0100, Joakim Bygdell wrote: > > > On 25 Jan 2016, at 20:35, Jan Mulder wrote: > > > > On 25-01-16 20:17, Dirk Hohndel wrote: > >> On Mon, Jan 25, 2016 at 06:44:50PM +0100, Joakim Bygdell wrote: > >>> After adding "Cylinder" to the

Re: [PATCH 1/3] QML-UI: Rearrange the DiveDetails page

2016-01-25 Thread Dirk Hohndel
On Mon, Jan 25, 2016 at 10:09:08PM +0100, Joakim Bygdell wrote: > >>> Yes. Let's assume you have a dive with the following weights: > >>> > >>> "integrated" : 4kg > >>> "ankle" : 2kg > >>> > >>> Subsurface-mobile shows > >>> > >>> weights: 6kg > >>> > >>> Now you edit this to be 7kg. How do

Re: [PATCH 1/3] QML-UI: Rearrange the DiveDetails page

2016-01-25 Thread Joakim Bygdell
> On 25 Jan 2016, at 21:54, Dirk Hohndel wrote: > > On Mon, Jan 25, 2016 at 09:23:39PM +0100, Joakim Bygdell wrote: >>> >>> Yes. Let's assume you have a dive with the following weights: >>> >>> "integrated" : 4kg >>> "ankle" : 2kg >>> >>> Subsurface-mobile shows >>> >>>

Re: [PATCH 1/3] QML-UI: Rearrange the DiveDetails page

2016-01-25 Thread Dirk Hohndel
On Mon, Jan 25, 2016 at 08:20:31PM +0100, Joakim Bygdell wrote: > > > On 25 Jan 2016, at 20:17, Dirk Hohndel wrote: > > > > On Mon, Jan 25, 2016 at 06:44:50PM +0100, Joakim Bygdell wrote: > >> After adding "Cylinder" to the DiveDetails page the objects had to be > >>

Re: [PATCH 1/3] QML-UI: Rearrange the DiveDetails page

2016-01-25 Thread Joakim Bygdell
> On 25 Jan 2016, at 20:35, Jan Mulder wrote: > > On 25-01-16 20:17, Dirk Hohndel wrote: >> On Mon, Jan 25, 2016 at 06:44:50PM +0100, Joakim Bygdell wrote: >>> After adding "Cylinder" to the DiveDetails page the objects had to be >>> rearranged >>> in order to better