Re: [PATCH 2/2] Adding about page to Subsurface-mobile

On Wednesday, February 10, 2016 07:50:00 PM Miika Turkia wrote: > On Wed, Feb 10, 2016 at 5:29 PM, Sebastian Kügler wrote: > > On Wednesday, February 10, 2016 05:09:51 PM Miika Turkia wrote: > >> +import QtQuick.Window 2.2 > >> +import QtQuick.Dialogs 1.2 > > > > Seems unused? > >

[PATCH 2/2] Adding about page to Subsurface-mobile

This isn't pretty, but having the version string available on a place that people are likely to find does make sense when going public with the Subsurface-mobile. Especially when we do a public release, I assume the developer menu with App log might not be readily available for people to identify

Re: [PATCH 2/2] Adding about page to Subsurface-mobile

On Wednesday, February 10, 2016 05:09:51 PM Miika Turkia wrote: > +import QtQuick.Window 2.2 > +import QtQuick.Dialogs 1.2 Seems unused? > + signal accept What is this used for? Could you attach or link a screenshot to this page? That makes it much easier to review the visual aspects.

Re: [PATCH 2/2] Adding about page to Subsurface-mobile

> On Feb 10, 2016, at 9:50 AM, Miika Turkia wrote: > > On Wed, Feb 10, 2016 at 5:29 PM, Sebastian Kügler wrote: >> On Wednesday, February 10, 2016 05:09:51 PM Miika Turkia wrote: >>> +import QtQuick.Window 2.2 >>> +import QtQuick.Dialogs 1.2 >> >> Seems

[PATCH 2/2] Adding about page to Subsurface-mobile

This isn't pretty, but having the version string available on a place that people are likely to find does make sense when going public with the Subsurface-mobile. Especially when we do a public release, I assume the developer menu with App log might not be readily available for people to identify

Re: [PATCH 2/2] Adding about page to Subsurface-mobile

On Wed, Feb 10, 2016 at 5:29 PM, Sebastian Kügler wrote: > On Wednesday, February 10, 2016 05:09:51 PM Miika Turkia wrote: >> +import QtQuick.Window 2.2 >> +import QtQuick.Dialogs 1.2 > > Seems unused? > >> + signal accept > > What is this used for? I am quite clueless when