Re: [PATCH 2/2] Properly clear sensor pressure data for synthetic plotinfo entries

2017-10-06 Thread Linus Torvalds
On Fri, Oct 6, 2017 at 10:46 AM, Stefan Fuchs wrote: > > Could you please have a quick look at this: > https://github.com/Subsurface-divelog/subsurface/pull/628 That looks right. Alternatively, if the planner really wants to set pressures by hand (I'm not sure why it would want

Re: [PATCH 2/2] Properly clear sensor pressure data for synthetic plotinfo entries

2017-10-06 Thread Stefan Fuchs
Hi Linus, Am 20.09.2017 um 10:16 schrieb Stefan Fuchs: >> On Fri, Sep 15, 2017 at 5:31 AM, Stefan Fuchs wrote: >>> Sorry for the maybe stupid questions: This does already solve the issue with >>> the spike I reported, isn't it? >> Maybe. I'm not convinced it didn't exist before,

Re: [PATCH 2/2] Properly clear sensor pressure data for synthetic plotinfo entries

2017-09-20 Thread Robert Helling
Stefan, > On 20. Sep 2017, at 10:16, Stefan Fuchs wrote: > > The question is now: Why does the planner (or whatever) does the thing > correctly when creating the dive but then does a mistake when replanning the > same dive? both these issues (this and the other mail) look like

Re: [PATCH 2/2] Properly clear sensor pressure data for synthetic plotinfo entries

2017-09-20 Thread Stefan Fuchs
Hi Linus, hallo Robert, sorry, me again regarding the wrong pressure data graph or let's better say wrong pressure data entry in the XML file where Linus did a pretty extensive analysis. Am 15.09.2017 um 20:22 schrieb Linus Torvalds: > On Fri, Sep 15, 2017 at 5:31 AM, Stefan Fuchs

Re: [PATCH 2/2] Properly clear sensor pressure data for synthetic plotinfo entries

2017-09-15 Thread Linus Torvalds
On Fri, Sep 15, 2017 at 5:31 AM, Stefan Fuchs wrote: > > Sorry for the maybe stupid questions: This does already solve the issue with > the spike I reported, isn't it? Maybe. I'm not convinced it didn't exist before, though, although maybe hidden. It definitely existed as far as

Re: [PATCH 2/2] Properly clear sensor pressure data for synthetic plotinfo entries

2017-09-15 Thread Stefan Fuchs
Hi Linus, Am 14.09.2017 um 21:20 schrieb Linus Torvalds: > From: Linus Torvalds <torva...@linux-foundation.org> > Date: Thu, 14 Sep 2017 12:14:33 -0700 > Subject: [PATCH 2/2] Properly clear sensor pressure data for synthetic > plotinfo entries > > We only cleared the f

[PATCH 2/2] Properly clear sensor pressure data for synthetic plotinfo entries

2017-09-14 Thread Linus Torvalds
From: Linus Torvalds <torva...@linux-foundation.org> Date: Thu, 14 Sep 2017 12:14:33 -0700 Subject: [PATCH 2/2] Properly clear sensor pressure data for synthetic plotinfo entries We only cleared the first sensor data when we created new synthetic plot info entries, because we only used t