> On Apr 3, 2022, at 2:11 AM, Berthold wrote:
> Your analysis sounds very plausible. This seems to work as intended, or at
> least how it worked before.
I don't remember that this was what we intended, but as you say... plausible
for sure.
> Generally, I'm not a fan of default parameters
Hi Linus,
On Sonntag, 3. April 2022 00:30:39 CEST Linus Torvalds wrote:
> That default flag was added by commit b6f821886 ("mobile: unify
> download code on mobile and desktop"), but as far as I can tell, it
> acted that way even before (it used to do
>
> add_imported_dives(, nullptr, ,
On Sat, Apr 2, 2022 at 2:18 PM Dirk Hohndel via subsurface
wrote:
>
> I'd appreciate some other eyeballs on this :)
I have a suspicion.
Notable, the mobile side does:
importModel.recordDives()
from the qml code.
And look what the default flags are:
Q_INVOKABLE void
moving this to the developer mailing list.
There's something odd here. And I can't figure out what's going wrong.
Contrary to the comments in the code (oh how I love that), it seems that both
desktop and mobile call into the same routine:
// Note: this function is only used from mobile -
