Re: handling fingerprints

2021-11-13 Thread Dirk Hohndel via subsurface
Hi Jason! > On Nov 13, 2021, at 2:52 PM, JB2Cool wrote: > > I think i understand what i'm meant to be testing but i can't seem to get any > functional difference between using 5.0.4 and 5.0.4-27-gb87cbed53cd6. Well, for the thing that I want you to test, there should be a "day and night"

Re: handling fingerprints

2021-11-13 Thread JB2Cool via subsurface
I think i understand what i'm meant to be testing but i can't seem to get any functional difference between using 5.0.4 and 5.0.4-27-gb87cbed53cd6. Can you spell it out for dummies how to test this for you (I know you've already written it out but i'm talking farm animal stupid instructions). I

Re: handling fingerprints

2021-11-12 Thread Dirk Hohndel via subsurface
To avoid confusion: you'll need Subsurface-mobile 3.4.1(or newer) and Subsurface 5.0.4.25 (or newer) to test this... /D > On Nov 12, 2021, at 3:46 PM, Dirk Hohndel via subsurface > wrote: > > My code to share fingerprints via the cloud has been merged into master. > Android test binaries

Re: handling fingerprints

2021-11-12 Thread Dirk Hohndel via subsurface
My code to share fingerprints via the cloud has been merged into master. Android test binaries with that new code are pending review to be pushed into the beta channel. I'll work on iOS test binaries in a moment. It would be extremely helpful if this could get some testing. This new feature is

Re: handling fingerprints

2021-10-25 Thread Jef Driesen via subsurface
On 25/10/2021 19:25, Linus Torvalds wrote: On Mon, Oct 25, 2021 at 10:13 AM Jef Driesen wrote: What's the reason for ignoring the fingerprint if you don't have the corresponding dive anymore? Simple: you successfully downloaded all the dives, but had some problems, and never saved them.

Re: handling fingerprints

2021-10-25 Thread Linus Torvalds via subsurface
On Mon, Oct 25, 2021 at 10:13 AM Jef Driesen wrote: > > What's the reason for ignoring the fingerprint if you don't have the > corresponding dive anymore? Simple: you successfully downloaded all the dives, but had some problems, and never saved them. Maybe just a "oops, screwed up editing" and

Re: handling fingerprints

2021-10-25 Thread Jef Driesen via subsurface
On 24/10/2021 02:12, Dirk Hohndel via subsurface wrote: (3) close the cloud storage, open a local .xml file; download again -> fingerprint file is found, but the matching dive is not in the dive list, so fingerprint gets ignored (but why are we even looking at it???) -> dives are

handling fingerprints

2021-10-23 Thread Dirk Hohndel via subsurface
Hey Linus, The more I think about our current fingerprint handling (I think that's our third attempt), the more I think we are still not doing this right. Right now we consider fingerprint files specific to a host (so the specific system - PC, laptop, phone, tablet) that Subsurface runs on.