Re: fundamental design issues with trips and dives

2019-11-07 Thread Dirk Hohndel
> On Nov 7, 2019, at 10:03 AM, Linus Torvalds > wrote: > > On Thu, Nov 7, 2019 at 9:46 AM Dirk Hohndel wrote: >> >> I like the thinking here. Radically simple. It does, however, breaks a lot >> of assumptions in our code, but I'm willing to deal with that in favor of >> something that's

Re: Feedback Subsurface-mobile 2.2.3 (4.9.3.258) for iOS

2019-11-07 Thread Dirk Hohndel
Thank you so much. Seriously. Thank you. I think a lot of people on this list massively underestimate how much value we get from people who just simply test the code and report back. /D > On Nov 7, 2019, at 9:22 AM, Hartley Horwitz wrote: > > I've filtered, downloaded, edited existing dives.

Re: fundamental design issues with trips and dives

2019-11-07 Thread Linus Torvalds
On Thu, Nov 7, 2019 at 9:46 AM Dirk Hohndel wrote: > > I like the thinking here. Radically simple. It does, however, breaks a lot of > assumptions in our code, but I'm willing to deal with that in favor of > something that's logical and consistent. Hmm. It shouldn't break any assumptions in

Re: fundamental design issues with trips and dives

2019-11-07 Thread Dirk Hohndel
Yes, I think that is a very reasonable scenario and as Linus points out, the original design had that in mind... /D > On Nov 7, 2019, at 9:54 AM, Richard Houser wrote: > > Agreed. It's just an arbitrary container. > > Consider the less crazy case of going on a trip with a group near West

Re: fundamental design issues with trips and dives

2019-11-07 Thread Dirk Hohndel
> On Nov 7, 2019, at 10:10 AM, Berthold Stoeger > wrote: > > Dirk, > > On Donnerstag, 7. November 2019 18:17:28 CET Dirk Hohndel wrote: > >> (4) ??? other ideas? > > This all works on desktop, so my idea would be to use the desktop tree model > and the desktop undo commands. More details

Re: Feedback Subsurface-mobile 2.2.3 (4.9.3.258) for iOS

2019-11-07 Thread Hartley Horwitz
I've filtered, downloaded, edited existing dives. All working very well. Thanks!! It is very fast expanding and contracting trips. Changed preferences. Loaded from and saved to the cloud. Edited existing GPS coordinates and observed the change to the map. I have NOT tested BTLE download. I

Re: fundamental design issues with trips and dives

2019-11-07 Thread Berthold Stoeger
Dirk, On Donnerstag, 7. November 2019 18:17:28 CET Dirk Hohndel wrote: > (4) ??? other ideas? This all works on desktop, so my idea would be to use the desktop tree model and the desktop undo commands. More details later (in the metro to dinner). Berthold

Re: fundamental design issues with trips and dives

2019-11-07 Thread Linus Torvalds
On Thu, Nov 7, 2019 at 9:17 AM Dirk Hohndel wrote: > > (4) ??? other ideas? Stop thinking that dates have anything to do with dive trips. A dive is in a trip. A trip is just a container. The date is completely and utterly irrelevant, and has nothing to do with what trip a dive is. The *only*

Re: fundamental design issues with trips and dives

2019-11-07 Thread Richard Houser
Agreed. It's just an arbitrary container. Consider the less crazy case of going on a trip with a group near West Palm Florida for example. They aren't die hard divers, but have 6 dives spread across a week. It's still a dive trip. Then you hear a college buddy is in-state on vacation, and

fundamental design issues with trips and dives

2019-11-07 Thread Dirk Hohndel
I hope that this subject line gets the right people to read this email - getting traction on the developer list has been very hard lately. I'm on a flight from Amsterdam to Portland and am contemplating yet another rewrite of the divelist models for mobile. The rewrite I did this week showed

Re: fundamental design issues with trips and dives

2019-11-07 Thread Dirk Hohndel
> On Nov 7, 2019, at 9:40 AM, Linus Torvalds > wrote: > > On Thu, Nov 7, 2019 at 9:17 AM Dirk Hohndel wrote: >> >> (4) ??? other ideas? > > Stop thinking that dates have anything to do with dive trips. > > A dive is in a trip. A trip is just a container. The date is > completely and

Re: fundamental design issues with trips and dives

2019-11-07 Thread Willem Ferguson
On 2019/11/08 00:25, Dirk Hohndel wrote: On Nov 7, 2019, at 2:02 PM, Linus Torvalds wrote: On Thu, Nov 7, 2019 at 12:14 PM Berthold Stoeger wrote: It doesn't have to. Just like you defined a proxy model on top of the DiveListModel, one could implement a proxy model on top of the tree model

Re: fundamental design issues with trips and dives

2019-11-07 Thread Linus Torvalds
On Thu, Nov 7, 2019 at 12:14 PM Berthold Stoeger wrote: > > It doesn't have to. Just like you defined a proxy model on top of the > DiveListModel, one could implement a proxy model on top of the tree model that > "linearizes" it. Maybe we should do that in general, even for the desktop case. I

Re: fundamental design issues with trips and dives

2019-11-07 Thread Dirk Hohndel
> On Nov 7, 2019, at 2:02 PM, Linus Torvalds > wrote: > > On Thu, Nov 7, 2019 at 12:14 PM Berthold Stoeger > wrote: >> >> It doesn't have to. Just like you defined a proxy model on top of the >> DiveListModel, one could implement a proxy model on top of the tree model >> that >>

Re: fundamental design issues with trips and dives

2019-11-07 Thread Dirk Hohndel
Berthold, > On Nov 7, 2019, at 12:14 PM, Berthold Stoeger > wrote: >> Yes, I looked at using the tree model and the undo commands. I actually >> spent quite a bit of time on that path before doing the current rewrite >> that is now in beta test on both Android and iOS. >> >> My conclusion is

Re: fundamental design issues with trips and dives

2019-11-07 Thread Berthold Stoeger
On Donnerstag, 7. November 2019 19:32:22 CET Dirk Hohndel wrote: > > On Nov 7, 2019, at 10:10 AM, Berthold Stoeger > > wrote: > > This all works on desktop, so my idea would be to use the desktop tree > > model and the desktop undo commands. More details later (in the metro to > > dinner). > Yes,

Re: Feedback Subsurface-mobile 2.2.3 (4.9.3.258) for iOS

2019-11-07 Thread Rainer Mohr
Works like a charm :-) Also, any editing of a dive is immediately and correctly reflected in the list. Rainer Am 07.11.19 um 02:27 schrieb Dirk Hohndel: On Thu, Nov 07, 2019 at 12:42:51AM +0100, Dirk Hohndel wrote: On Wed, Nov 06, 2019 at 02:22:59PM +0100, Dirk Hohndel wrote: Ugh. Thanks.

Re: fundamental design issues with trips and dives

2019-11-07 Thread Linus Torvalds
On Thu, Nov 7, 2019 at 2:25 PM Dirk Hohndel wrote: > > > And it might be truly *lovely* for startup if we didn't populate the > > whole model at all. For the git format, we could literally avoid even > > parsing the dives that are in a collapsed trip and this not visible. > > So we'd have a