Re: new website - or "jet lag is good"

2015-10-11 Thread Salvador Cuñat
Hi again.

2015-10-11 8:22 GMT+02:00 Salvador Cuñat :

> Good morning.
>
> 2015-10-11 8:01 GMT+02:00 Dirk Hohndel :
>
>> After about 20 hours of editing and copying and modifying I have a mockup
>> of the new website ready.
>>
>> Please go to http://ssrftest.subsurface-divelog.org and let me know what
>> you think.
>>
>>
>> It looks rather bizarre in my browser  };-)
>
>
> Previous  snapshot only happens on translated page (shows a column with
*all* translations, english original included).  In english, page looks
just fine.

Regards.

Salva.
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: [PATCH 1/1] Use ~/.subsurface as default directory on Linux

2015-10-11 Thread Salvador Cuñat
2015-10-11 7:58 GMT+02:00 Dirk Hohndel :

>
> I would like .subsurface much better.
>
> Me too.  This is the way most applications do, so it will also be the
place where a user would expect to find such things.

Regards.

Salva.
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Dive Site Problem: nearby sites

2015-10-11 Thread Willem Ferguson
I want to make some changes to the user manual pertaining to the 
management of coordinates. So I create an hypothetical dive as follows:


Create a new dive:  Log -> Add dive
Specify a location that I have dived on several occasions. (In my case 
Aliwal Shoal: Cathedral)

Image 'Divesite1.png', attached, appears.
Now I am assuming that I am diving a different part of the Cathedral, 
NOT represented by any existing coordinates. So I doubleclick the 
highlighted option in Divesite1.png.

I hit the button "Apply changes". Now the dive information has been saved.
Then I hit the globe button to the right of the Location text box. I 
want to provide the coordinates.

Image Divesite2.png, attached appears.
But in the bottom list box there are no other locations of Aliwal Shoal: 
Cathedral


I would have expected all my previous dive locations at the Cathedral to 
be listed here.


Typing the coordinates of the new dive site at this stage does not make 
a difference. Neither using the existing coordinates for Cathedral, nor 
by changing the coordinates very slightly to refer to a site not exactly 
similar to any of the existing dives at Cathedral.


Am I misunderstanding the UI?

Kind regards,
willem




___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


RE: new website - or "jet lag is good"

2015-10-11 Thread Steve
After about 20 hours of editing and copying and modifying I have a mockup of
the new website ready.

 

Please go to http://ssrftest.subsurface-divelog.org and let me know what you
think.

 

I know that there are a few glitches... I finally need to try to get back to
a sane sleeping rhythm so I'll stop now even though I'm not completely done.

The dive computer ramblings need to be cleaned up. The translations of the
manuals are missing.

The translations of many of the pages are completely out of whack and most
pages haven't been updated to 4.5

So don't think of this as reviewing content (with the exception of the
landing page), but of reviewing layout and overall look and feel.

 

Thanks

 

/D

 

 

Looks good on my laptop.

I would change the different languages bar to the top rather than at the
bottom which you need to scroll down before you see it from the homepage.

 

Steve

 

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: Problem with printing dives

2015-10-11 Thread Joakim Bygdell
Willem, 

> On 11 Oct 2015, at 8:27, Willem Ferguson  
> wrote:
> Hi Lubomir,
> 
> See attached image.
> When zoomed in, the whole image of the printed profile is affected. Not what 
> one would like.
> The printed profile should be independent of the zoom level on the screen, I 
> think?
> Will try the patch later today.
> Kind regards,
> willem
> 
That behaviour can be seen on Beta3 as well.
But I agree, the printed profile should not be affected by the zoom level.

/Jocke

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: new website - or "jet lag is good"

2015-10-11 Thread Joakim Bygdell

> On 11 Oct 2015, at 8:01, Dirk Hohndel  wrote:
> 
> After about 20 hours of editing and copying and modifying I have a mockup of 
> the new website ready.
> 
> Please go to http://ssrftest.subsurface-divelog.org 
>  and let me know what you think.
> 
> I know that there are a few glitches... I finally need to try to get back to 
> a sane sleeping rhythm so I'll stop now even though I'm not completely done.
> The dive computer ramblings need to be cleaned up. The translations of the 
> manuals are missing.
> The translations of many of the pages are completely out of whack and most 
> pages haven't been updated to 4.5
> So don't think of this as reviewing content (with the exception of the 
> landing page), but of reviewing layout and overall look and feel.
> 
Adding a few thing to what the others have said.

The lefthand navigation frame goes all the way to the bottom of the page and 
thus covers the language row with the result that only “sh” from English is 
visible.
It is really apparent on the bugtracker page.

I suggest that the command snippets get placed in a scrollable frame, 
otherwise the page gets disproportionally wide when viewed on a phone


/Jocke

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


New website

2015-10-11 Thread Amit Chaudhuri
Hi Guys,

possibly dumb question about the new website (which looks pretty good to me).

I have in mind that some work had been done to support mobile devices
(e.g. Android phones).  Maybe I just imagined it or it is not yet
mature enough to shout about. But I was expecting to see mention of it
on the new website and didn't see it.

Is this something that's missing or not obvious on the new site, or
did I just invent the whole thing?

Regards,

A
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: new website - or "jet lag is good"

2015-10-11 Thread John Smith
Something weird going on in the MISC section 




Sent from my iPad

> On 11 Oct 2015, at 07:01, Dirk Hohndel  wrote:
> 
> After about 20 hours of editing and copying and modifying I have a mockup of 
> the new website ready.
> 
> Please go to http://ssrftest.subsurface-divelog.org and let me know what you 
> think.
> 
> I know that there are a few glitches... I finally need to try to get back to 
> a sane sleeping rhythm so I'll stop now even though I'm not completely done.
> The dive computer ramblings need to be cleaned up. The translations of the 
> manuals are missing.
> The translations of many of the pages are completely out of whack and most 
> pages haven't been updated to 4.5
> So don't think of this as reviewing content (with the exception of the 
> landing page), but of reviewing layout and overall look and feel.
> 
> Thanks
> 
> /D
> ___
> subsurface mailing list
> subsurface@subsurface-divelog.org
> http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: Problem with printing dives

2015-10-11 Thread Lubomir I. Ivanov
On 11 October 2015 at 10:27, Joakim Bygdell  wrote:
>
>
> On 10 Oct 2015, at 23:05, Lubomir I. Ivanov  wrote:
> Joakim,
>
> 1) a question:
> do you see those same line widths enlarge when you zoom in the profile
> (e.g. mouse scroll wheel) or do their widths stay constant at all zoom
> levels?
>

ok, seems like you guys found another bug.
what i meant though is - do the white lines enlarge when zooming in
the profile or does their width stays the same?
(without printing, simply looking at it)

>
> Printing zoomed profile have other issues, look at Wilhelms reply.
>
>
> 2) a test:
> can you try the attached patch (and perhaps you WIllem too) and see if
> it solves the line widths when printing?
>
>
> Take a look at the images, your patch does solve the issue with the line 
> widths, IF there is no printer installed.
> The question is why we have a different behaviour when saving to pdf from 
> print preview if there is no printer installed.
>
>

i have no idea; Qt bugs most likely..
the master_patch.png indicates to me that the patch works for both
with a printer installed an no printer.
is that correct?

lubomir
--
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: Problem with printing dives

2015-10-11 Thread Willem Ferguson

On 10/10/2015 23:05, Lubomir I. Ivanov wrote:
2) a test: can you try the attached patch (and perhaps you WIllem too) 
and see if it solves the line widths when printing? 


thanks. lubomir -- 


Lubomir,
Yes, it solves the print problem on my system too.
Thank you for your time!
Kind regards,
willem

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


[PATCH 2/2] profilewidget2: fix line width when printing on OSX and Linux

2015-10-11 Thread Lubomir I. Ivanov
From: "Lubomir I. Ivanov" 

On OSX and Linux only, the cosmetic width of the QPen
on profile axes does not work and is weirdly dependent on the
fact if a printer is installed or not. Possible Qt bugs at hand.

The same is not present on Win32.

To solve the issues we add setPrintMode() in DiveCartesianAxis
and call it for all instances of the class in ProfileWidget2.

This patch also moves gridPen() as a private member function
of PartialGasPressureAxis as it now needs to access member
variables.

Fixes #943

Reported-by: Willem Ferguson 
Signed-off-by: Lubomir I. Ivanov 
---

not sure if this is the best solution possible...
if anyone has objections after a review, please state them.
---
 qt-ui/profile/divecartesianaxis.cpp | 29 +
 qt-ui/profile/divecartesianaxis.h   |  4 
 qt-ui/profile/profilewidget2.cpp| 10 ++
 3 files changed, 35 insertions(+), 8 deletions(-)

diff --git a/qt-ui/profile/divecartesianaxis.cpp 
b/qt-ui/profile/divecartesianaxis.cpp
index 46f1a96..bf5a538 100644
--- a/qt-ui/profile/divecartesianaxis.cpp
+++ b/qt-ui/profile/divecartesianaxis.cpp
@@ -8,11 +8,14 @@
 #include "divelineitem.h"
 #include "profilewidget2.h"
 
-static QPen gridPen()
+QPen DiveCartesianAxis::gridPen()
 {
QPen pen;
pen.setColor(getColor(TIME_GRID));
-   pen.setWidth(2);
+   /* cosmetic width() == 0 for lines in printMode
+* having setCosmetic(true) and width() > 0 does not work when
+* printing on OSX and Linux */
+   pen.setWidth(DiveCartesianAxis::printMode ? 0 : 2);
pen.setCosmetic(true);
return pen;
 }
@@ -33,6 +36,18 @@ void DiveCartesianAxis::setFontLabelScale(qreal scale)
changed = true;
 }
 
+void DiveCartesianAxis::setPrintMode(bool mode)
+{
+   printMode = mode;
+   // update the QPen of all lines depending on printMode
+   QPen newPen = gridPen();
+   QColor oldColor = pen().brush().color();
+   newPen.setBrush(oldColor);
+   setPen(newPen);
+   Q_FOREACH (DiveLineItem *item, lines)
+   item->setPen(pen());
+}
+
 void DiveCartesianAxis::setMaximum(double maximum)
 {
if (IS_FP_SAME(max, maximum))
@@ -57,6 +72,7 @@ void DiveCartesianAxis::setTextColor(const QColor )
 
 DiveCartesianAxis::DiveCartesianAxis() : QObject(),
QGraphicsLineItem(),
+   printMode(false),
unitSystem(0),
orientation(LeftToRight),
min(0),
@@ -220,10 +236,8 @@ void DiveCartesianAxis::updateTicks(color_indice_t color)
childPos = begin - i * stepSize;
}
DiveLineItem *line = new DiveLineItem(this);
-   QPen pen;
+   QPen pen = gridPen();
pen.setBrush(getColor(color));
-   pen.setCosmetic(true);
-   pen.setWidthF(2);
line->setPen(pen);
line->setZValue(0);
lines.push_back(line);
@@ -340,11 +354,10 @@ double DiveCartesianAxis::fontLabelScale() const
 
 void DiveCartesianAxis::setColor(const QColor )
 {
-   QPen defaultPen(color);
+   QPen defaultPen = gridPen();
+   defaultPen.setColor(color);
defaultPen.setJoinStyle(Qt::RoundJoin);
defaultPen.setCapStyle(Qt::RoundCap);
-   defaultPen.setWidth(2);
-   defaultPen.setCosmetic(true);
setPen(defaultPen);
 }
 
diff --git a/qt-ui/profile/divecartesianaxis.h 
b/qt-ui/profile/divecartesianaxis.h
index 1515569..27cfa62 100644
--- a/qt-ui/profile/divecartesianaxis.h
+++ b/qt-ui/profile/divecartesianaxis.h
@@ -16,6 +16,9 @@ class DiveCartesianAxis : public QObject, public 
QGraphicsLineItem {
Q_PROPERTY(QPointF pos WRITE setPos READ pos)
Q_PROPERTY(qreal x WRITE setX READ x)
Q_PROPERTY(qreal y WRITE setY READ y)
+private:
+   bool printMode;
+   QPen gridPen();
 public:
enum Orientation {
TopToBottom,
@@ -25,6 +28,7 @@ public:
};
DiveCartesianAxis();
virtual ~DiveCartesianAxis();
+   void setPrintMode(bool mode);
void setMinimum(double minimum);
void setMaximum(double maximum);
void setTickInterval(double interval);
diff --git a/qt-ui/profile/profilewidget2.cpp b/qt-ui/profile/profilewidget2.cpp
index ab9ae2c..3ccd1bb 100644
--- a/qt-ui/profile/profilewidget2.cpp
+++ b/qt-ui/profile/profilewidget2.cpp
@@ -1479,6 +1479,16 @@ void ProfileWidget2::setPrintMode(bool mode, bool 
grayscale)
 {
printMode = mode;
resetZoom();
+
+   // set printMode for axes
+   profileYAxis->setPrintMode(mode);
+   gasYAxis->setPrintMode(mode);
+   temperatureAxis->setPrintMode(mode);
+   timeAxis->setPrintMode(mode);
+   cylinderPressureAxis->setPrintMode(mode);
+   heartBeatAxis->setPrintMode(mode);
+   percentageAxis->setPrintMode(mode);
+
isGrayscale = mode ? grayscale : false;

[PATCH 1/2] profilewidget2: add resetZoom()

2015-10-11 Thread Lubomir I. Ivanov
From: "Lubomir I. Ivanov" 

resetZoom() is now a new method that is called both
when 'printMode' is updated or when the dive is re-plotted.

Fixes a bug where zooming in on the profile and then
printing the dive has the profile at the wrong zoom level (makes
the profile look smaller).

Reported-by: Willem Ferguson 
Signed-off-by: Lubomir I. Ivanov 
---
 qt-ui/profile/profilewidget2.cpp | 16 +++-
 qt-ui/profile/profilewidget2.h   |  1 +
 2 files changed, 12 insertions(+), 5 deletions(-)

diff --git a/qt-ui/profile/profilewidget2.cpp b/qt-ui/profile/profilewidget2.cpp
index 5d2b507..ab9ae2c 100644
--- a/qt-ui/profile/profilewidget2.cpp
+++ b/qt-ui/profile/profilewidget2.cpp
@@ -477,6 +477,15 @@ void ProfileWidget2::setupSceneAndFlags()
background->setFlag(QGraphicsItem::ItemIgnoresTransformations);
 }
 
+void ProfileWidget2::resetZoom()
+{
+   if (!zoomLevel)
+   return;
+   const qreal defScale = 1.0 / qPow(zoomFactor, (qreal)zoomLevel);
+   scale(defScale, defScale);
+   zoomLevel = 0;
+}
+
 // Currently just one dive, but the plan is to enable All of the selected 
dives.
 void ProfileWidget2::plotDive(struct dive *d, bool force)
 {
@@ -521,11 +530,7 @@ void ProfileWidget2::plotDive(struct dive *d, bool force)
}
 
// restore default zoom level
-   if (zoomLevel) {
-   const qreal defScale = 1.0 / qPow(zoomFactor, (qreal)zoomLevel);
-   scale(defScale, defScale);
-   zoomLevel = 0;
-   }
+   resetZoom();
 
// reset some item visibility on printMode changes
toolTipItem->setVisible(!printMode);
@@ -1473,6 +1478,7 @@ bool ProfileWidget2::getPrintMode()
 void ProfileWidget2::setPrintMode(bool mode, bool grayscale)
 {
printMode = mode;
+   resetZoom();
isGrayscale = mode ? grayscale : false;
mouseFollowerHorizontal->setVisible(!mode);
mouseFollowerVertical->setVisible(!mode);
diff --git a/qt-ui/profile/profilewidget2.h b/qt-ui/profile/profilewidget2.h
index 7e038ed..2d1a7bf 100644
--- a/qt-ui/profile/profilewidget2.h
+++ b/qt-ui/profile/profilewidget2.h
@@ -71,6 +71,7 @@ public:
};
 
ProfileWidget2(QWidget *parent = 0);
+   void resetZoom();
void plotDive(struct dive *d = 0, bool force = false);
virtual bool eventFilter(QObject *, QEvent *);
void setupItem(AbstractProfilePolygonItem *item, DiveCartesianAxis 
*hAxis, DiveCartesianAxis *vAxis, DivePlotDataModel *model, int vData, int 
hData, int zValue);
-- 
1.7.11.msysgit.0

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: Problem with printing dives

2015-10-11 Thread Lubomir I. Ivanov
On 11 October 2015 at 13:46, Willem Ferguson
 wrote:
> Yes, it solves the print problem on my system too.
> Thank you for your time!

Willem and Joakim,

i have just sent two official patches to the mailing list, namely:
[PATCH 1/2] profilewidget2: add resetZoom()
fixes the badly zoomed profile when printing. this bug i can reproduce locally.

[PATCH 2/2] profilewidget2: fix line width when printing on OSX and Linux

i need your ACKS or tests (Acked-by: or Tested-by:) on this one as the
bug does not happen on my setup. it differs from the last patch
(_patch.diff) as it now keeps the grid width to a sane, visible
pleasant value on the screen, while *only* when printing forces a
"hairline" / cosmetic / 0-valued-width grid. the previous patch sets
the grid to "hairline" at all times.

thanks
lubomir
--
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: [PATCH 2/2] profilewidget2: fix line width when printing on OSX and Linux

2015-10-11 Thread Lubomir I. Ivanov
On 11 October 2015 at 14:21, Lubomir I. Ivanov  wrote:
> From: "Lubomir I. Ivanov" 
>
> On OSX and Linux only, the cosmetic width of the QPen
> on profile axes does not work and is weirdly dependent on the
> fact if a printer is installed or not. Possible Qt bugs at hand.
>
> The same is not present on Win32.
>
> To solve the issues we add setPrintMode() in DiveCartesianAxis
> and call it for all instances of the class in ProfileWidget2.
>
> This patch also moves gridPen() as a private member function
> of PartialGasPressureAxis as it now needs to access member
> variables.
>
> Fixes #943
>
> Reported-by: Willem Ferguson 
> Signed-off-by: Lubomir I. Ivanov 

pending Acked-by: / Tested-by!

lubomir
--
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: [PATCH 2/2] profilewidget2: fix line width when printing on OSX and Linux

2015-10-11 Thread Tomaz Canabrava
Ack
Em 11 de out de 2015 08:29, "Lubomir I. Ivanov" 
escreveu:

> On 11 October 2015 at 14:21, Lubomir I. Ivanov 
> wrote:
> > From: "Lubomir I. Ivanov" 
> >
> > On OSX and Linux only, the cosmetic width of the QPen
> > on profile axes does not work and is weirdly dependent on the
> > fact if a printer is installed or not. Possible Qt bugs at hand.
> >
> > The same is not present on Win32.
> >
> > To solve the issues we add setPrintMode() in DiveCartesianAxis
> > and call it for all instances of the class in ProfileWidget2.
> >
> > This patch also moves gridPen() as a private member function
> > of PartialGasPressureAxis as it now needs to access member
> > variables.
> >
> > Fixes #943
> >
> > Reported-by: Willem Ferguson 
> > Signed-off-by: Lubomir I. Ivanov 
>
> pending Acked-by: / Tested-by!
>
> lubomir
> --
> ___
> subsurface mailing list
> subsurface@subsurface-divelog.org
> http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
>
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: [PATCH 1/1] Use ~/.subsurface as default directory on Linux

2015-10-11 Thread Benjamin
On Sun, 11 Oct 2015 08:58 Dirk Hohndel  wrote:



I was going to mention that... I think that was an unintended side effect of
a patch that Lubomir sent.

I would like .subsurface much better.

What do others think?

This is the directory that both the default .xml file as well as the hashes,
the picturedata and the git cache directories are in...

/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


It does sound more "standard" to have those files in .subsurface instead of
in subsurface.
But I'm not really much of an expert :)

Benjamin
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: new website - or "jet lag is good"

2015-10-11 Thread Davide DB
Hi Dirk,

Did you changed/updated the cms you used for the website?
While translating Italian pages I remember it was a pita. I had to insert
html escape chars by myself.
On Oct 11, 2015 8:01 AM, "Dirk Hohndel"  wrote:

> After about 20 hours of editing and copying and modifying I have a mockup
> of the new website ready.
>
> Please go to http://ssrftest.subsurface-divelog.org and let me know what
> you think.
>
> I know that there are a few glitches... I finally need to try to get back
> to a sane sleeping rhythm so I'll stop now even though I'm not completely
> done.
> The dive computer ramblings need to be cleaned up. The translations of the
> manuals are missing.
> The translations of many of the pages are completely out of whack and most
> pages haven't been updated to 4.5
> So don't think of this as reviewing content (with the exception of the
> landing page), but of reviewing layout and overall look and feel.
>
> Thanks
>
> /D
>
> ___
> subsurface mailing list
> subsurface@subsurface-divelog.org
> http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
>
>
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: Problem with printing dives

2015-10-11 Thread Joakim Bygdell

> On 10 Oct 2015, at 23:05, Lubomir I. Ivanov  wrote:
> Joakim,
> 
> 1) a question:
> do you see those same line widths enlarge when you zoom in the profile
> (e.g. mouse scroll wheel) or do their widths stay constant at all zoom
> levels?

Printing zoomed profile have other issues, look at Wilhelms reply.

> 
> 2) a test:
> can you try the attached patch (and perhaps you WIllem too) and see if
> it solves the line widths when printing?

Take a look at the images, your patch does solve the issue with the line 
widths, IF there is no printer installed.
The question is why we have a different behaviour when saving to pdf from print 
preview if there is no printer installed.

> 
> thanks.
> lubomir
> --



/Jocke

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: new website - or "jet lag is good"

2015-10-11 Thread Gaetan Bisson
[2015-10-10 23:01:15 -0700] Dirk Hohndel:
> Please go to http://ssrftest.subsurface-divelog.org 
>  and let me know what you think.

Wow, great work, that really looks awesome.

The only thing I noted is that we have two redundant social media
banners (one in "top-header" and the other in "footer-bottom"); perhaps
the top one could be removed so page contents get bumped up?

Cheers.

-- 
Gaetan
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: new website - or "jet lag is good"

2015-10-11 Thread Rick Walsh
Hi,

On 11 Oct 2015 17:01, "Dirk Hohndel"  wrote:
>
> After about 20 hours of editing and copying and modifying I have a mockup
of the new website ready.
>
> Please go to http://ssrftest.subsurface-divelog.org and let me know what
you think.

I've had a quick look on my phone. Using Chrome on my Galaxy S6.  I like
the new layout, including that it draws attention to cool features at the
top. A few points.
-Main headings on each page are inconsistent size. Landing page is small.
Downloads is large. FAQ is small, etc.
-I think the heading colour would look better as "Subsurface blue", rather
than black.
-How will the page look on old/text browsers? Not sure this really matters
for a solely desktop/smartphone program.
-On the landing page is it better to elaborate on the features in case the
reader doesn't wait to scroll through them at the top? Cloud storage,
platforms and the planner aren't mentioned except in the bit that flashes
through at the top.

Rick

>
> I know that there are a few glitches... I finally need to try to get back
to a sane sleeping rhythm so I'll stop now even though I'm not completely
done.
> The dive computer ramblings need to be cleaned up. The translations of
the manuals are missing.
> The translations of many of the pages are completely out of whack and
most pages haven't been updated to 4.5
> So don't think of this as reviewing content (with the exception of the
landing page), but of reviewing layout and overall look and feel.
>
> Thanks
>
> /D
>
> ___
> subsurface mailing list
> subsurface@subsurface-divelog.org
> http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
>
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


new website - or "jet lag is good"

2015-10-11 Thread Dirk Hohndel
After about 20 hours of editing and copying and modifying I have a mockup of 
the new website ready.

Please go to http://ssrftest.subsurface-divelog.org 
 and let me know what you think.

I know that there are a few glitches... I finally need to try to get back to a 
sane sleeping rhythm so I'll stop now even though I'm not completely done.
The dive computer ramblings need to be cleaned up. The translations of the 
manuals are missing.
The translations of many of the pages are completely out of whack and most 
pages haven't been updated to 4.5
So don't think of this as reviewing content (with the exception of the landing 
page), but of reviewing layout and overall look and feel.

Thanks

/D___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: [PATCH] Problem with printing dives

2015-10-11 Thread Willem Ferguson

On 11/10/2015 14:29, Willem Ferguson wrote:

On 11/10/2015 13:28, Lubomir I. Ivanov wrote:

On 11 October 2015 at 13:46, Willem Ferguson
 wrote:

Yes, it solves the print problem on my system too.
Thank you for your time!

Willem and Joakim,

i have just sent two official patches to the mailing list, namely:
[PATCH 1/2] profilewidget2: add resetZoom()
fixes the badly zoomed profile when printing. this bug i can 
reproduce locally.


[PATCH 2/2] profilewidget2: fix line width when printing on OSX and 
Linux


i need your ACKS or tests (Acked-by: or Tested-by:) on this one as the
bug does not happen on my setup. it differs from the last patch
(_patch.diff) as it now keeps the grid width to a sane, visible
pleasant value on the screen, while *only* when printing forces a
"hairline" / cosmetic / 0-valued-width grid. the previous patch sets
the grid to "hairline" at all times.

thanks
lubomir
--



ACK

Attached an image of the result of the above patch for printing to the 
PDF printer. This is on Ubuntu 15.04.


Kind regards,
willem



___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: [PATCH 1/2] profilewidget2: add resetZoom()

2015-10-11 Thread Joakim Bygdell

> On 11 Oct 2015, at 13:21, Lubomir I. Ivanov  wrote:
> 
> From: "Lubomir I. Ivanov" 
> 
> resetZoom() is now a new method that is called both
> when 'printMode' is updated or when the dive is re-plotted.
> 
> Fixes a bug where zooming in on the profile and then
> printing the dive has the profile at the wrong zoom level (makes
> the profile look smaller).
> 
> Reported-by: Willem Ferguson 
> Signed-off-by: Lubomir I. Ivanov 
> ---
> qt-ui/profile/profilewidget2.cpp | 16 +++-
> qt-ui/profile/profilewidget2.h   |  1 +
> 2 files changed, 12 insertions(+), 5 deletions(-)
> 
> diff --git a/qt-ui/profile/profilewidget2.cpp 
> b/qt-ui/profile/profilewidget2.cpp
> index 5d2b507..ab9ae2c 100644
> --- a/qt-ui/profile/profilewidget2.cpp
> +++ b/qt-ui/profile/profilewidget2.cpp
> @@ -477,6 +477,15 @@ void ProfileWidget2::setupSceneAndFlags()
>   background->setFlag(QGraphicsItem::ItemIgnoresTransformations);
> }
> 
> +void ProfileWidget2::resetZoom()
> +{
> + if (!zoomLevel)
> + return;
> + const qreal defScale = 1.0 / qPow(zoomFactor, (qreal)zoomLevel);
> + scale(defScale, defScale);
> + zoomLevel = 0;
> +}
> +
> // Currently just one dive, but the plan is to enable All of the selected 
> dives.
> void ProfileWidget2::plotDive(struct dive *d, bool force)
> {
> @@ -521,11 +530,7 @@ void ProfileWidget2::plotDive(struct dive *d, bool force)
>   }
> 
>   // restore default zoom level
> - if (zoomLevel) {
> - const qreal defScale = 1.0 / qPow(zoomFactor, (qreal)zoomLevel);
> - scale(defScale, defScale);
> - zoomLevel = 0;
> - }
> + resetZoom();
> 
>   // reset some item visibility on printMode changes
>   toolTipItem->setVisible(!printMode);
> @@ -1473,6 +1478,7 @@ bool ProfileWidget2::getPrintMode()
> void ProfileWidget2::setPrintMode(bool mode, bool grayscale)
> {
>   printMode = mode;
> + resetZoom();
>   isGrayscale = mode ? grayscale : false;
>   mouseFollowerHorizontal->setVisible(!mode);
>   mouseFollowerVertical->setVisible(!mode);
> diff --git a/qt-ui/profile/profilewidget2.h b/qt-ui/profile/profilewidget2.h
> index 7e038ed..2d1a7bf 100644
> --- a/qt-ui/profile/profilewidget2.h
> +++ b/qt-ui/profile/profilewidget2.h
> @@ -71,6 +71,7 @@ public:
>   };
> 
>   ProfileWidget2(QWidget *parent = 0);
> + void resetZoom();
>   void plotDive(struct dive *d = 0, bool force = false);
>   virtual bool eventFilter(QObject *, QEvent *);
>   void setupItem(AbstractProfilePolygonItem *item, DiveCartesianAxis 
> *hAxis, DiveCartesianAxis *vAxis, DivePlotDataModel *model, int vData, int 
> hData, int zValue);
> -- 
> 1.7.11.msysgit.0
> 
> ___
> subsurface mailing list
> subsurface@subsurface-divelog.org
> http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Tested on El Capitan.
ACK

/Jocke

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: Segfault upon exit from coordinates specification

2015-10-11 Thread Tomaz Canabrava
William, Guido, looking at that.
Em 11 de out de 2015 09:53, "Guido Lerch"  escreveu:

> Hi Willem
> I had similar issues, can you try the following?
> Open your logbook with an xml editor, remove all duplicates.
> Retry.
>
> When doing a lot of testing and interrupting a debug, sometimes the
> duplication handling has issues when importing dives.
>
> Regards,
> Guido
> +41 79 3217739
>
> > Am 11.10.2015 um 14:19 schrieb Willem Ferguson <
> willemfergu...@zoology.up.ac.za>:
> >
> > I do the following:
> > Create new dive using log->Add dive
> > I provide name for an existing dive site and hit Apply changes
> > Edit coordinates in dive site info panel by hitting the globe button
> (these happen to be existing coordinates)
> > Type existing coordinates (this generates some warnings in the terminal)
> > Hit Discard changes: do not accept the information
> > Exit Subsurface.
> > Subsurface gives segfault.
> > Here is the terminal output:
> >
> > Setting a New dive site
> > Setting the dive site id on the dive: 304245814
> > Warning, two different dive sites with same name have a different id
> 2893376900 and 304245814
> > Warning, two different dive sites with same name have a different id
> 2893376900 and 304245814
> > Warning, two different dive sites with same name have a different id
> 2893376900 and 304245814
> > Warning, two different dive sites with same name have a different id
> 2893376900 and 304245814
> > Warning, two different dive sites with same name have a different id
> 2893376900 and 304245814
> > Warning, two different dive sites with same name have a different id
> 2893376900 and 304245814
> > Warning, two different dive sites with same name have a different id
> 2893376900 and 304245814
> > Warning, two different dive sites with same name have a different id
> 2893376900 and 304245814
> > cannot open "/home/willem/subsurface/hashes"
> > *** Error in `./subsurface': double free or corruption (fasttop):
> 0x025be950 ***
> > Aborted (core dumped)
> >
> > Kind regards,
> > willem
> >
> > ___
> > subsurface mailing list
> > subsurface@subsurface-divelog.org
> > http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
> ___
> subsurface mailing list
> subsurface@subsurface-divelog.org
> http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
>
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Segfault upon exit from coordinates specification

2015-10-11 Thread Willem Ferguson

I do the following:
Create new dive using log->Add dive
I provide name for an existing dive site and hit Apply changes
Edit coordinates in dive site info panel by hitting the globe button 
(these happen to be existing coordinates)

Type existing coordinates (this generates some warnings in the terminal)
Hit Discard changes: do not accept the information
Exit Subsurface.
Subsurface gives segfault.
Here is the terminal output:

Setting a New dive site
Setting the dive site id on the dive: 304245814
Warning, two different dive sites with same name have a different id 
2893376900 and 304245814
Warning, two different dive sites with same name have a different id 
2893376900 and 304245814
Warning, two different dive sites with same name have a different id 
2893376900 and 304245814
Warning, two different dive sites with same name have a different id 
2893376900 and 304245814
Warning, two different dive sites with same name have a different id 
2893376900 and 304245814
Warning, two different dive sites with same name have a different id 
2893376900 and 304245814
Warning, two different dive sites with same name have a different id 
2893376900 and 304245814
Warning, two different dive sites with same name have a different id 
2893376900 and 304245814

cannot open "/home/willem/subsurface/hashes"
*** Error in `./subsurface': double free or corruption (fasttop): 
0x025be950 ***

Aborted (core dumped)

Kind regards,
willem

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


wrong italian translation

2015-10-11 Thread Giorgio Marzano
I noticed an error in one italian translation.

in function get_time_string, file statistics.c:

snprintf(buf, sizeof(buf), translate("gettextFromC", "%dh %dmin"),
hours, minutes);


should return "20o, 39min" (o is for "ore", italian for hours)

Instead I get "20g, 39min" (g is gor "giorni", italian for days).

How am I suppose to proceed to fix this? I subscribed to transiflex but
italian seems to be somehow locked, i guess because it is at 100%
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: wrong italian translation

2015-10-11 Thread Dirk Hohndel

> On Oct 11, 2015, at 7:00 AM, Giorgio Marzano  
> wrote:
> 
> I noticed an error in one italian translation.
> 
> in function get_time_string, file statistics.c:
> 
> snprintf(buf, sizeof(buf), translate("gettextFromC", "%dh %dmin"), hours, 
> minutes);
> 
> should return "20o, 39min" (o is for "ore", italian for hours)
> 
> Instead I get "20g, 39min" (g is gor "giorni", italian for days).
> 
> How am I suppose to proceed to fix this? I subscribed to transiflex but 
> italian seems to be somehow locked, i guess because it is at 100%

No, Italian isn't locked at all.
Click on Italian, pick subsurface4 as resource, click on translate.
Then in the search field in the top left pick TEXT: and enter %dh (so this is 
the English text you are looking for)
You'll see two strings

%dd %dh %dmin  -- translated as %dg %dg %dmin
%dh %dmin   -- translated as %dg %dmin

So it sounds like the second one is mis-translated. I could of course fix this 
myself right now, but I think this is one of those "teach people to fish" 
moments. So please let me know if you can follow along what I just explained 
and can then fix it...

Thanks

/D___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: New website

2015-10-11 Thread Dirk Hohndel

> On Oct 11, 2015, at 2:45 AM, Amit Chaudhuri  
> wrote:
> 
> Hi Guys,
> 
> possibly dumb question about the new website (which looks pretty good to me).
> 
> I have in mind that some work had been done to support mobile devices
> (e.g. Android phones).  Maybe I just imagined it or it is not yet
> mature enough to shout about. But I was expecting to see mention of it
> on the new website and didn't see it.
> 
> Is this something that's missing or not obvious on the new site, or
> did I just invent the whole thing?

The Android App will be mentioned in the announcement as "Beta test will start 
soon".

Sebastianr has joined our team and sent the first few patches; I tested them on 
the 
desktop where they are a nice improvement, but then noticed that Lubomir's 
changes to file locations broke the Android build. But I really wanted to focus 
on the 
web site this weekend so I haven't fixed that, yet.

So the status of the Android app is "hopefully Sebastian will help us get this 
to a better
point". I also know that Stephen (another new developer) is considering helping 
with
that. And that Guido is thinking about porting the Android app to IOS.

So once 4.5 is out (still aiming for a release by mid week) I assume that we 
will focus
on the mobile apps (while Tomaz rewrites all of Subsurface and breaks most 
things
in the process) (just kidding).

Makes sense?

/D

PS: to avoid confusion: Sebastian and Stephen are "new developers to 
Subsurface".
They are both extremely accomplished developers, Sebastian indeed around Qt and
QML, Stephen in a completely different area (Linux networking kernel hacker).
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: Problem with printing dives

2015-10-11 Thread Lubomir I. Ivanov
On 11 October 2015 at 15:29, Willem Ferguson
 wrote:
>
> Attached an image of the result of the above patch for printing to the PDF
> printer. This is on Ubuntu 15.04.
> I am not sure how to do the Tested-by as part of the submission process.
>

an ACK in the email should suffice.

the image looks good to me.
the side effect is that all grind lines are now "hairline" width when
printing, but i don't have other solutions ATM.

lubomir
--
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: Segfault upon exit from coordinates specification

2015-10-11 Thread Guido Lerch
Hi Willem
I had similar issues, can you try the following?
Open your logbook with an xml editor, remove all duplicates.
Retry.

When doing a lot of testing and interrupting a debug, sometimes the duplication 
handling has issues when importing dives.

Regards,
Guido
+41 79 3217739

> Am 11.10.2015 um 14:19 schrieb Willem Ferguson 
> :
> 
> I do the following:
> Create new dive using log->Add dive
> I provide name for an existing dive site and hit Apply changes
> Edit coordinates in dive site info panel by hitting the globe button (these 
> happen to be existing coordinates)
> Type existing coordinates (this generates some warnings in the terminal)
> Hit Discard changes: do not accept the information
> Exit Subsurface.
> Subsurface gives segfault.
> Here is the terminal output:
> 
> Setting a New dive site
> Setting the dive site id on the dive: 304245814
> Warning, two different dive sites with same name have a different id 
> 2893376900 and 304245814
> Warning, two different dive sites with same name have a different id 
> 2893376900 and 304245814
> Warning, two different dive sites with same name have a different id 
> 2893376900 and 304245814
> Warning, two different dive sites with same name have a different id 
> 2893376900 and 304245814
> Warning, two different dive sites with same name have a different id 
> 2893376900 and 304245814
> Warning, two different dive sites with same name have a different id 
> 2893376900 and 304245814
> Warning, two different dive sites with same name have a different id 
> 2893376900 and 304245814
> Warning, two different dive sites with same name have a different id 
> 2893376900 and 304245814
> cannot open "/home/willem/subsurface/hashes"
> *** Error in `./subsurface': double free or corruption (fasttop): 
> 0x025be950 ***
> Aborted (core dumped)
> 
> Kind regards,
> willem
> 
> ___
> subsurface mailing list
> subsurface@subsurface-divelog.org
> http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: [PATCH] android.cpp: update path retriaval scheme

2015-10-11 Thread Lubomir I. Ivanov
On 11 October 2015 at 20:36, Joakim Bygdell  wrote:
>
>> On 11 Oct 2015, at 18:55, Lubomir I. Ivanov  wrote:
>>
>> From: "Lubomir I. Ivanov" 
>>
>> Android was skipped as a OS target when the recent path retriaval
>> modifications in .c were made.
>>
>> Signed-off-by: Lubomir I. Ivanov 
>> ---
>> code tested without the QAndoroid* API calls in an external test
>> project. not tested for the actual OS on runtime or as a compile
>> target!
>
> It builds ok but then it fails to write any files when syncing from colud.
>

sorry, i cannot test it on runtime. someone needs to figure out what's
happening.

lubomir
--
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: Custom print template

2015-10-11 Thread Lubomir I. Ivanov
On 11 October 2015 at 20:48, Sergey Starosek  wrote:
> Hi all,
>
> Previously there was an option ('Custom' item in the templates drop-down
> list)
> to create new print template. Now it has disappeared and the only way is to
> export an existing one under different name, then import and edit it.
>
> What's the right way of doing that?
>

we decided to remove the editing logic behind the custom.html template.
exporting then importing is a valid way of adding a new template. you
can also go to the folder and create files manually.

lubomir
--
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: [PATCH] android.cpp: update path retriaval scheme

2015-10-11 Thread Lubomir I. Ivanov
On 11 October 2015 at 20:53, Joakim Bygdell  wrote:
>
> On 11 Oct 2015, at 19:42, Lubomir I. Ivanov  wrote:
>
> On 11 October 2015 at 20:36, Joakim Bygdell  wrote:
>
>
> On 11 Oct 2015, at 18:55, Lubomir I. Ivanov  wrote:
>
> From: "Lubomir I. Ivanov" 
>
> Android was skipped as a OS target when the recent path retriaval
> modifications in .c were made.
>
> Signed-off-by: Lubomir I. Ivanov 
> ---
> code tested without the QAndoroid* API calls in an external test
> project. not tested for the actual OS on runtime or as a compile
> target!
>
>
> It builds ok but then it fails to write any files when syncing from colud.
>
>
> sorry, i cannot test it on runtime. someone needs to figure out what's
> happening.
>
>
> It fails during cloning, the hash folder is created but nothing is put in
> it.
> Also if I manually tell it to load dives from cloud it craches.
>
>

if the hash folder is created then the patch in this thread seems to
have done it's job. from here on it, could be a libgit2 issue. :\
a thorough debug of some of the git-access calls may be required.

lubomir
--
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: [PATCH] android.cpp: update path retriaval scheme

2015-10-11 Thread Dirk Hohndel
On Sun, Oct 11, 2015 at 08:58:07PM +0300, Lubomir I. Ivanov wrote:
> On 11 October 2015 at 20:53, Joakim Bygdell  wrote:
> >
> > On 11 Oct 2015, at 19:42, Lubomir I. Ivanov  wrote:
> >
> > On 11 October 2015 at 20:36, Joakim Bygdell  wrote:
> >
> >
> > On 11 Oct 2015, at 18:55, Lubomir I. Ivanov  wrote:
> >
> > From: "Lubomir I. Ivanov" 
> >
> > Android was skipped as a OS target when the recent path retriaval
> > modifications in .c were made.
> >
> > Signed-off-by: Lubomir I. Ivanov 
> > ---
> > code tested without the QAndoroid* API calls in an external test
> > project. not tested for the actual OS on runtime or as a compile
> > target!
> >
> >
> > It builds ok but then it fails to write any files when syncing from colud.
> >
> >
> > sorry, i cannot test it on runtime. someone needs to figure out what's
> > happening.
> >
> >
> > It fails during cloning, the hash folder is created but nothing is put in
> > it.
> > Also if I manually tell it to load dives from cloud it craches.
> >
> >
> 
> if the hash folder is created then the patch in this thread seems to
> have done it's job. from here on it, could be a libgit2 issue. :\
> a thorough debug of some of the git-access calls may be required.

Debugging the Android app - the one thing that's more painful than
debugging the Windows version :-)

Seriously, I'll look into it (or maybe Anton will), but I won't spend time
on the Android app until after the web site is life and 4.5 has been
released... priorities.

/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: Hebrew translation of Subsurface [was Re: crash on planning a dive with LANG=fi]

2015-10-11 Thread Dirk Hohndel

> On Oct 11, 2015, at 11:30 AM, Benjamin  wrote:
> 
> I can try, but it won't be this week. It's my not-often-practiced 3rd 
> language, so I can't offer any miracles :S

While many of our translations are done by native speakers who speak about 
diving in their native language all the time, I know for a fact that this isn't 
the case for all of them.
And it's much easier to find people willing to clean up an existing translation 
than to start a translation. So your work would be extremely welcome. We had 
quite a few Hebrew users in the Subsurface 3 days, but sadly the two people who 
used to work on it seem to have disappeared.

Can you please request to join the Hebrew team on Transifex?

And as for the timing - we almost always need a ".1" release a couple wee after 
a new release. So missing next week's release is not a huge issue - I will 
simply pull the translation into the update release that I'm sure we'll do 
towards the end of this month.

Thanks

/D

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: [PATCH 1/1] Use ~/.subsurface as default directory on Linux

2015-10-11 Thread Miika Turkia
On Sun, Oct 11, 2015 at 8:30 PM, Dirk Hohndel  wrote:
> On Sun, Oct 11, 2015 at 12:04:11PM +0300, Lubomir I. Ivanov wrote:
>> On 11 October 2015 at 11:28, Lubomir I. Ivanov  wrote:
>> > On 11 October 2015 at 08:36, Gaetan Bisson  wrote:
>> >> Hi guys,
>> >>
>> >> I only just noticed that cloud storage now uses (and automatically
>> >> creates) the ~/subsurface directory. Perhaps I missed some discussion
>> >> about it, but I would much prefer a name that starts with a dot. Does
>> >> the attached patch makes sense to you?
>> >>
>> >
>> > ACK.
>> >
>>
>> the dot is the way to go,
>>
>> i find it odd that ~/subsurface (no dot) was the suggested path for
>> the user default XML, since version 2.0 (or something) and nobody
>> complained
>> i think this indicates that nobody was using the default XML path on Linux.
>
> I'm not sure that's true - we did a few odd things that people seemed to
> just accept. But now is the time to fix it :-)
>
> I'll take Gaetan's patch and that fixes this issue.

This patch causes the log file to always be opened in edited mode. (I
have my preferences set to load the log from the old location, as I
suppose most of our users currently have.)

miika
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: Dive planner oddities

2015-10-11 Thread Robert C. Helling
Sergey,

thanks for testing this. Unfortunately I think I need some more explanation of 
your findigs.

> On 11 Oct 2015, at 20:06, Sergey Starosek  wrote:
> 
> Some planner testing results:
> Reset preferences, no default divelog
> Start planner (Buehlmann model)
> Switch to recreational model
> Note that 2nd waypoint is not aligned with graph
What exactly do you mean by „not aligned“? Do you refer to the fact that the 
handle is not at the end of the 15m segment? That is on purpose, this is what 
„recreational mode“ is about: The second handle is the last manually entered 
waypoint and in recreational mode the planner stays at that depth for the 
maximum time that does not get you in conflict with gas usage and deco 
obligations.


> Change depth for the 1st and 2nd waypoint to be 30m
> Note a peak on a SAC graph
Maybe I am stupid but I cannot see it on your screen shots. Actually, I don’t 
see the pO2 graph at all. When I run subsurface, I can see the graph but no 
peak. Could you indicate on the screen shot where I am supposed to look?

> Cancel plan, close and restart ssrf
> Open planner
> Note that 2nd waypoint is not aligned with graph

As above.

Best
Robert



signature.asc
Description: Message signed with OpenPGP using GPGMail
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: [PATCH 2/2] profilewidget2: fix line width when printing on OSX and Linux

2015-10-11 Thread Joakim Bygdell

> On 11 Oct 2015, at 13:29, Lubomir I. Ivanov  wrote:
> 
> pending Acked-by: / Tested-by!
> 
> lubomir
> 
ACK

/Jocke

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: wrong italian translation

2015-10-11 Thread Giorgio Marzano
I think I just did it. What now?
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: wrong italian translation

2015-10-11 Thread Dirk Hohndel
On Sun, Oct 11, 2015 at 07:50:05PM +0200, Giorgio Marzano wrote:
> I think I just did it. What now?

I just pulled the translations and pushed them out on master. So this
should be fixed now.

I also kicked off new daily builds on all platforms, they will take a
little while to all be completed, check in a few minutes if you want to
try precompiled binaries :-)

/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Hebrew translation of Subsurface [was Re: crash on planning a dive with LANG=fi]

2015-10-11 Thread Dirk Hohndel
On Sun, Oct 11, 2015 at 09:24:27PM +0300, Sergey Starosek wrote:
> Dirk,
> 
> On Sun, Oct 11, 2015 at 9:14 PM, Dirk Hohndel  wrote:
> 
> > On Sun, Oct 11, 2015 at 09:10:40PM +0300, Sergey Starosek wrote:
> >
> > Thanks for testing. I fixed this in the Portuguese translation (and the
> > two instances in the rather incomplete Hebrew translation). The new daily
> > binaries are compiling... if you could update this in few minutes and
> > retest that would be very welcome.
> >
> > Planner with PT and FI locales works for me. Can't test hebrew since SSRF
> does not offer it in the locales list.

Oh, right. I removed that since it fell to such a low tranlation ratio...

I changed the subject to see if we have any Hebrew speakers left on this
list who would like to get that translation back into decent shape...

Anyone?

Thanks

/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: Dive Site Problem: nearby sites

2015-10-11 Thread Dirk Hohndel

> On Oct 11, 2015, at 4:14 AM, Willem Ferguson 
>  wrote:
> 
> I want to make some changes to the user manual pertaining to the management 
> of coordinates. So I create an hypothetical dive as follows:
> 
> Create a new dive:  Log -> Add dive
> Specify a location that I have dived on several occasions. (In my case Aliwal 
> Shoal: Cathedral)
> Image 'Divesite1.png', attached, appears.
> Now I am assuming that I am diving a different part of the Cathedral, NOT 
> represented by any existing coordinates. So I doubleclick the highlighted 
> option in Divesite1.png.
> I hit the button "Apply changes". Now the dive information has been saved.
> Then I hit the globe button to the right of the Location text box. I want to 
> provide the coordinates.
> Image Divesite2.png, attached appears.
> But in the bottom list box there are no other locations of Aliwal Shoal: 
> Cathedral
> 
> I would have expected all my previous dive locations at the Cathedral to be 
> listed here.
> 
> Typing the coordinates of the new dive site at this stage does not make a 
> difference. Neither using the existing coordinates for Cathedral, nor by 
> changing the coordinates very slightly to refer to a site not exactly similar 
> to any of the existing dives at Cathedral.
> 
> Am I misunderstanding the UI?

I would have assumed the existing site to show up there.

Tomaz, can you comment?

/D

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: new website - or "jet lag is good"

2015-10-11 Thread Dirk Hohndel
Responding to my own email...

> On Oct 11, 2015, at 6:40 AM, Dirk Hohndel  wrote:
> 
> Ahh,
> 
> Clearly it's much easier to get feedback on the website than to get people to 
> test :-)
> 
> Is this an example of the bike shedding phenomenon? :-)

First things first. Me and my big mouth.
What I should have said was "Thank you to all of you who provided feedback. 
Much appreciated. I need as many people as possible to look at this and help me 
iron out the kinks before the site goes live".

> I'll try to answer to all of the comments here...
> 
>> On Oct 10, 2015, at 11:20 PM, Rick Walsh > > wrote:
>> I've had a quick look on my phone. Using Chrome on my Galaxy S6.  I like the 
>> new layout, including that it draws attention to cool features at the top. A 
>> few points.
>> -Main headings on each page are inconsistent size. Landing page is small. 
>> Downloads is large. FAQ is small, etc.
>> 
> 
> Yes, I noticed that, too. The pages are two different ways - Landing and FAQ 
> use an additional toolset that the other pages don't use. I'll take a look at 
> how to make this consistent.

I think I have now fixed most of them - I know there are a couple left that are 
a different size and black (see next item). If you stumble across them please 
point them out here so I don't end up missing any.

>> -I think the heading colour would look better as "Subsurface blue", rather 
>> than black.
>> 
> 
> Good point

This should be fixed for most, see previous point.
>> -On the landing page is it better to elaborate on the features in case the 
>> reader doesn't wait to scroll through them at the top? Cloud storage, 
>> platforms and the planner aren't mentioned except in the bit that flashes 
>> through at the top.
>> 
> 
> I tried both ways and it felt really redundant. So I'm not sure what to do 
> here. I'll ask a friend of mine who has helped me with rewording this page 
> (and as working on writing a better announcement). She tends to know what 
> works with audiences :-)
> 

What do people here think. I just added a German translation for the landing 
page and did that slightly differently - I'm not sure it's better, though.

>> On Oct 10, 2015, at 11:22 PM, Salvador Cuñat > > wrote:
>> 
>> Good morning.
>> 
>> 2015-10-11 8:01 GMT+02:00 Dirk Hohndel > >:
>> After about 20 hours of editing and copying and modifying I have a mockup of 
>> the new website ready.
>> 
>> Please go to http://ssrftest.subsurface-divelog.org 
>>  and let me know what you think.
>> 
>> 
>> It looks rather bizarre in my browser  };-)
> 
> 
> Yes, I kinda mentioned that but should have said it more strongly...
> a) the site automatically follows the language settings of your browser - so 
> if you usually browse the web in Spanish (or German) it will show you that 
> translation (which hopefully means less need for the language switching)
> b) while I spent a ton of time migrating a good chunk of the translations, 
> the landing page and the dive ramblings page and most of the posts are broken 
> with respect to translations
> But many other pages should do the right thing, e.g. the FAQ or the Downloads 
> page (except that I believe I have some changed to the non-existend 4.5 and 
> some are the old text). Which reminds me, I noticed that the translations are 
> WAY out of sync for some of the pages. As everything else we do, this is all 
> a matter of the right people having enough time. Where the "right people" way 
> to often ends up being "me".

So I think with the exception of the landing page and many of the older news 
items all the translations should now be cleaned up.
I'll send a separate email about web site translations in a moment.

>> On Oct 10, 2015, at 11:34 PM, Steve > > wrote:
>>  
>> Looks good on my laptop.
>> I would change the different languages bar to the top rather than at the 
>> bottom which you need to scroll down before you see it from the homepage.
> 
> 
> Well, it's at the bottom on purpose because as I mentioned above, most people 
> should never need it and having it on the top means it steals important 
> vertical space when you first open the page. So I think I'll leave it on the 
> bottom.

I left it at the bottom but moved it up above the footer with the social media 
icons. It now gets correctly resized / wrapped if the window is too narrow.

>> On Oct 11, 2015, at 1:02 AM, Gaetan Bisson > > wrote:
>> 
>> The only thing I noted is that we have two redundant social media
>> banners (one in "top-header" and the other in "footer-bottom"); perhaps
>> the top one could be removed so page contents get bumped up?
> 
> 
> Oh, good catch - I thought I had disabled the 

crash on planning a dive with LANG=fi

2015-10-11 Thread Miika Turkia
I seem to be getting a crash when trying to open dive planner with the
latest daily build for Ubuntu (that is actually a week old), or the
beta3. This occurs when the Subsurface language is set to Finnish.

My self built binary works just fine, so a bit hard to debug without
debugging symbols. As far as I know, the everything works fine in
English...

...
#6  0x715355a6 in ___vsnprintf_chk (s=0x7fffc4f0
"VAROITUS: TÄMÄ ON UUSI TOTEUTUS ", maxlen=, flags=1,
slen=,
format=0x158e478 "VAROITUS: TÄMÄ ON UUSI TOTEUTUS %S ALGORITMISTA
JA SUKELLUSTEN SUUNNITTELUOMINAISUUDESTA. TESTAUS EI OLE OLLUT
RIITTÄVÄN KATTAVAA, JOTEN SUOSITAMME, ETTÄ ETTE SUKELLA VAIN NÄIDEN
TULOSTEN PERUST"..., args=args@entry=0x7fffc348) at
vsnprintf_chk.c:63
#7  0x71535508 in ___snprintf_chk (s=,
maxlen=, flags=, slen=,
format=) at snprintf_chk.c:34
#8  0x006701b5 in ?? ()
#9  0x00674197 in plan ()
#10 0x00614e71 in DivePlannerPointsModel::createTemporaryPlan() ()
#11 0x005f1f36 in ProfileWidget2::plotDive(dive*, bool) ()
#12 0x005f3589 in ProfileWidget2::pointInserted(QModelIndex
const&, int, int) ()
#13 0x723289c9 in QMetaObject::activate(QObject*, int, int,
void**) () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
...

miika
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: crash on planning a dive with LANG=fi

2015-10-11 Thread Miika Turkia
On Sun, Oct 11, 2015 at 8:41 PM, Dirk Hohndel  wrote:
> On Sun, Oct 11, 2015 at 08:11:17PM +0300, Miika Turkia wrote:
>> I seem to be getting a crash when trying to open dive planner with the
>> latest daily build for Ubuntu (that is actually a week old), or the
>> beta3. This occurs when the Subsurface language is set to Finnish.
>>
>> My self built binary works just fine, so a bit hard to debug without
>> debugging symbols. As far as I know, the everything works fine in
>> English...
>>
>> ...
>> #6  0x715355a6 in ___vsnprintf_chk (s=0x7fffc4f0
>> "VAROITUS: TÄMÄ ON UUSI TOTEUTUS ", maxlen=, flags=1,
>> slen=,
>> format=0x158e478 "VAROITUS: TÄMÄ ON UUSI TOTEUTUS %S ALGORITMISTA
>
> I notice the %S vs. %s - the man page doesn't mention upper case '%S', just
> lower case '%s'
>
> That seems to be an error in the Hebrew, Finnish and Portuguese
> translations. I don't know if that is what causes the crash (after all,
> you have the error in your self compiled binary)... but I'll fix that in
> the translations and cut a new set of dailies...

Well, this is already fixed for Finnish in Transifex...but let's see
what the new build does.

miika
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Custom print template

2015-10-11 Thread Sergey Starosek
Hi all,

Previously there was an option ('Custom' item in the templates drop-down
list)
to create new print template. Now it has disappeared and the only way is to
export an existing one under different name, then import and edit it.

What's the right way of doing that?

Sergey

P.S. Current master bfaf57e1
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: [PATCH] android.cpp: update path retriaval scheme

2015-10-11 Thread Joakim Bygdell

> On 11 Oct 2015, at 19:42, Lubomir I. Ivanov  wrote:
> 
> On 11 October 2015 at 20:36, Joakim Bygdell  > wrote:
>> 
>>> On 11 Oct 2015, at 18:55, Lubomir I. Ivanov  wrote:
>>> 
>>> From: "Lubomir I. Ivanov" 
>>> 
>>> Android was skipped as a OS target when the recent path retriaval
>>> modifications in .c were made.
>>> 
>>> Signed-off-by: Lubomir I. Ivanov 
>>> ---
>>> code tested without the QAndoroid* API calls in an external test
>>> project. not tested for the actual OS on runtime or as a compile
>>> target!
>> 
>> It builds ok but then it fails to write any files when syncing from colud.
>> 
> 
> sorry, i cannot test it on runtime. someone needs to figure out what's
> happening.

It fails during cloning, the hash folder is created but nothing is put in it.
Also if I manually tell it to load dives from cloud it craches. 

> 
> lubomir
> --

/Jocke

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: crash on planning a dive with LANG=fi

2015-10-11 Thread Sergey Starosek
Dirk,

On Sun, Oct 11, 2015 at 9:14 PM, Dirk Hohndel  wrote:

> On Sun, Oct 11, 2015 at 09:10:40PM +0300, Sergey Starosek wrote:
>
> Thanks for testing. I fixed this in the Portuguese translation (and the
> two instances in the rather incomplete Hebrew translation). The new daily
> binaries are compiling... if you could update this in few minutes and
> retest that would be very welcome.
>
> Planner with PT and FI locales works for me. Can't test hebrew since SSRF
does not offer it in the locales list.

Sergey
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: user manual: text for reverese lookup

2015-10-11 Thread Dirk Hohndel
I'm adding the mailing list to this conversation in hopes that others can play 
with this as well
so we can figure out if this is a bigger problem...

> On Oct 11, 2015, at 11:44 AM, Willem Ferguson 
>  wrote:
> 
> On 11/10/2015 20:22, Dirk Hohndel wrote:
>> 
>> I have not managed to get reverse lookup working yet, but I am continuing
>> with experiments to get it working.
>> Let me know if I can help you in any way.
>> 
>> This ONLY works with dive sites that have GPS data. Which reminds me that
>> I still need to disable the button for sites that don't have GPS data...
>> 
>> 
> What do you mean with "GPS data"? ONLY from the Subsurface companion and not 
> for coordinates provided by hand?

When you are on the dive site management page in Subsurface, there need to be 
GPS coordinates.
It does not matter where they come from, whether they are from the web service 
/ companion app,
manually entered or entered via the Marble map makes no difference. But you 
need to have GPS
coordinates for a dive site in order for reverse lookup to work.

> The way I currently do this is as follows:
> Create a manually-added dive.
> Do not specify locality name.
> save other Notes panel dive data with Accept changes
> Edit dive site panel
> Provide coordinates
> Hit globe button to do reverse lookup (presumably giving site name in dive 
> site name text box).

The name doesn't play into this at all. It's just the GPS coordinates.
I assume the site is shown correctly on the map?
What happens if you first accept the changes (so that the coordinates are 
stored), then go back to the dive site panel and hit the button?

It is possible that for some odd reason the web service doesn't accept requests 
from South Africa. Unlikely, but possible.

> I use  coordinates I obtain from geonames.org, so it should be able to find 
> the place name.

Well, if you can use geonames.org from a browser than the reverse lookup should 
work, too.
I'm really puzzled what's going wrong there. More things we need to debug :-)

/D

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: [PATCH 1/1] Use ~/.subsurface as default directory on Linux

2015-10-11 Thread Dirk Hohndel
On Sun, Oct 11, 2015 at 12:04:11PM +0300, Lubomir I. Ivanov wrote:
> On 11 October 2015 at 11:28, Lubomir I. Ivanov  wrote:
> > On 11 October 2015 at 08:36, Gaetan Bisson  wrote:
> >> Hi guys,
> >>
> >> I only just noticed that cloud storage now uses (and automatically
> >> creates) the ~/subsurface directory. Perhaps I missed some discussion
> >> about it, but I would much prefer a name that starts with a dot. Does
> >> the attached patch makes sense to you?
> >>
> >
> > ACK.
> >
> 
> the dot is the way to go,
> 
> i find it odd that ~/subsurface (no dot) was the suggested path for
> the user default XML, since version 2.0 (or something) and nobody
> complained
> i think this indicates that nobody was using the default XML path on Linux.

I'm not sure that's true - we did a few odd things that people seemed to
just accept. But now is the time to fix it :-)

I'll take Gaetan's patch and that fixes this issue.

Once again (as I've been saying alot in the last two weeks), thanks for
catching this Gaetan, thanks for following up everyone else. This is the
thing I am most happy about - the amount of things that we find an fix in
this beta cycle is exciting.

I'm really hopeful that 4.5 will turn out to be a really strong release.

A few more days for the documentation, translations and of course the web
site to settle and then I'll cut the release.

Please keep testing, please keep finding and fixing bugs.

/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: [PATCH] android.cpp: update path retriaval scheme

2015-10-11 Thread Joakim Bygdell

> On 11 Oct 2015, at 18:55, Lubomir I. Ivanov  wrote:
> 
> From: "Lubomir I. Ivanov" 
> 
> Android was skipped as a OS target when the recent path retriaval
> modifications in .c were made.
> 
> Signed-off-by: Lubomir I. Ivanov 
> ---
> code tested without the QAndoroid* API calls in an external test
> project. not tested for the actual OS on runtime or as a compile
> target!

It builds ok but then it fails to write any files when syncing from colud.

> ---
> android.cpp | 27 +++
> 1 file changed, 23 insertions(+), 4 deletions(-)
> 
> diff --git a/android.cpp b/android.cpp
> index c4bd191..3e14bec 100644
> --- a/android.cpp
> +++ b/android.cpp
> @@ -42,19 +42,38 @@ bool subsurface_ignore_font(const char *font)
> void subsurface_user_info(struct user_info *user)
> { /* Encourage use of at least libgit2-0.20 */ }
> 
> -const char *system_default_filename(void)
> +static const char *system_default_path_append(const char *append)
> {
>   /* Replace this when QtCore/QStandardPaths getExternalStorageDirectory 
> landed */
>   QAndroidJniObject externalStorage = 
> QAndroidJniObject::callStaticObjectMethod("android/os/Environment", 
> "getExternalStorageDirectory", "()Ljava/io/File;");
>   QAndroidJniObject externalStorageAbsolute = 
> externalStorage.callObjectMethod("getAbsolutePath", "()Ljava/lang/String;");
> - QString system_default_filename = externalStorageAbsolute.toString() + 
> "/subsurface.xml";
> + QString path = externalStorageAbsolute.toString();
>   QAndroidJniEnvironment env;
>   if (env->ExceptionCheck()) {
>   // FIXME: Handle exception here.
>   env->ExceptionClear();
> - return strdup("/sdcard/subsurface.xml");
> + path = QString("/sdcard");
>   }
> - return strdup(system_default_filename.toUtf8().data());
> + if (append)
> + path += QString("/%1").arg(append);
> + return strdup(path.toUtf8().data());
> +}
> +
> +const char *system_default_directory(void)
> +{
> + static const char *path = NULL;
> + if (!path)
> + path = system_default_path_append(NULL);
> + return path;
> +}
> +
> +const char *system_default_filename(void)
> +{
> + static const char *filename = "subsurface.xml";
> + static const char *path = NULL;
> + if (!path)
> + path = system_default_path_append(filename);
> + return path;
> }
> 
> int enumerate_devices(device_callback_t callback, void *userdata, int dc_type)
> -- 
> 1.7.11.msysgit.0
> 
> ___
> subsurface mailing list
> subsurface@subsurface-divelog.org
> http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

/Jocke

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: Custom print template

2015-10-11 Thread Sergey Starosek
Lubomir, 11.10.2015, 20:55, "Lubomir I. Ivanov" :we decided to remove the editing logic behind the custom.html template.exporting then importing is a valid way of adding a new template. youcan also go to the folder and create files manually.Thanks for the explanation. Will wait for Willem's update to user manual and will update translation then. Sergey
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: crash on planning a dive with LANG=fi

2015-10-11 Thread Dirk Hohndel
On Sun, Oct 11, 2015 at 09:10:40PM +0300, Sergey Starosek wrote:
> Dirk,
>  
> 11.10.2015, 20:58, "Dirk Hohndel" :
> 
> 
>  
> 
> Interesting - this seems to be fixed already in the Finnish translation.
> Could you do me a favor and try the Portuguese translation - same "%S" in
> the string. If that crashes, too, then I guess we have a better idea
> what's happening.
> 
> Crashes here with Portuguese (Portual):

Thanks for testing. I fixed this in the Portuguese translation (and the
two instances in the rather incomplete Hebrew translation). The new daily
binaries are compiling... if you could update this in few minutes and
retest that would be very welcome.

At this second as I'm writing this the Ubuntu builds are still running on
Canonical's build farm.

/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: crash on planning a dive with LANG=fi

2015-10-11 Thread Miika Turkia
On Sun, Oct 11, 2015 at 9:24 PM, Sergey Starosek
 wrote:
> Dirk,
>
> On Sun, Oct 11, 2015 at 9:14 PM, Dirk Hohndel  wrote:
>>
>> On Sun, Oct 11, 2015 at 09:10:40PM +0300, Sergey Starosek wrote:
>>
>> Thanks for testing. I fixed this in the Portuguese translation (and the
>> two instances in the rather incomplete Hebrew translation). The new daily
>> binaries are compiling... if you could update this in few minutes and
>> retest that would be very welcome.
>>
> Planner with PT and FI locales works for me. Can't test hebrew since SSRF
> does not offer it in the locales list.

Same here on Ubuntu 15.04 (vivid) 64bit.

miika
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: Hebrew translation of Subsurface [was Re: crash on planning a dive with LANG=fi]

2015-10-11 Thread Benjamin
I can try, but it won't be this week. It's my not-often-practiced 3rd
language, so I can't offer any miracles :S

Benjamin

On 11 October 2015 at 21:28, Dirk Hohndel  wrote:

> On Sun, Oct 11, 2015 at 09:24:27PM +0300, Sergey Starosek wrote:
> > Dirk,
> >
> > On Sun, Oct 11, 2015 at 9:14 PM, Dirk Hohndel  wrote:
> >
> > > On Sun, Oct 11, 2015 at 09:10:40PM +0300, Sergey Starosek wrote:
> > >
> > > Thanks for testing. I fixed this in the Portuguese translation (and the
> > > two instances in the rather incomplete Hebrew translation). The new
> daily
> > > binaries are compiling... if you could update this in few minutes and
> > > retest that would be very welcome.
> > >
> > > Planner with PT and FI locales works for me. Can't test hebrew since
> SSRF
> > does not offer it in the locales list.
>
> Oh, right. I removed that since it fell to such a low tranlation ratio...
>
> I changed the subject to see if we have any Hebrew speakers left on this
> list who would like to get that translation back into decent shape...
>
> Anyone?
>
> Thanks
>
> /D
> ___
> subsurface mailing list
> subsurface@subsurface-divelog.org
> http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
>
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: [PATCH 1/1] Use ~/.subsurface as default directory on Linux

2015-10-11 Thread Gaetan Bisson
[2015-10-12 00:20:14 +0300] Lubomir I. Ivanov:
> i would say -1 for $XDG_DATA_HOME as that doesn't seem to be
> established very well, yet.
> but $HOME/.local/share/subsurface is less intrusive than ~/.subsurface
> IMHO, so +1 to that.

As far as I understand the XDG specs:
- the cloud storage cache should go under ~/.cache/Subsurface/
- the configuration file should go under ~/.config/Subsurface/
- some other things should go under ~/.local/share/Subsurface/

To me, that really scatters user data over many directories for
little-to-no benefit. Instead, I'd like an app called Subsurface to
simply write its user data under ~/.subsurface/: that's a unique
directory for me to symlink, backup, or rename, for instance in case
there's an issue I want to debug with a fresh profile.

But that's just my two cents.

-- 
Gaetan
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: [PATCH 1/1] Use ~/.subsurface as default directory on Linux

2015-10-11 Thread Dirk Hohndel

> On Oct 11, 2015, at 3:35 PM, Gaetan Bisson  wrote:
> 
> [2015-10-12 00:20:14 +0300] Lubomir I. Ivanov:
>> i would say -1 for $XDG_DATA_HOME as that doesn't seem to be
>> established very well, yet.
>> but $HOME/.local/share/subsurface is less intrusive than ~/.subsurface
>> IMHO, so +1 to that.
> 
> As far as I understand the XDG specs:
> - the cloud storage cache should go under ~/.cache/Subsurface/
> - the configuration file should go under ~/.config/Subsurface/
> - some other things should go under ~/.local/share/Subsurface/
> 
> To me, that really scatters user data over many directories for
> little-to-no benefit. Instead, I'd like an app called Subsurface to
> simply write its user data under ~/.subsurface/: that's a unique
> directory for me to symlink, backup, or rename, for instance in case
> there's an issue I want to debug with a fresh profile.
> 
> But that's just my two cents.

I'll add my +2 cents as well. I think this makes more sense.

/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: new website - or "jet lag is good"

2015-10-11 Thread Robert C. Helling
Hi,

> On 11 Oct 2015, at 15:40, Dirk Hohndel  wrote:
> 
>  The reality is that a lot of people consume the web on iPads and not on 
> desktops and that changes some of the underlying ideas of what you can show 
> and how you should show it. Less visual clutter is the main goal here...

I just asked my wife (who has an advertising background) to have a look at the 
new page.

Her main comment was that she would want some more visual information on „is 
this for me“ on the landing page. The widget with the four slides is nice but 
does not convey a lot of information and the text below she says she would not 
look at at a first go. She suggested to add a few more screen shots where the 
first time visitor gets an idea on what it’s all about. Show a look at the log 
and profile, show a photo of a dive computer (or several for that matter) 
connected to a laptop about to download, maybe show the planner. She wants a 
visual impression before having to download and install something, or click to 
the manual and scroll down for several pages. The video tutorial would also be 
good, if it were about the latest version and did not start with how to install 
or build it from the command line („that says very loud: Not for me“ she says). 
Just something that invites the person that happens to come across that page 
(due to a link or recommendation).

Best
Robert


signature.asc
Description: Message signed with OpenPGP using GPGMail
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: Dive planner oddities

2015-10-11 Thread Rick Walsh
Hi Sergey,

Thanks for testing the planner.  The more people that try it and the more
feedback the better.

On 12 Oct 2015 6:35 am, "Sergey Starosek"  wrote:
>
> HI Robert,
>
> Away from keyboard, answering from mobile.
>
> On Oct 11, 2015 22:18, "Robert C. Helling"  wrote:
> >
> > Sergey,
> >
> > thanks for testing this. Unfortunately I think I need some more
explanation of your findigs.
> >
> > What exactly do you mean by „not aligned“? Do you refer to the fact
that the handle is not at the end of the 15m segment? That is on purpose,
this is what „recreational mode“ is about: The second handle is the last
manually entered waypoint and in recreational mode the planner stays at
that depth for the maximum time that does not get you in conflict with gas
usage and deco obligations.
>
> Thanks for the explanation,  user manual needs to clarify on this,  I
think. Will do more testing on this tomorrow.
>

Maybe we should also add a tooltip on recreational mode saying something
like, "maximize bottom time without deco".

> >> Note a peak on a SAC graph
> >
> > Maybe I am stupid but I cannot see it on your screen shots. Actually, I
don’t see the pO2 graph at all. When I run subsurface, I can see the graph
but no peak. Could you indicate on the screen shot where I am supposed to
look?
>
> I was talking about  cylinder pressure graph (SAC is irrelevant here,
just color of the line). Look for the spike just around ascent beginning.
>

The cylinder pressure graph should start to flatten when starting ascent.
Assuming a constant SAC, gas consumption varies with depth.  Is that what
you're referring to?

Cheers,

Rick
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re:

2015-10-11 Thread Robert C. Helling
Willem,

> On 08 Oct 2015, at 18:47, Willem Ferguson  
> wrote:
> 
> 
> It looks to me like the section on recreational diving is more or less ok? Am 
> I missing something?

sorry for replying so late. All what you write is correct but (also as Sergey’s 
comments in a different threat show) maybe it would be good if very early in 
the paragraph you say what the recreational mode is about (before getting into 
details why to use it or which settings you have to adjust). Namely, in my 
words (that could most likely be improved language wise):

"Recreational mode is what comes closest to planning a dive based on the 
non-decompression limit (NDL). It computes the maximal time a diver can stay at 
the current depth without incurring any mandatory decompression stops and 
without using more than the existing gas (minus a reserve).“

What do you think?

Best
Robert


signature.asc
Description: Message signed with OpenPGP using GPGMail
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: Dive Site Problem: nearby sites

2015-10-11 Thread Tomaz Canabrava
Maybe I didn't update the model after adding a divesite, will check that.
Em 11 de out de 2015 15:56, "Dirk Hohndel"  escreveu:

>
> > On Oct 11, 2015, at 4:14 AM, Willem Ferguson <
> willemfergu...@zoology.up.ac.za> wrote:
> >
> > I want to make some changes to the user manual pertaining to the
> management of coordinates. So I create an hypothetical dive as follows:
> >
> > Create a new dive:  Log -> Add dive
> > Specify a location that I have dived on several occasions. (In my case
> Aliwal Shoal: Cathedral)
> > Image 'Divesite1.png', attached, appears.
> > Now I am assuming that I am diving a different part of the Cathedral,
> NOT represented by any existing coordinates. So I doubleclick the
> highlighted option in Divesite1.png.
> > I hit the button "Apply changes". Now the dive information has been
> saved.
> > Then I hit the globe button to the right of the Location text box. I
> want to provide the coordinates.
> > Image Divesite2.png, attached appears.
> > But in the bottom list box there are no other locations of Aliwal Shoal:
> Cathedral
> >
> > I would have expected all my previous dive locations at the Cathedral to
> be listed here.
> >
> > Typing the coordinates of the new dive site at this stage does not make
> a difference. Neither using the existing coordinates for Cathedral, nor by
> changing the coordinates very slightly to refer to a site not exactly
> similar to any of the existing dives at Cathedral.
> >
> > Am I misunderstanding the UI?
>
> I would have assumed the existing site to show up there.
>
> Tomaz, can you comment?
>
> /D
>
>
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: Dive planner oddities

2015-10-11 Thread Sergey Starosek
HI Robert,

Away from keyboard, answering from mobile.

On Oct 11, 2015 22:18, "Robert C. Helling"  wrote:
>
> Sergey,
>
> thanks for testing this. Unfortunately I think I need some more
explanation of your findigs.
>
> What exactly do you mean by „not aligned“? Do you refer to the fact that
the handle is not at the end of the 15m segment? That is on purpose, this
is what „recreational mode“ is about: The second handle is the last
manually entered waypoint and in recreational mode the planner stays at
that depth for the maximum time that does not get you in conflict with gas
usage and deco obligations.

Thanks for the explanation,  user manual needs to clarify on this,  I
think. Will do more testing on this tomorrow.

>> Note a peak on a SAC graph
>
> Maybe I am stupid but I cannot see it on your screen shots. Actually, I
don’t see the pO2 graph at all. When I run subsurface, I can see the graph
but no peak. Could you indicate on the screen shot where I am supposed to
look?

I was talking about  cylinder pressure graph (SAC is irrelevant here, just
color of the line). Look for the spike just around ascent beginning.

Sergey
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Preferences storage and recovery

2015-10-11 Thread Willem Ferguson
The last two builds loses the preferences on my Ubuntu box. Every time I 
start up Subsurface, the default values are back. Most obvious is that 
it does not remember the dive log file name. Does anyone else have that 
issue?

Kind regards,
willem

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: crash on planning a dive with LANG=fi

2015-10-11 Thread Thiago Macieira
On Sunday 11 October 2015 10:41:12 Dirk Hohndel wrote:
> I notice the %S vs. %s - the man page doesn't mention upper case '%S', just
> lower case '%s'

The info page does:

`%S'
 This is an alias for `%ls' which is supported for compatibility
 with the Unix standard.

And later:

`l'
 Specifies that the argument is a `long int' or `unsigned long
 int', as appropriate.  Two `l' characters is like the `L'
 modifier, below.

 If used with `%c' or `%s' the corresponding parameter is
 considered as a wide character or wide character string
 respectively.  This use of `l' was introduced in Amendment 1 to
 ISO C90.


So %S is looking for a null-terminated string of wchar_t. Since the input 
string isn't wchar_t, it crashes on wcslen().
-- 
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
   Software Architect - Intel Open Source Technology Center
  PGP/GPG: 0x6EF45358; fingerprint:
  E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: [PATCH 1/1] Use ~/.subsurface as default directory on Linux

2015-10-11 Thread Lubomir I. Ivanov
On 11 October 2015 at 08:36, Gaetan Bisson  wrote:
> Hi guys,
>
> I only just noticed that cloud storage now uses (and automatically
> creates) the ~/subsurface directory. Perhaps I missed some discussion
> about it, but I would much prefer a name that starts with a dot. Does
> the attached patch makes sense to you?
>

https://github.com/torvalds/subsurface/commit/f1b4fb21db82f99da24738cae8a4acb4b323765c#commitcomment-13706965
probonopd commented on f1b4fb2 26 minutes ago
"Wouldn't $XDG_DATA_HOME/subsurface which usually points to
$HOME/.local/share/subsurface be more suitable?
https://developer.gnome.org/basedir-spec/;

i would say -1 for $XDG_DATA_HOME as that doesn't seem to be
established very well, yet.
but $HOME/.local/share/subsurface is less intrusive than ~/.subsurface
IMHO, so +1 to that.

opinions?

lubomir
--
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


minor [PATCHES] for freediving

2015-10-11 Thread Giorgio Marzano
Hi,

I know that this is something which won't be merged before the next
release, but I would like to propose those patches for a (low priority)
review. They are all easy, cosmetic and  freedive specific (no impact on
scuba)


0001-Change-plot-scaling-to-handle-FREEDIVE-mode hacks the autoscaling
function to produce better result for the usually very short freedives


0001-Display-day-number-in-trips-longer-than-1-day is the old patch to add
some info in the trip header. I only rebased it to the last master


0001-Display-divetime-according-to-dive-mode-and-translat changes, for
freedive mode, the time strings in the info and statistics tab. For us
seconds may be very relevant.


0001-Enable-Disable-toolbar-element-in-freedive-mode disable some toolbar
element for freedive mode. I found very disturbing those buttons which are,
for me, of no use.  I would like, in the future, to understand how ppO2 and
similar are different in scuba and freediving. It would be important to
represent them in a correct way, to profile the risk of "taravana"
(something like the decompression disease but for freedivers)



G
From 6c91115e393c6dfa7743072c0f5e868ad260e09e Mon Sep 17 00:00:00 2001
From: Giorgio Marzano 
Date: Tue, 6 Oct 2015 21:08:27 +0200
Subject: [PATCH] Display day number in trips longer than 1 day

Signed-off-by: Giorgio Marzano 
---
 helpers.h   |  3 ++-
 qt-models/divetripmodel.cpp |  6 --
 qthelper.cpp| 37 +
 3 files changed, 35 insertions(+), 11 deletions(-)

diff --git a/helpers.h b/helpers.h
index 6c5c31c..760d962 100644
--- a/helpers.h
+++ b/helpers.h
@@ -33,7 +33,8 @@ int parseTemperatureToMkelvin(const QString );
 QString get_dive_duration_string(timestamp_t when, QString hourText, QString minutesText);
 QString get_dive_date_string(timestamp_t when);
 QString get_short_dive_date_string(timestamp_t when);
-QString get_trip_date_string(timestamp_t when, int nr);
+bool is_same_day (timestamp_t trip_when, timestamp_t dive_when);
+QString get_trip_date_string(timestamp_t when, int nr, bool getday);
 QString uiLanguage(QLocale *callerLoc);
 QLocale getLocale();
 QString getDateFormat();
diff --git a/qt-models/divetripmodel.cpp b/qt-models/divetripmodel.cpp
index 819bb54..78a7a74 100644
--- a/qt-models/divetripmodel.cpp
+++ b/qt-models/divetripmodel.cpp
@@ -43,6 +43,7 @@ static QVariant dive_table_alignment(int column)
 QVariant TripItem::data(int column, int role) const
 {
 	QVariant ret;
+	bool oneDayTrip=true;
 
 	if (role == DiveTripModel::TRIP_ROLE)
 		return QVariant::fromValue(trip);
@@ -59,14 +60,15 @@ QVariant TripItem::data(int column, int role) const
 			while (d) {
 if (!d->hidden_by_filter)
 	countShown++;
+oneDayTrip &= is_same_day (trip->when,  d->when);
 d = d->next;
 			}
 			if (countShown < trip->nrdives)
 shownText = tr("(%1 shown)").arg(countShown);
 			if (trip->location && *trip->location)
-ret = QString(trip->location) + ", " + get_trip_date_string(trip->when, trip->nrdives) + " " + shownText;
+ret = QString(trip->location) + ", " + get_trip_date_string(trip->when, trip->nrdives, oneDayTrip) + " "+ shownText;
 			else
-ret = get_trip_date_string(trip->when, trip->nrdives) + shownText;
+ret = get_trip_date_string(trip->when, trip->nrdives, oneDayTrip) + shownText;
 			break;
 		}
 	}
diff --git a/qthelper.cpp b/qthelper.cpp
index a963ad7..dd5f974 100644
--- a/qthelper.cpp
+++ b/qthelper.cpp
@@ -1011,20 +1011,41 @@ const char *get_dive_date_c_string(timestamp_t when)
 	return strdup(text.toUtf8().data());
 }
 
-QString get_trip_date_string(timestamp_t when, int nr)
+bool is_same_day(timestamp_t trip_when, timestamp_t dive_when)
+{
+	static timestamp_t twhen = (timestamp_t) 0;
+	static struct tm tmt;
+	struct tm tmd;
+
+	utc_mkdate(dive_when, );
+
+	if (twhen != trip_when) {
+		twhen = trip_when;
+		utc_mkdate(twhen, );
+	}
+
+	return ((tmd.tm_mday == tmt.tm_mday) && (tmd.tm_mon == tmt.tm_mon) && (tmd.tm_year == tmt.tm_year));
+}
+
+QString get_trip_date_string(timestamp_t when, int nr, bool getday)
 {
 	struct tm tm;
 	utc_mkdate(when, );
+	QDateTime localTime = QDateTime::fromTime_t(when);
+	localTime.setTimeSpec(Qt::UTC);
+	QString ret ;
+
 	if (nr != 1) {
-		QString ret =  translate("gettextFromC", "%1 %2 (%3 dives)");
-		return ret.arg(monthname(tm.tm_mon))
-			.arg(tm.tm_year + 1900)
-			.arg(nr);
+		if (getday) {
+			ret = localTime.date().toString(dateFormat).append(" (%1 dives)").arg(nr);
+		} else {
+			ret = localTime.date().toString("MMM yy").append(" (%1 dives)").arg(nr);
+		}
 	} else {
-		QString ret = translate("gettextFromC", "%1 %2 (1 dive)");
-		return ret.arg(monthname(tm.tm_mon))
-			.arg(tm.tm_year + 1900);
+		ret = localTime.date().toString(dateFormat).append(" (1 dive)");
 	}
+	return ret;
+
 }
 
 extern "C" void reverseGeoLookup(degrees_t latitude, degrees_t longitude, uint32_t uuid)
-- 
1.9.1

From 

Button text not translated

2015-10-11 Thread Rick Walsh
Hi,

Testing the windows daily binary (4.4.98-75) on Windows 10, it appears that
a number of buttons haven't been translated.  I tested this in Swedish,
Danish and German (fun in a language you can't speak).  Examples include:
- Dive plan: Save and Cancel buttons are in English
- Close without saving: Save, Discard and Cancel are in English
- Preferences: OK, Discard, and Apply are in English

Sorry, I'm not sure where these strings are marked in the code, and I don't
have time at the moment to work it out.

Cheers,

Rick
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


[PATCH] Planner: add recreational mode tooltip

2015-10-11 Thread Rick Walsh
Recreational mode isn't self-explanatory.  Add a hint for the user.

Signed-off-by: Rick Walsh 
---

I'm not sure we want to introduce a new string for 4.5. Maybe save for later.

 qt-ui/plannerSettings.ui | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/qt-ui/plannerSettings.ui b/qt-ui/plannerSettings.ui
index 2319220..4db69f8 100644
--- a/qt-ui/plannerSettings.ui
+++ b/qt-ui/plannerSettings.ui
@@ -392,6 +392,9 @@
   
   

+
+ Maximize bottom time allowed by gas and no decompression 
limits
+
 
  Recreational mode
 
-- 
2.4.3

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: Button text not translated

2015-10-11 Thread Rick Walsh
On 12 October 2015 at 10:47, Rick Walsh  wrote:

> Hi,
>
> Testing the windows daily binary (4.4.98-75) on Windows 10, it appears
> that a number of buttons haven't been translated.  I tested this in
> Swedish, Danish and German (fun in a language you can't speak).  Examples
> include:
> - Dive plan: Save and Cancel buttons are in English
> - Close without saving: Save, Discard and Cancel are in English
> - Preferences: OK, Discard, and Apply are in English
>
> Sorry, I'm not sure where these strings are marked in the code, and I
> don't have time at the moment to work it out.
>

I'm pretty sure these are standard QDialogButtonBox buttons, and
translations should be handled by qt5.  How to do this is beyond me.

FWIW, I just tried on Fedora 22, using the latest master (c9c9673), and the
problem is the same.  I do have qm files, including qt_sv.qm, qt_de.qm and
qtbase_de.qm, in /usr/share/qt5/translations.


> Cheers,
>
> Rick
>
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: Button text not translated

2015-10-11 Thread Dirk Hohndel

> On Oct 11, 2015, at 7:08 PM, Rick Walsh  wrote:
> 
> 
> 
> On 12 October 2015 at 10:47, Rick Walsh  > wrote:
> Hi,
> 
> Testing the windows daily binary (4.4.98-75) on Windows 10, it appears that a 
> number of buttons haven't been translated.  I tested this in Swedish, Danish 
> and German (fun in a language you can't speak).  Examples include:
> - Dive plan: Save and Cancel buttons are in English
> - Close without saving: Save, Discard and Cancel are in English
> - Preferences: OK, Discard, and Apply are in English
> 
> Sorry, I'm not sure where these strings are marked in the code, and I don't 
> have time at the moment to work it out.
> 
> I'm pretty sure these are standard QDialogButtonBox buttons, and translations 
> should be handled by qt5.  How to do this is beyond me.
> 
> FWIW, I just tried on Fedora 22, using the latest master (c9c9673), and the 
> problem is the same.  I do have qm files, including qt_sv.qm, qt_de.qm and 
> qtbase_de.qm, in /usr/share/qt5/translations.

Those texts should indeed come from the Qt translations. And if you have the qt 
and qtbase .qm files, I'm not quite sure where to take this. Hmm.

Thiago, any ideas?

/D

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: Button text not translated

2015-10-11 Thread Rick Walsh
On 12 October 2015 at 13:59, Dirk Hohndel  wrote:

>
> On Oct 11, 2015, at 7:08 PM, Rick Walsh  wrote:
>
>
>
> On 12 October 2015 at 10:47, Rick Walsh  wrote:
>
>> Hi,
>>
>> Testing the windows daily binary (4.4.98-75) on Windows 10, it appears
>> that a number of buttons haven't been translated.  I tested this in
>> Swedish, Danish and German (fun in a language you can't speak).  Examples
>> include:
>> - Dive plan: Save and Cancel buttons are in English
>> - Close without saving: Save, Discard and Cancel are in English
>> - Preferences: OK, Discard, and Apply are in English
>>
>> Sorry, I'm not sure where these strings are marked in the code, and I
>> don't have time at the moment to work it out.
>>
>
> I'm pretty sure these are standard QDialogButtonBox buttons, and
> translations should be handled by qt5.  How to do this is beyond me.
>
> FWIW, I just tried on Fedora 22, using the latest master (c9c9673), and
> the problem is the same.  I do have qm files, including qt_sv.qm, qt_de.qm
> and qtbase_de.qm, in /usr/share/qt5/translations.
>
>
> Those texts should indeed come from the Qt translations. And if you have
> the qt and qtbase .qm files, I'm not quite sure where to take this. Hmm.
>

I have qt_[some languages].qm and qtbase_[fewer languages].qm (from the
qt5-qttranslatations Fedora package).  I'm not sure if that's significant.
German at least has both; Swedish (sv) and Danish (da) have qt_??.qm, but
not qtbase_??.qm.

ls -1 /usr/share/qt5/translations/qt_??.qm
/usr/share/qt5/translations/qtbase_??.qm
/usr/share/qt5/translations/qt_ar.qm
/usr/share/qt5/translations/qtbase_ca.qm
/usr/share/qt5/translations/qtbase_cs.qm
/usr/share/qt5/translations/qtbase_de.qm
/usr/share/qt5/translations/qtbase_fi.qm
/usr/share/qt5/translations/qtbase_fr.qm
/usr/share/qt5/translations/qtbase_hu.qm
/usr/share/qt5/translations/qtbase_it.qm
/usr/share/qt5/translations/qtbase_ja.qm
/usr/share/qt5/translations/qtbase_ko.qm
/usr/share/qt5/translations/qtbase_lv.qm
/usr/share/qt5/translations/qtbase_ru.qm
/usr/share/qt5/translations/qtbase_sk.qm
/usr/share/qt5/translations/qtbase_uk.qm
/usr/share/qt5/translations/qt_ca.qm
/usr/share/qt5/translations/qt_cs.qm
/usr/share/qt5/translations/qt_da.qm
/usr/share/qt5/translations/qt_de.qm
/usr/share/qt5/translations/qt_es.qm
/usr/share/qt5/translations/qt_fa.qm
/usr/share/qt5/translations/qt_fi.qm
/usr/share/qt5/translations/qt_fr.qm
/usr/share/qt5/translations/qt_gl.qm
/usr/share/qt5/translations/qt_he.qm
/usr/share/qt5/translations/qt_hu.qm
/usr/share/qt5/translations/qt_it.qm
/usr/share/qt5/translations/qt_ja.qm
/usr/share/qt5/translations/qt_ko.qm
/usr/share/qt5/translations/qt_lt.qm
/usr/share/qt5/translations/qt_pl.qm
/usr/share/qt5/translations/qt_pt.qm
/usr/share/qt5/translations/qt_ru.qm
/usr/share/qt5/translations/qt_sk.qm
/usr/share/qt5/translations/qt_sl.qm
/usr/share/qt5/translations/qt_sv.qm
/usr/share/qt5/translations/qt_uk.qm

On Windows I'm using your installer package, so I assume it depends on the
translations in your build system.


> Thiago, any ideas?
>
> /D
>
>
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface