Re: QML inconsistency Android <-> Desktop

2016-05-16 Thread Dirk Hohndel
On Mon, May 16, 2016 at 09:24:33PM +0200, Joakim Bygdell wrote: > > Can you send a follow up patch that addresses that? > Sure. Thanks > > And thank you for your contribution. I know this was a massive pain to get > > working and really appreciate that you stuck with it and figured it out. > Can

Re: QML inconsistency Android <-> Desktop

2016-05-16 Thread Joakim Bygdell
> On 16 May 2016, at 21:21, Dirk Hohndel wrote: > > On Mon, May 16, 2016 at 09:12:13PM +0200, Joakim Bygdell wrote: >> >>> On 16 May 2016, at 20:39, Dirk Hohndel wrote: >>> >>> On Mon, May 16, 2016 at 11:17:22AM -0700, Dirk Hohndel wrote: On Sat, May

Re: QML inconsistency Android <-> Desktop

2016-05-16 Thread Dirk Hohndel
On Mon, May 16, 2016 at 09:12:13PM +0200, Joakim Bygdell wrote: > > > On 16 May 2016, at 20:39, Dirk Hohndel wrote: > > > > On Mon, May 16, 2016 at 11:17:22AM -0700, Dirk Hohndel wrote: > >> On Sat, May 07, 2016 at 02:33:50PM +0200, Joakim Bygdell wrote: > >>> When running

Re: QML inconsistency Android <-> Desktop

2016-05-16 Thread Joakim Bygdell
> On 16 May 2016, at 20:39, Dirk Hohndel wrote: > > On Mon, May 16, 2016 at 11:17:22AM -0700, Dirk Hohndel wrote: >> On Sat, May 07, 2016 at 02:33:50PM +0200, Joakim Bygdell wrote: >>> When running Subsurface-mobile on my laptop >>> I have a fully functional combobox that

Re: QML inconsistency Android <-> Desktop

2016-05-16 Thread Dirk Hohndel
On Mon, May 16, 2016 at 11:17:22AM -0700, Dirk Hohndel wrote: > On Sat, May 07, 2016 at 02:33:50PM +0200, Joakim Bygdell wrote: > > When running Subsurface-mobile on my laptop > > I have a fully functional combobox that autocompletes text input > > based on what exists in the list model. > > > >

Re: QML inconsistency Android <-> Desktop

2016-05-16 Thread Dirk Hohndel
On Sat, May 07, 2016 at 02:33:50PM +0200, Joakim Bygdell wrote: > When running Subsurface-mobile on my laptop > I have a fully functional combobox that autocompletes text input > based on what exists in the list model. > > However when I run the same build on android > the autocompletion only

[PATCH 1/3] Add functions to DiveObjectsHelper

2016-05-16 Thread Joakim Bygdell
This generated the QStringLists needed to populate the combobxes in DiveDetailsEdit. Signed-off-by: Joakim Bygdell --- core/subsurface-qt/DiveObjectHelper.cpp | 51 + core/subsurface-qt/DiveObjectHelper.h | 6 2 files changed, 57

[PATCH 2/3] QML UI: add comboboxes to DiveDetailsEdit

2016-05-16 Thread Joakim Bygdell
This adds autocompleting text input fields for suit, buddy and divemaster. Signed-off-by: Joakim Bygdell --- core/subsurface-qt/DiveObjectHelper.cpp | 18 mobile-widgets/qml/DiveDetails.qml | 12 +-- mobile-widgets/qml/DiveDetailsEdit.qml | 37

[PATCH 3/3] QML UI: hide handles for comboboxes

2016-05-16 Thread Joakim Bygdell
Hide the handles for the comboboxes, making the text input fields look like the normal text fields. This is left as a separate patch as there currently seems to be issues with autocomplete on Android. Signed-off-by: Joakim Bygdell --- mobile-widgets/qml/DiveDetailsEdit.qml