Re: [PATCH 2/2] Fix plurals translation

2015-10-30 Thread Sergey Starosek
Jan, Dirk, On Fri, Oct 30, 2015 at 12:18 AM, Jan Mulder wrote: > > with (after applying Sergey's patch 2/2) results exactly in the desired > behaviour: 1 dive, 2 dives. > > The only thing I do not like is that Transiflex warns about different > number of parenthesis between

Re: [PATCH 2/2] Fix plurals translation

2015-10-30 Thread Sergey Starosek
Dirk, On Thu, Oct 29, 2015 at 10:33 PM, Dirk Hohndel wrote: > > The .ts file for those looks like this: > > > > , %n dive(s) here) > > > > > > > > (%n dive(s)) > > >

Re: [PATCH 2/2] Fix plurals translation

2015-10-30 Thread Sergey Starosek
Dirk, On Fri, Oct 30, 2015 at 5:25 PM, Dirk Hohndel wrote: > > I can see following for en_GB locale: > > > > > > > > , %n dive(s) here) > > > > > > > > > > > > > > > > > > For ru_RU locale there're three

Re: [PATCH 2/2] Fix plurals translation

2015-10-30 Thread Dirk Hohndel
On Thu, Oct 29, 2015 at 10:18:14PM +0100, Jan Mulder wrote: > On 29-10-15 20:33, Dirk Hohndel wrote: > >On Thu, Oct 29, 2015 at 12:17:05PM -0700, Dirk Hohndel wrote: > > > > > > > > (%n dive(s)) > > > > > > > > > > > >and clearly transifex

Re: [PATCH 2/2] Fix plurals translation

2015-10-30 Thread Dirk Hohndel
On Fri, Oct 30, 2015 at 01:16:40PM +0300, Sergey Starosek wrote: > Dirk, > > On Thu, Oct 29, 2015 at 10:33 PM, Dirk Hohndel wrote: > > > > > The .ts file for those looks like this: > > > > > > > > , %n dive(s) here) > > > > > >

Re: [PATCH 2/2] Fix plurals translation

2015-10-29 Thread Dirk Hohndel
So we had a bunch of problems with the plural forms and just dropped them for 4.5 Are these resolved? /D On Thu, Oct 29, 2015 at 11:24:47AM +0300, sergey.staro...@gmail.com wrote: > From: Sergey Starosek > > This allows separate translation of singular and plural

Re: [PATCH 2/2] Fix plurals translation

2015-10-29 Thread Sergey Starosek
Dirk, On Thu, Oct 29, 2015 at 6:34 PM, Dirk Hohndel wrote: > So we had a bunch of problems with the plural forms and just dropped them > for 4.5 > > Are these resolved? > I've spotted only two using 'git grep'. Likely this needs more thorough search. And/or a kind of

Re: [PATCH 2/2] Fix plurals translation

2015-10-29 Thread Dirk Hohndel
On Thu, Oct 29, 2015 at 09:59:06PM +0300, Sergey Starosek wrote: > On Thu, Oct 29, 2015 at 9:25 PM, Dirk Hohndel wrote: > > > > > So we had a bunch of problems with the plural forms and just dropped > > them > > > > for 4.5 > > > > > > > > Are these resolved? > > > > > > > > >

Re: [PATCH 2/2] Fix plurals translation

2015-10-29 Thread Sergey Starosek
On Thu, Oct 29, 2015 at 9:25 PM, Dirk Hohndel wrote: > > > So we had a bunch of problems with the plural forms and just dropped > them > > > for 4.5 > > > > > > Are these resolved? > > > > > > > I've spotted only two using 'git grep'. Likely this needs more thorough > > search.

Re: [PATCH 2/2] Fix plurals translation

2015-10-29 Thread Dirk Hohndel
On Thu, Oct 29, 2015 at 09:14:49PM +0300, Sergey Starosek wrote: > Dirk, > > On Thu, Oct 29, 2015 at 6:34 PM, Dirk Hohndel wrote: > > > So we had a bunch of problems with the plural forms and just dropped them > > for 4.5 > > > > Are these resolved? > > > > I've spotted only

Re: [PATCH 2/2] Fix plurals translation

2015-10-29 Thread Dirk Hohndel
On Thu, Oct 29, 2015 at 12:17:05PM -0700, Dirk Hohndel wrote: > On Thu, Oct 29, 2015 at 09:59:06PM +0300, Sergey Starosek wrote: > > On Thu, Oct 29, 2015 at 9:25 PM, Dirk Hohndel wrote: > > > > > > > So we had a bunch of problems with the plural forms and just dropped > > >

Re: [PATCH 2/2] Fix plurals translation

2015-10-29 Thread Jan Mulder
On 29-10-15 20:33, Dirk Hohndel wrote: On Thu, Oct 29, 2015 at 12:17:05PM -0700, Dirk Hohndel wrote: (%n dive(s)) and clearly transifex does not like this. Some googling seems to imply that transifex is aware of the bug and

[PATCH 2/2] Fix plurals translation

2015-10-29 Thread sergey . starosek
From: Sergey Starosek This allows separate translation of singular and plural forms Signed-off-by: Sergey Starosek --- qt-ui/modeldelegates.cpp | 2 +- qthelper.cpp | 11 --- 2 files changed, 5 insertions(+), 8