Re: [PR] MapWidget enhancements

2017-08-08 Thread Linus Torvalds
On Tue, Aug 8, 2017 at 2:45 PM, Lubomir I. Ivanov wrote: > > updated the PR with a second patch to fix this: > https://github.com/Subsurface-divelog/subsurface/pull/536 > > it was caused by missing those dive sites which are skipped for being > too close to each other when

Re: [PR] MapWidget enhancements

2017-08-08 Thread Lubomir I. Ivanov
On 8 August 2017 at 22:53, Linus Torvalds wrote: > On Sun, Aug 6, 2017 at 5:32 PM, Lubomir I. Ivanov wrote: >> >> this PR implements the requested functionality to be able to: >> >> select a trip or any list of dives and the Map widget should

Re: [PR] MapWidget enhancements

2017-08-08 Thread Lubomir I. Ivanov
On 8 August 2017 at 22:53, Linus Torvalds wrote: > On Sun, Aug 6, 2017 at 5:32 PM, Lubomir I. Ivanov wrote: >> >> this PR implements the requested functionality to be able to: >> >> select a trip or any list of dives and the Map widget should

Re: [PR] MapWidget enhancements

2017-08-08 Thread Linus Torvalds
On Sun, Aug 6, 2017 at 5:32 PM, Lubomir I. Ivanov wrote: > > this PR implements the requested functionality to be able to: > > select a trip or any list of dives and the Map widget should estimate > a center coordinate and a zoom level so that the list of selected > dives

Re: [PR] MapWidget enhancements

2017-08-07 Thread Lubomir I. Ivanov
added a new PR. i think i found QDeclarativeMap (QML Map) bugs, so i try to work around those. - The QML Map has a couple of methods - toCoordinate(someQPointF) and fromCoordinate(someQGeoCoordinate). Ideally, if one passes a point to toCoordinate() and then attempts

[PR] MapWidget enhancements

2017-08-06 Thread Lubomir I. Ivanov
https://github.com/Subsurface-divelog/subsurface/pull/531 this PR implements the requested functionality to be able to: select a trip or any list of dives and the Map widget should estimate a center coordinate and a zoom level so that the list of selected dives