Re: [Patch] String translation issues

2015-09-05 Thread Salvador Cuñat
2015-09-05 17:16 GMT+02:00 Salvador Cuñat : > > And looks like you applied the patch before the coffee. > > Do you want me to rework it ? > > Hmmm, you reworked it. So it was after the cofee. Thanks Dirk. Regards. Salva. ___ subsurface mailing list s

Re: [Patch] String translation issues

2015-09-05 Thread Salvador Cuñat
2015-09-05 16:06 GMT+02:00 Dirk Hohndel : > > >>> > > >>hey salva, > > >>yes, ON/OFF should be added for translation as tr("ON"), tr("OFF"). > > >I wonder if it wouldn't be better to have > > > > > >ui->dialogStatus->setText(tr("The local Bluetooth device was %1.") > > > .arg(on ? "turned ON"

Re: [Patch] String translation issues

2015-09-05 Thread Dirk Hohndel
On Sat, Sep 05, 2015 at 03:55:59PM +0200, Guillaume Gardet wrote: > Le 05/09/2015 15:53, Dirk Hohndel a écrit : > >On Sat, Sep 05, 2015 at 12:25:57PM +0300, Lubomir I. Ivanov wrote: > >>On 5 September 2015 at 12:08, Salvador Cuñat > >>wrote: > >>>Good morning. > >>> > >>>There is a string in qt-u

Re: [Patch] String translation issues

2015-09-05 Thread Guillaume Gardet
Le 05/09/2015 15:53, Dirk Hohndel a écrit : On Sat, Sep 05, 2015 at 12:25:57PM +0300, Lubomir I. Ivanov wrote: On 5 September 2015 at 12:08, Salvador Cuñat wrote: Good morning. There is a string in qt-ui/btdeviceselectiondialog.cpp which doesn't have a good translation: ui->dialogSt

Re: [Patch] String translation issues

2015-09-05 Thread Dirk Hohndel
On Sat, Sep 05, 2015 at 12:25:57PM +0300, Lubomir I. Ivanov wrote: > On 5 September 2015 at 12:08, Salvador Cuñat wrote: > > Good morning. > > > > There is a string in qt-ui/btdeviceselectiondialog.cpp which doesn't have a > > good translation: > > > > > >ui->dialogStatus->setText(tr("The

Re: [Patch] String translation issues

2015-09-05 Thread Lubomir I. Ivanov
On 5 September 2015 at 12:08, Salvador Cuñat wrote: > Good morning. > > There is a string in qt-ui/btdeviceselectiondialog.cpp which doesn't have a > good translation: > > >ui->dialogStatus->setText(tr("The local Bluetooth device was turned > %1.") > .arg(o

[Patch] String translation issues

2015-09-05 Thread Salvador Cuñat
Good morning. There is a string in qt-ui/btdeviceselectiondialog.cpp which doesn't have a good translation: ui->dialogStatus->setText(tr("The local Bluetooth device was turned %1.") .arg(on? "ON" : "OFF")); as "turn on" translates to a word and "turn off"