Re: Missing pO2 samples from CCR download [was: 4.7.8: a couple of questions]

2018-06-23 Thread Anton Lundin
On 23 June, 2018 - Davide DB wrote: > Anton, > > I don't see any compelling reason to express your antipathy toward me. There's no antipathy, just answers to questions and statements. //Anton -- Anton Lundin+46702-161604 ___ subsurface

Re: Missing pO2 samples from CCR download [was: 4.7.8: a couple of questions]

2018-06-23 Thread Davide DB
Anton, I don't see any compelling reason to express your antipathy toward me. Take care davide@mobile ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Missing pO2 samples from CCR download [was: 4.7.8: a couple of questions]

2018-06-21 Thread Anton Lundin
On 21 June, 2018 - Dirk Hohndel wrote: > Hi Davide, > > We just merged the patches from Anton, a new test build should show up in > https://github.com/Subsurface-divelog/subsurface/releases/tag/continuous > > soon. >

Re: Missing pO2 samples from CCR download [was: 4.7.8: a couple of questions]

2018-06-20 Thread Dirk Hohndel
Hi Davide, We just merged the patches from Anton, a new test build should show up in https://github.com/Subsurface-divelog/subsurface/releases/tag/continuous soon. This link always gets you the latest test installer - and

Re: Missing pO2 samples from CCR download [was: 4.7.8: a couple of questions]

2018-06-20 Thread Linus Torvalds
On Thu, Jun 21, 2018 at 4:20 AM Dirk Hohndel wrote: > > Thanks, Anton. This looks reasonable. Assuming Linus sees no issue we can add > this today and if Davide is still interested he can test the new binaries. I've taken them. I pulled Jef's fix for the Uwatec Aladin Tec too.

Re: Missing pO2 samples from CCR download [was: 4.7.8: a couple of questions]

2018-06-20 Thread Martin Long
I'll test them either way once a binary is available. This problem has affected me too. On Wed, 20 Jun 2018, 20:20 Dirk Hohndel, wrote: > Thanks, Anton. This looks reasonable. Assuming Linus sees no issue we can > add this today and if Davide is still interested he can test the new > binaries.

Re: Missing pO2 samples from CCR download [was: 4.7.8: a couple of questions]

2018-06-20 Thread Dirk Hohndel
Thanks, Anton. This looks reasonable. Assuming Linus sees no issue we can add this today and if Davide is still interested he can test the new binaries. /D > On Jun 21, 2018, at 4:06 AM, Anton Lundin wrote: > > Of course I forgot to even compile it, so here's a updated 0002 patch > which

Re: Missing pO2 samples from CCR download [was: 4.7.8: a couple of questions]

2018-06-20 Thread Anton Lundin
Of course I forgot to even compile it, so here's a updated 0002 patch which actually compiles. //Anton On 20 June, 2018 - Anton Lundin wrote: > Here's the patches. > > I splitted them into two, so Jef can cherry-pick the first one, and a > second one which adds a strings that says the source

Re: Missing pO2 samples from CCR download [was: 4.7.8: a couple of questions]

2018-06-20 Thread Anton Lundin
Here's the patches. I splitted them into two, so Jef can cherry-pick the first one, and a second one which adds a strings that says the source of the PPO2 values. //Anton On 18 June, 2018 - Dirk Hohndel wrote: > As I said before, I can't seem to find that patch. No idea why. If someone >

Re: Missing pO2 samples from CCR download [was: 4.7.8: a couple of questions]

2018-06-20 Thread Long, Martin
I can't seem to get my Android build environment working at the moment. If anyone is able to give me an apk with these patches, I'll happily test them. Thanks Martin On 17 June 2018 at 23:05, Aaron Scheiner wrote: > In the attached screenshot the green line is the voted PO2 from the DC (I >

Re: Missing pO2 samples from CCR download [was: 4.7.8: a couple of questions]

2018-06-19 Thread Davide DB
Hi Dirk, I'm sure that this problem will solved. It's clear that is anyway a Shearwater problem or an undocumented feature. The interim solution proposed by Anton is already a good step forward. BTW you will not find a patch: Anton just posted a "diff". You will find everything here:

Re: Missing pO2 samples from CCR download [was: 4.7.8: a couple of questions]

2018-06-19 Thread Long, Martin
The problem is it wasn't really a patch, it was just a diff posted in this thread, but Jef then said he wasn't happy with it. I guess that Aaron's stuff above superceeds this now. On 17 June 2018 at 23:26, Dirk Hohndel wrote: > As I said before, I can't seem to find that patch. No idea why. If

Re: Missing pO2 samples from CCR download [was: 4.7.8: a couple of questions]

2018-06-19 Thread Dirk Hohndel
As I said before, I can't seem to find that patch. No idea why. If someone sends it to me I'll be happy to add it. I said that before as well. If hate to see Davide abandon Subsurface over this... /D On June 18, 2018 5:39:43 AM GMT+09:00, "Long, Martin" wrote: >Dirk, > >I would say that

Re: Missing pO2 samples from CCR download [was: 4.7.8: a couple of questions]

2018-06-19 Thread Aaron Scheiner
In the attached screenshot the green line is the voted PO2 from the DC (I changed the colours because... messing around. They're not colour blindness friendly). On my JJ the reported PO2 from the dive computer (Petrel 2) is slightly lower than the uncalibrated sensor values. I've tested

Re: Missing pO2 samples from CCR download [was: 4.7.8: a couple of questions]

2018-06-19 Thread Long, Martin
Dirk, I would say that Anton's patch would do it as an interim solution. Jef isn't keen, as he has a better solution, but doesn't have the time to work on it yet. However, it does remove the regression, and prevent further loss of data in imports, until the *ideal* solution can be added. Data is

Re: Missing pO2 samples from CCR download [was: 4.7.8: a couple of questions]

2018-06-19 Thread Aaron Scheiner
I'm in the same boat and last week I started working on adding an additional field to both subsurface and libdivecomputer (I called it voted PO2). I managed to get the import and display of it working before I got interrupted by other stuff. It has subsequently occurred to me that this may not be

Re: Missing pO2 samples from CCR download [was: 4.7.8: a couple of questions]

2018-06-17 Thread Dirk Hohndel
> On Jun 17, 2018, at 6:52 PM, Davide DB wrote: > > On Thu, Jun 14, 2018, 15:34 Long, Martin > wrote: > I'm in agreement with Davide that any interim solution we can get running is > better than the way it is working now. It's a regression, and tbh if there >

Re: Missing pO2 samples from CCR download [was: 4.7.8: a couple of questions]

2018-06-17 Thread Davide DB
On Thu, Jun 14, 2018, 15:34 Long, Martin wrote: > I'm in agreement with Davide that any interim solution we can get running > is better than the way it is working now. It's a regression, and tbh if > there isn't an interim solution then it ought to be reverted to the old > behaviour. At the

Re: Missing pO2 samples from CCR download [was: 4.7.8: a couple of questions]

2018-06-14 Thread Long, Martin
I'm in agreement with Davide that any interim solution we can get running is better than the way it is working now. It's a regression, and tbh if there isn't an interim solution then it ought to be reverted to the old behaviour. At the moment I'm having to use Shearwater desktop for reviewing all

Re: Missing pO2 samples from CCR download [was: 4.7.8: a couple of questions]

2018-06-11 Thread Anton Lundin
On 11 June, 2018 - Jef Driesen wrote: > On 11-06-18 20:21, Anton Lundin wrote: > >On 04 June, 2018 - Dirk Hohndel wrote: > > > >>I don't have an outstanding patch from you, so not sure what you are > >>referring to. > > > >There was a diff a while back in this thread, in >

Re: Missing pO2 samples from CCR download [was: 4.7.8: a couple of questions]

2018-06-11 Thread Davide DB
On Mon, 11 Jun 2018 at 20:21, Anton Lundin wrote: > > On 04 June, 2018 - Dirk Hohndel wrote: > > > I don't have an outstanding patch from you, so not sure what you are > > referring to. > > There was a diff a while back in this thread, in > 20180523144751.gc12...@hirohito.acc.umu.se , which made

Re: Missing pO2 samples from CCR download [was: 4.7.8: a couple of questions]

2018-06-11 Thread Jef Driesen
On 11-06-18 20:21, Anton Lundin wrote: On 04 June, 2018 - Dirk Hohndel wrote: I don't have an outstanding patch from you, so not sure what you are referring to. There was a diff a while back in this thread, in 20180523144751.gc12...@hirohito.acc.umu.se , which made the code fall back to the

Re: Missing pO2 samples from CCR download [was: 4.7.8: a couple of questions]

2018-06-11 Thread Anton Lundin
On 04 June, 2018 - Dirk Hohndel wrote: > I don't have an outstanding patch from you, so not sure what you are > referring to. There was a diff a while back in this thread, in 20180523144751.gc12...@hirohito.acc.umu.se , which made the code fall back to the voted/averaged ppo2 instead of

Re: Missing pO2 samples from CCR download [was: 4.7.8: a couple of questions]

2018-06-04 Thread Dirk Hohndel
I don't have an outstanding patch from you, so not sure what you are referring to. /D > On Jun 4, 2018, at 6:46 AM, Anton Lundin wrote: > > If Dirk/Linus feels for it, hey can grab the diff and make up a commit > message and it will be in the next dev build. > > I can't really do it because

Re: Missing pO2 samples from CCR download [was: 4.7.8: a couple of questions]

2018-06-04 Thread Anton Lundin
If Dirk/Linus feels for it, hey can grab the diff and make up a commit message and it will be in the next dev build. I can't really do it because I'm on a diving trip in the baltic, in a storm, making good head way on tonights target of getting hammered. //Anton - skepp åhoj! On June 4, 2018

Re: Missing pO2 samples from CCR download [was: 4.7.8: a couple of questions]

2018-06-03 Thread Martin Long
Davide, I can confirm I also had this problem, and now I've got 6 months of dives with missing data. The fallback solution looks ideal to me. I hope we're able to get a build with these changes soon. Martin On Fri, 25 May 2018, 18:33 Anton Lundin, wrote: > On 25 May, 2018 - Jef Driesen wrote:

Re: Missing pO2 samples from CCR download [was: 4.7.8: a couple of questions]

2018-05-25 Thread Anton Lundin
On 25 May, 2018 - Jef Driesen wrote: > On 25-05-18 16:35, Willem Ferguson wrote: > >On 25/05/2018 15:55, Jef Driesen wrote: > >>The main disadvantage is that you'll no longer know which type of ppO2 > >>(sensor or voted/average) you are getting. Especially if you only have > >>one sensor. > > >

Re: Missing pO2 samples from CCR download [was: 4.7.8: a couple of questions]

2018-05-25 Thread Jef Driesen
On 25-05-18 16:35, Willem Ferguson wrote: On 25/05/2018 15:55, Jef Driesen wrote: The main disadvantage is that you'll no longer know which type of ppO2 (sensor or voted/average) you are getting. Especially if you only have one sensor. I would agree, but at least one gets the calculated pO2

Re: Missing pO2 samples from CCR download [was: 4.7.8: a couple of questions]

2018-05-25 Thread Davide DB
On Fri, 25 May 2018 at 16:36, Willem Ferguson < willemfergu...@zoology.up.ac.za> wrote: > I do not quite get the argument about one sensor? For one sensor there > is no averaging or voting?? I'm not seeing something, so please spell it > out? Me too. I used to have a pSCR with one sensor and a

Re: Missing pO2 samples from CCR download [was: 4.7.8: a couple of questions]

2018-05-25 Thread Willem Ferguson
On 25/05/2018 15:55, Jef Driesen wrote: On 2018-05-23 16:47, Anton Lundin wrote: On 23 May, 2018 - Anton Lundin wrote: The simple solution is to just emit the average/voted ppO2 when we can't find the calibration values. Its a graceful degradation of functionality, and way better than not

Re: Missing pO2 samples from CCR download [was: 4.7.8: a couple of questions]

2018-05-25 Thread Jef Driesen
On 2018-05-23 16:47, Anton Lundin wrote: On 23 May, 2018 - Anton Lundin wrote: The simple solution is to just emit the average/voted ppO2 when we can't find the calibration values. Its a graceful degradation of functionality, and way better than not showing any ppO2 at all. It should be

Re: Missing pO2 samples from CCR download [was: 4.7.8: a couple of questions]

2018-05-24 Thread Davide DB
For the records, I updated the original Github issue with the new problema and latest findings https://github.com/Subsurface-divelog/subsurface/issues/971 Bye -- Davide https://vimeo.com/bocio/videos ___ subsurface mailing list

Re: Missing pO2 samples from CCR download [was: 4.7.8: a couple of questions]

2018-05-24 Thread Davide DB
On Wed, 23 May 2018 at 19:24, Aaron Scheiner wrote: > I just tried re-downloading logs from my Petrel 2 using both the current beta Android app and the current Windows application available for download (4.7.8) and neither downloaded the PO2 samples. > So I'm experiencing

Re: Missing pO2 samples from CCR download [was: 4.7.8: a couple of questions]

2018-05-23 Thread Aaron Scheiner
I just tried re-downloading logs from my Petrel 2 using both the current beta Android app and the current Windows application available for download (4.7.8) and neither downloaded the PO2 samples. So I'm experiencing the same bug :D . Aaron The libdivecomputer log file

Re: Missing pO2 samples from CCR download [was: 4.7.8: a couple of questions]

2018-05-23 Thread Davide DB
Cool, thanks! On Wed, 23 May 2018 at 16:58, Aaron Scheiner wrote: > Yes, all three sensor values are rendered and they tend towards the set point, which is also rendered. They show on both the desktop and Android apps (for me). > I'll be home soon, I'll try downloading them

Re: Missing pO2 samples from CCR download [was: 4.7.8: a couple of questions]

2018-05-23 Thread Aaron Scheiner
Yes, all three sensor values are rendered and they tend towards the set point, which is also rendered. They show on both the desktop and Android apps (for me). I'll be home soon, I'll try downloading them into a clean profile with the absolute latest software and see what happens. On Wed, May

Re: Missing pO2 samples from CCR download [was: 4.7.8: a couple of questions]

2018-05-23 Thread Davide DB
On Wed, 23 May 2018 at 16:37, Aaron Scheiner wrote: > I have a JJ CCR (2017 CE model) with a Petrel 2 DiveCAN computer attached. > I do all my downloads using the Android app (I'm on the beta channel) and I mostly view the data on Linux. I never use the Shearwater desktop

Re: Missing pO2 samples from CCR download [was: 4.7.8: a couple of questions]

2018-05-23 Thread Davide DB
On Wed, 23 May 2018 at 16:22, Jef Driesen wrote: > On 2018-05-23 14:58, Davide DB wrote: > > On Wed, May 23, 2018, 12:08 Willem Ferguson > > > > wrote: > >> If this is the case, then the problem should in principle be solvable > >> and

Re: Missing pO2 samples from CCR download [was: 4.7.8: a couple of questions]

2018-05-23 Thread Anton Lundin
On 23 May, 2018 - Anton Lundin wrote: > On 23 May, 2018 - Jef Driesen wrote: > > > On 2018-05-23 14:58, Davide DB wrote: > > >On Wed, May 23, 2018, 12:08 Willem Ferguson > > > > > >wrote: > > >>If this is the case, then the problem should in principle be solvable

Re: Missing pO2 samples from CCR download [was: 4.7.8: a couple of questions]

2018-05-23 Thread Anton Lundin
On 23 May, 2018 - Jef Driesen wrote: > On 2018-05-23 14:58, Davide DB wrote: > >On Wed, May 23, 2018, 12:08 Willem Ferguson > > > >wrote: > >>If this is the case, then the problem should in principle be solvable > >>and it possibly means that the coding in the

Re: Missing pO2 samples from CCR download [was: 4.7.8: a couple of questions]

2018-05-23 Thread Aaron Scheiner
I have a JJ CCR (2017 CE model) with a Petrel 2 DiveCAN computer attached. I do all my downloads using the Android app (I'm on the beta channel) and I mostly view the data on Linux. I never use the Shearwater desktop application. I haven't noticed any discrepancies in the data so far. I'm hoping

Re: Missing pO2 samples from CCR download [was: 4.7.8: a couple of questions]

2018-05-23 Thread Jef Driesen
On 2018-05-23 14:58, Davide DB wrote: On Wed, May 23, 2018, 12:08 Willem Ferguson wrote: If this is the case, then the problem should in principle be solvable and it possibly means that the coding in the dive log is slightly different from that of the standard

Re: Missing pO2 samples from CCR download [was: 4.7.8: a couple of questions]

2018-05-23 Thread Davide DB
On Wed, May 23, 2018, 12:08 Willem Ferguson wrote: Hi Willem, Thank you for the kind reply. I will try to explain me again > Davide, > > Does the correct pO2 show on the Shearwater download software (i.e. the > Shearwater Desktop)?. This means that the data

Re: Missing pO2 samples from CCR download [was: 4.7.8: a couple of questions]

2018-05-23 Thread Willem Ferguson
Davide, I forgot to mention that my understanding is that the Petrel provides a voltage, not a pO2 value and that this voltage is converted to a pO2 value in the Shearwater Desktop or in Subsurface. You possibly may have to find the calibration value(s) as well as the voltages in order to

Re: Missing pO2 samples from CCR download [was: 4.7.8: a couple of questions]

2018-05-23 Thread Willem Ferguson
On 23/05/2018 11:01, Davide DB wrote: Hi guys, Is there any chance that one day it will be possible to see O2 sample on a CCR dive? -- Davide Davide, Does the correct pO2 show on the Shearwater download software (i.e. the Shearwater Desktop)?. This means that the data are correctly

Re: Missing pO2 samples from CCR download [was: 4.7.8: a couple of questions]

2018-05-23 Thread Davide DB
Hi guys, Is there any chance that one day it will be possible to see O2 sample on a CCR dive? On Thu, 10 May 2018 at 22:48, Davide DB wrote: > On Thu, 3 May 2018 at 21:39, Davide DB wrote: > > On Thu, 3 May 2018 at 18:52, Anton Lundin

Re: Missing pO2 samples from CCR download [was: 4.7.8: a couple of questions]

2018-05-03 Thread Davide DB
On Thu, 3 May 2018 at 18:52, Anton Lundin wrote: > On 03 May, 2018 - Davide DB wrote: > > > On Thu, 3 May 2018 at 13:15, Anton Lundin wrote: > > > > > On 03 May, 2018 - Davide DB wrote: > > > > > > > On Wed, 2 May 2018 at 11:04, Anton Lundin

Re: Missing pO2 samples from CCR download [was: 4.7.8: a couple of questions]

2018-05-03 Thread Anton Lundin
On 03 May, 2018 - Davide DB wrote: > On Thu, 3 May 2018 at 13:15, Anton Lundin wrote: > > > On 03 May, 2018 - Davide DB wrote: > > > > > On Wed, 2 May 2018 at 11:04, Anton Lundin wrote: > > > > > > > > > > > Try to download them into a fresh logbook with

Re: 4.7.8: a couple of questions

2018-05-03 Thread Anton Lundin
On 03 May, 2018 - Davide DB wrote: > On Wed, 2 May 2018 at 11:04, Anton Lundin wrote: > > > > > Try to download them into a fresh logbook with the current desktop > > version, to see what's happens then. > > > > I've just downloaded my dives on a fresh Win10 4.7.8

Re: 4.7.8: a couple of questions

2018-05-02 Thread Davide DB
On Wed, 2 May 2018 at 13:19, Anton Lundin wrote: > On 02 May, 2018 - Davide DB wrote: > > > On Wed, 2 May 2018 at 11:04, Anton Lundin wrote: > > > > > > > What's happening when you're trying to merge them? > > > > > > > > > > > > > The second dive (#175)

Re: 4.7.8: a couple of questions

2018-05-02 Thread Anton Lundin
On 02 May, 2018 - Davide DB wrote: > On Wed, 2 May 2018 at 11:04, Anton Lundin wrote: > > > > > What's happening when you're trying to merge them? > > > > > > > > > > The second dive (#175) disappear but the first dive remain unaffected (47 > > > minutes). > > > > Can you

Re: 4.7.8: a couple of questions

2018-05-02 Thread Davide DB
On Wed, 2 May 2018 at 11:04, Anton Lundin wrote: > > Try to download them into a fresh logbook with the current desktop > version, to see what's happens then. > I will do tonight > > > - I merged some dives made during a ccr training. I cannot merge two of > > > > them.

Re: 4.7.8: a couple of questions

2018-05-02 Thread Anton Lundin
On 02 May, 2018 - Davide DB wrote: > On Wed, 2 May 2018 at 10:31, Anton Lundin wrote: > > > On 30 April, 2018 - Davide DB wrote: > > > > > Hi all, > > > > > > I was playing with 4.7.8 on Windows 7 and I noted a couple of things: > > > > > > - I cannot see anymore pO2 sensor

Re: 4.7.8: a couple of questions

2018-05-02 Thread Davide DB
On Wed, 2 May 2018 at 10:31, Anton Lundin wrote: > On 30 April, 2018 - Davide DB wrote: > > > Hi all, > > > > I was playing with 4.7.8 on Windows 7 and I noted a couple of things: > > > > - I cannot see anymore pO2 sensor from my Petrel controller. No average > pO2 > > nor

Re: 4.7.8: a couple of questions

2018-05-02 Thread Anton Lundin
On 30 April, 2018 - Davide DB wrote: > Hi all, > > I was playing with 4.7.8 on Windows 7 and I noted a couple of things: > > - I cannot see anymore pO2 sensor from my Petrel controller. No average pO2 > nor individual. On preference tab I have individual and setpoint option > checked nad the

Re: 4.7.8: a couple of questions

2018-05-01 Thread Davide DB
Hi all, Is it my fault or should I file a issue on Github? Thanks davide@mobile ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

4.7.8: a couple of questions

2018-04-30 Thread Davide DB
Hi all, I was playing with 4.7.8 on Windows 7 and I noted a couple of things: - I cannot see anymore pO2 sensor from my Petrel controller. No average pO2 nor individual. On preference tab I have individual and setpoint option checked nad the toolbar has O2 toggled The last time I saw them it