new Android Beta

[Dirk Hohndel]

I just pushed that out - and received the warning that we need to add 64bit 
binaries in a couple of months.
Last time I checked our 64bit binaries still had broken BLE download. Another 
thing to add to the never-ending TODO list, I guess.

/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: New Android beta - maps

[Lubomir I. Ivanov]

On 14 March 2018 at 16:45, Lubomir I. Ivanov  wrote:
> On 14 March 2018 at 16:41, Lubomir I. Ivanov  wrote:
>> On 14 March 2018 at 16:01, Willem Ferguson
>>
>>> 2) Is the pin that is automatically dropped a vital part of the exercise? It
>>> is just the centre of the previous screen. If you are not convinced, then
>>> open Google maps but leave out the pin because it distracts from what one is
>>> trying to do and the centre of the screen has no special meaning ???
>>>
>>
>> i'm not sure i understand what you mean here.
>> centering the map widget and doing one of the first 3 context menu
>> entries just works with the map widget center, which to me seems like
>> the right thing to do and is more flexible.
>>
>
> ah, i guess you mean the google maps pin which is positioned over the
> coordinates when doing "open in gmaps".
> i must admit, i have no idea how to hide it. need to do research when
> i get some free time.
>

PR:
https://github.com/Subsurface-divelog/subsurface/pull/1167

lubomir
--
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: New Android beta - maps

[Lubomir I. Ivanov]

On 14 March 2018 at 16:41, Lubomir I. Ivanov  wrote:
> On 14 March 2018 at 16:01, Willem Ferguson
>
>> 2) Is the pin that is automatically dropped a vital part of the exercise? It
>> is just the centre of the previous screen. If you are not convinced, then
>> open Google maps but leave out the pin because it distracts from what one is
>> trying to do and the centre of the screen has no special meaning ???
>>
>
> i'm not sure i understand what you mean here.
> centering the map widget and doing one of the first 3 context menu
> entries just works with the map widget center, which to me seems like
> the right thing to do and is more flexible.
>

ah, i guess you mean the google maps pin which is positioned over the
coordinates when doing "open in gmaps".
i must admit, i have no idea how to hide it. need to do research when
i get some free time.

lubomir
--
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: New Android beta - maps

[Lubomir I. Ivanov]

On 14 March 2018 at 16:01, Willem Ferguson
 wrote:
> On 14/03/2018 15:03, Lubomir I. Ivanov wrote:
>>
>>
>> using the map center instead of the selected marker is something i did
>> by design because of the following scenario:
>> - the user browses his/her dives on the map
>> - decides to propose a new dive location to friend where there is no
>> marker yet
>> - zooms over that location
>> - copies the location to clipboard
>>
>> if copying/"open in gmaps" of coordinates was only possibly based on a
>> selected marker then the above wouldn't be possible
>> also the menu items would not work at all if there were no markers on the
>> map.
>>
>> maybe the menu text has to be adjusted?
>>
>> lubomir
>> --
>>
> Lubomir, for me the map that interacts with total smoothness is just
> miraculous on the mobile platform. I accept your approach. In that case I
> would do two things.
>
> 1) In the map menu, the option "Open location in Google Maps" is misleading
> because within our context a location is a dive site. Would it make sense to
> change it to 'Change screen to Google maps" ??.
>

i would like to point out that this is the same menu and behavior as
the desktop map, which has been active for quite some time and we
didn't get negative feedback on this particular topic.
not sure i like "Change screen to Google maps", maybe we should do the
following rename for the menu entries:
"Open location in Google Maps" -> "View in Google Maps"
"Copy location to clipboard (decimal)" -> "Copy coordinates to
clipboard (decimal)"
"Copy location to clipboard (sexagesimal)" -> "Copy coordinates to
clipboard (sexagesimal)"

note the drop of "location" which seems to be the confusing part for
you in this case.

but i would like others to confirm the change. comments?

> 2) Is the pin that is automatically dropped a vital part of the exercise? It
> is just the centre of the previous screen. If you are not convinced, then
> open Google maps but leave out the pin because it distracts from what one is
> trying to do and the centre of the screen has no special meaning ???
>

i'm not sure i understand what you mean here.
centering the map widget and doing one of the first 3 context menu
entries just works with the map widget center, which to me seems like
the right thing to do and is more flexible.

> Your map is such an excellent contribution. I was impressed  when I cut my
> wifi and mobile data and the smoothness with which the map worked with no
> Internet.
>

thank you very much!

lubomir
--
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: New Android beta - maps

[Willem Ferguson]

On 14/03/2018 15:03, Lubomir I. Ivanov wrote:


using the map center instead of the selected marker is something i did
by design because of the following scenario:
- the user browses his/her dives on the map
- decides to propose a new dive location to friend where there is no marker yet
- zooms over that location
- copies the location to clipboard

if copying/"open in gmaps" of coordinates was only possibly based on a
selected marker then the above wouldn't be possible
also the menu items would not work at all if there were no markers on the map.

maybe the menu text has to be adjusted?

lubomir
--

Lubomir, for me the map that interacts with total smoothness is just 
miraculous on the mobile platform. I accept your approach. In that case 
I would do two things.


1) In the map menu, the option "Open location in Google Maps" is 
misleading because within our context a location is a dive site. Would 
it make sense to change it to 'Change screen to Google maps" ??.


2) Is the pin that is automatically dropped a vital part of the 
exercise? It is just the centre of the previous screen. If you are not 
convinced, then open Google maps but leave out the pin because it 
distracts from what one is trying to do and the centre of the screen has 
no special meaning ???


Your map is such an excellent contribution. I was impressed  when I cut 
my wifi and mobile data and the smoothness with which the map worked 
with no Internet.


Kind regards,

willem



--
This message and attachments are subject to a disclaimer.
Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf for full 
details.

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: New Android beta - maps

[Lubomir I. Ivanov]

On 14 March 2018 at 14:39, Willem Ferguson
 wrote:
> On 14/03/2018 14:19, Lubomir I. Ivanov wrote:
>>
>>
>> NOTE: the map uses the current center to copy to clipboard coordinates
>> or open the location in google maps.
>> it doesn't use the selected marker coordinates. this is by design.
>>
>> having said that, i cannot reproduce any error for dozens of dives.
>> here are my steps:
>> - open dive list
>> - select random dives with gps data
>> - open dive details
>> - edit dive to see coordinates
>> - close "edit" and click "map it"
>> - copy coordinates to clipboard
>> - try [+], [-] to zoom in/out
>>
>> do you happening to be using [+] / [-] for zooming in your tests above?
>> if not the center can be changed because of the slight pan when you
>> zoom with pinch.
>>
>> lubomir
>> --
>>
> This is the problem. I did not use the [+] and [-] buttons to zoom in or
> out. I used my fingers to pinch or expand the screen for zooming. Using the
> middle of the screen as a reference is counterintuitive and a less useful
> way than using the coordinates of the selected dive site. It is clear which
> dive site is selected and, if Google Maps is selected, I would expect the
> Google Maps to focus on the selected dive site ??
>
> If this is programmatically a problem then I would disable zooming using
> one's fingers.
>

using the map center instead of the selected marker is something i did
by design because of the following scenario:
- the user browses his/her dives on the map
- decides to propose a new dive location to friend where there is no marker yet
- zooms over that location
- copies the location to clipboard

if copying/"open in gmaps" of coordinates was only possibly based on a
selected marker then the above wouldn't be possible
also the menu items would not work at all if there were no markers on the map.

maybe the menu text has to be adjusted?

lubomir
--
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Fwd: Re: New Android beta - maps

[Willem Ferguson]

On 14/03/2018 14:19, Lubomir I. Ivanov wrote:


NOTE: the map uses the current center to copy to clipboard coordinates
or open the location in google maps.
it doesn't use the selected marker coordinates. this is by design.

having said that, i cannot reproduce any error for dozens of dives.
here are my steps:
- open dive list
- select random dives with gps data
- open dive details
- edit dive to see coordinates
- close "edit" and click "map it"
- copy coordinates to clipboard
- try [+], [-] to zoom in/out

do you happening to be using [+] / [-] for zooming in your tests above?
if not the center can be changed because of the slight pan when you
zoom with pinch.

lubomir
--



 This is the problem. I did not use the [+] and [-] buttons to zoom in or
out. I used my fingers to pinch or expand the screen for zooming. Using
the middle of the screen as a reference is counterintuitive and a less
useful way than using the coordinates of the selected dive site. It is
clear which dive site is selected and, if Google Maps is selected, I
would expect the Google Maps to focus on the selected dive site ??

If this is programmatically a problem then I would disable zooming using
one's fingers.

Kind regards,

willem




--
This message and attachments are subject to a disclaimer.
Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf for full 
details.

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: New Android beta - maps

[Willem Ferguson]

On 14/03/2018 14:19, Lubomir I. Ivanov wrote:


NOTE: the map uses the current center to copy to clipboard coordinates
or open the location in google maps.
it doesn't use the selected marker coordinates. this is by design.

having said that, i cannot reproduce any error for dozens of dives.
here are my steps:
- open dive list
- select random dives with gps data
- open dive details
- edit dive to see coordinates
- close "edit" and click "map it"
- copy coordinates to clipboard
- try [+], [-] to zoom in/out

do you happening to be using [+] / [-] for zooming in your tests above?
if not the center can be changed because of the slight pan when you
zoom with pinch.

lubomir
--

This is the problem. I did not use the [+] and [-] buttons to zoom in or 
out. I used my fingers to pinch or expand the screen for zooming. Using 
the middle of the screen as a reference is counterintuitive and a less 
useful way than using the coordinates of the selected dive site. It is 
clear which dive site is selected and, if Google Maps is selected, I 
would expect the Google Maps to focus on the selected dive site ??


If this is programmatically a problem then I would disable zooming using 
one's fingers.


Kind regards,

willem




--
This message and attachments are subject to a disclaimer.
Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf for full 
details.

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: New Android beta - maps

[Lubomir I. Ivanov]

On 14 March 2018 at 10:21, Willem Ferguson
 wrote:
> On 13/03/2018 15:03, Dirk Hohndel wrote:
>>>
>>>
> c) Copy location to clipboard (decimal) then coordinates for a
> *different* irrelevant location is copied to clipboard.
>
> d) Copy location to clipboard (sexagesimal) then a *another
> different*
> random location is copied to the clipboard.
>
 c), d) same as above. cannot confirm.
>>>
>>> Can you give an example of the location you are at, and the string that
>>> is
>>> copied to the clipboard? That might help us figure out what's wrong.
>>>
>>>
>>> /D
>>
>>
>> I did several tests.
>>
>> Ironically my first test provided absolute accurate information with no
>> error, but subsequent tests produced errors.
>>
>> Here are some of the results. See:
>>
>> https://www.dropbox.com/sh/y4iel9m7qve5phu/AAAWvA8NlqSAgMPaOMKg5KrZa?dl=0
>>
>> These data report on 4 tests:
>>
>> The reference dive site is shown on Map perspective.png, using the map
>> facility in Subsurface-mobile. The location is correct.
>>
>> These tests were done by shutting down Subsurface-mobile and restarting it
>> between tests.
>>
>> Test 1 and Test 1a.
>>
>> These were tests with the map focused close to (zoomed in on) the dive
>> site when using the map menu. The location in Google maps is out. The Pin is
>> the one dropped by Subsurface-mobile, the small red icon is the dive site.
>> The error is maybe around 10 km.
>>
>> Test 2
>>
>> Zoomed out further in the Subsurface-mobile map before using the map menu.
>> Error is larger than before maybe around 150km to the north-west.
>>
>> Test 3
>>
>> Zoomed out even further before using map menu, covering large part of
>> continent. Error is even larger than in Test 2, several hundreds of km out
>> to the north.
>>
>> The direction of the error appears to be random but maybe the magnitude of
>> the error is associated with the zooming factor.
>>
>> The information copied to clipboard (decimal, hexagesimal) appear to be
>> consistent with the location shown in Google-maps (see Location info.png).
>>

NOTE: the map uses the current center to copy to clipboard coordinates
or open the location in google maps.
it doesn't use the selected marker coordinates. this is by design.

having said that, i cannot reproduce any error for dozens of dives.
here are my steps:
- open dive list
- select random dives with gps data
- open dive details
- edit dive to see coordinates
- close "edit" and click "map it"
- copy coordinates to clipboard
- try [+], [-] to zoom in/out

do you happening to be using [+] / [-] for zooming in your tests above?
if not the center can be changed because of the slight pan when you
zoom with pinch.

lubomir
--
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: New Android beta - maps

[Willem Ferguson]

On 13/03/2018 15:03, Dirk Hohndel wrote:



    c) Copy location to clipboard (decimal) then coordinates for a
*different* irrelevant location is copied to clipboard.

    d) Copy location to clipboard (sexagesimal) then a *another 
different*

random location is copied to the clipboard.


c), d) same as above. cannot confirm.
Can you give an example of the location you are at, and the string 
that is

copied to the clipboard? That might help us figure out what's wrong.


/D


I did several tests.

Ironically my first test provided absolute accurate information with 
no error, but subsequent tests produced errors.


Here are some of the results. See:

https://www.dropbox.com/sh/y4iel9m7qve5phu/AAAWvA8NlqSAgMPaOMKg5KrZa?dl=0

These data report on 4 tests:

The reference dive site is shown on Map perspective.png, using the map 
facility in Subsurface-mobile. The location is correct.


These tests were done by shutting down Subsurface-mobile and 
restarting it between tests.


Test 1 and Test 1a.

These were tests with the map focused close to (zoomed in on) the dive 
site when using the map menu. The location in Google maps is out. The 
Pin is the one dropped by Subsurface-mobile, the small red icon is the 
dive site. The error is maybe around 10 km.


Test 2

Zoomed out further in the Subsurface-mobile map before using the map 
menu. Error is larger than before maybe around 150km to the north-west.


Test 3

Zoomed out even further before using map menu, covering large part of 
continent. Error is even larger than in Test 2, several hundreds of km 
out to the north.


The direction of the error appears to be random but maybe the 
magnitude of the error is associated with the zooming factor.


The information copied to clipboard (decimal, hexagesimal) appear to 
be consistent with the location shown in Google-maps (see Location 
info.png).


Kind regards,

willem







--
This message and attachments are subject to a disclaimer.
Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf for full 
details.

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: New Android beta

[Lubomir I. Ivanov]

On 13 March 2018 at 15:03, Dirk Hohndel  wrote:
>
>> On Mar 13, 2018, at 5:51 AM, Lubomir I. Ivanov  wrote:
>>>
>>> Tried the map facility on Android 7.0 on a Galaxy S6. I could not fault it
>>> in any way. Tried lots of things but it appeared rock stable.  This included
>>> switching between map mode and satellite image mode. Lubomir, you are magic.
>>> Two issues:
>>>
>>> 1) It would help if, like the desktop version, the map initialised on the
>>> most recent dive location.
>>>
>>
>> the desktop version dive list and map are more tightly linked.
>> on desktop the map updates immediately and also an entry is selected
>> in the dive list.
>> on mobile you have to click "map it" from dive details to move the map
>> to a new marker and a dive list entry is not selected on startup.
>>
>> if you want the most recent dive to be selected on the map it also
>> makes sense for it to be selected in the dive list.
>>
>> currently the map initializes over Greenwhich, but it's zoomed in.
>> maybe it should be zoomed out to see the entire globe.
>
> I think it would make sense to start the app with the last dive selected.
>

ok. TBD for a future patch.

>>> 2) The menu options do not all work. If I:
>>>
>>>a) Select a particular dive site on the map and go to the dive list, it
>>> goes to dives at an an appropriate dive site in the dive list. The tests
>>> that I did went to the most recent dives at that site. Excellent. :-)
>>>
>>>b) Open location in Google Maps, then an irrelevant location about 800
>>> km away is opened.
>>>
>>
>> strange, cannot confirm. just tried zooming in very deep from the
>> subsurface map and opening in google map reproduced the location
>> exactly.
>
> Is this a locale problem again? Are we sending a localized string to Google
> maps by mistake?
>

the "open location in gmaps" uses decimal format and is not bound to locale:
https://www.google.com/maps/place/7.1335419
134.222761/@7.1335419
134.222761,5000m/data=!3m1!1e3!4m2!3m1!1s0x0:0x0

this is the same as the old "Map it" code.
https://github.com/Subsurface-divelog/subsurface/blob/master/map-widget/qml/MapWidget.qml#L327

>>>c) Copy location to clipboard (decimal) then coordinates for a
>>> *different* irrelevant location is copied to clipboard.
>>>
>>>d) Copy location to clipboard (sexagesimal) then a *another different*
>>> random location is copied to the clipboard.
>>>
>>
>> c), d) same as above. cannot confirm.
>
> Can you give an example of the location you are at, and the string that is
> copied to the clipboard? That might help us figure out what's wrong.
>

decimal is not locale bound.
hexagesimal is locale bound and the directions are translated E, W, N, S.

>>>e) Obviously the option "Select visible dive locations" does not work.
>>> This is probably not because of faulty map functions but because of the way
>>> the dive list works at the moment that does not make this operation
>>> possible.
>>
>> works for me. zoom over a single marker that is not selected. run
>> "Select visible dive locations" and the marker is selected.
>> it follows the same logic as a) - only a single dive in the list is selected.
>
> And if multiple markers are in the window, what's the expected behavior?
>

select most recent dive.

lubomir
--
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: New Android beta

[Lubomir I. Ivanov]

On 13 March 2018 at 10:58, Willem Ferguson
 wrote:
> On 11/03/2018 22:40, Dirk Hohndel wrote:
>>
>> We now have a version of the map widget for the mobile app, thanks to
>> Lubomir.
>>
>> I pushed an Android update to the beta channel and would appreciate
>> testing and feedback.
>>
>> Thanks
>>
>> /D
>
>
> Tried the map facility on Android 7.0 on a Galaxy S6. I could not fault it
> in any way. Tried lots of things but it appeared rock stable.  This included
> switching between map mode and satellite image mode. Lubomir, you are magic.
> Two issues:
>
> 1) It would help if, like the desktop version, the map initialised on the
> most recent dive location.
>

the desktop version dive list and map are more tightly linked.
on desktop the map updates immediately and also an entry is selected
in the dive list.
on mobile you have to click "map it" from dive details to move the map
to a new marker and a dive list entry is not selected on startup.

if you want the most recent dive to be selected on the map it also
makes sense for it to be selected in the dive list.

currently the map initializes over Greenwhich, but it's zoomed in.
maybe it should be zoomed out to see the entire globe.

> 2) The menu options do not all work. If I:
>
> a) Select a particular dive site on the map and go to the dive list, it
> goes to dives at an an appropriate dive site in the dive list. The tests
> that I did went to the most recent dives at that site. Excellent. :-)
>
> b) Open location in Google Maps, then an irrelevant location about 800
> km away is opened.
>

strange, cannot confirm. just tried zooming in very deep from the
subsurface map and opening in google map reproduced the location
exactly.

> c) Copy location to clipboard (decimal) then coordinates for a
> *different* irrelevant location is copied to clipboard.
>
> d) Copy location to clipboard (sexagesimal) then a *another different*
> random location is copied to the clipboard.
>

c), d) same as above. cannot confirm.

> e) Obviously the option "Select visible dive locations" does not work.
> This is probably not because of faulty map functions but because of the way
> the dive list works at the moment that does not make this operation
> possible.
>

works for me. zoom over a single marker that is not selected. run
"Select visible dive locations" and the marker is selected.
it follows the same logic as a) - only a single dive in the list is selected.

lubomir
--
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: New Android beta

[Willem Ferguson]

On 11/03/2018 22:40, Dirk Hohndel wrote:

We now have a version of the map widget for the mobile app, thanks to Lubomir.

I pushed an Android update to the beta channel and would appreciate testing and 
feedback.

Thanks

/D


Tried the map facility on Android 7.0 on a Galaxy S6. I could not fault 
it in any way. Tried lots of things but it appeared rock stable.  This 
included switching between map mode and satellite image mode. Lubomir, 
you are magic. Two issues:


1) It would help if, like the desktop version, the map initialised on 
the most recent dive location.


2) The menu options do not all work. If I:

    a) Select a particular dive site on the map and go to the dive 
list, it goes to dives at an an appropriate dive site in the dive list. 
The tests that I did went to the most recent dives at that site. 
Excellent. :-)


    b) Open location in Google Maps, then an irrelevant location about 
800 km away is opened.


    c) Copy location to clipboard (decimal) then coordinates for a 
*different* irrelevant location is copied to clipboard.


    d) Copy location to clipboard (sexagesimal) then a *another 
different* random location is copied to the clipboard.


    e) Obviously the option "Select visible dive locations" does not 
work. This is probably not because of faulty map functions but because 
of the way the dive list works at the moment that does not make this 
operation possible.


Kind regards,

willem



--
This message and attachments are subject to a disclaimer.
Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf for full 
details.

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: New Android beta

[Chirana Gheorghita Eugeniu Theodor]

works ok on s6 edge + also.

On Tue, Mar 13, 2018 at 9:46 AM, Miodrag Adamovic 
wrote:

> Works on Note 8. Maybe you could put some sort of marker overlay,so you
> could put location more precisely.
>
> Sent from Blue 
> On 13 Mar 2018, at 08:30, Benjamin  wrote:
>>
>> The map works for me on a Galaxy S5 running Android 6.0.1.
>>
>> On Mon, 12 Mar 2018, 13:26 Dirk Hohndel,  wrote:
>>
>>>
>>> We now have a version of the map widget for the mobile app, thanks to
>>> Lubomir.
>>>
>>> I pushed an Android update to the beta channel and would appreciate
>>> testing and feedback.
>>>
>>> Thanks
>>>
>>> /D
>>> --
>>> from my phone.
>>> ___
>>> subsurface mailing list
>>> subsurface@subsurface-divelog.org
>>> http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
>>>
>> --
>>
>> subsurface mailing list
>> subsurface@subsurface-divelog.org
>> http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
>>
>>
> ___
> subsurface mailing list
> subsurface@subsurface-divelog.org
> http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
>
>


-- 

Cu stima/Best regards/Mit freundlichen Grüßen,

Chirana-Gheorghita Eugeniu-Theodor
Bucharest, Romania

e-mail : off...@adaptcom.ro
mobile: 0743 698721
0747 447675
SSI diver ID: 1118289
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: New Android beta

[Miodrag Adamovic]

Works on Note 8. Maybe you could put some sort of marker overlay,so you could 
put location more precisely.

⁣Sent from Blue ​

On 13 Mar 2018, 08:30, at 08:30, Benjamin  wrote:
>The map works for me on a Galaxy S5 running Android 6.0.1.
>
>On Mon, 12 Mar 2018, 13:26 Dirk Hohndel,  wrote:
>
>>
>> We now have a version of the map widget for the mobile app, thanks to
>> Lubomir.
>>
>> I pushed an Android update to the beta channel and would appreciate
>> testing and feedback.
>>
>> Thanks
>>
>> /D
>> --
>> from my phone.
>> ___
>> subsurface mailing list
>> subsurface@subsurface-divelog.org
>>
>http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
>>
>
>
>
>
>___
>subsurface mailing list
>subsurface@subsurface-divelog.org
>http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: New Android beta

[Benjamin]

The map works for me on a Galaxy S5 running Android 6.0.1.

On Mon, 12 Mar 2018, 13:26 Dirk Hohndel,  wrote:

>
> We now have a version of the map widget for the mobile app, thanks to
> Lubomir.
>
> I pushed an Android update to the beta channel and would appreciate
> testing and feedback.
>
> Thanks
>
> /D
> --
> from my phone.
> ___
> subsurface mailing list
> subsurface@subsurface-divelog.org
> http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
>
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

New Android beta

[Dirk Hohndel]

We now have a version of the map widget for the mobile app, thanks to Lubomir.

I pushed an Android update to the beta channel and would appreciate testing and 
feedback.

Thanks

/D
-- 
from my phone.
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: new Android Beta

[Jan Mulder]

On 06-10-17 18:29, Dirk Hohndel wrote:

1) Credentials screen:

Main menu > Settings > Cloud status Change

My existing credential data are deleted, expecting new credential data.

When I want to exit by using the Android EXIT button, I exit Subsurface. I would have 
expected to return to the Settings screen, not to exit the program. In addition, when I 
re-open Subsurface, my credential data have been omitted. I would not expect the existing 
data to be deleted until the "Sign in or Register" button has been selected. It 
should be possible to return gracefully without deleting the existing credential data. 
Upon restarting the program after not changing the credentials and wanting to return to 
the Settings screen, the dive list is empty, only being accessible after typing in the 
existing credential data into the credentials screen.

Good point. Ideally this would go into a github issue - if you aren't 
comfortable dealing with github, let me know and I'll add it there



I just pushed a PR #655 for (part of) this. What is still not working is 
the Android BACK.


--jan
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: new Android Beta

[Willem Ferguson]

>From phone. I am at a diving site this weekend. Yes, I mean the Android
Back button. I can repeat the problem fairly easily on my phone. Add any
text to the notes field of an existing dive. Hit the Back button to close
the keyboard. Keyboard closes. No action bar. Hit Back again. Action button
to save new information appears. Hit the Save action button. This opens the
dive in view mode. No blue action button, only location and distbin icons.
Hit Back again. The blue pencil appears. Hit Back again. No effect. No way
to close Subsurface mobile. Can get to dive list via main menu but cannot
closr programme. I can send screenshot or screencast if required.
Will send dive xml with integrated dive plan tomorrow. Kind regards, Willem

On 06 Oct 2017 18:29, "Dirk Hohndel"  wrote:

>
> > On Oct 6, 2017, at 1:18 AM, Willem Ferguson <
> willemfergu...@zoology.up.ac.za> wrote:
> >
> > 1) Credentials screen:
> >
> > Main menu > Settings > Cloud status Change
> >
> > My existing credential data are deleted, expecting new credential data.
> >
> > When I want to exit by using the Android EXIT button, I exit Subsurface.
> I would have expected to return to the Settings screen, not to exit the
> program. In addition, when I re-open Subsurface, my credential data have
> been omitted. I would not expect the existing data to be deleted until the
> "Sign in or Register" button has been selected. It should be possible to
> return gracefully without deleting the existing credential data. Upon
> restarting the program after not changing the credentials and wanting to
> return to the Settings screen, the dive list is empty, only being
> accessible after typing in the existing credential data into the
> credentials screen.
>
> Good point. Ideally this would go into a github issue - if you aren't
> comfortable dealing with github, let me know and I'll add it there
>
> > 2) I find the blue action button at the bottom of the screen totally
> erratic. Sometimes it disappears, leaving the one or two additional icons
> on the action bar but with a white space where the blue action button
> should be.
>
> Hmm. That's a new one for me. We have a couple of screens that don't have
> an action button:
>
> - settings screen
> - dive edit with keyboard open
> - about page
>
> Where else do you see the button disappear?
>
> > 3) After editing a dive, the Android EXIT button does not work in most
> cases. For instance, I cannot return from an edited dive profile screen
> back to the dive list by tapping the Android EXIT button. The only way to
> get back to the dive list is via the Main Menu > Dive List. In fact, I
> cannot exit from Subsurface after editing, I need to kill the process via
> Android. But see the interaction under point (1) above where, on other
> occasions the EXIT button did work.
>
> So by EXIT button I assume you mean the BACK button? Android changed
> things over the years, but I don't recall an EXIT button.
> Using the latest Beta binary (-929) -- the one where the pink theme works
> again -- I cannot reproduce this here. When editing/adding a dive the first
> tap on exit closes the keyboard, the second one closes the edit screen, the
> third one brings me from dive details view back to dive list, and another
> tap exits Subsurface-mobile...
>
>
> /D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: new Android Beta - user manual

[Dirk Hohndel]

> On Oct 6, 2017, at 9:22 AM, Dirk Hohndel  wrote:
> 
> 
>> On Oct 6, 2017, at 12:21 AM, Willem Ferguson 
>>  wrote:
>> It would be very helpful if the latest existing version of the mobile manual 
>> in master was accessible from the beta so that one can judge the appearance 
>> and readability, and decide which updates to the text and images are 
>> required. At the moment I just have a html version of it that does not quite 
>> resemble the user manual as viewed on the mobile app. The current rendering 
>> of the mobile user manual (as viewed using the beta) is several versions 
>> behind the contents in master.
> 
> Yes, sorry, I'll do that.

You can now get to it from the browser on your phone via this link:

https://subsurface-divelog.org/documentation/subsurface-mobile-v2-user-manual/

I will update the latest beta to show this version instead.

I know that people have suggested to bundle the manual with Subsurface-mobile. 
I don't know how to do that - but I think it would be great if we could figure 
this out.

/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: new Android Beta

[Dirk Hohndel]

> On Oct 6, 2017, at 1:18 AM, Willem Ferguson  
> wrote:
> 
> 1) Credentials screen:
> 
> Main menu > Settings > Cloud status Change
> 
> My existing credential data are deleted, expecting new credential data.
> 
> When I want to exit by using the Android EXIT button, I exit Subsurface. I 
> would have expected to return to the Settings screen, not to exit the 
> program. In addition, when I re-open Subsurface, my credential data have been 
> omitted. I would not expect the existing data to be deleted until the "Sign 
> in or Register" button has been selected. It should be possible to return 
> gracefully without deleting the existing credential data. Upon restarting the 
> program after not changing the credentials and wanting to return to the 
> Settings screen, the dive list is empty, only being accessible after typing 
> in the existing credential data into the credentials screen.

Good point. Ideally this would go into a github issue - if you aren't 
comfortable dealing with github, let me know and I'll add it there

> 2) I find the blue action button at the bottom of the screen totally erratic. 
> Sometimes it disappears, leaving the one or two additional icons on the 
> action bar but with a white space where the blue action button should be.

Hmm. That's a new one for me. We have a couple of screens that don't have an 
action button:

- settings screen
- dive edit with keyboard open
- about page

Where else do you see the button disappear?

> 3) After editing a dive, the Android EXIT button does not work in most cases. 
> For instance, I cannot return from an edited dive profile screen back to the 
> dive list by tapping the Android EXIT button. The only way to get back to the 
> dive list is via the Main Menu > Dive List. In fact, I cannot exit from 
> Subsurface after editing, I need to kill the process via Android. But see the 
> interaction under point (1) above where, on other occasions the EXIT button 
> did work.

So by EXIT button I assume you mean the BACK button? Android changed things 
over the years, but I don't recall an EXIT button.
Using the latest Beta binary (-929) -- the one where the pink theme works again 
-- I cannot reproduce this here. When editing/adding a dive the first tap on 
exit closes the keyboard, the second one closes the edit screen, the third one 
brings me from dive details view back to dive list, and another tap exits 
Subsurface-mobile...


/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: new Android Beta

[Dirk Hohndel]

> On Oct 6, 2017, at 12:23 AM, Davide DB  wrote:
> 
> On 5 October 2017 at 21:13, Dirk Hohndel  wrote:
>> 
>> Also, theming has regressed in my latest testing. I'd love it if someone 
>> else could take a look at that. Linus' preferred theme (PINK) appears to 
>> have been broken by some change...
>> 
> 
> Yesterday I had the opportunity to play a bit for few minutes. I had
> the pink theme selected. I noted that now it is a mix with the blue
> one.

I reverted to a different version of Kirigami and the very latest build should
now be ok again. And Marco is kindly looking into what broke there so
hopefully this will be addressed when using Kirigami master as well.

/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: new Android Beta - user manual

[Dirk Hohndel]

> On Oct 6, 2017, at 12:21 AM, Willem Ferguson 
>  wrote:
> It would be very helpful if the latest existing version of the mobile manual 
> in master was accessible from the beta so that one can judge the appearance 
> and readability, and decide which updates to the text and images are 
> required. At the moment I just have a html version of it that does not quite 
> resemble the user manual as viewed on the mobile app. The current rendering 
> of the mobile user manual (as viewed using the beta) is several versions 
> behind the contents in master.

Yes, sorry, I'll do that.

/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: new Android Beta

[Willem Ferguson]

On 05/10/2017 21:13, Dirk Hohndel wrote:

I think this is very close to being able to release as Subsurface-mobile 2.0

The two keys UI issues (cloud credentials and edit overlay) have been addressed.
There are a few small issues left (especially with the vertical positioning of 
the edit page - I'm working on that one).
Also, theming has regressed in my latest testing. I'd love it if someone else 
could take a look at that. Linus' preferred theme (PINK) appears to have been 
broken by some change...

I don't think we're quite ready for new screen shots, but it would be great to 
try to update the user manual to reflect the changes we made.

Thanks

/D



Subsurface Beta 4.6.4.871 on Galaxy S6 running Android 7.0


1) Credentials screen:

Main menu > Settings > Cloud status Change

My existing credential data are deleted, expecting new credential data.

When I want to exit by using the Android EXIT button, I exit Subsurface. 
I would have expected to return to the Settings screen, not to exit the 
program. In addition, when I re-open Subsurface, my credential data have 
been omitted. I would not expect the existing data to be deleted until 
the "Sign in or Register" button has been selected. It should be 
possible to return gracefully without deleting the existing credential 
data. Upon restarting the program after not changing the credentials and 
wanting to return to the Settings screen, the dive list is empty, only 
being accessible after typing in the existing credential data into the 
credentials screen.


2) I find the blue action button at the bottom of the screen totally 
erratic. Sometimes it disappears, leaving the one or two additional 
icons on the action bar but with a white space where the blue action 
button should be.


3) After editing a dive, the Android EXIT button does not work in most 
cases. For instance, I cannot return from an edited dive profile screen 
back to the dive list by tapping the Android EXIT button. The only way 
to get back to the dive list is via the Main Menu > Dive List. In fact, 
I cannot exit from Subsurface after editing, I need to kill the process 
via Android. But see the interaction under point (1) above where, on 
other occasions the EXIT button did work.


Kind regards,

Willem





--
This message and attachments are subject to a disclaimer.
Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf for full 
details.

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: new Android Beta

[Davide DB]

On 5 October 2017 at 21:13, Dirk Hohndel  wrote:
>
> Also, theming has regressed in my latest testing. I'd love it if someone else 
> could take a look at that. Linus' preferred theme (PINK) appears to have been 
> broken by some change...
>

Yesterday I had the opportunity to play a bit for few minutes. I had
the pink theme selected. I noted that now it is a mix with the blue
one.

-- 
Davide
https://vimeo.com/bocio/videos
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: new Android Beta - user manual

[Willem Ferguson]

On 05/10/2017 21:13, Dirk Hohndel wrote:

I think this is very close to being able to release as Subsurface-mobile 2.0

The two keys UI issues (cloud credentials and edit overlay) have been addressed.
There are a few small issues left (especially with the vertical positioning of 
the edit page - I'm working on that one).
Also, theming has regressed in my latest testing. I'd love it if someone else 
could take a look at that. Linus' preferred theme (PINK) appears to have been 
broken by some change...

I don't think we're quite ready for new screen shots, but it would be great to 
try to update the user manual to reflect the changes we made.

Thanks

/D


It would be very helpful if the latest existing version of the mobile 
manual in master was accessible from the beta so that one can judge the 
appearance and readability, and decide which updates to the text and 
images are required. At the moment I just have a html version of it that 
does not quite resemble the user manual as viewed on the mobile app. The 
current rendering of the mobile user manual (as viewed using the beta) 
is several versions behind the contents in master.


Kind regards,

willem



--
This message and attachments are subject to a disclaimer.
Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf for full 
details.

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

new Android Beta

[Dirk Hohndel]

I think this is very close to being able to release as Subsurface-mobile 2.0

The two keys UI issues (cloud credentials and edit overlay) have been addressed.
There are a few small issues left (especially with the vertical positioning of 
the edit page - I'm working on that one).
Also, theming has regressed in my latest testing. I'd love it if someone else 
could take a look at that. Linus' preferred theme (PINK) appears to have been 
broken by some change...

I don't think we're quite ready for new screen shots, but it would be great to 
try to update the user manual to reflect the changes we made.

Thanks

/D

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface