Re: [Sugar-devel] [PATCH Paint activity v2] Implemented Mirroring Effect in Paint Activity (SL#2463)

2010-10-21 Thread Manusheel Gupta
James, Thanks for the timely feedback. Ayush and team members, Please make sure that we communicate clearly on list servs on our implementation plans and strategies before we submit patches. Will improve productivity and clarity of work. Regards, Manu On Thu, Oct 21, 2010 at 7:38 AM,

Re: [Sugar-devel] [PATCH Paint activity v2] Implemented Mirroring Effect in Paint Activity (SL#2463)

2010-10-21 Thread Ayush Goyal
James, I am sorry for the confusion over the OLPC#2495 SL#2463 bug issue i should also have contacted u but instead i made most of the changes u suggested and uploaded them. Also i uploaded some errors lat time it must have created some confusion. Regarding the changes you are asking me

Re: [Sugar-devel] [PATCH Paint activity v2] Implemented Mirroring Effect in Paint Activity (SL#2463)

2010-10-21 Thread James Cameron
On Thu, Oct 21, 2010 at 10:29:35PM +0530, Ayush Goyal wrote: Regarding the changes you are asking me to make in implementation of the effects separately for applying effect over a selection and for entire image i have referenced the functions for effect already present and used that as

[Sugar-devel] [PATCH Paint activity v2] Implemented Mirroring Effect in Paint Activity (SL#2463)

2010-10-20 Thread Ayush Goyal
Two mirror effects 'Mirror Horizontal' and 'Mirror Vertical' have been added. Mirror horizontal tool flips the entire image or selected area horizontally. Mirror vertical tool does the same vertically. Signed-off-by: Ayush Goyal ay...@seeta.in --- Area.py | 47

Re: [Sugar-devel] [PATCH Paint activity v2] Implemented Mirroring Effect in Paint Activity (SL#2463)

2010-10-20 Thread James Cameron
On Wed, Oct 20, 2010 at 08:00:16PM +0530, Ayush Goyal wrote: +if self.selmove: +size = self.pixmap_sel.get_size() +pix = gtk.gdk.Pixbuf(gtk.gdk.COLORSPACE_RGB, False, 8, +size[0], size[1]) +pix.get_from_drawable(self.pixmap_sel, +