[Sugar-devel] [PATCH] Autocomplete functionality for the address does not work #2406
From: Simon Schampijer si...@schampijer.de see as well #2291 for more info. This one is important for 0.90. --- webtoolbar.py |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/webtoolbar.py b/webtoolbar.py index 69a3c8e..20616a4 100644 --- a/webtoolbar.py +++ b/webtoolbar.py @@ -160,7 +160,7 @@ class WebEntry(AddressEntry): def __view_button_press_event_cb(self, view, event): model = view.get_model() -path, col_, x_, y_ = view.get_path_at_pos(event.x, event.y) +path, col_, x_, y_ = view.get_path_at_pos(int(event.x), int(event.y)) if path: uri = model[path][self._COL_ADDRESS] self.activate(uri) -- 1.7.2.2 ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH] Autocomplete functionality for the address does not work #2406
Excerpts from simon's message of Wed Oct 06 13:57:20 +0200 2010: see as well #2291 for more info. This one is important for 0.90. A bit more background information would be nice. A one-line summary of the analysis in #2291 (i.e. input vs. screen, sub-pixel vs. whole- pixel coordinate systems) would suffice. Also the summary should be more active (e.g. fix address completion). Please adjust these before pushing. Thanks! Acked-By: Sascha Silbe sascha-...@silbe.org Sascha -- http://sascha.silbe.org/ http://www.infra-silbe.de/ signature.asc Description: PGP signature ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH] Autocomplete functionality for the address does not work #2406
On 10/06/2010 03:20 PM, Sascha Silbe wrote: Excerpts from simon's message of Wed Oct 06 13:57:20 +0200 2010: see as well #2291 for more info. This one is important for 0.90. A bit more background information would be nice. A one-line summary of the analysis in #2291 (i.e. input vs. screen, sub-pixel vs. whole- pixel coordinate systems) would suffice. Also the summary should be more active (e.g. fix address completion). Please adjust these before pushing. Thanks! Acked-By: Sascha Silbesascha-...@silbe.org Sascha Thanks for the review. Will address your comments. Regards, Simon ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH] Autocomplete functionality for the address does not work #2406
On 10/06/2010 03:23 PM, Simon Schampijer wrote: On 10/06/2010 03:20 PM, Sascha Silbe wrote: Excerpts from simon's message of Wed Oct 06 13:57:20 +0200 2010: see as well #2291 for more info. This one is important for 0.90. A bit more background information would be nice. A one-line summary of the analysis in #2291 (i.e. input vs. screen, sub-pixel vs. whole- pixel coordinate systems) would suffice. Also the summary should be more active (e.g. fix address completion). Please adjust these before pushing. Thanks! Acked-By: Sascha Silbesascha-...@silbe.org Sascha Thanks for the review. Will address your comments. Regards, Simon Hmm, Lucian was to quick. Lucian you should leave the ticket number in the comment. Actually, you should probably take it as is unless there is a reason to not do so. 'git-am' will do so for you. http://git.sugarlabs.org/projects/browse/repos/mainline/commits/e8130523d74e24be64362c723a9ebed1087fc521 Btw, the other commits were all intended to go on master and sucrose-0.90? You might want to branch off at this stage [1], if you have things that are not intended to land in 0.90. Regards, Simon http://wiki.sugarlabs.org/go/Development_Team/Release#Branching ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH] Autocomplete functionality for the address does not work #2406
On 6 October 2010 14:31, Simon Schampijer si...@schampijer.de wrote: On 10/06/2010 03:23 PM, Simon Schampijer wrote: On 10/06/2010 03:20 PM, Sascha Silbe wrote: Excerpts from simon's message of Wed Oct 06 13:57:20 +0200 2010: see as well #2291 for more info. This one is important for 0.90. A bit more background information would be nice. A one-line summary of the analysis in #2291 (i.e. input vs. screen, sub-pixel vs. whole- pixel coordinate systems) would suffice. Also the summary should be more active (e.g. fix address completion). Please adjust these before pushing. Thanks! Acked-By: Sascha Silbesascha-...@silbe.org Sascha Thanks for the review. Will address your comments. Regards, Simon Hmm, Lucian was to quick. Lucian you should leave the ticket number in the comment. Actually, you should probably take it as is unless there is a reason to not do so. 'git-am' will do so for you. I don't think git-am works with gmail. http://git.sugarlabs.org/projects/browse/repos/mainline/commits/e8130523d74e24be64362c723a9ebed1087fc521 Btw, the other commits were all intended to go on master and sucrose-0.90? You might want to branch off at this stage [1], if you have things that are not intended to land in 0.90. Regards, Simon http://wiki.sugarlabs.org/go/Development_Team/Release#Branching There's no patches I wanted to apply that I wouldn't want in 0.90. Should I branch anyway? ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH] Autocomplete functionality for the address does not work #2406
On 10/06/2010 03:41 PM, Lucian Branescu wrote: On 6 October 2010 14:31, Simon Schampijersi...@schampijer.de wrote: On 10/06/2010 03:23 PM, Simon Schampijer wrote: On 10/06/2010 03:20 PM, Sascha Silbe wrote: Excerpts from simon's message of Wed Oct 06 13:57:20 +0200 2010: see as well #2291 for more info. This one is important for 0.90. A bit more background information would be nice. A one-line summary of the analysis in #2291 (i.e. input vs. screen, sub-pixel vs. whole- pixel coordinate systems) would suffice. Also the summary should be more active (e.g. fix address completion). Please adjust these before pushing. Thanks! Acked-By: Sascha Silbesascha-...@silbe.org Sascha Thanks for the review. Will address your comments. Regards, Simon Hmm, Lucian was to quick. Lucian you should leave the ticket number in the comment. Actually, you should probably take it as is unless there is a reason to not do so. 'git-am' will do so for you. I don't think git-am works with gmail. Maybe Tomeu has some helpful info on that: http://blog.tomeuvizoso.net/2010/09/fetching-patches-from-gmail.html http://git.sugarlabs.org/projects/browse/repos/mainline/commits/e8130523d74e24be64362c723a9ebed1087fc521 Btw, the other commits were all intended to go on master and sucrose-0.90? You might want to branch off at this stage [1], if you have things that are not intended to land in 0.90. Regards, Simon http://wiki.sugarlabs.org/go/Development_Team/Release#Branching There's no patches I wanted to apply that I wouldn't want in 0.90. Should I branch anyway? I am about to send this, but you get a sneaky preview :) Let me know if it does not make sense. To give a short answer to your question: No. === Branching === After the final release of a module, a branch should be created to host further stable development. If you do not have an 'unstable' commit yet you can leave your branch as is, as this ease the work for translators by not having to translate for two branches. Regards, Simon ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH] Autocomplete functionality for the address does not work #2406
On 10/06/2010 04:32 PM, Lucian Branescu wrote: On 6 October 2010 15:26, Sascha Silbe sascha-ml-reply-to-201...@silbe.org wrote: Excerpts from Simon Schampijer's message of Wed Oct 06 15:31:07 +0200 2010: Hmm, Lucian was to quick. Hehe. No problem; I don't think this particular patch is going to matter when hunting down some issue and there's enough information in the description, even if just through an indirection (bug tracker). I just want to make sure we move in the right general direction. Good commit messages are getting more important as the number of contributors increases since no single person will have an overview of all the code (changes) anymore. This is why I pester new contributors and core developers alike with my complaints about commit messages. Yes, it's a good thing you do keep pestering people. And I should know better, too. +1 That is what reviews are for, to keep the quality high. Please keep on. Regards, Simon ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
