Re: [Sugar-devel] [PATCH] fix trivial typo in extension loading exception
El Thu, 03-06-2010 a las 14:03 +0200, Tomeu Vizoso escribió: Well, but I guess we want to test a particular new process and for that, it needs to be written somewhere. Otherwise, each of us could end up testing a different process. Bernie was going to propose concrete changes but then got diverted to the realness summit. Is something stopping the other interested parties to propose the process they think is better? Even though I care very much about the upstream development process, at this time I'm really too busy with the F11-0.88 builds to put the necessary amount of thought into it. So, yeah, I'd appreciate if James could kindly help out by writing down a draft based on our previous discussions. -- // Bernie Innocenti - http://codewiz.org/ \X/ Sugar Labs - http://sugarlabs.org/ ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH] fix trivial typo in extension loading exception
El Thu, 03-06-2010 a las 11:57 +1000, James Cameron escribió: Unfortunately, the old process is still in place. A new process will enter into effect when the wiki is changed. I think you should test a proposed new process and not wait for it to enter into effect. If you don't have time to test the process, then it means the new process cannot be adopted, because it is untested. It's also my fault: I promised that I'd write down a final draft of the review process that we had agreed upon a couple of weeks ago. Hopefully I'll have some time to work on it next week, but feel free to beat me on time. This email summarizes the current status: - Mensaje reenviado De: Tomeu Vizoso to...@tomeuvizoso.net Para: Bernie Innocenti ber...@codewiz.org Cc: Sugar Devel sugar-devel@lists.sugarlabs.org, Fedora OLPC List fedora-olpc-l...@redhat.com, Peter Robinson pbrobin...@gmail.com, SoaS s...@lists.sugarlabs.org, Sebastian Dziallas s...@sugarlabs.org Asunto: changes to the review process (was Re: [Sugar-devel] Sugar 0.88 packages) Fecha: Mon, 17 May 2010 12:18:10 +0200 On Sat, May 15, 2010 at 00:02, Bernie Innocenti ber...@codewiz.org wrote: El Fri, 14-05-2010 a las 08:59 +0200, Tomeu Vizoso escribió: I'm just asking for someone to propose a set of concrete and coherent changes to the current process, is it really asking too much? I'm sorry but I cannot go through the old threads, ask individuals for clarifications, then draft that new process myself. Do you want the proposal posted to the wiki? We could basically take Sasha's original plan and copy it to the wiki. I think it was quite well thought: http://lists.sugarlabs.org/archive/sugar-devel/2010-April/023410.html I propose the following amendments: 1) Scrap the paragraph saying that any sugar developer can approve changes, because it turned out to be a controversial point. The who and the where of reviews are orthogonal topics that can be discussed independently. 2) Also scrap the part where Sascha proposes ways to track patches in the list, since we can now use Patchwork for this. 3) Add all the clarifications in my follow-up to Sascha's proposal: http://lists.sugarlabs.org/archive/sugar-devel/2010-April/023468.html 4) The existing conventions still apply for referencing tickets in the commit logs 5) When a corresponding ticket exists, the committer should add a link to the patch discussion in Patchwork before committing the patch. Does this sound good enough for an initial iteration? If so, I could take care of transcribing it into the wiki. Then, we can further refine the process as we go. Hi Bernie, I think this is an excellent step forward, I really appreciate you having taken the time to do this. I still need to explore patchwork further and I'm a bit concerned about requiring that reviewers amend the commit message but I'm willing to give it a test drive and see how it works in real. I'm looking forward for the new text proposal. Regards, Tomeu -- // Bernie Innocenti - http://codewiz.org/ \X/ Sugar Labs - http://sugarlabs.org/ ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH] fix trivial typo in extension loading exception
On Thu, Jun 3, 2010 at 03:57, James Cameron qu...@laptop.org wrote: On Wed, Jun 02, 2010 at 11:19:08AM +0200, Tomeu Vizoso wrote: On Wed, Jun 2, 2010 at 06:39, James Cameron qu...@laptop.org wrote: On Tue, Jun 01, 2010 at 08:17:32AM +, Sascha Silbe wrote: While you're at it, can you avoid the escaping by using different quotes and replace % with , (for consistency with our style guidelines - it doesn't really make a difference in this particular case), please? Heh. ?Sure. ?Tell me where your style guidelines are? Diversion. What we're missing from the process at the moment is the people who apply the patches are supposed to say so as a reply to the thread. Either nobody is applying these reviewed patches, or those who are applying them are not saying so. ?;-} Unfortunately, the old process is still in place. A new process will enter into effect when the wiki is changed. I think you should test a proposed new process and not wait for it to enter into effect. If you don't have time to test the process, then it means the new process cannot be adopted, because it is untested. Well, but I guess we want to test a particular new process and for that, it needs to be written somewhere. Otherwise, each of us could end up testing a different process. Bernie was going to propose concrete changes but then got diverted to the realness summit. Is something stopping the other interested parties to propose the process they think is better? Regards, Tomeu -- James Cameron http://quozl.linux.org.au/ ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH] fix trivial typo in extension loading exception
On Tue, Jun 01, 2010 at 08:17:32AM +, Sascha Silbe wrote:
While you're at it, can you avoid the escaping by using different quotes
and replace % with , (for consistency with our style guidelines - it
doesn't really make a difference in this particular case), please?
I've read your style guidelines on
http://wiki.sugarlabs.org/go/Development_Team/Code_guidelines in
particular the use of logging.debug('foo %r bar', x) instead of
logging.debug('foo %r bar' % x) as you pointed out, but also that the
code is about communicating to people, and I propose the following
alternate patch which simplifies the message so that it is succinct and
therefore more readily comprehended:
From c6063e8e61286f225027493d7b63368e652e6c27 Mon Sep 17 00:00:00 2001
From: James Cameron qu...@laptop.org
Date: Wed, 2 Jun 2010 16:30:29 +1000
Subject: [PATCH] simplify extension loading exception error
Discovered in shell logs of os240py, this exception was triggered due
to the yet to be merged touchpad control panel extension. But the
exception used incorrect grammar.
---
src/jarabe/controlpanel/gui.py |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/src/jarabe/controlpanel/gui.py b/src/jarabe/controlpanel/gui.py
index 51d9820..0f002fd 100644
--- a/src/jarabe/controlpanel/gui.py
+++ b/src/jarabe/controlpanel/gui.py
@@ -259,8 +259,7 @@ class ControlPanel(gtk.Window):
keywords.append(item)
options[item]['keywords'] = keywords
else:
-_logger.error('There is no CLASS constant specifieds '
\
- 'in the view file \'%s\'.' % item)
+_logger.error('no CLASS attribute in %s', item)
except Exception:
logging.error('Exception while loading extension:\n' + \
''.join(traceback.format_exception(*sys.exc_info(
--
1.7.1
--
James Cameron
http://quozl.linux.org.au/
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH] fix trivial typo in extension loading exception
On Wed, Jun 2, 2010 at 06:39, James Cameron qu...@laptop.org wrote: On Tue, Jun 01, 2010 at 08:17:32AM +, Sascha Silbe wrote: While you're at it, can you avoid the escaping by using different quotes and replace % with , (for consistency with our style guidelines - it doesn't really make a difference in this particular case), please? Heh. Sure. Tell me where your style guidelines are? Diversion. What we're missing from the process at the moment is the people who apply the patches are supposed to say so as a reply to the thread. Either nobody is applying these reviewed patches, or those who are applying them are not saying so. ;-} Unfortunately, the old process is still in place. A new process will enter into effect when the wiki is changed. I mention that because it's the sort of thing that I'd expect you as a committer to the repository to have handled yourself rather than write a reply about it. I presume you were terribly busy and couldn't afford the time. Or is there something about the process I'm not understanding? As all non-trivial patches are being reviewed, we can give commit rights to all submitters patches and let them do the push themselves. Regards, Tomeu -- James Cameron http://quozl.linux.org.au/ ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH] fix trivial typo in extension loading exception
On Wed, Jun 02, 2010 at 11:19:08AM +0200, Tomeu Vizoso wrote: On Wed, Jun 2, 2010 at 06:39, James Cameron qu...@laptop.org wrote: On Tue, Jun 01, 2010 at 08:17:32AM +, Sascha Silbe wrote: While you're at it, can you avoid the escaping by using different quotes and replace % with , (for consistency with our style guidelines - it doesn't really make a difference in this particular case), please? Heh. ?Sure. ?Tell me where your style guidelines are? Diversion. What we're missing from the process at the moment is the people who apply the patches are supposed to say so as a reply to the thread. Either nobody is applying these reviewed patches, or those who are applying them are not saying so. ?;-} Unfortunately, the old process is still in place. A new process will enter into effect when the wiki is changed. I think you should test a proposed new process and not wait for it to enter into effect. If you don't have time to test the process, then it means the new process cannot be adopted, because it is untested. -- James Cameron http://quozl.linux.org.au/ ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH] fix trivial typo in extension loading exception
Excerpts from James Cameron's message of Tue Jun 01 01:27:02 + 2010:
diff --git a/src/jarabe/controlpanel/gui.py b/src/jarabe/controlpanel/gui.py
index 51d9820..0ec70d3 100644
--- a/src/jarabe/controlpanel/gui.py
+++ b/src/jarabe/controlpanel/gui.py
@@ -259,7 +259,7 @@ class ControlPanel(gtk.Window):
keywords.append(item)
options[item]['keywords'] = keywords
else:
-_logger.error('There is no CLASS constant specifieds
' \
+_logger.error('There is no CLASS constant specified
' \
'in the view file \'%s\'.' % item)
While you're at it, can you avoid the escaping by using different quotes
and replace % with , (for consistency with our style guidelines - it
doesn't really make a difference in this particular case), please?
With or without that change:
Reviewed-By: Sascha Silbe sascha-...@silbe.org
Sascha
--
http://sascha.silbe.org/
http://www.infra-silbe.de/
signature.asc
Description: PGP signature
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH] fix trivial typo in extension loading exception
On Tue, Jun 01, 2010 at 08:17:32AM +, Sascha Silbe wrote: While you're at it, can you avoid the escaping by using different quotes and replace % with , (for consistency with our style guidelines - it doesn't really make a difference in this particular case), please? Heh. Sure. Tell me where your style guidelines are? Diversion. What we're missing from the process at the moment is the people who apply the patches are supposed to say so as a reply to the thread. Either nobody is applying these reviewed patches, or those who are applying them are not saying so. ;-} I mention that because it's the sort of thing that I'd expect you as a committer to the repository to have handled yourself rather than write a reply about it. I presume you were terribly busy and couldn't afford the time. Or is there something about the process I'm not understanding? -- James Cameron http://quozl.linux.org.au/ ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
[Sugar-devel] [PATCH] fix trivial typo in extension loading exception
Discovered in shell logs of os240py, this exception was triggered due
to the yet to be merged touchpad control panel extension. But the
exception used incorrect grammar.
Reverts part of a change by Tomeu in 77575b4 in 2008-10.
---
src/jarabe/controlpanel/gui.py |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/jarabe/controlpanel/gui.py b/src/jarabe/controlpanel/gui.py
index 51d9820..0ec70d3 100644
--- a/src/jarabe/controlpanel/gui.py
+++ b/src/jarabe/controlpanel/gui.py
@@ -259,7 +259,7 @@ class ControlPanel(gtk.Window):
keywords.append(item)
options[item]['keywords'] = keywords
else:
-_logger.error('There is no CLASS constant specifieds '
\
+_logger.error('There is no CLASS constant specified ' \
'in the view file \'%s\'.' % item)
except Exception:
logging.error('Exception while loading extension:\n' + \
--
1.7.1
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel
