Re: [Sugar-devel] [PATCH sugar] Control Panel: making about my computer section hardware independent, OLPC #11232

2011-10-18 Thread Simon Schampijer
On 10/17/2011 08:38 PM, Sascha Silbe wrote: Excerpts from Simon Schampijer's message of 2011-10-17 11:07:13 +0200: - powerpc is not a popular Sugar platform to make an enormous effort for supporting it I wouldn't consider anything we discussed an enormous effort. With that attitude PowerPC

[Sugar-devel] [PATCH sugar] Control Panel: making about my computer section hardware independent, OLPC #11232

2011-10-18 Thread Simon Schampijer
'/ofw' is not used anymore on the XO, '/proc/device-tree' is used now instead. Instead of just adjusting for that change we took the chance to make the section hardware independent. As the firmware version we display the bios version if available on non XO hardware. On the XO we display a human

Re: [Sugar-devel] [PATCH sugar] Control Panel: making about my computer section hardware independent, OLPC #11232

2011-10-18 Thread James Cameron
Reviewed-by: James Cameron qu...@laptop.org -- James Cameron http://quozl.linux.org.au/ ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel

Re: [Sugar-devel] [PATCH sugar] Control Panel: making about my computer section hardware independent, OLPC #11232

2011-10-18 Thread Simon Schampijer
On 10/18/2011 09:48 AM, James Cameron wrote: Reviewed-by: James Cameronqu...@laptop.org Acked as well by Sascha on irc, pushed to master and the 0.94 branch. http://git.sugarlabs.org/sugar/mainline/commit/64aae3b42c259af85db4051aa54c74a1b303f21b Regards, Simon

Re: [Sugar-devel] [PATCH sugar] Control Panel: making about my computer section hardware independent, OLPC #11232

2011-10-18 Thread Frederick Grose
On Tue, Oct 18, 2011 at 2:31 AM, Simon Schampijer si...@schampijer.dewrote: On 10/17/2011 08:38 PM, Sascha Silbe wrote: Excerpts from Simon Schampijer's message of 2011-10-17 11:07:13 +0200: - powerpc is not a popular Sugar platform to make an enormous effort for supporting it I

Re: [Sugar-devel] [PATCH sugar] Control Panel: making about my computer section hardware independent, OLPC #11232

2011-10-17 Thread Simon Schampijer
On 10/09/2011 08:55 PM, Sascha Silbe wrote: Excerpts from Simon Schampijer's message of 2011-10-09 18:01:35 +0200: The serial number is often only readable by root on non-XO hardware, that is why we do not read it. If the serial number can not be found on an XO we display the entry as 'Not

Re: [Sugar-devel] [PATCH sugar] Control Panel: making about my computer section hardware independent, OLPC #11232

2011-10-17 Thread James Cameron
On Mon, Oct 17, 2011 at 09:23:18AM +0200, Simon Schampijer wrote: def _parse_firmware_number(firmware_no): if firmware_no is None: firmware_no = _not_available else: # try to extract Open Firmware version from OLPC style # version string, e.g. CL2 Q4B11 Q4B

Re: [Sugar-devel] [PATCH sugar] Control Panel: making about my computer section hardware independent, OLPC #11232

2011-10-17 Thread Simon Schampijer
On 10/17/2011 09:36 AM, James Cameron wrote: On Mon, Oct 17, 2011 at 09:23:18AM +0200, Simon Schampijer wrote: def _parse_firmware_number(firmware_no): if firmware_no is None: firmware_no = _not_available else: # try to extract Open Firmware version from OLPC style

Re: [Sugar-devel] [PATCH sugar] Control Panel: making about my computer section hardware independent, OLPC #11232

2011-10-17 Thread Simon Schampijer
On 10/17/2011 10:37 AM, Simon Schampijer wrote: On 10/17/2011 09:36 AM, James Cameron wrote: On Mon, Oct 17, 2011 at 09:23:18AM +0200, Simon Schampijer wrote: def _parse_firmware_number(firmware_no): if firmware_no is None: firmware_no = _not_available else: # try to extract Open Firmware

Re: [Sugar-devel] [PATCH sugar] Control Panel: making about my computer section hardware independent, OLPC #11232

2011-10-17 Thread Peter Robinson
On Mon, Oct 17, 2011 at 10:07 AM, Simon Schampijer si...@schampijer.de wrote: On 10/17/2011 10:37 AM, Simon Schampijer wrote: On 10/17/2011 09:36 AM, James Cameron wrote: On Mon, Oct 17, 2011 at 09:23:18AM +0200, Simon Schampijer wrote: def _parse_firmware_number(firmware_no): if

Re: [Sugar-devel] [PATCH sugar] Control Panel: making about my computer section hardware independent, OLPC #11232

2011-10-17 Thread James Cameron
On Mon, Oct 17, 2011 at 11:07:13AM +0200, Simon Schampijer wrote: - the string does always start with CL: CL1 for XO-1, CL1B for XO-1.5, CL2 for XO-1.75, ... Actually, it also starts with CL1 for XO-1.5, we didn't change it, even though we used CL1B elsewhere. At the time I was talking about

Re: [Sugar-devel] [PATCH sugar] Control Panel: making about my computer section hardware independent, OLPC #11232

2011-10-17 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of 2011-10-17 11:07:13 +0200: - powerpc is not a popular Sugar platform to make an enormous effort for supporting it I wouldn't consider anything we discussed an enormous effort. With that attitude PowerPC would never be a viable platform. Catch-22.

Re: [Sugar-devel] [PATCH sugar] Control Panel: making about my computer section hardware independent, OLPC #11232

2011-10-10 Thread James Cameron
On Sun, Oct 09, 2011 at 08:55:27PM +0200, Sascha Silbe wrote: def _parse_firmware_number(firmware_no): if firmware_no is None: return _not_available firmware_no = firmware_no.replace('\0', ' ').strip() # try to extract Open Firmware version from OLPC style version

Re: [Sugar-devel] [PATCH sugar] Control Panel: making about my computer section hardware independent, OLPC #11232

2011-10-09 Thread Simon Schampijer
On 10/08/2011 09:57 PM, Sascha Silbe wrote: Excerpts from Simon Schampijer's message of 2011-10-07 11:13:15 +0200: '/ofw' is not used anymore on the XO, '/proc/device-tree' is used now instead. Instead of just adjusting for that change we took the chance to make the section hardware

[Sugar-devel] [PATCH sugar] Control Panel: making about my computer section hardware independent, OLPC #11232

2011-10-09 Thread Simon Schampijer
'/ofw' is not used anymore on the XO, '/proc/device-tree' is used now instead. Instead of just adjusting for that change we took the chance to make the section hardware independent. As the firmware version we display the bios version if available on non XO hardware. As ethtool has become a

Re: [Sugar-devel] [PATCH sugar] Control Panel: making about my computer section hardware independent, OLPC #11232

2011-10-09 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of 2011-10-09 12:54:40 +0200: @@ -58,6 +58,8 @@ def get_serial_number(): serial_no = _read_file(os.path.join(_OFW_TREE, _SN)) elif os.path.exists(os.path.join(_PROC_TREE, _SN)): serial_no =

[Sugar-devel] [PATCH sugar] Control Panel: making about my computer section hardware independent, OLPC #11232

2011-10-09 Thread Simon Schampijer
'/ofw' is not used anymore on the XO, '/proc/device-tree' is used now instead. Instead of just adjusting for that change we took the chance to make the section hardware independent. As the firmware version we display the bios version if available on non XO hardware. As ethtool has become a

Re: [Sugar-devel] [PATCH sugar] Control Panel: making about my computer section hardware independent, OLPC #11232

2011-10-09 Thread Simon Schampijer
On 10/09/2011 05:22 PM, Sascha Silbe wrote: Excerpts from Simon Schampijer's message of 2011-10-09 12:54:40 +0200: @@ -58,6 +58,8 @@ def get_serial_number(): serial_no = _read_file(os.path.join(_OFW_TREE, _SN)) elif os.path.exists(os.path.join(_PROC_TREE, _SN)):

Re: [Sugar-devel] [PATCH sugar] Control Panel: making about my computer section hardware independent, OLPC #11232

2011-10-09 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of 2011-10-09 18:01:35 +0200: The serial number is often only readable by root on non-XO hardware, that is why we do not read it. If the serial number can not be found on an XO we display the entry as 'Not available'. [...] -def get_firmware_number():

Re: [Sugar-devel] [PATCH sugar] Control Panel: making about my computer section hardware independent, OLPC #11232

2011-10-08 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of 2011-10-07 11:13:15 +0200: '/ofw' is not used anymore on the XO, '/proc/device-tree' is used now instead. Instead of just adjusting for that change we took the chance to make the section hardware independent. As the firmware version we display the

[Sugar-devel] [PATCH sugar] Control Panel: making about my computer section hardware independent, OLPC #11232

2011-10-07 Thread Simon Schampijer
'/ofw' is not used anymore on the XO, '/proc/device-tree' is used now instead. Instead of just adjusting for that change we took the chance to make the section hardware independent. As the firmware version we display the bios version if available on non XO hardware. As ethtool has become a