Re: [Sugar-devel] Report on Sl# 2080 , Pulsing icon delayed by 5 seconds or so.
Sure , we can work to get a combined patch but your patch still disables the animation in most of the icons and we can check the real deal only after we can see the animation because thats the real part where all the system resources go and lead to that delay. We should first try to get that part working and then run fresh tests to check the improvements. On the other hand my patch my patch also gives a near 50% reduction in delay with the animation playing but the community still hasn't reached on a consensus regarding the issue so I guess we need to reach on a common point of approval , then only we can get any working patch accepted and move on to other issues. Regards Anurag On Fri, Nov 5, 2010 at 4:05 PM, Martin Dengler mar...@martindengler.com wrote: On Fri, Nov 05, 2010 at 02:24:58PM +0530, Anurag Chowdhury wrote: Hello I have prepared a detailed report on the issue SL # 2080, Pulsing icon delayed by 5 seconds or so , and have made it online at http://wiki.sugarlabs.org/go/Pulsing_icon_delayed_by_5_seconds . Thanks for that. Next time, could you link to the SL bug in the wiki page and the wiki page in the SL bug? I have done this for you. Any feedback is appreciated. Again, thanks for this summary. I think the thing to do is merge my patch for #2080 and then address the other issues. I'll do that soon. Regards, --Anurag Martin ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] Report on Sl# 2080 , Pulsing icon delayed by 5 seconds or so.
On Fri, Nov 05, 2010 at 06:05:16PM +0530, Anurag Chowdhury wrote: Sure , we can work to get a combined patch but your patch still disables the animation in most of the icons I think you're talking about something else than my patch. No animation is disabled. Not sure what's wrong but the patch you linked to[1] in your wiki page clearly does nothing like disabling any animation. Regards Anurag Martin 1. http://www.martindengler.com/tmp/sl.o-2080/pulsingicon.py-set-new-colors-in-one-go-to-avoid-multiple-calls-to-SVG-rendering.patch pgpTNJcvBAYTE.pgp Description: PGP signature ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] Report on Sl# 2080 , Pulsing icon delayed by 5 seconds or so.
On Fri, Nov 5, 2010 at 6:35 AM, Martin Dengler mar...@martindengler.com wrote: Again, thanks for this summary. I think the thing to do is merge my patch for #2080 and then address the other issues. I'll do that soon. Hi Martin. would it make sense to change (in toolkit) jarabe/view/icon.py to optionally return the cairo object, instead of paint()ing it? Then you can render the SVG once or twice (for zoom effect?), keep those raster images cached in the pulsingicon object, and use Cairo's paint_with_alpha() instead of straight paint(). Which will be fast. (Load/render your sprites only once, get creative in how you blit them... ) The pulsing color combinations change (get simpler) with this. To get back to what we have now (or an approximation) you could render to blackwhite (and a reverse) and use them as masks, painting with masked full color fills. A bit more work. I'm following this tutorial -- mask() and paint_with_alpha() should be enough. I am disappointed that I cannot see more advanced blitting opts. http://www.tortall.net/mu/wiki/CairoTutorial m -- martin.langh...@gmail.com mar...@laptop.org -- School Server Architect - ask interesting questions - don't get distracted with shiny stuff - working code first - http://wiki.laptop.org/go/User:Martinlanghoff ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] Report on Sl# 2080 , Pulsing icon delayed by 5 seconds or so.
On Fri, Nov 05, 2010 at 09:28:23AM -0400, Martin Langhoff wrote: On Fri, Nov 5, 2010 at 6:35 AM, Martin Dengler mar...@martindengler.com wrote: Again, thanks for this summary. I think the thing to do is merge my patch for #2080 and then address the other issues. I'll do that soon. If I call this change #1... would it make sense to change (in toolkit) jarabe/view/icon.py to optionally return the cairo object, instead of paint()ing it? Then you can render the SVG once or twice (for zoom effect?), keep those raster images cached in the pulsingicon object, and use Cairo's paint_with_alpha() instead of straight paint(). Which will be fast. (Load/render your sprites only once, get creative in how you blit them... ) The pulsing color combinations change (get simpler) with this. ...and this change #2... To get back to what we have now (or an approximation) you could render to blackwhite (and a reverse) and use them as masks, painting with masked full color fills. A bit more work. ...and this change #3, I'll have a go at implementing #2 and #3 soon. Since #1 is separate and an improvement from what we have now, it can be merged earlier9 Unless there are issues, which I haven't seen yet). I'm following this tutorial -- mask() and paint_with_alpha() should be enough. I am disappointed that I cannot see more advanced blitting opts. http://www.tortall.net/mu/wiki/CairoTutorial Thanks for the link - I've seen it before but it's always good to come back to absorb a bit more. m Martin pgpTOVmf91qPQ.pgp Description: PGP signature ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] Report on Sl# 2080 , Pulsing icon delayed by 5 seconds or so.
On Fri, Nov 5, 2010 at 6:53 PM, Martin Dengler mar...@martindengler.com wrote: On Fri, Nov 05, 2010 at 06:05:16PM +0530, Anurag Chowdhury wrote: Sure , we can work to get a combined patch but your patch still disables the animation in most of the icons I think you're talking about something else than my patch. No animation is disabled. Not sure what's wrong but the patch you linked to[1] in your wiki page clearly does nothing like disabling any animation. Well, I actually didn't meant that. I was talking about the change noticed by Gary (and me too) i.e. after the application of the patch we don't get to see the pulsing icon animation in most of the icons , all we see is only the grayscale svg icon , this anomaly is also linked with the complexity of the icons i.e. more complex icons don't show up the animation while the simpler ones do. Regards Anurag Martin 1. http://www.martindengler.com/tmp/sl.o-2080/pulsingicon.py-set-new-colors-in-one-go-to-avoid-multiple-calls-to-SVG-rendering.patch ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] Report on Sl# 2080 , Pulsing icon delayed by 5 seconds or so.
On Fri, Nov 05, 2010 at 09:49:01PM +0530, Anurag Chowdhury wrote: On Fri, Nov 5, 2010 at 6:53 PM, Martin Dengler mar...@martindengler.com wrote: On Fri, Nov 05, 2010 at 06:05:16PM +0530, Anurag Chowdhury wrote: Sure , we can work to get a combined patch but your patch still disables the animation in most of the icons I think you're talking about something else than my patch. No animation is disabled. Not sure what's wrong but the patch you linked to[1] in your wiki page clearly does nothing like disabling any animation. Well, I actually didn't meant that. I was talking about the change noticed by Gary (and me too) i.e. after the application of the patch we don't get to see the pulsing icon animation in most of the icons , all we see is only the grayscale svg icon , this anomaly is also linked with the complexity of the icons i.e. more complex icons don't show up the animation while the simpler ones do. Are you talking about the pulsing from greyscale to color, or the zooming? Gary was talking about the zooming[1] IIUC, and that is obviously not changed by my patch. I understood his comment to mean that there was already a zooming issue in the build he was referring to, and that my patch did not change that. Can you please help me understand a bit more why you think my patch causes the pulsing icon to not show in color? I don't see that in my sugar-jhbuild before or after my patch. Martin 1. http://lists.sugarlabs.org/archive/sugar-devel/2010-October/028444.html pgptiHCsoKp3T.pgp Description: PGP signature ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
