[sup-devel] encoding branch

2009-11-25 Thread Rich Lane
I've pushed a branch "encoding" to my repo (git://github.com/rlane/sup) which has many fixes for the encoding issues ruby 1.9 creates. It successfully indexes the Enron and SpamAssassin corpuses, as well as all my own mail. AFAIK we've taken care of all the other ruby 1.9 issues, so sup should work

Re: [sup-devel] [issue24] sup doesn't understand inline encoding of file names

2009-11-27 Thread Rich Lane
Excerpts from Tero Tilus's message of Thu Nov 26 08:10:31 -0500 2009: > Gaute Hope, 2009-11-25 19:26: > > When I receive emails with attachments with inline encoding such as: > > > > =?ISO-8859-1?Q?framside_sm=E5_stader_STORE_VYER.jpg?= > > > > sup should convert them to: framside_små_stader_STOR

Re: [sup-devel] [PATCH] Make sup's textfield behave more like readline

2009-11-27 Thread Rich Lane
Excerpts from Steven Walter's message of Fri Nov 20 09:07:14 -0500 2009: > On Thu, Nov 19, 2009 at 11:51 PM, Rich Lane wrote: > >> I also switched some of the key-code integers to character-literal > >> syntax as I thought that was a bit more readable. > >>

[sup-devel] pull request

2009-11-27 Thread Rich Lane
Hi William, Please pull branch master from git://github.com/rlane/sup. This includes the following topic branches: xapian-comment-fix config-ask-for-to fix-bounce-cmd display-poll-labels decode-attachment-filenames textfield-tweaks thread-view-mode-undo date-format-fix ___

Re: [sup-devel] [PATCH] XapianIndex.each_message_in_thread_for yields messages in cronological order

2009-12-27 Thread Rich Lane
Excerpts from Tero Tilus's message of Tue Dec 22 07:42:52 -0500 2009: > This way I got rid of a couple of counterintuitive threading results. > Namely real root of a thread would occasionally not be displayed as a > root if a message containing the real root in the middle of its > refs-list (dunno

[sup-devel] [PATCH] try loading ncursesw

2009-12-29 Thread Rich Lane
--- bin/sup | 14 +- lib/sup/buffer.rb |7 ++- 2 files changed, 19 insertions(+), 2 deletions(-) diff --git a/bin/sup b/bin/sup index 471e833..fcc254f 100755 --- a/bin/sup +++ b/bin/sup @@ -1,7 +1,15 @@ #!/usr/bin/env ruby require 'rubygems' -require 'ncurses'

[sup-devel] [PATCH 1/4] factor saving out of thread/message classes

2009-12-29 Thread Rich Lane
--- lib/sup/index.rb |7 +++ lib/sup/message.rb |5 + lib/sup/modes/thread-index-mode.rb |2 +- lib/sup/thread.rb |2 +- 4 files changed, 10 insertions(+), 6 deletions(-) diff --git a/lib/sup/index.rb b/lib/sup/index.rb in

[sup-devel] [PATCH 2/4] async thread indexing

2009-12-29 Thread Rich Lane
--- bin/sup|2 ++ lib/sup/index.rb | 26 +- lib/sup/modes/thread-index-mode.rb |2 +- 3 files changed, 28 insertions(+), 2 deletions(-) diff --git a/bin/sup b/bin/sup index 471e833..f9ed7d5 100755 --- a/bin/sup +++ b/

[sup-devel] [PATCH 4/4] force the index sync thread to give up the cpu

2009-12-29 Thread Rich Lane
--- lib/sup/index.rb |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/lib/sup/index.rb b/lib/sup/index.rb index 1131ec7..4f491d6 100644 --- a/lib/sup/index.rb +++ b/lib/sup/index.rb @@ -201,6 +201,8 @@ class BaseIndex while m = @sync_queue.deq return if m == :d

[sup-devel] [PATCH 3/4] immediate thread indexing

2009-12-29 Thread Rich Lane
--- lib/sup/modes/inbox-mode.rb|4 +++ lib/sup/modes/thread-index-mode.rb | 40 +-- lib/sup/modes/thread-view-mode.rb |7 ++ 3 files changed, 26 insertions(+), 25 deletions(-) diff --git a/lib/sup/modes/inbox-mode.rb b/lib/sup/modes/inbox-mod

Re: [sup-devel] [PATCH] XapianIndex.each_message_in_thread_for yields messages in cronological order

2009-12-30 Thread Rich Lane
Excerpts from William Morgan's message of Wed Dec 30 09:10:54 -0500 2009: > Reformatted excerpts from Tero Tilus's message of 2009-12-29: > > For what I know you might trigger this by replying to many messages at > > once and thus having a list of ids in-reply-to header (in whatever > > order of co

Re: [sup-devel] topic branch merge report

2009-12-31 Thread Rich Lane
Excerpts from William Morgan's message of Thu Dec 31 15:31:50 -0500 2009: > Rich, I think I need your help with the two branches 'xapian-bugfix' and > 'xapian-message-state', which are generating a conflict for some reason, > and I don't understand the code well enough to resolve. Would you be > a

[sup-devel] Ruby 1.9 encoding fixes

2009-12-31 Thread Rich Lane
This patchset fixes the string encoding issues on Ruby 1.9.1. The general strategy is to treat raw messsages as binary and ensure that everything is passed through Iconv or String#ascii before being displayed or stored. I tested an earlier version of this patchset (with more debug checks) on around

[sup-devel] [PATCH 02/10] display_size is just size on Ruby 1.9

2009-12-31 Thread Rich Lane
--- lib/sup/util.rb |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib/sup/util.rb b/lib/sup/util.rb index f99e1c1..5f68d0d 100644 --- a/lib/sup/util.rb +++ b/lib/sup/util.rb @@ -177,7 +177,7 @@ class String ## nasty multibyte hack for ruby 1.8. if it's utf-8, split i

[sup-devel] [PATCH 03/10] add String#check

2009-12-31 Thread Rich Lane
--- lib/sup/util.rb | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/lib/sup/util.rb b/lib/sup/util.rb index 5f68d0d..fc90350 100644 --- a/lib/sup/util.rb +++ b/lib/sup/util.rb @@ -296,6 +296,16 @@ class String ## ## split_on will be passed to String#split,

[sup-devel] [PATCH 04/10] add String#ascii

2009-12-31 Thread Rich Lane
--- lib/sup/util.rb | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/lib/sup/util.rb b/lib/sup/util.rb index fc90350..508bcee 100644 --- a/lib/sup/util.rb +++ b/lib/sup/util.rb @@ -306,6 +306,19 @@ class String raise CheckError.new($!.message) end

[sup-devel] [PATCH 01/10] open mail source files as binary

2009-12-31 Thread Rich Lane
--- lib/sup/maildir.rb |4 ++-- lib/sup/mbox/loader.rb |4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/sup/maildir.rb b/lib/sup/maildir.rb index c2bd27a..0852576 100644 --- a/lib/sup/maildir.rb +++ b/lib/sup/maildir.rb @@ -59,7 +59,7 @@ class Maildir < Sourc

[sup-devel] [PATCH 06/10] add String#transcode

2009-12-31 Thread Rich Lane
--- lib/sup/util.rb |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/lib/sup/util.rb b/lib/sup/util.rb index 560ac73..c27e527 100644 --- a/lib/sup/util.rb +++ b/lib/sup/util.rb @@ -319,6 +319,10 @@ class String out.force_encoding Encoding::UTF_8 if out.respond_to? :

[sup-devel] [PATCH 05/10] fixup Iconv#easy_decode for Ruby 1.9

2009-12-31 Thread Rich Lane
--- lib/sup/util.rb | 21 + 1 files changed, 13 insertions(+), 8 deletions(-) diff --git a/lib/sup/util.rb b/lib/sup/util.rb index 508bcee..560ac73 100644 --- a/lib/sup/util.rb +++ b/lib/sup/util.rb @@ -664,21 +664,26 @@ class FinishLine end class Iconv - def self.easy_

[sup-devel] [PATCH 09/10] use header from the RMail::Message in Message#parse_header

2009-12-31 Thread Rich Lane
--- lib/sup/message.rb | 24 ++-- 1 files changed, 14 insertions(+), 10 deletions(-) diff --git a/lib/sup/message.rb b/lib/sup/message.rb index f3ac874..519243a 100644 --- a/lib/sup/message.rb +++ b/lib/sup/message.rb @@ -31,6 +31,7 @@ class Message MAX_SIG_DISTANCE = 15

[sup-devel] [PATCH 08/10] decode raw header/message to ascii before viewing

2009-12-31 Thread Rich Lane
--- lib/sup/modes/thread-view-mode.rb |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/sup/modes/thread-view-mode.rb b/lib/sup/modes/thread-view-mode.rb index 8b5642e..52b54dd 100644 --- a/lib/sup/modes/thread-view-mode.rb +++ b/lib/sup/modes/thread-view-mode.rb @@

[sup-devel] [PATCH 07/10] transcode output from mime-decode hook too

2009-12-31 Thread Rich Lane
--- lib/sup/message-chunks.rb |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/lib/sup/message-chunks.rb b/lib/sup/message-chunks.rb index 581b707..6328f1f 100644 --- a/lib/sup/message-chunks.rb +++ b/lib/sup/message-chunks.rb @@ -99,7 +99,7 @@ EOS text = case @c

[sup-devel] [PATCH 10/10] decode header fields of enclosed messages

2009-12-31 Thread Rich Lane
--- lib/sup/message.rb | 13 + 1 files changed, 5 insertions(+), 8 deletions(-) diff --git a/lib/sup/message.rb b/lib/sup/message.rb index 519243a..ff05df6 100644 --- a/lib/sup/message.rb +++ b/lib/sup/message.rb @@ -446,15 +446,12 @@ private from = payload.header.from.firs

[sup-devel] [PATCH] ruby 1.9: use String#ord in ask_getch and ask_yes_or_no

2010-01-01 Thread Rich Lane
In Ruby 1.9, character literals and the return value from string index accesses are now themselves strings and need to be converted to integers with String#ord. This was breaking ask_getch. Integer#ord is defined on Ruby 1.8 so this won't cause problems there. --- lib/sup/buffer.rb |4 ++-- 1

[sup-devel] [PATCH] xapian: respect :skip_killed in each_message_in_thread_for

2010-01-01 Thread Rich Lane
--- lib/sup/xapian_index.rb |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib/sup/xapian_index.rb b/lib/sup/xapian_index.rb index cebb148..955ec8f 100644 --- a/lib/sup/xapian_index.rb +++ b/lib/sup/xapian_index.rb @@ -127,7 +127,7 @@ EOS while not queue.empty?

Re: [sup-devel] [PATCH 01/10] open mail source files as binary

2010-01-01 Thread Rich Lane
Excerpts from William Morgan's message of Fri Jan 01 16:43:13 -0500 2010: > Reformatted excerpts from Anthony Martinez's message of 2010-01-01: > > Especially if you use Maildir for a source, the resulting torrent of > > warnings makes Sup a bit difficult to use. > > > > I've gone and reverted thi

[sup-devel] [PATCH] ruby 1.9: expect nil start_offset when an MBox::Loader is first created

2010-01-01 Thread Rich Lane
Various callers (including sup-add) passed a nil start_offset. Through a convoluted path probably involving the fact that nil.to_i == 0, this did the right thing on Ruby 1.8. It crashes on 1.9, so change initialize to expect a nil offset and replace it with 0. --- lib/sup/mbox/loader.rb |3 ++-

[sup-devel] [PATCH] switch default index to Xapian

2010-01-01 Thread Rich Lane
Previous versions didn't add an :index entry in config.yaml, so preserve compatibility by using Ferret if no index is specified and the ferret directory exists. --- This patch is meant for 0.10. AFAIK the xapian index has feature-parity with ferret. There are a couple of issues remaining with quer

[sup-devel] [PATCH] xapian: translate from/to query term prefixes to search over both name and email fields

2010-01-01 Thread Rich Lane
--- lib/sup/xapian_index.rb | 19 --- 1 files changed, 12 insertions(+), 7 deletions(-) diff --git a/lib/sup/xapian_index.rb b/lib/sup/xapian_index.rb index cebb148..c192b26 100644 --- a/lib/sup/xapian_index.rb +++ b/lib/sup/xapian_index.rb @@ -159,14 +159,15 @@ EOS subs

[sup-devel] [PATCH] force binary encoding before parsing decrypted messages

2010-01-02 Thread Rich Lane
--- lib/sup/crypto.rb |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/lib/sup/crypto.rb b/lib/sup/crypto.rb index fb2661a..91652c7 100644 --- a/lib/sup/crypto.rb +++ b/lib/sup/crypto.rb @@ -130,6 +130,7 @@ class CryptoManager end output = IO.read output_fn.pat

[sup-devel] [PATCH] support high colors in colors.yaml

2010-01-02 Thread Rich Lane
Add constants for colors >15 so that they can be used in the colors config file. You can use integers for all available colors. If you're running xterm-256color or compatible you can use "cXYZ" for the 6x6x6 color cube and "gXY" for grayscale. --- Using `tput` might be bad if we support any platfor

Re: [sup-devel] [PATCH] support high colors in colors.yaml

2010-01-03 Thread Rich Lane
Excerpts from Rich Lane's message of 2010-01-02 18:50:00 -0500: > Add constants for colors >15 so that they can be used in the colors config > file. You can use integers for all available colors. If you're running > xterm-256color or compatible you can use "cXYZ" for the 6x6x6 color cube and > "gXY

[sup-devel] [PATCH 3/3] add keybinding 'Oc' to reload colors

2010-01-03 Thread Rich Lane
--- bin/sup | 10 ++ lib/sup/colormap.rb |6 +- 2 files changed, 15 insertions(+), 1 deletions(-) diff --git a/bin/sup b/bin/sup index 5571598..0716e55 100755 --- a/bin/sup +++ b/bin/sup @@ -96,6 +96,11 @@ global_keymap = Keymap.new do |k| k.add :recall_draft, "Ed

[sup-devel] [PATCH 2/3] send color errors to the log instead of flashing

2010-01-03 Thread Rich Lane
During startup, when these errors are most likely to occur, not enough buffer initialization has been done for BufferManager.flash to work. --- lib/sup/colormap.rb |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib/sup/colormap.rb b/lib/sup/colormap.rb index 71c715f..d28

[sup-devel] [PATCHv2 1/3] support high colors in colors.yaml

2010-01-03 Thread Rich Lane
Add constants for colors >15 so that they can be used in the colors config file. You can use integers for all available colors. If you're running xterm-256color or compatible you can use "cXYZ" for the 6x6x6 color cube and "gX" for 24 shades of gray. --- lib/sup/colormap.rb | 34

[sup-devel] [PATCH] add a mouse-enabled colorpicker to contrib

2010-01-03 Thread Rich Lane
Intended to make colorscheme creation easier. --- contrib/colorpicker.rb | 104 1 files changed, 104 insertions(+), 0 deletions(-) create mode 100644 contrib/colorpicker.rb diff --git a/contrib/colorpicker.rb b/contrib/colorpicker.rb new file mod

[sup-devel] [PATCH] utf-8 script encoding

2010-01-03 Thread Rich Lane
--- Does this patch help? bin/sup |1 + bin/sup-add |1 + bin/sup-config |1 + bin/sup-dump|1 + bin/sup-recover-sources |1 + b

Re: [sup-devel] [sup-talk] Ferret to Xapian conversion

2010-01-03 Thread Rich Lane
Excerpts from Anthony Martinez's message of 2010-01-03 14:38:52 -0500: > Speaking of not having the Xapian gem, when I tried "gem install xapian-full", > it looked like it worked, but didn't actually install a gem on my system. > Here's > the build log: http://pastebin.com/f2d25a13c > > I tried t

[sup-devel] [PATCH] add console commands to get/set loglevel

2010-01-04 Thread Rich Lane
--- lib/sup/logger.rb |3 ++- lib/sup/modes/console-mode.rb |4 2 files changed, 6 insertions(+), 1 deletions(-) diff --git a/lib/sup/logger.rb b/lib/sup/logger.rb index ccaeae0..ab97e47 100644 --- a/lib/sup/logger.rb +++ b/lib/sup/logger.rb @@ -14,13 +14,14 @@ class Logg

[sup-devel] [PATCH] implement String#each on Ruby 1.9 for lockfile

2010-01-04 Thread Rich Lane
--- lib/sup/util.rb |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/lib/sup/util.rb b/lib/sup/util.rb index 206c18a..2d3a2ad 100644 --- a/lib/sup/util.rb +++ b/lib/sup/util.rb @@ -290,6 +290,12 @@ class String end end + unless method_defined? :each +def

[sup-devel] [PATCH] implement const_missing for Index

2010-01-04 Thread Rich Lane
Otherwise, constant references to LockError and ParseError will fail. --- This should be added to the ruby-1.9-encoding branch. lib/sup/index.rb |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/lib/sup/index.rb b/lib/sup/index.rb index f02c96b..8a4b8f2 100644 --- a/lib/sup

[sup-devel] [PATCH] only open mail files in binary mode on Ruby 1.9

2010-01-04 Thread Rich Lane
--- lib/sup/maildir.rb |4 ++-- lib/sup/mbox/loader.rb |4 ++-- lib/sup/util.rb|7 +++ 3 files changed, 11 insertions(+), 4 deletions(-) diff --git a/lib/sup/maildir.rb b/lib/sup/maildir.rb index 0852576..b2c5847 100644 --- a/lib/sup/maildir.rb +++ b/lib/sup/maildir.rb

Re: [sup-devel] [PATCH] implement const_missing for Index

2010-01-04 Thread Rich Lane
Excerpts from William Morgan's message of 2010-01-04 14:43:58 -0500: > Reformatted excerpts from Rich Lane's message of 2010-01-04: > > This should be added to the ruby-1.9-encoding branch. > > Not to ferret-deprecation? Oh, right, sorry. Airports are messing with my brain. __

[sup-devel] [PATCH] call index.load in sup-add

2010-01-06 Thread Rich Lane
If it's going to call index.save, it needs to load it first. --- bin/sup-add |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/bin/sup-add b/bin/sup-add index c53378d..a7a3752 100755 --- a/bin/sup-add +++ b/bin/sup-add @@ -86,6 +86,7 @@ end $terminal.wrap_at = :auto Redwoo

[sup-devel] [PATCH] fix ask_for_contacts on Ruby 1.9

2010-01-13 Thread Rich Lane
From: Rich Lane String doesn't respond to :map anymore. The previous code was also joining with " " instead of ", ", which was broken. --- lib/sup/buffer.rb |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib/sup/buffer.rb b/lib/sup/buffer.

[sup-devel] [PATCH] xapian: add boolean terms with zero wdf

2010-01-14 Thread Rich Lane
Xapian's Flint backend stores the document length in every posting, so if the document length is changed (by adding a label, for example), every posting entry needs to be rewritten. This basically nullifies the performance improvement from the Xapian bug 250 fix. We can prevent this by adding these

[sup-devel] [PATCH 4/4] trivial index format upgrade

2010-01-16 Thread Rich Lane
A v2 client can read a v1 index, but a v1 client cannot read a v2 index. Once the v2 client modifies the index the v1 client will be unable to read it. So, make the version check match that. --- lib/sup/xapian_index.rb |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/

[sup-devel] [PATCH 2/4] index email addresses as text

2010-01-16 Thread Rich Lane
This lets you search for an email address (or its component parts, since it's indexed as a phrase) with no prefix. --- lib/sup/xapian_index.rb |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/lib/sup/xapian_index.rb b/lib/sup/xapian_index.rb index c0b2f9f..6fa6c55 100644

[sup-devel] [PATCH 3/4] id query prefix synonym for msgid

2010-01-16 Thread Rich Lane
notmuch has created an "id:" convention for referring to emails. We already had "msgid:", but support this syntax too. --- lib/sup/xapian_index.rb |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/lib/sup/xapian_index.rb b/lib/sup/xapian_index.rb index 6fa6c55..eefd492 10064

[sup-devel] [PATCH 1/4] dont index redundant data

2010-01-16 Thread Rich Lane
Use the Xapian QueryParser ability to map a prefix in the query to multiple prefixes in the index. This means we don't need to store duplicate names, email addresses, and subjects. This also adds the stemmed attachment filenames to the default (non-prefixed) search. We're storing a subset of the da

[sup-devel] RFC: Nuke remote sources

2010-01-17 Thread Rich Lane
Every few days someone joins the IRC channel complaining of poor performance or bugs with IMAP sources, and we have to tell them to use offlineimap or fetchmail instead. This is embarrassing. There are likely many more users who don't bother to ask on IRC and either unhappily tolerate IMAP or give

[sup-devel] [PATCH 3/3] simplify sup-add

2010-01-17 Thread Rich Lane
--- bin/sup-add | 40 1 files changed, 0 insertions(+), 40 deletions(-) diff --git a/bin/sup-add b/bin/sup-add index 059a4e2..e354ea8 100755 --- a/bin/sup-add +++ b/bin/sup-add @@ -30,50 +30,10 @@ EOS opt :unusual, "Do not automatically poll these sou

[sup-devel] [PATCH 1/3] remove mbox+ssh source

2010-01-17 Thread Rich Lane
--- README.txt |1 - Rakefile |1 - bin/sup-add|8 -- bin/sup-config | 13 --- doc/NewUserGuide.txt |1 - lib/sup/mbox.rb|2 - lib/sup/mbox/ssh-file.rb | 254 ---

[sup-devel] [PATCH 2/3] remove imap source

2010-01-17 Thread Rich Lane
--- README.txt | 10 +-- bin/sup-add |9 -- bin/sup-config | 21 --- bin/sup-recover-sources | 13 +-- doc/FAQ.txt |8 +- doc/NewUserGuide.txt| 21 +-- lib/sup.rb |1 - lib/sup/imap.rb | 349 ---

Re: [sup-devel] [PATCH] Saved Search Support

2010-01-19 Thread Rich Lane
Excerpts from Eric Sherman's message of 2010-01-18 18:44:37 -0500: > Start an index search with a \ backslash and press enter to get a list > of searches that were previously saved from search-results-mode with % > percent or added from search-list-mode directly. Saved searches may be > used in ot

[sup-devel] [PATCH] asciify untrusted strings before displaying in TextMode

2010-01-19 Thread Rich Lane
--- lib/sup/modes/file-browser-mode.rb |2 +- lib/sup/modes/text-mode.rb |2 +- lib/sup/modes/thread-view-mode.rb |4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/sup/modes/file-browser-mode.rb b/lib/sup/modes/file-browser-mode.rb index b92468d..72e

Re: [sup-devel] [PATCHv2] Saved Search Support

2010-01-19 Thread Rich Lane
Excerpts from Eric Sherman's message of 2010-01-19 22:48:50 -0500: > There is no nesting limit and searches are always expanded completely > before they are turned into proper queries for the index. What do you think about doing the expansion in Index.parse_query, right after the custom-search hoo

[sup-devel] [PATCH] copy thread when spawning ThreadViewMode

2010-01-21 Thread Rich Lane
Currently ThreadIndexMode just passes a reference to the selected thread when spawning a ThreadViewMode. This is a problem because as long as the original ThreadIndexMode is alive that thread will be updated with new messages, but ThreadViewMode will not display them. This can lead to the user unkn

[sup-devel] [PATCH] fix textfield truncation

2010-01-21 Thread Rich Lane
Long query strings (for example) are (for some people) silently truncated. Other people have seen large amounts of whitespace inserted at word boundaries. These issues are caused by using a multiline text field. This patch uses a single-line dynamically growable textfield instead. It also disables

[sup-devel] [PATCH] configurable color highlights

2010-01-22 Thread Rich Lane
Adds a :highlight key to the color entries in colors.yaml that names another color to be used for highlighting. --- lib/sup/colormap.rb | 18 ++ 1 files changed, 14 insertions(+), 4 deletions(-) diff --git a/lib/sup/colormap.rb b/lib/sup/colormap.rb index 6f21f9a..aeb3818 100644

[sup-devel] [PATCH] enable ruby-prof with SUP_PROFILE environment variable

2010-01-23 Thread Rich Lane
If SUP_PROFILE is set, it's used as the filename to dump profiling output which you can use kcachegrind to inspect. --- bin/sup | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/bin/sup b/bin/sup index 7824aca..f7c4af7 100755 --- a/bin/sup +++ b/bin/sup @@ -14,6 +1

[sup-devel] [PATCH] dont check thread-index-mode dirtiness on every keypress

2010-01-23 Thread Rich Lane
Now that changes are instantly written to the index it's unnecessary to put the "modified" message in the status line. Removing this cuts the time for a simple action like moving the cursor by 75% or more, depending on the number of messages loaded. --- lib/sup/modes/thread-index-mode.rb |2 +-

[sup-devel] [PATCH] dont restrict colors to those in Colormap::DEFAULT_COLORS

2010-01-24 Thread Rich Lane
This is necessary for user-created highlight colors. A side effect is that invalid color names now default to ugly red/green instead of what was in DEFAULT_COLORS, which seems more useful for debugging colormap problems. Also remove the redundant warnings. --- lib/sup/colormap.rb | 58 ++

[sup-devel] [PATCH 2/3] add keymap rebinding support

2010-01-24 Thread Rich Lane
Keymap#delete removes an existing keybinding and Keymap#add! deletes existing bindings to the given keys before adding new ones. Keymap#add_multi now allows adding new bindings to an existing submap. --- lib/sup/keymap.rb | 27 --- 1 files changed, 24 insertions(+), 3 del

[sup-devel] [PATCH 3/3] keybindings hook

2010-01-24 Thread Rich Lane
Add a hook specifically for custom keybindings. The advantage of this over the startup hook is that we can assume it's safe to reload this one while Sup is running. The "modes" variable provides a debatably-useful mapping between user-visible mode names and the actual classes, for use with class_ev

[sup-devel] [PATCH 1/3] make mode keymap easily accessible to hooks

2010-01-24 Thread Rich Lane
--- lib/sup/mode.rb |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/lib/sup/mode.rb b/lib/sup/mode.rb index c8ad0cc..b9e0698 100644 --- a/lib/sup/mode.rb +++ b/lib/sup/mode.rb @@ -10,6 +10,10 @@ class Mode @@keymaps[self] = keymap end + def self.keymap +@

[sup-devel] [PATCH] fix participants queries

2010-01-25 Thread Rich Lane
--- lib/sup/xapian_index.rb |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib/sup/xapian_index.rb b/lib/sup/xapian_index.rb index 5efd47b..443b88d 100644 --- a/lib/sup/xapian_index.rb +++ b/lib/sup/xapian_index.rb @@ -407,7 +407,7 @@ EOS pos_terms << mkterm(:source

Re: [sup-devel] [PATCH] copy thread when spawning ThreadViewMode

2010-01-25 Thread Rich Lane
This breaks ThreadIndexMode#launch_another_thread. I'll send a new patch. ___ Sup-devel mailing list Sup-devel@rubyforge.org http://rubyforge.org/mailman/listinfo/sup-devel

[sup-devel] [PATCH] fix missing parentheses warning

2010-01-25 Thread Rich Lane
--- lib/sup/message.rb |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/sup/message.rb b/lib/sup/message.rb index 3e55de5..a85cc0d 100644 --- a/lib/sup/message.rb +++ b/lib/sup/message.rb @@ -450,9 +450,9 @@ private subj = decode_header_field(payload.heade

Re: [sup-devel] Fwd: Re: Sup 0.10 released

2010-01-25 Thread Rich Lane
Excerpts from William Morgan's message of 2010-01-25 16:19:13 -0500: > I'm seeing a weird behavior with the xapian-full gem, and so is this > guy. The installation claims it fails, but it actually succeeds. The > spec file is not copied over after installation, so `gem list` doesn't > show it, but

Re: [sup-devel] Fwd: Re: Sup 0.10 released

2010-01-25 Thread Rich Lane
Excerpts from Rich Lane's message of 2010-01-25 17:05:49 -0500: > Excerpts from William Morgan's message of 2010-01-25 16:19:13 -0500: > > I'm seeing a weird behavior with the xapian-full gem, and so is this > > guy. The installation claims it fails, but it actually succeeds. The > > spec file is n

Re: [sup-devel] Fwd: Re: Sup 0.10 released

2010-01-25 Thread Rich Lane
Excerpts from Mark Alexander's message of 2010-01-25 19:21:14 -0500: > On Mon, Jan 25, 2010 at 6:37 PM, Rich Lane wrote: > > I think I fixed it. Please try xapian-full 1.1.3.1 from gemcutter. > > Can you describe what you did to fix it? I spent several hours > trying t

Re: [sup-devel] [issue53] Error if the composed text has tabs in the first character

2010-01-27 Thread Rich Lane
Excerpts from Mark Alexander's message of 2010-01-27 16:57:33 -0500: > I've been noticing this problem for a long time now. > I think it happens with tabs anywhere in the > message, or perhaps at the beginning of lines, > but I haven't played with it enough to know for sure. Sup assumes that 1 cod

Re: [sup-devel] [issue59] gem install sup on osx 10.6 fails due to .bundle instead of .so being built in xapian-full

2010-01-31 Thread Rich Lane
Excerpts from anonymous's message of 2010-01-31 16:38:24 -0500: > > New submission from anonymous: > > on a default os X 10.6 machine (after updating rubygems) doing a 'gem sup > install' fails: > > The problem is xapian-full is making a .bundle instead of a .so. It's easy to > change to make a

[sup-devel] updated edge branch

2010-02-21 Thread Rich Lane
There are a bunch of patches that haven't been merged to mainline yet, so I merged them to my edge branch. I didn't look too hard at them so don't assume that this branch could be merged to mainline as-is. git://github.com/rlane/sup.git git log --no-merges --abbrev-commit --pretty=oneline mainlin

Re: [sup-devel] [PATCH] I can haz moar hooks: attachment-mentioned, index-mode-date-widget

2010-02-21 Thread Rich Lane
Excerpts from Tero Tilus's message of 2010-01-21 20:32:00 -0500: > William Morgan, 2009-12-21 15:38: > > Reformatted excerpts from Tero Tilus's message of 2009-12-19: > > > The detect-missing-attachment hook is pretty self evident but what you > > > had in mind for the dates? Formatter for the thr

Re: [sup-devel] sup for sale

2010-02-25 Thread Rich Lane
I'm willing to do it. I've been working on other projects lately, but I can make time for Sup. I created accounts (rlane) at gitorious and rubyforge. ___ Sup-devel mailing list Sup-devel@rubyforge.org http://rubyforge.org/mailman/listinfo/sup-devel

Re: [sup-devel] [PATCH] Implement inline GPG

2010-02-26 Thread Rich Lane
Excerpts from Michael Stapelberg's message of 2010-02-18 06:40:45 -0500: > Hi, > > as my previous patch was not merged, I have updated the patch to apply against > the current code. Furthermore, it now correctly handles character sets for the > GPG encrypted part. > > The patch has been tested by

[sup-devel] merged into master: colors, xapian-updates, saved-search

2010-02-26 Thread Rich Lane
Also some random stray diffs that had accumulated in next. ___ Sup-devel mailing list Sup-devel@rubyforge.org http://rubyforge.org/mailman/listinfo/sup-devel

Re: [sup-devel] [PATCH 3/3] keybindings hook

2010-02-26 Thread Rich Lane
Branch keybindings, merged into next. ___ Sup-devel mailing list Sup-devel@rubyforge.org http://rubyforge.org/mailman/listinfo/sup-devel

Re: [sup-devel] [PATCH] fix textfield truncation

2010-02-26 Thread Rich Lane
Applied to master. ___ Sup-devel mailing list Sup-devel@rubyforge.org http://rubyforge.org/mailman/listinfo/sup-devel

Re: [sup-devel] [PATCH] enable ruby-prof with SUP_PROFILE environment variable

2010-02-26 Thread Rich Lane
Applied to master. ___ Sup-devel mailing list Sup-devel@rubyforge.org http://rubyforge.org/mailman/listinfo/sup-devel

Re: [sup-devel] [PATCH] catch xapian query parser exceptions and display them to the user

2010-02-26 Thread Rich Lane
Applied to master. ___ Sup-devel mailing list Sup-devel@rubyforge.org http://rubyforge.org/mailman/listinfo/sup-devel

Re: [sup-devel] [PATCH] dont check thread-index-mode dirtiness on every keypress

2010-02-26 Thread Rich Lane
Applied to master. ___ Sup-devel mailing list Sup-devel@rubyforge.org http://rubyforge.org/mailman/listinfo/sup-devel

Re: [sup-devel] [PATCH] prevent "year too big to marshal" crashes

2010-02-26 Thread Rich Lane
Applied to master. ___ Sup-devel mailing list Sup-devel@rubyforge.org http://rubyforge.org/mailman/listinfo/sup-devel

Re: [sup-devel] [PATCH] dont restrict colors to those in Colormap::DEFAULT_COLORS

2010-02-26 Thread Rich Lane
Branch highlights, merged to next. ___ Sup-devel mailing list Sup-devel@rubyforge.org http://rubyforge.org/mailman/listinfo/sup-devel

Re: [sup-devel] [PATCH] show (recipients) instead of lone "me"

2010-02-27 Thread Rich Lane
Applied to master. ___ Sup-devel mailing list Sup-devel@rubyforge.org http://rubyforge.org/mailman/listinfo/sup-devel

Re: [sup-devel] [PATCHv3] idle and unidle updates

2010-02-27 Thread Rich Lane
Branch idle, merged to next. ___ Sup-devel mailing list Sup-devel@rubyforge.org http://rubyforge.org/mailman/listinfo/sup-devel

Re: [sup-devel] [PATCH] flush index on idle

2010-02-27 Thread Rich Lane
Branch idle, merged to next. ___ Sup-devel mailing list Sup-devel@rubyforge.org http://rubyforge.org/mailman/listinfo/sup-devel

Re: [sup-devel] [PATCH] I can haz moar hooks: attachment-mentioned, index-mode-date-widget

2010-02-27 Thread Rich Lane
Branch mentions-attachments-hook, merged into next. ___ Sup-devel mailing list Sup-devel@rubyforge.org http://rubyforge.org/mailman/listinfo/sup-devel

Re: [sup-devel] [PATCHv5] [issue14] poll updates accumulate while idle

2010-02-27 Thread Rich Lane
Branch idle, merged to next. ___ Sup-devel mailing list Sup-devel@rubyforge.org http://rubyforge.org/mailman/listinfo/sup-devel

Re: [sup-devel] [PATCH] Bugfix: Create dynamically growing fields (long filenames are now supported)

2010-02-27 Thread Rich Lane
Excerpts from Michael Stapelberg's message of 2010-02-15 17:13:00 -0500: > Hi, > > the attached patch modifies textfield.rb to create a dynamically growable > field > instead of one with a fixed size. The text field can now hold a dynamic amount > of characters which is often necessary if you hav

Re: [sup-devel] [PATCH] Bugfix: Don\xe2\x80\x99t call Ncurses.getch when in shell\x96out mode

2010-02-27 Thread Rich Lane
Excerpts from Michael Stapelberg's message of 2010-02-18 22:26:37 -0500: > Hi, > > (at least for me) the attached patch finally fixes the pinentry-ncurses > problems we were still having (as soon as you press a key, the screen is > garbage). > > To quote the commit message: > > Previously, whe

Re: [sup-devel] [PATCH] Publish hook

2010-02-27 Thread Rich Lane
Branch publish-hook, merged to next. ___ Sup-devel mailing list Sup-devel@rubyforge.org http://rubyforge.org/mailman/listinfo/sup-devel

Re: [sup-devel] [PATCH] I can haz moar hooks: attachment-mentioned, index-mode-date-widget

2010-02-27 Thread Rich Lane
Branch date-widget-hook, merged to next. ___ Sup-devel mailing list Sup-devel@rubyforge.org http://rubyforge.org/mailman/listinfo/sup-devel

Re: [sup-devel] [PATCH] Make automatic jumping to first/next open message configurable

2010-02-27 Thread Rich Lane
Applied to master. ___ Sup-devel mailing list Sup-devel@rubyforge.org http://rubyforge.org/mailman/listinfo/sup-devel

Re: [sup-devel] [PATCH] in thread-view-mode, doubling up on the multi-keys now DTRT

2010-02-27 Thread Rich Lane
Applied to master. ___ Sup-devel mailing list Sup-devel@rubyforge.org http://rubyforge.org/mailman/listinfo/sup-devel

Re: [sup-devel] [PATCH] Add config option to limit text wrapping width

2010-02-27 Thread Rich Lane
Applied to master. ___ Sup-devel mailing list Sup-devel@rubyforge.org http://rubyforge.org/mailman/listinfo/sup-devel

Re: [sup-devel] [PATCH] Add hook gpg-args to allow the user to add/remove flags

2010-02-27 Thread Rich Lane
Applied to master. ___ Sup-devel mailing list Sup-devel@rubyforge.org http://rubyforge.org/mailman/listinfo/sup-devel

Re: [sup-devel] [issue73] Missing dependency "sup/idle"

2010-02-27 Thread Rich Lane
Excerpts from anonymous's message of 2010-02-27 08:05:58 -0500: > Now, I don't know my way around ruby and i am no git guru, so maybe > this is my fault, but my guess is the file has been forgotten to be > added? Yep, I forgot to add the file. Sorry about that. Should be fixed now. ___

  1   2   3   >