Re: [PATCH/RFC] Re: logpipe error handling patch

2014-08-08 Thread Gerrit Pape
On Thu, Aug 07, 2014 at 11:39:08AM +0200, Jan Pobrislo wrote: > On Fri, 1 Aug 2014 05:32:16 + > Gerrit Pape wrote: > > On Wed, Jul 30, 2014 at 03:01:16PM +0200, Jan Pobrislo wrote: > > > I was under the assumption that the pipe is left open so you can > > > send signals in case the supervised

Re: [PATCH/RFC] Re: logpipe error handling patch

2014-08-07 Thread Jan Pobrislo
On Fri, 1 Aug 2014 05:32:16 + Gerrit Pape wrote: > On Wed, Jul 30, 2014 at 03:01:16PM +0200, Jan Pobrislo wrote: > > I was under the assumption that the pipe is left open so you can > > send signals in case the supervised processes have trouble exiting > > the normal way. > > The service stop

[PATCH/RFC] Re: logpipe error handling patch

2014-07-31 Thread Gerrit Pape
On Wed, Jul 30, 2014 at 03:01:16PM +0200, Jan Pobrislo wrote: > On Wed, 30 Jul 2014 00:37:47 +0100 > Laurent Bercot wrote: > > At this point, the service is > > dysfunctional and there's no way to recover it: so runsv should not > > be accepting commands anymore, and close its control pipe instead

Re: logpipe error handling patch

2014-07-30 Thread Jan Pobrislo
On Wed, 30 Jul 2014 00:37:47 +0100 Laurent Bercot wrote: > On 29/07/2014 20:59, Jan Pobrislo wrote: > > There are two possible resolutions - either make runsv create new > > pipe when asked to start up again or make it die since it's unable > > to spawn a child. > > Actually, there's only one

Re: logpipe error handling patch

2014-07-29 Thread Laurent Bercot
On 29/07/2014 20:59, Jan Pobrislo wrote: There are two possible resolutions - either make runsv create new pipe when asked to start up again or make it die since it's unable to spawn a child. Actually, there's only one possible resolution. When runsv is told to exit, it kills the service and

RE: logpipe error handling patch

2014-07-29 Thread James Powell
Thanks Jan. I'll try Gerrit's git repository first to see if it has any further updates before I use the patch. > Date: Tue, 29 Jul 2014 22:44:51 +0200 > From: c...@webprojekty.cz > To: supervision@list.skarnet.org > Subject: Re: logpipe error handling patch > >

Re: logpipe error handling patch

2014-07-29 Thread Jan Pobrislo
On Tue, 29 Jul 2014 13:08:37 -0700 James Powell wrote: > Yeah its a workaround but I've implemented it anyway in my LFS hint > to be sure it works right. > > If you don't mind me asking Jan, can I host it on the runit-for-LFS > project on GoogleCode? Sure, go ahead if you want. I think it's bet

Re: logpipe error handling patch

2014-07-29 Thread Jan Pobrislo
Wrote a quick mockup for restoring the pipe (untested, may eat your pet). I suppose there'll be better places to do pipe initialization at, if you want to go this route, but this one ought to work.diff --git a/src/runsv.c b/src/runsv.c index ecf4677..991e211 100644 --- a/src/runsv.c +++ b/src/runsv

RE: logpipe error handling patch

2014-07-29 Thread James Powell
ebprojekty.cz> Sent: ‎7/‎29/‎2014 1:00 PM To: supervision@list.skarnet.org<mailto:supervision@list.skarnet.org> Subject: Re: logpipe error handling patch On Tue, 29 Jul 2014 15:22:36 + Gerrit Pape wrote: > Thanks for the patch, but it works around the bug and doesn't fix it

Re: logpipe error handling patch

2014-07-29 Thread Jan Pobrislo
On Tue, 29 Jul 2014 15:22:36 + Gerrit Pape wrote: > Thanks for the patch, but it works around the bug and doesn't fix its > root cause. There are two possible resolutions - either make runsv create new pipe when asked to start up again or make it die since it's unable to spawn a child. My p

Re: logpipe error handling patch

2014-07-29 Thread Gerrit Pape
On Sat, Jul 26, 2014 at 10:44:18AM +0200, c...@webprojekty.cz wrote: > Hello, I wrote a patch for how broken filedescriptors when creating child > are handled. Currently only the child dies, leaving non-working instance of > runsv in place. My patch makes it kill the parent so the runsv process can