Re: [Suspend-devel] Reordering in resume 0/2

2007-01-23 Thread Tim Dijkstra
On Tue, 23 Jan 2007 10:08:44 +0100 Stefan Seyfried <[EMAIL PROTECTED]> wrote: > On Mon, Jan 22, 2007 at 11:43:21PM +0100, Tim Dijkstra wrote: > > Hi, > > > First patch is somewhat unrelated. While fixing this I was trying to > > get the logic of read_image(). The last part is unnecessary complex.

Re: [Suspend-devel] Reordering in resume 0/2

2007-01-23 Thread Stefan Seyfried
On Mon, Jan 22, 2007 at 11:43:21PM +0100, Tim Dijkstra wrote: > Hi, > First patch is somewhat unrelated. While fixing this I was trying to > get the logic of read_image(). The last part is unnecessary complex. The > if(!error || !ret) should always be true. The only reason I can think > of is rebo

Re: [Suspend-devel] Reordering in resume 0/2

2007-01-23 Thread Pavel Machek
Hi! > First patch is somewhat unrelated. While fixing this I was trying to > get the logic of read_image(). The last part is unnecessary complex. The > if(!error || !ret) should always be true. The only reason I can think > of is reboot() failing. This patch just removes that `if' and adds > some

[Suspend-devel] Reordering in resume 0/2

2007-01-22 Thread Tim Dijkstra
Hi, I got some bug reports and unwanted behavior by resume. The problem boiled down to the fact that resume treats 'no image in partition' as a regular, while it is of course expected behavior on a normal boot. Some symptoms that will be fixed by these patches - resume sets console loglevel to so