On Sun, 27 Oct 2013, Ian Lepore wrote:
Log:
Remove the last dregs of trapframe_t. It turns out only arm was using
this type, so remove it to make arm code more consistant with other
platforms. Thanks to bde@ for pointing out only arm used trapframe_t.
Thanks.
Bruce
On Sun, 27 Oct 2013, Ian Lepore wrote:
On Mon, 2013-10-28 at 04:42 +1100, Bruce Evans wrote:
On Sun, 27 Oct 2013, Ian Lepore wrote:
Log:
Eliminate a compiler warning about extraneous parens.
Wow, what flags give these warnings?
--- busdma_machdep.o ---
/local/build/staging/freebsd/dp10
On Tue, 15 Oct 2013, Kevin Lo wrote:
Log:
Treat INADDR_NONE as uint32_t.
Reviewed by: glebius
Modified:
head/sys/netinet/in.h
Modified: head/sys/netinet/in.h
==
--- head/sys/netinet/in.h Tue Oct 15
On Thu, 12 Sep 2013, Bryan Drewery wrote:
On 9/12/2013 6:36 AM, Hiroki Sato wrote:
Bryan Drewery bdrew...@freebsd.org wrote
in 201309120053.r8c0rc7h082...@svn.freebsd.org:
bd Author: bdrewery (ports committer)
bd Date: Thu Sep 12 00:53:38 2013
bd New Revision: 255486
bd URL:
On Thu, 29 Aug 2013, Sergey Kandaurov wrote:
On 22 August 2013 14:51, Bruce Evans b...@optusnet.com.au wrote:
expand_number() remains a very badly designed and implemented function.
Its design errors start with its name. It doesn't expand numbers. It
...
[...]
Some of the other bugs
On Wed, 21 Aug 2013, Jilles Tjoelker wrote:
On Thu, Aug 22, 2013 at 01:24:13AM +0400, Sergey Kandaurov wrote:
On Wed, Aug 21, 2013 at 10:27:25PM +0200, Jilles Tjoelker wrote:
On Wed, Aug 21, 2013 at 11:03:10PM +0400, Sergey Kandaurov wrote:
On Wed, Aug 21, 2013 at 09:21:47PM +0400, Andrey
On Thu, 22 Aug 2013, [utf-8] Dag-Erling Sm??rgrav wrote:
Dag-Erling Sm??rgrav d...@des.no writes:
This breaks the build in usr.bin/expr because expr.y already provides a
prototype, and gcc does not accept multiple prototypes, even if they're
identical. That is arguably a bug in gcc,
ISTR
On Thu, 22 Aug 2013, [utf-8] Dag-Erling Sm??rgrav wrote:
Bruce Evans b...@optusnet.com.au writes:
Dag-Erling Sm??rgrav d...@des.no writes:
Oh, it's actually our own fault for including -Wredundant-decls in
CFLAGS. Is there a good reason to keep it?
How else would you detect bogus
On Wed, 14 Aug 2013, Dimitry Andric wrote:
On Aug 13, 2013, at 20:39, Pedro F. Giffuni p...@freebsd.org wrote:
Log:
ext2fs: update format specifiers for ext4 type.
This is still quite broken.
Modified: head/sys/fs/ext2fs/ext2_subr.c
On Thu, 8 Aug 2013, Ulrich [utf-8] Sp??rlein wrote:
On Fri, 2013-07-26 at 15:53:43 +, Dag-Erling Smrgrav wrote:
Modified: head/lib/libfetch/common.c
==
--- head/lib/libfetch/common.c Fri Jul 26 14:43:38 2013
On Wed, 7 Aug 2013, Hiroki Sato wrote:
Ian Lepore i...@freebsd.org wrote
in 1375807689.3320.48.ca...@revolution.hippie.lan:
ia On Tue, 2013-08-06 at 15:49 +, Hiroki Sato wrote:
ia /* Generate maximum time in timespec. */
ia - memset(tm_max.tv_sec, 0xff, sizeof(tm_max.tv_sec));
ia
On Tue, 30 Jul 2013, Sergey Kandaurov wrote:
Log:
Fix up paths after r253790.
While here, use $? contraction.
Reported by: O. Hartmann
Modified:
head/sys/modules/usb/runfw/Makefile
Modified: head/sys/modules/usb/runfw/Makefile
On Mon, 29 Jul 2013, Andrey Zonov wrote:
Log:
Unbreak sysctl ABI changes introduced in r253662
Requested by: bde
Thanks.
Bruce
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send
On Tue, 30 Jul 2013, David O'Brien wrote:
On Wed, Jul 24, 2013 at 03:29:34PM -0400, John Baldwin wrote:
On Wednesday, July 24, 2013 2:32:15 pm David E. O'Brien wrote:
per style(9):
Kernel include files (i.e. sys/*.h) come first; normally, include
sys/types.h OR sys/param.h, but
On Mon, 29 Jul 2013, David Chisnall wrote:
Author: theraven
Date: Mon Jul 29 08:32:13 2013
New Revision: 253764
URL: http://svnweb.freebsd.org/changeset/base/253764
Log:
Reenable the isnan(double) / isinf(double) declarations when targeting C89 +
SUSv2 mode.
This isn't reenabling. but
On Mon, 29 Jul 2013, David Schultz wrote:
On Thu, Jul 11, 2013, David Chisnall wrote:
+static __inline int
+__inline_isnan(double __x)
+{
+
+ return (__x != __x);
+}
+
+static __inline int
+__inline_isnanf(float __x)
+{
+
+ return (__x != __x);
+}
+
+static __inline int
On Mon, 29 Jul 2013, David Chisnall wrote:
Bruce,
It's very difficult within this verbiage to work out what you believe the
correct code should look like. Please either provide a patch or commit the fix
yourself.
I prefer to give details.
[Context lost to top posting.]
Bruce
On Fri, 26 Jul 2013, Juli Mallett wrote:
On Fri, Jul 26, 2013 at 2:26 PM, Andrey Zonov z...@freebsd.org wrote:
On 7/26/13 8:09 AM, Jilles Tjoelker wrote:
As noted in mail from Bruce Evans, please preserve the ABI of
VM_SWAPPING_ENABLED here.
I don't think it's a big problem. Internally we
On Sat, 27 Jul 2013, Andrey Zonov wrote:
On 7/27/13 12:47 AM, Bruce Evans wrote:
...
Especially since the main reason numbered sysctls exist is to support old
binaries (and sources) that use them.
Does it look OK?
It looks functionally OK, but ugly.
diff --git a/sys/vm/vm_param.h b/sys
On Thu, 25 Jul 2013, Alan Cox wrote:
On Jul 25, 2013, at 3:40 PM, Andrey Zonov wrote:
On 7/23/13 6:25 PM, Jeff Roberson wrote:
Author: jeff
Date: Wed Jul 24 01:25:56 2013
New Revision: 253587
URL: http://svnweb.freebsd.org/changeset/base/253587
Log:
- Remove the long obsolete
On Thu, 25 Jul 2013, Marko Zec wrote:
On Thursday 25 July 2013 10:07:58 Marius Strobl wrote:
On Mon, Jul 15, 2013 at 01:32:55AM +, Craig Rodrigues wrote:
Author: rodrigc
Date: Mon Jul 15 01:32:55 2013
New Revision: 253346
URL: http://svnweb.freebsd.org/changeset/base/253346
Log:
PR:
On Thu, 25 Jul 2013, David Chisnall wrote:
On 25 Jul 2013, at 09:11, Hans Petter Selasky h...@bitfrost.no wrote:
The structure looks like some size, so bzero() might run faster than memset()
depending on the compiler settings. Should be profiled before changed!
They will generate identical
On Wed, 24 Jul 2013, John Baldwin wrote:
On Wednesday, July 24, 2013 2:32:15 pm David E. O'Brien wrote:
Author: obrien
Date: Wed Jul 24 18:32:15 2013
New Revision: 253618
URL: http://svnweb.freebsd.org/changeset/base/253618
Log:
per style(9):
Kernel include files (i.e. sys/*.h) come
On Thu, 18 Jul 2013, Kevin Lo wrote:
Log:
Replace PRId64 with jd in a printf call. Cast the corresponding value to
intmax_t, because the original type is off_t.
Reported by: bde
Thanks, but it still includes inttypes.h for the definition of PRId64.
Use of inttypes.h instead of stdint.h
On Wed, 17 Jul 2013, Kevin Lo wrote:
Log:
Use PRId64 instead of %gd to print an int64_t.
This is a different printf format error, and a style bug.
Printf format errors:
commit log: %gd doesn't exist. You mean %qd
old: file_size has type off_t, but was printed using %qd. off_t is only
On Tue, 16 Jul 2013, John Baldwin wrote:
On Monday, July 15, 2013 11:40:58 am Andrey V. Elsukov wrote:
Log:
Include sys/systm.h after sys/param.h.
Suggested by: pluknet
Does this fix something?
Style bugs at least. sys/systm.h defines APIs which may be used in
other headers (in
On Sat, 13 Jul 2013, Tijl Coosemans wrote:
On 2013-07-12 11:14, Bruce Evans wrote:
On Thu, 11 Jul 2013, Tijl Coosemans wrote:
On 2013-07-11 22:03, Tijl Coosemans wrote:
...
isnan(double) is part of SUSv2. It should be visible when compiling with
-D_XOPEN_SOURCE=500. I think you need
On Thu, 11 Jul 2013, David Chisnall wrote:
On 11 Jul 2013, at 19:52, Tijl Coosemans t...@coosemans.org wrote:
GCC doesn't support _Generic yet for -std=c11.
Ugh. Given that they also lack a fine-grained feature check mechanism, they
really should not advertise support for a language
On Thu, 11 Jul 2013, Tijl Coosemans wrote:
On 2013-07-11 22:03, Tijl Coosemans wrote:
On 2013-07-11 21:36, David Chisnall wrote:
On 11 Jul 2013, at 19:52, Tijl Coosemans t...@coosemans.org wrote:
@@ -227,8 +250,6 @@ double expm1(double);
double fma(double, double, double);
double
On Mon, 8 Jul 2013, Aleksandr Rybalko wrote:
On Mon, 1 Jul 2013 11:56:25 +1000 (EST)
Bruce Evans b...@optusnet.com.au wrote:
On Sun, 30 Jun 2013, Aleksandr Rybalko wrote:
Log:
Decrypt magic numbers - define names for fields of Generic Timer's CNTKCTL reg.
Submitted by: Ruslan Bukin b
On Tue, 9 Jul 2013, Andriy Gapon wrote:
Log:
should_yield: protect from td_swvoltick being uninitialized or too stale
The distance between ticks and td_swvoltick should be calculated as
an unsigned number. Previously we could end up comparing a negative
number with hogticks in which case
On Tue, 9 Jul 2013, Jim Harris wrote:
On Sat, Jul 6, 2013 at 7:26 PM, Bruce Evans b...@optusnet.com.au wrote:
On Sat, 6 Jul 2013, Jilles Tjoelker wrote:
On Sat, Jul 06, 2013 at 08:42:49PM +0200, Pawel Jakub Dawidek wrote:
[]* ...
Bruce, until sysexits(3) doesn't explicitly say
On Mon, 8 Jul 2013, Pedro F. Giffuni wrote:
Log:
Avoid a panic and return EINVAL instead.
Merge from UFS r232692:
syscall() fuzzing can trigger this panic.
This breaks the assertion without fixing the bug.
I don't know what is in the inscrutable reference r232692, but UFS doesn't
exist,
On Tue, 9 Jul 2013, Pedro F. Giffuni wrote:
Author: pfg
Date: Tue Jul 9 01:31:04 2013
New Revision: 253050
URL: http://svnweb.freebsd.org/changeset/base/253050
Log:
Enhancement when writing an entire block of a file.
Merge from UFS r231313:
This change first attempts the uiomove() to
On Tue, 9 Jul 2013, Bruce Evans wrote:
On Tue, 9 Jul 2013, Pedro F. Giffuni wrote:
...
Log:
Enhancement when writing an entire block of a file.
Merge from UFS r231313:
...
Oops, I didn't mean to reply to that (it seemed to be correct :-), and
just quoted it all.
Bruce
One minor interjection and I'll butt out of the discussion...
In another thread involving Pawel, phk campaigns against errno and asks
for error strings (even if they are only in English). Using perror()
did this long ago for program termination, and using the err() family
does it
On Sat, 6 Jul 2013, Jilles Tjoelker wrote:
On Sat, Jul 06, 2013 at 08:42:49PM +0200, Pawel Jakub Dawidek wrote:
On Thu, Jul 04, 2013 at 11:44:28AM +1000, Bruce Evans wrote:
Many style bugs are visible in this patch:
[...]
- sysexits.h is used
[...]
Bruce, until sysexits(3) doesn't
On Thu, 4 Jul 2013, Andrey Chernov wrote:
On 04.07.2013 6:47, Bruce Evans wrote:
Er, I think it is too dangerous to change either RAND_MAX or the offset
without more preparation:
- increasing the range returned (and increasing RAND_MAX to match) would
obviously be binary-incompatible. Old
On Thu, 4 Jul 2013, Jim Harris wrote:
Log:
Fix printf argument mismatch reported by gcc on i386.
This just substitutes one printf format with another.
Modified: head/sbin/nvmecontrol/firmware.c
==
---
On Wed, 3 Jul 2013, Andrey A. Chernov wrote:
Log:
1) POSIX requires rand(3) return values to be in the [0, RAND_MAX] range,
but ACM formula we use have internal state (and return value) in the
[1, 0x7ffe] range, so our RAND_MAX (0x7fff) is never reached
because it is off by one,
On Tue, 2 Jul 2013, Bruce Evans wrote:
...
Also, random(9) is internally broken on 64-bit arches. It shouldn't
exist. It is not random() at all, but just rand() with the clamp to
RAND_MAX removed. Its linear congruential generator is suboptimal
for 64 bits, and other parts of its algorithm
On Tue, 2 Jul 2013, Andrey Chernov wrote:
On 02.07.2013 11:39, Bruce Evans wrote:
The bugs are a little different than I said above. There is no overflow
problem and no problem with invalid values being produces, since the
algorithm from ACM is careful to do everything with 32 bit signed
On Tue, 2 Jul 2013, Kirk McKusick wrote:
Log:
Make better use of metadata area by avoiding using it for data blocks
that no should no longer immediately follow their indirect blocks.
I use the following changes for allocation at the start of cylinder group.
They seem to be related.
% diff
On Tue, 2 Jul 2013, Andriy Gapon wrote:
on 02/07/2013 20:52 Attilio Rao said the following:
I was just pointing out that the real bug is not in the subtraction
itself but on the hogticks comparison.
This is because hogticks is not an absolute measurement but it
represents really a ticks
On Wed, 3 Jul 2013, Andrey Chernov wrote:
On 02.07.2013 20:33, Bruce Evans wrote:
I checked the values returned by rand(). The ACM part works as
intended, so it never returns RAND_MAX. It also never returns 0. So
the distribution of values in the documented range [0, RAND_MAX] is
very non
On Mon, 1 Jul 2013, Pedro F. Giffuni wrote:
Log:
Change i_gen in UFS to an unsigned type.
Further simplify the i_gen calculation for older disks.
Having a zero here is not really a problem and this is more
similar to what is done in newfs_random().
This seems to be a minor problem.
On Mon, 1 Jul 2013, Pedro F. Giffuni wrote:
Log:
Change i_gen in UFS to an unsigned type.
Revert the simplification of the i_gen calculation.
It is still a good idea to avoid zero values and for the case
of old filesystems there is probably no advantage in using
the complete 32 bits
On Sun, 30 Jun 2013, Aleksandr Rybalko wrote:
Log:
Decrypt magic numbers - define names for fields of Generic Timer's CNTKCTL reg.
Submitted by: Ruslan Bukin b...@bsdpad.com
Modified:
head/sys/arm/arm/generic_timer.c
Modified: head/sys/arm/arm/generic_timer.c
On Wed, 26 Jun 2013, Gleb Smirnoff wrote:
On Wed, Jun 26, 2013 at 11:42:39AM +1000, Bruce Evans wrote:
B Anyway, as Gleb said, there is no point in
B optimizing the i386 kernel.
B
B I said that there is every point in optimizing the i386 kernel. This
B applies even more to other 32-bit
On Tue, 25 Jun 2013, Gleb Smirnoff wrote:
On Mon, Jun 24, 2013 at 11:16:33PM +1000, Bruce Evans wrote:
B K This is quite interesting idea, but I still did not decided if it
B K acceptable. The issue is that we could add the carry to the other
B K processor counter, if the preemption kicks
On Tue, 25 Jun 2013, Konstantin Belousov wrote:
On Tue, Jun 25, 2013 at 08:14:41PM +1000, Bruce Evans wrote:
On Tue, 25 Jun 2013, Konstantin Belousov wrote:
Updates to the counter cannot be done from the interrupt context.
This is fragile, however. It prevents using counters for things
On Mon, 24 Jun 2013, Gleb Smirnoff wrote:
did you run your benchmarks in userland or in kernel? How many
parallel threads were updating the same counter?
Can you please share your benchmarks?
Only userland, with 1 thread.
I don't have any more benchmarks than the test program in previous
On Mon, 24 Jun 2013, Gleb Smirnoff wrote:
On Sun, Jun 23, 2013 at 10:33:43AM +0300, Konstantin Belousov wrote:
K On Sat, Jun 22, 2013 at 06:58:15PM +1000, Bruce Evans wrote:
K So the i386 version be simply addl; adcl to memory. Each store in
K this is atomic at the per-CPU level
On Mon, 24 Jun 2013, Konstantin Belousov wrote:
On Sun, Jun 23, 2013 at 07:57:57PM +1000, Bruce Evans wrote:
The case that can't be fixed by rereading the counters is when fetching
code runs in between the stores. If the stores are on a another CPU
that is currently executing them, then we
On Tue, 25 Jun 2013, I wrote:
My current best design:
- use ordinary mutexes to protect counter fetches in non-per-CPU contexts.
- use native-sized or always 32-bit counters. Counter updates are done
by a single addl on i386. Fix pcpu.h on arches other than amd64 and
i386 and use the same
On Sun, 23 Jun 2013, Konstantin Belousov wrote:
On Sat, Jun 22, 2013 at 01:37:58PM +1000, Bruce Evans wrote:
On Sat, 22 Jun 2013, I wrote:
...
Here are considerably expanded tests, with noninline tests dropped.
Summary of times on Athlon64:
simple increment: 4
On Sun, 23 Jun 2013, Konstantin Belousov wrote:
On Sat, Jun 22, 2013 at 06:58:15PM +1000, Bruce Evans wrote:
So the i386 version be simply addl; adcl to memory. Each store in
this is atomic at the per-CPU level. If there is no carry, then the
separate stores are equivalent to adding separate
On Sun, 23 Jun 2013, I wrote:
I thought of lots of variations, but couldn't find one that works perfectly.
One idea (that goes with the sign check on the low 32 bits) is to use a
misaligned add to memory to copy the 31st bit as a carry bit to the the
high word. The value of the counter is
On Sat, 22 Jun 2013, I wrote:
On Sat, 22 Jun 2013, I wrote:
...
Here are considerably expanded tests, with noninline tests dropped.
Summary of times on Athlon64:
simple increment: 4-7 cycles (1)
simple increment preceded by feature test: 5-8 cycles (1)
On Sat, 22 Jun 2013, Garrett Cooper wrote:
On Jun 22, 2013, at 11:22 AM, Steven Hartland wrote:
I thought the use of PRIu64 was frowned on?
It is in FreeBSD, unlike Linux (for better or for worse). It should be
cast with either intmax_t or uintmax_t and use %jd or %ju.
Do you
On Fri, 21 Jun 2013, Gleb Smirnoff wrote:
On Fri, Jun 21, 2013 at 09:04:34AM +1000, Bruce Evans wrote:
B The i386 version of the counter asm doesn't support the immediate
B constraint for technical reasons. 64 bit counters are too large and
B slow to use on i386, especially when
On Fri, 21 Jun 2013, Gleb Smirnoff wrote:
On Fri, Jun 21, 2013 at 09:02:36PM +1000, Bruce Evans wrote:
B Not if it is a 32-bit increment on 32-bit systems, as it should be.
B
B I said to use a daemon to convert small (16 or 32 bit) counters into
B larger (32 or 64 bit) ones. It is almost
On Sat, 22 Jun 2013, I wrote:
...
Here are considerably expanded tests, with noninline tests dropped.
Summary of times on Athlon64:
simple increment: 4-7 cycles (1)
simple increment preceded by feature test: 5-8 cycles (1)
simple 32-bit increment:
On Thu, 20 Jun 2013, Konstantin Belousov wrote:
Log:
Allow immediate operand.
..
Modified: head/sys/amd64/include/counter.h
==
--- head/sys/amd64/include/counter.hThu Jun 20 14:20:03 2013
(r252031)
+++
On Fri, 21 Jun 2013, I wrote:
On Thu, 20 Jun 2013, Konstantin Belousov wrote:
...
@@ -44,7 +44,7 @@ counter_u64_add(counter_u64_t c, int64_t
...
The i386 version of the counter asm doesn't support the immediate
constraint for technical reasons. 64 bit counters are too large and
slow to use
On Fri, 21 Jun 2013, Bruce Evans wrote:
On Fri, 21 Jun 2013, I wrote:
On Thu, 20 Jun 2013, Konstantin Belousov wrote:
...
@@ -44,7 +44,7 @@ counter_u64_add(counter_u64_t c, int64_t
...
The i386 version of the counter asm doesn't support the immediate
constraint for technical reasons. 64
On Mon, 17 Jun 2013, David Chisnall wrote:
Log:
Rename a parameter in sys/time.h so that you don't get warnings for things
like libdialog that include both this header and math.h.
All the bintime stuff has similar namespace errors, starting with the
field names 'sec' and 'frac' not having a
On Mon, 17 Jun 2013, Sergey Kandaurov wrote:
Log:
Clean up -Wheader-guard warnings.
An interesting feature. It seems to be missing warnings about style bugs
in header-guard names.
Modified: head/sys/dev/puc/puc_bfe.h
On Sat, 15 Jun 2013, Konstantin Belousov wrote:
On Tue, Jun 04, 2013 at 06:14:49PM +1000, Bruce Evans wrote:
On Tue, 4 Jun 2013, Konstantin Belousov wrote:
On Mon, Jun 03, 2013 at 02:24:26AM -0700, Alfred Perlstein wrote:
On 6/3/13 12:55 AM, Konstantin Belousov wrote:
On Sun, Jun 02, 2013
On Tue, 11 Jun 2013, John Baldwin wrote:
Log:
Bump the CPU/WCPU column width by one so that it fits values from 100% up
to 999.99% CPU. It still won't be aligned if you have a multithreaded
process using more than 1000% CPU (e.g. idle process on an idle 12-way
system), but 100% is a common
On Wed, 5 Jun 2013, Chris Rees wrote:
On 5 Jun 2013 06:33, David Schultz d...@freebsd.org wrote:
...
Log:
Style fixes.
Submitted by: bde
...
==
--- head/lib/msun/Makefile Wed Jun 5 01:22:59 2013
On Wed, 5 Jun 2013, Chris Rees wrote:
On 5 Jun 2013 10:46, Bruce Evans b...@optusnet.com.au wrote:
On Wed, 5 Jun 2013, Chris Rees wrote:
On 5 Jun 2013 06:33, David Schultz d...@freebsd.org wrote:
...
Log:
Style fixes.
Submitted by: bde
On Tue, 4 Jun 2013, Konstantin Belousov wrote:
On Mon, Jun 03, 2013 at 02:24:26AM -0700, Alfred Perlstein wrote:
On 6/3/13 12:55 AM, Konstantin Belousov wrote:
On Sun, Jun 02, 2013 at 09:27:53PM -0700, Alfred Perlstein wrote:
Hey Konstaintin, shouldn't this be scaled against the actual
On Fri, 31 May 2013, Jeremie Le Hen wrote:
On Sat, May 25, 2013 at 06:59:12PM +, Marcel Moolenaar wrote:
...
Log:
Make the malloc(3) family of functions weak and make their non-weak
implementations visible for use by applications. The functions $F that
are now weak symbols are:
On Mon, 3 Jun 2013, David Schultz wrote:
Log:
Add logl, log2l, log10l, and log1pl.
Submitted by: bde
Thanks for looking after this.
Bruce
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To
n Sun, 26 May 2013, Stefan Esser wrote:
Am 25.05.2013 06:31, schrieb Bruce Evans:
On Fri, 24 May 2013, Stefan Esser wrote:
...
Another possibility (too obfuscated for my taste) is:
if (ferror(ofp) {
fclose(ofp);
ofp = NULL;
}
if (ofp
On Sat, 25 May 2013 m...@freebsd.org wrote:
On Sat, May 25, 2013 at 10:09 AM, Hans Petter Selasky
hsela...@freebsd.orgwrote:
...
Log:
Fix some statical clang analyzer warnings.
...
==
---
On Fri, 24 May 2013, Stefan Esser wrote:
...
Log:
The error handling for writes to the target file could lead to the final
fclose() being skipped. Fix this by using boolean and | instead of
short-cut operators and ||.
While here, increment the last part of the version string. The reason
On Tue, 21 May 2013, Alexey Dokuchaev wrote:
On Mon, May 20, 2013 at 07:20:48AM -0600, Warner Losh wrote:
On May 19, 2013, at 8:21 PM, Alexey Dokuchaev wrote:
Apparently not: I've been running FreeBSD 8.4-PRERELEASE without pmtimer
for a while, and noticed that my laptop stops keeping time
On Mon, 20 May 2013, Stefan Farfeleder wrote:
On Mon, May 20, 2013 at 01:06:50PM +0200, Ed Schouten wrote:
Hi Stefan,
2013/5/19 Stefan Farfeleder stef...@freebsd.org:
Shouldn't we fix lint and our headers to use a different macro name? One
starting with __?
Fixing lint: yes. Changing our
On Mon, 20 May 2013, Benjamin Kaduk wrote:
On Mon, May 20, 2013 at 11:50 AM, Stefan Farfeleder stef...@freebsd.orgwrote:
Since nobody wants to update lint to recent C standards, maybe it's time to
remove it?
I'm not going to defend it. At first I thought it was useful for checking
for old
On Fri, 10 May 2013, John Baldwin wrote:
On Thursday, May 09, 2013 11:05:46 pm Bruce Evans wrote:
On Mon, 6 May 2013, John Baldwin wrote:
...
static int
vn_ioctl(fp, com, data, active_cred, td)
struct file *fp;
u_long com;
void *data;
struct ucred *active_cred
On Mon, 6 May 2013, John Baldwin wrote:
On Saturday, May 04, 2013 4:47:43 am Bruce Evans wrote:
Log:
Fix FIONREAD on regular files. The computed result was being ignored and
it was being passed down to VOP_IOCTL() where it promptly resulted in
ENOTTY due to a missing else for the past 8
Log:
Fix FIONREAD on regular files. The computed result was being ignored and
it was being passed down to VOP_IOCTL() where it promptly resulted in
ENOTTY due to a missing else for the past 8 years. While here, use a
shared vnode lock while fetching the current file's size.
In another
On Sun, 28 Apr 2013, Eitan Adler wrote:
Log:
Mark usage() __dead2
This just adds a style bug.
Modified: head/bin/hostname/hostname.c
==
--- head/bin/hostname/hostname.cSun Apr 28 22:12:40 2013
On Mon, 29 Apr 2013, Ed Schouten wrote:
2013/4/29 Bruce Evans b...@optusnet.com.au:
- usr.bin/rlogin/rlogin.c has it in a gratuitously different form, as
'static _Noreturn voidusage(void);'. This is bogus since
_Noreturn is a wrapper for a new C++ feature
I hate to correct you
On Fri, 26 Apr 2013, Jilles Tjoelker wrote:
On Thu, Apr 25, 2013 at 09:56:01PM +1000, Bruce Evans wrote:
On Wed, 24 Apr 2013, Jilles Tjoelker wrote:
Log:
getdtablesize(2): Describe what this function actually does.
...
.Sh NAME
.Nm getdtablesize
-.Nd get descriptor table size
+.Nd get file
On Wed, 24 Apr 2013, Jilles Tjoelker wrote:
Log:
getdtablesize(2): Describe what this function actually does.
getdtablesize() returns the limit on new file descriptors; this says nothing
about existing descriptors.
It's still quite broken.
Modified: head/lib/libc/sys/getdtablesize.2
On Tue, 16 Apr 2013, Dimitry Andric wrote:
On 2013-04-16 06:19, ?? ?? wrote:
...
The warnings that usersmtp.c still triggers when -DSASL is used are:
: cc -O2 -pipe -I/usr/src/usr.sbin/sendmail/../../contrib/sendmail/src
On Thu, 11 Apr 2013, Garrett Cooper wrote:
On Apr 11, 2013, at 11:13 AM, Colin Percival wrote:
On 04/11/13 00:59, Bruce Evans wrote:
Log:
Include types.h for C99 uintXX_t types.
This adds namespace pollution that was carefully left out.
... and as a developer, I wish we left out
On Thu, 11 Apr 2013, Gleb Smirnoff wrote:
Juli,
On Thu, Apr 11, 2013 at 11:05:28AM -0700, Juli Mallett wrote:
J On Thu, Apr 11, 2013 at 09:07:25PM +1000, Bruce Evans wrote:
J B Just routine avoidance of namespace pollution. This is easy in such a
J B simple header.
J
J Sorry, with all
On Thu, 11 Apr 2013, Juli Mallett wrote:
On Thu, Apr 11, 2013 at 11:00 AM, Gleb Smirnoff gleb...@freebsd.org wrote:
Bruce,
On Thu, Apr 11, 2013 at 09:07:25PM +1000, Bruce Evans wrote:
B Just routine avoidance of namespace pollution. This is easy in such a
B simple header.
Sorry, with all
On Thu, 11 Apr 2013, Kenneth D. Merry wrote:
On Thu, Apr 11, 2013 at 17:06:44 +1000, Bruce Evans wrote:
...
It is now clear that this is still too verbose, since cur_secs and prev_secs
are not used except to initialize etime. Simplifying this gives:
etime = ctx-cur_time.tv_sec - ctx
On Wed, 10 Apr 2013, Kenneth D. Merry wrote:
Log:
Fix a time calculation error in ctlstat_standard().
ctlstat.c: When converting a timeval to a floating point
number in ctlstat_standard(), cast the nanoseconds
calculation to a long double, so we don't lose
Log:
Include types.h for C99 uintXX_t types.
This adds namespace pollution that was carefully left out.
Modified:
head/lib/libkvm/kvm.h
Modified: head/lib/libkvm/kvm.h
==
--- head/lib/libkvm/kvm.h Thu Apr 11
On Thu, 11 Apr 2013, Gleb Smirnoff wrote:
On Thu, Apr 11, 2013 at 05:59:24PM +1000, Bruce Evans wrote:
B Modified:
B head/lib/libkvm/kvm.h
B
B Modified: head/lib/libkvm/kvm.h
B
==
B --- head/lib/libkvm/kvm.h
On Thu, 11 Apr 2013, Gleb Smirnoff wrote:
On Thu, Apr 11, 2013 at 06:49:02PM +1000, Bruce Evans wrote:
B On Thu, Apr 11, 2013 at 05:59:24PM +1000, Bruce Evans wrote:
B B Modified:
B B head/lib/libkvm/kvm.h
B B
B B Modified: head/lib/libkvm/kvm.h
B B
On Mon, 8 Apr 2013, Gleb Smirnoff wrote:
On Mon, Apr 08, 2013 at 03:41:27PM -0400, John Baldwin wrote:
J On Monday, April 08, 2013 3:19:10 pm Gleb Smirnoff wrote:
J Author: glebius
J Date: Mon Apr 8 19:19:10 2013
J New Revision: 249265
J URL: http://svnweb.freebsd.org/changeset/base/249265
On Thu, 4 Apr 2013, Alexander Motin wrote:
On 04.04.2013 23:53, Adrian Chadd wrote:
Hi,
Isn't this a prime candidate to replace with KASSERT()?
It could be, but NULL dereference attempt will crash system no less reliably
then KASSERT.
Much more reliably:
- if INAVRIANTS is not
On Fri, 5 Apr 2013 m...@freebsd.org wrote:
On Fri, Apr 5, 2013 at 8:21 AM, Bruce Evans b...@optusnet.com.au wrote:
This method works well in userland too. Instead of assert() or abort(),
use an null dereference, or more portably, a signal
Digressing quite a bit, doesn't abort() send
1301 - 1400 of 2128 matches
Mail list logo
