Author: cem
Date: Fri May 22 15:30:14 2020
New Revision: 361385
URL: https://svnweb.freebsd.org/changeset/base/361385
Log:
ctime.3: Use ASCII asterisks for C, not special unicode math glyphs
PR: 246656
Reported by: danfe
Modified:
head/contrib/tzcode/stdtime/ctime.3
Hi Andriy,
Would it make sense to also export sizes of those members? Currently
the code assumes the members may be relocated in the struct, but never
changed in size. If they can be moved around, maybe they might be
enlarged or shrunk at some time too? Maybe not; I am not very
familiar with
Author: cem
Date: Wed May 20 17:27:54 2020
New Revision: 361284
URL: https://svnweb.freebsd.org/changeset/base/361284
Log:
vmm(4): Add 12 user ABI compat after r349948
Reported by: kp
Reviewed by: jhb, kp
Tested by:kp
Differential Revision:
Hi Michael,
On Mon, May 18, 2020 at 12:05 PM Michael Tuexen wrote:
>
> > On 18. May 2020, at 20:23, Conrad Meyer wrote:
>
> > If truncation is intended, the GCC warning is spurious. Given how
> > often snprintf is used in this way, I wonder if it would make sense to
&g
On Mon, May 18, 2020 at 10:35 AM Michael Tuexen wrote:
>
> > On 18. May 2020, at 17:38, Conrad Meyer wrote:
> >
> > These changes are a bit odd. The only reason a standards-compliant
> > snprintf() would fail to nul-terminate a buffer is if the provided
> &g
either case applies to these strings,
although I did not read all of them thoroughly.)
On Mon, May 18, 2020 at 8:38 AM Conrad Meyer wrote:
>
> Hi Michael,
>
> These changes are a bit odd. The only reason a standards-compliant
> snprintf() would fail to nul-terminate a buffer is
Hi Michael,
These changes are a bit odd. The only reason a standards-compliant
snprintf() would fail to nul-terminate a buffer is if the provided
buffer had length zero. Since this is not the case in any of these
uses, I wonder why this revision was made? Does a SCTP downstream
have a broken
On Sun, May 17, 2020 at 4:49 PM Oliver Pinter wrote:
> On Sunday, May 17, 2020, Colin Percival wrote:
>> +# Provide instructions on how to mount the requested filesystem.
>> +FS=$1
>> +REGION=`fetch -qo-
>> http://169.254.169.254/latest/meta-data/placement/availability-zone | sed -e
>>
Author: cem
Date: Sat May 16 14:33:08 2020
New Revision: 36
URL: https://svnweb.freebsd.org/changeset/base/36
Log:
cam: ANSIfy 0-argument function definitions
No functional change.
Reviewed by: imp
Differential Revision:https://reviews.freebsd.org/D24854
Modified:
atkbdc_init(ctx);
pci_irq_init(ctx);
Added: head/usr.sbin/bhyve/kernemu_dev.c
==
--- /dev/null 00:00:00 1970 (empty, because file is newly added)
+++ head/usr.sbin/bhyve/kernemu_dev.c Fri May 15 15:54:
Author: cem
Date: Fri May 15 03:54:25 2020
New Revision: 361071
URL: https://svnweb.freebsd.org/changeset/base/361071
Log:
ObsoleteFiles: pdwait4.2.gz
A belated follow-up to r320058.
Modified:
head/ObsoleteFiles.inc
Modified: head/ObsoleteFiles.inc
Author: cem
Date: Thu May 14 03:01:23 2020
New Revision: 361021
URL: https://svnweb.freebsd.org/changeset/base/361021
Log:
vfs_extattr: Allow extattr names up to the full max
Extattr names are allowed to be 255 bytes -- not 254 bytes plus trailing
NUL. Provide a 256 buffer so that
Why not just use _Bool and leave the compatibility definition only for
C++ (#define _Bool bool)?
On Tue, May 12, 2020 at 11:12 AM Konstantin Belousov wrote:
>
> Author: kib
> Date: Tue May 12 18:12:20 2020
> New Revision: 360983
> URL: https://svnweb.freebsd.org/changeset/base/360983
>
> Log:
>
Author: cem
Date: Tue May 12 04:34:26 2020
New Revision: 360955
URL: https://svnweb.freebsd.org/changeset/base/360955
Log:
Revert r360944 and r360946 until reported issues can be resolved
Reported by: cy
Added:
head/sys/arm64/arm64/copystr.c
- copied unchanged from r360943,
Thanks Cy. I’ll revert it when I’m back at a computer.
Best,
Conrad
On Mon, May 11, 2020 at 20:28 Cy Schubert wrote:
> In message <202005112257.04bmvmx2096...@repo.freebsd.org>, Conrad Meyer
> writes:
> > Author: cem
> > Date: Mon May 11 22:57:21 2020
> > New R
Author: cem
Date: Tue May 12 00:42:16 2020
New Revision: 360946
URL: https://svnweb.freebsd.org/changeset/base/360946
Log:
Remove deleted files from the build
Fix build break introduced in r360944.
Reported by: kevans
Modified:
head/sys/conf/files.arm64
Author: cem
Date: Mon May 11 22:57:21 2020
New Revision: 360944
URL: https://svnweb.freebsd.org/changeset/base/360944
Log:
copystr(9): Move to deprecate [2/2]
Unlike the other copy*() functions, it does not serve to copy from one
address space to another or protect against potential
Author: cem
Date: Mon May 11 22:48:00 2020
New Revision: 360943
URL: https://svnweb.freebsd.org/changeset/base/360943
Log:
copystr(9): Move to deprecate [1/2]
Unlike the other copy*() functions, it does not serve to copy from one
address space to another or protect against potential
Author: cem
Date: Mon May 11 22:39:53 2020
New Revision: 360941
URL: https://svnweb.freebsd.org/changeset/base/360941
Log:
geom(4) mirror: Do not panic on gmirror(8) insert, resize
Geom_mirror initialization occurs in spurts and the present of a
non-destroyed g_mirror softc does not
Author: cem
Date: Sat May 9 19:26:44 2020
New Revision: 360852
URL: https://svnweb.freebsd.org/changeset/base/360852
Log:
clang: Reject %n for __attribute__((format(__freebsd_kprintf__)))
A follow-up to r360849.
Reported by: imp
Reviewed by: emaste, imp
X-MFC-With: r360849
Author: cem
Date: Tue May 5 18:06:32 2020
New Revision: 360665
URL: https://svnweb.freebsd.org/changeset/base/360665
Log:
ls(1): Fix trivial SEGV due to NULL deref in OOM path
Reported by: Anton Rang
Sponsored by: Dell EMC Isilon
Modified:
head/bin/ls/ls.c
Modified:
Author: cem
Date: Tue May 5 17:57:04 2020
New Revision: 360664
URL: https://svnweb.freebsd.org/changeset/base/360664
Log:
strdup.3: Slightly canonicalize OOM return/error status
Attempted to clean up the language around "this is a malloc'd object." May be
passed as a parameter to
Author: cem
Date: Tue May 5 17:55:45 2020
New Revision: 360663
URL: https://svnweb.freebsd.org/changeset/base/360663
Log:
pwcache.3: Explicitly document OOM condition
The pwcache functions allocate memory, and may return NULL pointers if that
allocation fails and the corresponding uid
Author: cem
Date: Sat May 2 18:54:25 2020
New Revision: 360566
URL: https://svnweb.freebsd.org/changeset/base/360566
Log:
kern_exec.c: Produce valid code ifndef SYS_PROTO_H
Reported by: Coccinelle
Modified:
head/sys/kern/kern_exec.c
Modified: head/sys/kern/kern_exec.c
Thanks, this looks like a big improvement!
On Thu, Apr 30, 2020 at 18:26 Jung-uk Kim wrote:
> Author: jkim
> Date: Fri May 1 01:26:36 2020
> New Revision: 360517
> URL: https://svnweb.freebsd.org/changeset/base/360517
>
> Log:
> MFV: r360512
>
> Merge ACPICA 20200430.
>
> ---
Author: cem
Date: Sat Apr 25 14:24:54 2020
New Revision: 360306
URL: https://svnweb.freebsd.org/changeset/base/360306
Log:
libc: partially revert r326576
In r326576 ("use @@@ instead of @@ in __sym_default"), an earlier version of
the phabricator-discussed patch was inadvertently
Author: cem
Date: Thu Apr 23 18:04:52 2020
New Revision: 360227
URL: https://svnweb.freebsd.org/changeset/base/360227
Log:
dumpon.8: Update minimum key size language
dumpon(8) has not accepted 1024-bit RSA keys since prior to r339784 (2018-10).
The manual page language was not updated at
Author: cem
Date: Thu Apr 23 17:56:48 2020
New Revision: 360226
URL: https://svnweb.freebsd.org/changeset/base/360226
Log:
EKCD: Preload error strings, PRNG seed; use OAEP padding
Preload OpenSSL ERR string data so that the formatted error messages are
vaguely meaningful. Add OpenSSL
Author: cem
Date: Thu Apr 23 17:30:03 2020
New Revision: 360224
URL: https://svnweb.freebsd.org/changeset/base/360224
Log:
acpi_ec(4): Don't probe erroneously if success occurred
In r360131, acpi_ec probe was changed to not clobber an error status prior to
several error cases that did
Author: cem
Date: Tue Apr 21 21:34:24 2020
New Revision: 360177
URL: https://svnweb.freebsd.org/changeset/base/360177
Log:
vmm(4): Decode and emulate BEXTR
Clang 10 -march=native kernels on znver1 emit BEXTR for APIC reads,
apparently. Decode and emulate the instruction.
Reviewed
Author: cem
Date: Tue Apr 21 21:33:06 2020
New Revision: 360176
URL: https://svnweb.freebsd.org/changeset/base/360176
Log:
vmm(4): Decode 3-byte VEX-prefixed instructions
Reviewed by: grehan
Differential Revision:https://reviews.freebsd.org/D24462
Modified:
Thanks!
On Mon, Apr 20, 2020 at 7:45 AM Mark Johnston wrote:
>
> Author: markj
> Date: Mon Apr 20 14:45:17 2020
> New Revision: 360122
> URL: https://svnweb.freebsd.org/changeset/base/360122
>
> Log:
> Handle trashed queue pointers in vm_page_acquire_unlocked().
>
>
Hi Niclas,
On Mon, Apr 20, 2020 at 9:57 AM Niclas Zeising wrote:
>
> On 2020-04-20 18:39, Justin Hibbits wrote:
> > For just powerpc32,
> > you should have:
> >
> > #if defined(__powerpc__) && !defined(__powerpc64__)
>
> Ok, I wasn't aware of that, I'll fix it.
FYI, arch(7) is a great resource
Author: cem
Date: Mon Apr 20 18:01:45 2020
New Revision: 360131
URL: https://svnweb.freebsd.org/changeset/base/360131
Log:
acpi_ec(4): Do not probe "successfully" if an error occurred
All of the 'goto out;' cases in this probe routine without explicit
initialization of 'ret' indicate
There is also mdoc(7), which describes the same thing:
SEE ALSO
References other manuals with related topics. This section should
exist for most manuals. Cross-references should conventionally be
ordered first by section, then alphabetically (ignoring
Committed in r360107, if you don't mind rebooting to try the patch. I
will work on the slightly more complicated additional steps mentioned
earlier, but those will take a little more time.
Thanks again,
Conrad
On Sun, Apr 19, 2020 at 4:50 PM Conrad Meyer wrote:
>
> https://reviews.freeb
Author: cem
Date: Sun Apr 19 23:53:47 2020
New Revision: 360107
URL: https://svnweb.freebsd.org/changeset/base/360107
Log:
vmm(4): Bump VM_MAX_MEMMAPS for vmgenid
As a short term solution for the problem reported by Shawn Webb re: r359950,
bump the maximum number of memmaps per VM. This
https://reviews.freebsd.org/D24507 :-)
On Sun, Apr 19, 2020 at 4:45 PM Peter Grehan wrote:
>
> > Unless there is an ABI problem, I think we should probably go
> > ahead and bump VM_MAX_MEMMAPS
>
> That's a reasonable fix - double it (or more) until it's made dynamic.
> The VGA code is another
d.org/HardenedBSD/pubkeys/src/branch/master/Shawn_Webb/03A4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc
>
> On Sun, Apr 19, 2020 at 04:04:16PM -0700, Conrad Meyer wrote:
> > Hey Shawn,
> >
> > I will take a look. Thanks for the report and especially the repro example.
> > What sort of bad symptoms
Hey Shawn,
I will take a look. Thanks for the report and especially the repro example.
What sort of bad symptoms are you observing (or will it be super obvious
when I try this)?
Thanks,
Conrad
On Sun, Apr 19, 2020 at 15:53 Shawn Webb wrote:
> On Wed, Apr 15, 2020 at 02:00:18AM +0000, Con
Hm, some of us just want kerberos to be completed excised. This
change makes WITHOUT_KERBEROS retain portions of kerberos? That seems
unfortunate.
On Sun, Apr 19, 2020 at 10:01 AM Cy Schubert wrote:
>
> Author: cy
> Date: Sun Apr 19 17:01:21 2020
> New Revision: 360102
> URL:
Hi Alex,
We usually do not use "extern" for function declarations in headers.
Best,
Conrad
On Sat, Apr 18, 2020 at 5:55 AM Alex Richardson wrote:
>
> Author: arichardson
> Date: Sat Apr 18 12:54:47 2020
> New Revision: 360073
> URL: https://svnweb.freebsd.org/changeset/base/360073
>
> Log:
>
Author: cem
Date: Fri Apr 17 20:20:03 2020
New Revision: 360054
URL: https://svnweb.freebsd.org/changeset/base/360054
Log:
xen-locore: Silence DWARF2 section warning
Silence the "DWARF2 can only represent one section per compilation unit"
warning in amd64 GENERIC builds by disabling
Author: cem
Date: Fri Apr 17 15:19:42 2020
New Revision: 360044
URL: https://svnweb.freebsd.org/changeset/base/360044
Log:
vmm.h: Add ABI assertions and mark implicit holes
The static assertions were added (with size and offsets from gdb) and verified
with a build prior to marking the
Author: cem
Date: Thu Apr 16 16:50:33 2020
New Revision: 360012
URL: https://svnweb.freebsd.org/changeset/base/360012
Log:
vmm(4): Expose instruction decode to userspace build
Permit instruction decoding logic to be compiled outside of the kernel for
rapid iteration and validation.
No.
On Wed, Apr 15, 2020 at 05:30 Shawn Webb wrote:
> On Wed, Apr 15, 2020 at 01:58:51AM +0000, Conrad Meyer wrote:
> > Author: cem
> > Date: Wed Apr 15 01:58:51 2020
> > New Revision: 359949
> > URL: https://svnweb.freebsd.org/changeset/base/359949
> >
>
Author: cem
Date: Wed Apr 15 05:55:14 2020
New Revision: 359959
URL: https://svnweb.freebsd.org/changeset/base/359959
Log:
bhyve(8): Correct copyright boilerplate for r359950
Use the text from the canonical sys/copyright.h 2-clause FreeBSD License.
Reported by: grehan (thanks!)
Author: cem
Date: Wed Apr 15 02:34:44 2020
New Revision: 359951
URL: https://svnweb.freebsd.org/changeset/base/359951
Log:
bhyve(8): Minor cosmetic niceties in instemul failure
Print the failed instruction stream as a contiguous stream of hex. This
is closer to something you could throw
gpe0_enabled = (*eax & gpe0_valid);
+ sci_update(ctx);
+ }
+ pthread_mutex_unlock(_lock);
+ return (0);
+}
+INOUT_PORT(gpe0_en, IO_GPE0_EN, IOPORT_F_INOUT, gpe0_en);
/*
* ACPI SMI Command Register
Added: head/usr.sbin/bhyve/vmgenc.c
==
Author: cem
Date: Wed Apr 15 01:58:51 2020
New Revision: 359949
URL: https://svnweb.freebsd.org/changeset/base/359949
Log:
bhyve(8): Add bootrom allocation abstraction
To allow more general use of the bootrom region, separate initialization from
allocation, and allocation from loading a
Author: cem
Date: Wed Apr 15 01:39:17 2020
New Revision: 359948
URL: https://svnweb.freebsd.org/changeset/base/359948
Log:
bus_dma.9: Remove erroneous usage recommendation
It is not valid to pass BUS_SPACE_UNRESTRICTED to bus_dma_tag_create()'s
nsegments parameter as it is interpreted as
Brooks,
On Tue, Apr 14, 2020 at 13:31 Brooks Davis wrote:
> Author: brooks
> Date: Tue Apr 14 20:30:48 2020
> New Revision: 359937
> URL: https://svnweb.freebsd.org/changeset/base/359937
>
> Log:
> Centralize compatability translation macros.
>
> Copy the CP, PTRIN, etc macros from
Author: cem
Date: Mon Apr 13 20:25:01 2020
New Revision: 359898
URL: https://svnweb.freebsd.org/changeset/base/359898
Log:
Disable QUEUE_MACRO_DEBUG_TRACE in LINT kernels
It changes the size of TAILQ_ENTRY, which obviously impacts ABI in a variety
of
ways. Some of these things are
Author: cem
Date: Sun Apr 12 18:04:20 2020
New Revision: 359829
URL: https://svnweb.freebsd.org/changeset/base/359829
Log:
Add queue(2) debug macros as build options
Add QUEUE_MACRO_DEBUG_TRACE and QUEUE_MACRO_DEBUG_TRASH as proper kernel
options. While here, alpha-sort the debug
Hi Michael,
On Sun, Apr 12, 2020 at 2:33 AM Michael Tuexen wrote:
> Yes. What I meant is that in the stream scheduler code (sctp_ss_functions.c)
> the pattern is
>
> TAILQ_REMOVE(>ss_data.out.list, sp, ss_next);
> sp->ss_next.tqe_next = NULL;
> sp->ss_next.tqe_prev =
Hi Michael,
On Sat, Apr 11, 2020 at 1:37 PM Michael Tuexen wrote:
>
> Author: tuexen
> Date: Sat Apr 11 20:36:54 2020
> New Revision: 359809
> URL: https://svnweb.freebsd.org/changeset/base/359809
>
> Log:
> Zero out pointers for consistency.
>
> This was found by running syzkaller on an
On Sat, Apr 11, 2020 at 1:45 PM Alexander V. Chernikov
wrote:
> This number only affects selection of the outbound path in presence of
> multiple paths available for the same prefix. It means to mitigate hash
> polarization in the network (
>
Hi Alexander,
On Sat, Apr 11, 2020 at 12:37 AM Alexander V. Chernikov
wrote:
>
> Author: melifaro
> Date: Sat Apr 11 07:37:08 2020
> New Revision: 359797
> URL: https://svnweb.freebsd.org/changeset/base/359797
>
> Log:
> Remove per-AF radix_mpath initializtion functions.
>
> Split their
Author: cem
Date: Tue Apr 7 16:40:41 2020
New Revision: 359696
URL: https://svnweb.freebsd.org/changeset/base/359696
Log:
libcasper(3): Export functions to C++
We must wrap C declarations in __BEGIN / __END_DECLS to avoid C++
name-mangling
of the declaration when including the C
Author: cem
Date: Mon Apr 6 23:07:56 2020
New Revision: 359674
URL: https://svnweb.freebsd.org/changeset/base/359674
Log:
libcasper: Constify cap_sysctl_limit_mib() mib parameter
No functional change. Minor API change that is nicer for consumers. ABI is
identical; the routine never
Author: cem
Date: Thu Apr 2 20:47:51 2020
New Revision: 359581
URL: https://svnweb.freebsd.org/changeset/base/359581
Log:
ddb(4): show lockchain: Don't dereference LK_KERNPROC
Also, print a little more information for otherwise unhandled inhibited
states.
Finally, improve the
Thanks!
On Thu, Mar 26, 2020 at 08:03 Mark Johnston wrote:
> Author: markj
> Date: Thu Mar 26 15:02:37 2020
> New Revision: 359330
> URL: https://svnweb.freebsd.org/changeset/base/359330
>
> Log:
> Remove unused SYSINIT macros for capability rights.
>
> Static rights are initialized in
Author: cem
Date: Wed Mar 25 23:12:43 2020
New Revision: 359311
URL: https://svnweb.freebsd.org/changeset/base/359311
Log:
Expand generic subword atomic primitives
The goal of this change is to make the atomic_load_acq_{8,16},
atomic_testandset{,_acq}_long, and atomic_testandclear_long
Author: cem
Date: Tue Mar 24 19:20:10 2020
New Revision: 359283
URL: https://svnweb.freebsd.org/changeset/base/359283
Log:
Fix PNP matching for iflib NIC drivers
The previous descriptor string specified that all fields were significant for
match. However, the only significant fields for
On Mon, Mar 23, 2020 at 6:25 PM Bryan Drewery wrote:
>
> On 3/23/2020 12:01 PM, Brooks Davis wrote:
> > Author: brooks
> > Date: Mon Mar 23 19:01:23 2020
> > New Revision: 359260
> > URL: https://svnweb.freebsd.org/changeset/base/359260
> >
> > Log:
> > Import the kyua test framework.
>
> Dumb
Author: cem
Date: Mon Mar 23 23:00:13 2020
New Revision: 359264
URL: https://svnweb.freebsd.org/changeset/base/359264
Log:
arm: Fix atomic long APIs to correct 'u_long' signedness
As defined in atomic(9) and implemented on other architectures, the
atomic(9) functions all act on unsigned
Author: cem
Date: Tue Mar 17 22:27:16 2020
New Revision: 359053
URL: https://svnweb.freebsd.org/changeset/base/359053
Log:
Implement sysctl kern.boot_id
Boot IDs are random, opaque 128-bit identifiers that distinguish distinct
system boots. A new ID is generated each time the system
Author: cem
Date: Mon Mar 16 22:25:25 2020
New Revision: 359022
URL: https://svnweb.freebsd.org/changeset/base/359022
Log:
Remove misleading / redundant bzero in callout_callwheel_init
The intent seems to be zeroing all of the cc_cpu array, or its singleton on
such platforms. The
Pedro,
It seems like you are attempting to belittle me, and perhaps the
entire USA, by intentionally conflating the calendar(1) program with
the entire concept of written records and education. Stop it. I know
you're smart and have been around FreeBSD long enough to understand
that in context,
On Sat, Mar 14, 2020 at 5:49 PM Pedro F. Giffuni wrote:
>
> Author: pfg
> Date: Sun Mar 15 00:49:06 2020
> New Revision: 359005
> URL: https://svnweb.freebsd.org/changeset/base/359005
>
> Log:
> calendar(1): Updates and corrections for some calendar files.
>
> These have an educational value
For additional context, this quiesces (false positive) Coverity CID 1383554.
On Fri, Mar 13, 2020 at 10:57 PM Xin LI wrote:
>
> Author: delphij
> Date: Sat Mar 14 05:57:22 2020
> New Revision: 358988
> URL: https://svnweb.freebsd.org/changeset/base/358988
>
> Log:
> Remove unneeded checks for
Author: cem
Date: Thu Mar 12 21:26:36 2020
New Revision: 358922
URL: https://svnweb.freebsd.org/changeset/base/358922
Log:
kern_shutdown: Add missing EKCD ifdef
Submitted by: Puneeth Jothaiah
Reviewed by: bdrewery
Sponsored by: Dell EMC Isilon
Modified:
Hi Xin Li,
Sorry to reply to an old commit.
On Tue, Nov 21, 2017 at 12:14 AM Xin LI wrote:
>
> Author: delphij
> Date: Tue Nov 21 08:14:30 2017
> New Revision: 326052
> URL: https://svnweb.freebsd.org/changeset/base/326052
>
> Log:
> Support SIGINFO.
> ...
> --- head/usr.bin/gzip/unpack.c
Author: cem
Date: Tue Mar 3 23:15:30 2020
New Revision: 358596
URL: https://svnweb.freebsd.org/changeset/base/358596
Log:
sys/signalvar.h: Fix opposite boolean sense in comment
Correct the sense of the comment describing sigsetmasked() to match the
code. It was exactly backwards.
Author: cem
Date: Tue Mar 3 00:20:08 2020
New Revision: 358562
URL: https://svnweb.freebsd.org/changeset/base/358562
Log:
Add extremely useful calendar(1) application to FreeBSD
It does extremely useful things like execute sendmail and spew dubiously
accurate factoids.
From the
Author: cem
Date: Mon Mar 2 23:37:47 2020
New Revision: 358561
URL: https://svnweb.freebsd.org/changeset/base/358561
Log:
Fix typo in r278616
FreeBSD isn't an encyclopedia.
Deleted:
head/tools/build/options/WITHOUT_CALENDAR
head/usr.bin/calendar/Makefile
Given the report and looking at the change, I suspect the problem is
the promotion of '-residue' from size_t (unsigned 32-bit on i386) to
off_t (signed 64-bit). Something like '-(off_t)residue' or even
'off_t residue;' should fix it.
Repro:
static void
myoff(off_t foo)
{
printf("%jd\n",
Author: cem
Date: Sat Feb 15 19:13:37 2020
New Revision: 357975
URL: https://svnweb.freebsd.org/changeset/base/357975
Log:
random(6): Re-add undocumented support for floating point denominators
And document it in the manual page.
PR: 244139
Submitted by: Keith White
Hi Michael,
On Tue, Feb 11, 2020 at 6:00 AM Michael Tuexen wrote:
>
> Author: tuexen
> Date: Tue Feb 11 14:00:27 2020
> New Revision: 357761
> URL: https://svnweb.freebsd.org/changeset/base/357761
>
> Log:
> Use an int instead of a bool variable, since bool is not supported
> on all
Hi Pawel,
I don't think the (notyet) static assertion is quite right.
On Thu, Feb 6, 2020 at 4:46 AM Pawel Biernacki wrote:
>
> Author: kaktus
> Date: Thu Feb 6 12:45:58 2020
> New Revision: 357614
> URL: https://svnweb.freebsd.org/changeset/base/357614
>
> Log:
> sysctl(9): add
Hi Dmitry,
This seems to trigger some panics via clock_gettime syscalls (native
and 32-bit, reported by Syzkaller):
panic: mutex process lock not owned at
/syzkaller/managers/main/kernel/sys/kern/kern_time.c:261
cpuid = 0
time = 1580841963
KDB: stack backtrace:
db_trace_self_wrapper() at
Author: cem
Date: Mon Feb 3 05:19:44 2020
New Revision: 357425
URL: https://svnweb.freebsd.org/changeset/base/357425
Log:
netinet/libalias: Fix typo in debug message
No functional change.
PR: 243831
Submitted by: Neel Chauhan
Differential Revision:
Hi Dimitry,
On Sat, Feb 1, 2020 at 12:29 PM Conrad Meyer wrote:
> Please un-disable the Makefile warnings removed in r357349 earlier, too.
Apologies, I just now caught up to my r357366 in my SVN email. Thank you.
Best,
Conrad
___
svn-src-
Author: cem
Date: Sat Feb 1 20:38:22 2020
New Revision: 357386
URL: https://svnweb.freebsd.org/changeset/base/357386
Log:
tpm(4): Fix 'go ready' in TPM 2.0 TIS driver
tpmtis_go_ready() read the value of the TPM_STS register, ORed
TPM_STS_CMD_READY with it, and wrote it back. However,
Author: cem
Date: Sat Feb 1 20:33:23 2020
New Revision: 357382
URL: https://svnweb.freebsd.org/changeset/base/357382
Log:
rand(3): Replace implementation with one backed by random(3) algorithm
rand(3)'s standard C API is extremely limiting, but we can do better
than the historical
On Sat, Feb 1, 2020 at 10:10 AM Dimitry Andric wrote:
>
> On 1 Feb 2020, at 18:48, Ian Lepore wrote:
> >
> > So you're going to switch from writing 0 to writing 0xfffe, and
> > just assume that will work the same?
> > ... [Caustic sarcasm elided]
>
> Hmm, the data sheet says:
>
> Writes
Author: cem
Date: Sat Feb 1 20:12:02 2020
New Revision: 357381
URL: https://svnweb.freebsd.org/changeset/base/357381
Log:
hwpstate_intel(4): Save admin-set EPP/EPB and restore after suspend
Modified:
head/sys/x86/cpufreq/hwpstate_intel.c
Modified: head/sys/x86/cpufreq/hwpstate_intel.c
Author: cem
Date: Sat Feb 1 20:11:25 2020
New Revision: 357380
URL: https://svnweb.freebsd.org/changeset/base/357380
Log:
hwpstate_intel(4): Print failure message only on failure
X-MFC-With: r357379
Modified:
head/sys/x86/cpufreq/hwpstate_intel.c
Modified:
Author: cem
Date: Sat Feb 1 19:50:10 2020
New Revision: 357379
URL: https://svnweb.freebsd.org/changeset/base/357379
Log:
hwpstate_intel(4): Detect and support PKG variant
If package-level control is present, we default to using it. Per-core
software control may be enabled by setting
Author: cem
Date: Sat Feb 1 19:49:13 2020
New Revision: 357378
URL: https://svnweb.freebsd.org/changeset/base/357378
Log:
hwpstate_intel(4): Add fallback EPP using PERF_BIAS MSR
Per Intel SDM (Vol 3b Part 2), if HWP indicates EPP (energy-performance
preference) is not supported, the
Author: cem
Date: Sat Feb 1 19:46:02 2020
New Revision: 357377
URL: https://svnweb.freebsd.org/changeset/base/357377
Log:
x86: Add/amend some power-management comments/macros
No functional change.
Modified:
head/sys/x86/cpufreq/hwpstate_intel.c
head/sys/x86/include/specialreg.h
Author: cem
Date: Sat Feb 1 19:45:27 2020
New Revision: 357376
URL: https://svnweb.freebsd.org/changeset/base/357376
Log:
hwpstate_intel(4): Error check epp sysctl & bail if HW does not support
feature
Modified:
head/sys/x86/cpufreq/hwpstate_intel.c
Modified:
Author: cem
Date: Sat Feb 1 17:54:46 2020
New Revision: 357373
URL: https://svnweb.freebsd.org/changeset/base/357373
Log:
intel_hwpstate(4): Use identcpu-cached cpuid 6 leaf
No functional change.
Modified:
head/sys/x86/cpufreq/hwpstate_intel.c
Modified:
Author: cem
Date: Sat Feb 1 17:30:45 2020
New Revision: 357372
URL: https://svnweb.freebsd.org/changeset/base/357372
Log:
intel_hwpstate(4): Don't leak bound thread in error conditions
I don't know why a Skylake CPU with the HWP feature bit present would trap
on MSR reads of the HWP
Hi John,
Isn't the 32-bit MSTATUS_SD and SSTATUS_SD also UB without explicit
unsigned suffix?
Best,
Conrad
On Fri, Jan 31, 2020 at 9:49 AM John Baldwin wrote:
>
> Author: jhb
> Date: Fri Jan 31 17:49:15 2020
> New Revision: 357337
> URL: https://svnweb.freebsd.org/changeset/base/357337
>
>
Hi Dimitry,
Do you think maybe the intent is to use ~TPM_CRB_CTRL_CANCEL_CMD
instead? Plain "0" might also make sense. But I think the compiler
is right here and the warning should not be disabled — !BIT(foo)
doesn't really make sense for a register. It happens to affect the
right bit only
Author: cem
Date: Fri Jan 31 17:40:41 2020
New Revision: 357336
URL: https://svnweb.freebsd.org/changeset/base/357336
Log:
hwpstate(4): Ignore CurPstateLimit by default
Add a sysctl knob to allow users to re-enable it, and document the knob and
default in cpufreq.4. (While here, add a
Author: cem
Date: Thu Jan 30 18:12:24 2020
New Revision: 357300
URL: https://svnweb.freebsd.org/changeset/base/357300
Log:
aic7xxx(4): Fix unintended sign extension in ahd_inq()
ahd_inb() returns type uint8_t. The shift left by untyped 24 implicitly
promotes the result to type (signed)
Author: cem
Date: Thu Jan 30 18:12:41 2020
New Revision: 357301
URL: https://svnweb.freebsd.org/changeset/base/357301
Log:
contrib/apr: Rip out bogus [CS]PRNG implementation
This construction used some relatively slow design involving SHA2; even if
it were fed real entropy (unclear;
Author: cem
Date: Thu Jan 30 17:50:51 2020
New Revision: 357299
URL: https://svnweb.freebsd.org/changeset/base/357299
Log:
contrib/apr: Remove scope leak UB
In apr_vformatter, the variable buf was declared inside a limited scope
region, but a pointer to it is leaked outside of that
101 - 200 of 1506 matches
Mail list logo