Re: svn commit: r233700 - head/sys/kern

2012-04-19 Thread John Baldwin
On Wednesday, April 18, 2012 4:10:01 pm Dimitry Andric wrote: > On 2012-04-18 15:54, John Baldwin wrote: > ... > > http://www.FreeBSD.org/~jhb/patches/asr_stailq.patch > > Yes, that seems to work just fine, at least for the list juggling. Thanks! > > The only additional fix needed now is the fol

Re: svn commit: r233700 - head/sys/kern

2012-04-18 Thread Dimitry Andric
On 2012-04-18 15:54, John Baldwin wrote: ... http://www.FreeBSD.org/~jhb/patches/asr_stailq.patch Yes, that seems to work just fine, at least for the list juggling. Thanks! The only additional fix needed now is the following. Shall I commit that including your patch? Index: sys/dev/asr/asr.

Re: svn commit: r233700 - head/sys/kern

2012-04-18 Thread John Baldwin
On Tuesday, April 17, 2012 4:24:38 pm Dimitry Andric wrote: > On 2012-04-02 13:52, John Baldwin wrote: > ... > >> It seems the for loop walks the list until the end, then tacks 'sc' onto > >> it. > >> > >> So to 'fix' the warning, and make the meaning more explicit, we should > >> probably rewrite

Re: svn commit: r233700 - head/sys/kern

2012-04-17 Thread Dimitry Andric
On 2012-04-02 13:52, John Baldwin wrote: ... It seems the for loop walks the list until the end, then tacks 'sc' onto it. So to 'fix' the warning, and make the meaning more explicit, we should probably rewrite that fragment as: LIST_INIT(&(sc->ha_ccb)); /* Link us into the H

Re: svn commit: r233700 - head/sys/kern

2012-04-02 Thread John Baldwin
On Friday, March 30, 2012 3:49:51 pm Dimitry Andric wrote: > On 2012-03-30 15:30, Stefan Farfeleder wrote: > > here are a few similar cases. > > Hm, what about this one that clang warns about: > >sys/dev/asr/asr.c:2420:57: warning: for loop has empty body [-Wempty- body] > for (ha = &

Re: svn commit: r233700 - head/sys/kern

2012-03-31 Thread Alexey Dokuchaev
On Sat, Mar 31, 2012 at 08:10:07PM +0900, Joerg Sonnenberger wrote: > On Fri, Mar 30, 2012 at 09:49:51PM +0200, Dimitry Andric wrote: > > On 2012-03-30 15:30, Stefan Farfeleder wrote: > > >here are a few similar cases. > > > > Hm, what about this one that clang warns about: > > > > sys/dev/asr/

Re: svn commit: r233700 - head/sys/kern

2012-03-31 Thread Joerg Sonnenberger
On Fri, Mar 30, 2012 at 09:49:51PM +0200, Dimitry Andric wrote: > On 2012-03-30 15:30, Stefan Farfeleder wrote: > >here are a few similar cases. > > Hm, what about this one that clang warns about: > > sys/dev/asr/asr.c:2420:57: warning: for loop has empty body [-Wempty-body] > for (ha =

Re: svn commit: r233700 - head/sys/kern

2012-03-30 Thread Dimitry Andric
On 2012-03-30 15:30, Stefan Farfeleder wrote: here are a few similar cases. Hm, what about this one that clang warns about: sys/dev/asr/asr.c:2420:57: warning: for loop has empty body [-Wempty-body] for (ha = &Asr_softc_list; *ha; ha = &((*ha)->ha_next));

Re: svn commit: r233700 - head/sys/kern

2012-03-30 Thread Stefan Farfeleder
Hi, here are a few similar cases. Stefan Index: tools/regression/lib/libc/nss/test-gethostby.c === --- tools/regression/lib/libc/nss/test-gethostby.c (revision 233700) +++ tools/regression/lib/libc/nss/test-gethostby.c (working copy)

svn commit: r233700 - head/sys/kern

2012-03-30 Thread David Xu
Author: davidxu Date: Fri Mar 30 12:57:14 2012 New Revision: 233700 URL: http://svn.freebsd.org/changeset/base/233700 Log: Remove trailing semicolon, it is a typo. Modified: head/sys/kern/kern_umtx.c Modified: head/sys/kern/kern_umtx.c