svn commit: r357240 - in head/sys: kern x86/cpufreq

2020-01-28 Thread Conrad Meyer
Author: cem Date: Wed Jan 29 03:15:34 2020 New Revision: 357240 URL: https://svnweb.freebsd.org/changeset/base/357240 Log: hwpstate_intel(4): Silence/fix Coverity reports These were all introduced in the initial import of hwpstate_intel(4). Reported by: Coverity CIDs: 141316

svn commit: r357241 - head/lib/libpmc/pmu-events

2020-01-28 Thread Conrad Meyer
Author: cem Date: Wed Jan 29 04:31:26 2020 New Revision: 357241 URL: https://svnweb.freebsd.org/changeset/base/357241 Log: libpmc: jevents: Partial style(9) pass Sort headers, move includes up to the top of the file, function return types on their own line; no functional change. Modifie

svn commit: r357243 - head/lib/libpmc/pmu-events

2020-01-28 Thread Conrad Meyer
Author: cem Date: Wed Jan 29 04:33:45 2020 New Revision: 357243 URL: https://svnweb.freebsd.org/changeset/base/357243 Log: libpmc: jevents: Go ahead and use snprintf(3) Reported by: Coverity CID: 1391362 Modified: head/lib/libpmc/pmu-events/jevents.c Modified: head/lib/libpm

svn commit: r357244 - head/sys/dev/qlxgb

2020-01-28 Thread Conrad Meyer
Author: cem Date: Wed Jan 29 04:41:26 2020 New Revision: 357244 URL: https://svnweb.freebsd.org/changeset/base/357244 Log: qlxgb(4): Use defined evaluation order Reported by: Coverity CID: 1193717 Modified: head/sys/dev/qlxgb/qla_os.c Modified: head/sys/dev/qlxgb/qla_os.c ==

svn commit: r357245 - head/sys/dev/qlxge

2020-01-28 Thread Conrad Meyer
Author: cem Date: Wed Jan 29 04:42:46 2020 New Revision: 357245 URL: https://svnweb.freebsd.org/changeset/base/357245 Log: qlxge(4): Ditto r357244 Reported by: Coverity CID: 1193716 Modified: head/sys/dev/qlxge/qls_os.c Modified: head/sys/dev/qlxge/qls_os.c =

svn commit: r357246 - head/tests/sys/sys

2020-01-28 Thread Conrad Meyer
Author: cem Date: Wed Jan 29 05:25:20 2020 New Revision: 357246 URL: https://svnweb.freebsd.org/changeset/base/357246 Log: qmath(3) test: Replace overcomplicated abomination with arc4random(3) The horrific GENRAND construction bent over backwards to construct 64-bit signed integers from t

svn commit: r357247 - head/sys/dev/ixgbe

2020-01-28 Thread Conrad Meyer
Author: cem Date: Wed Jan 29 05:31:40 2020 New Revision: 357247 URL: https://svnweb.freebsd.org/changeset/base/357247 Log: ixgbe(4): Eliminate bogus sizeof() expressions All of these uses of sizeof() were on the wrong type in relation to the pointer passed to SYSCTL_ADD_PROC as arg1. Fo

svn commit: r357248 - head/sys/dev/bnxt

2020-01-28 Thread Conrad Meyer
Author: cem Date: Wed Jan 29 05:42:24 2020 New Revision: 357248 URL: https://svnweb.freebsd.org/changeset/base/357248 Log: bnxt(4): Eliminate wrong sizeof() expression in memset() While here, clean up magic numbers. The memset(,0,) (and M_ZERO!) can just be removed; the bit_alloc() API

svn commit: r357249 - head/usr.sbin/ypldap

2020-01-28 Thread Conrad Meyer
Author: cem Date: Wed Jan 29 05:59:22 2020 New Revision: 357249 URL: https://svnweb.freebsd.org/changeset/base/357249 Log: ypldap(8): Fix absent va_end() in 'goto fail' path In this path, we used va_start() without pairing it with va_end(). Add the va_end(). (va_start() without paired v

svn commit: r357273 - head/tests/sys/sys

2020-01-29 Thread Conrad Meyer
Author: cem Date: Wed Jan 29 22:37:01 2020 New Revision: 357273 URL: https://svnweb.freebsd.org/changeset/base/357273 Log: Revert r357246 I have no idea what this code is trying to do, leave it be. Reported by: lwhsu Modified: head/tests/sys/sys/qmath_test.c Modified: head/tests/s

Re: svn commit: r357246 - head/tests/sys/sys

2020-01-29 Thread Conrad Meyer
Hi Li-Wen, Thanks for the report. I went ahead and reverted it in r357273. Best, Conrad On Wed, Jan 29, 2020 at 8:47 AM Li-Wen Hsu wrote: > > On Wed, Jan 29, 2020 at 1:25 PM Conrad Meyer wrote: > > > > Author: cem > > Date: Wed Jan 29 05:25:20 2020 > > New R

svn commit: r357299 - head/contrib/apr/strings

2020-01-30 Thread Conrad Meyer
Author: cem Date: Thu Jan 30 17:50:51 2020 New Revision: 357299 URL: https://svnweb.freebsd.org/changeset/base/357299 Log: contrib/apr: Remove scope leak UB In apr_vformatter, the variable buf was declared inside a limited scope region, but a pointer to it is leaked outside of that region

svn commit: r357301 - head/contrib/apr/random/unix

2020-01-30 Thread Conrad Meyer
Author: cem Date: Thu Jan 30 18:12:41 2020 New Revision: 357301 URL: https://svnweb.freebsd.org/changeset/base/357301 Log: contrib/apr: Rip out bogus [CS]PRNG implementation This construction used some relatively slow design involving SHA2; even if it were fed real entropy (unclear; exter

svn commit: r357300 - head/sys/dev/aic7xxx

2020-01-30 Thread Conrad Meyer
Author: cem Date: Thu Jan 30 18:12:24 2020 New Revision: 357300 URL: https://svnweb.freebsd.org/changeset/base/357300 Log: aic7xxx(4): Fix unintended sign extension in ahd_inq() ahd_inb() returns type uint8_t. The shift left by untyped 24 implicitly promotes the result to type (signed) i

svn commit: r357336 - in head: share/man/man4 sys/x86/cpufreq

2020-01-31 Thread Conrad Meyer
Author: cem Date: Fri Jan 31 17:40:41 2020 New Revision: 357336 URL: https://svnweb.freebsd.org/changeset/base/357336 Log: hwpstate(4): Ignore CurPstateLimit by default Add a sysctl knob to allow users to re-enable it, and document the knob and default in cpufreq.4. (While here, add a fe

Re: svn commit: r357349 - in head/sys: conf modules/tpm

2020-01-31 Thread Conrad Meyer
Hi Dimitry, Do you think maybe the intent is to use ~TPM_CRB_CTRL_CANCEL_CMD instead? Plain "0" might also make sense. But I think the compiler is right here and the warning should not be disabled — !BIT(foo) doesn't really make sense for a register. It happens to affect the right bit only beca

Re: svn commit: r357337 - head/sys/riscv/include

2020-01-31 Thread Conrad Meyer
Hi John, Isn't the 32-bit MSTATUS_SD and SSTATUS_SD also UB without explicit unsigned suffix? Best, Conrad On Fri, Jan 31, 2020 at 9:49 AM John Baldwin wrote: > > Author: jhb > Date: Fri Jan 31 17:49:15 2020 > New Revision: 357337 > URL: https://svnweb.freebsd.org/changeset/base/357337 > > Log:

svn commit: r357372 - head/sys/x86/cpufreq

2020-02-01 Thread Conrad Meyer
Author: cem Date: Sat Feb 1 17:30:45 2020 New Revision: 357372 URL: https://svnweb.freebsd.org/changeset/base/357372 Log: intel_hwpstate(4): Don't leak bound thread in error conditions I don't know why a Skylake CPU with the HWP feature bit present would trap on MSR reads of the HWP regi

svn commit: r357373 - head/sys/x86/cpufreq

2020-02-01 Thread Conrad Meyer
Author: cem Date: Sat Feb 1 17:54:46 2020 New Revision: 357373 URL: https://svnweb.freebsd.org/changeset/base/357373 Log: intel_hwpstate(4): Use identcpu-cached cpuid 6 leaf No functional change. Modified: head/sys/x86/cpufreq/hwpstate_intel.c Modified: head/sys/x86/cpufreq/hwpstate_in

svn commit: r357377 - in head/sys/x86: cpufreq include x86

2020-02-01 Thread Conrad Meyer
Author: cem Date: Sat Feb 1 19:46:02 2020 New Revision: 357377 URL: https://svnweb.freebsd.org/changeset/base/357377 Log: x86: Add/amend some power-management comments/macros No functional change. Modified: head/sys/x86/cpufreq/hwpstate_intel.c head/sys/x86/include/specialreg.h head

svn commit: r357376 - head/sys/x86/cpufreq

2020-02-01 Thread Conrad Meyer
Author: cem Date: Sat Feb 1 19:45:27 2020 New Revision: 357376 URL: https://svnweb.freebsd.org/changeset/base/357376 Log: hwpstate_intel(4): Error check epp sysctl & bail if HW does not support feature Modified: head/sys/x86/cpufreq/hwpstate_intel.c Modified: head/sys/x86/cpufreq/hwpstate_

svn commit: r357378 - in head/sys/x86: cpufreq include

2020-02-01 Thread Conrad Meyer
Author: cem Date: Sat Feb 1 19:49:13 2020 New Revision: 357378 URL: https://svnweb.freebsd.org/changeset/base/357378 Log: hwpstate_intel(4): Add fallback EPP using PERF_BIAS MSR Per Intel SDM (Vol 3b Part 2), if HWP indicates EPP (energy-performance preference) is not supported, the hard

svn commit: r357379 - in head: share/man/man4 sys/x86/cpufreq

2020-02-01 Thread Conrad Meyer
Author: cem Date: Sat Feb 1 19:50:10 2020 New Revision: 357379 URL: https://svnweb.freebsd.org/changeset/base/357379 Log: hwpstate_intel(4): Detect and support PKG variant If package-level control is present, we default to using it. Per-core software control may be enabled by setting th

svn commit: r357380 - head/sys/x86/cpufreq

2020-02-01 Thread Conrad Meyer
Author: cem Date: Sat Feb 1 20:11:25 2020 New Revision: 357380 URL: https://svnweb.freebsd.org/changeset/base/357380 Log: hwpstate_intel(4): Print failure message only on failure X-MFC-With: r357379 Modified: head/sys/x86/cpufreq/hwpstate_intel.c Modified: head/sys/x86/cpufreq/hwpstate

svn commit: r357381 - head/sys/x86/cpufreq

2020-02-01 Thread Conrad Meyer
Author: cem Date: Sat Feb 1 20:12:02 2020 New Revision: 357381 URL: https://svnweb.freebsd.org/changeset/base/357381 Log: hwpstate_intel(4): Save admin-set EPP/EPB and restore after suspend Modified: head/sys/x86/cpufreq/hwpstate_intel.c Modified: head/sys/x86/cpufreq/hwpstate_intel.c =

Re: svn commit: r357349 - in head/sys: conf modules/tpm

2020-02-01 Thread Conrad Meyer
On Sat, Feb 1, 2020 at 10:10 AM Dimitry Andric wrote: > > On 1 Feb 2020, at 18:48, Ian Lepore wrote: > > > > So you're going to switch from writing 0 to writing 0xfffe, and > > just assume that will work the same? > > ... [Caustic sarcasm elided] > > Hmm, the data sheet says: > > Writes (

svn commit: r357382 - in head: include lib/libc/stdlib

2020-02-01 Thread Conrad Meyer
Author: cem Date: Sat Feb 1 20:33:23 2020 New Revision: 357382 URL: https://svnweb.freebsd.org/changeset/base/357382 Log: rand(3): Replace implementation with one backed by random(3) algorithm rand(3)'s standard C API is extremely limiting, but we can do better than the historical 32-bit

svn commit: r357386 - head/sys/dev/tpm

2020-02-01 Thread Conrad Meyer
Author: cem Date: Sat Feb 1 20:38:22 2020 New Revision: 357386 URL: https://svnweb.freebsd.org/changeset/base/357386 Log: tpm(4): Fix 'go ready' in TPM 2.0 TIS driver tpmtis_go_ready() read the value of the TPM_STS register, ORed TPM_STS_CMD_READY with it, and wrote it back. However, th

Re: svn commit: r357349 - in head/sys: conf modules/tpm

2020-02-01 Thread Conrad Meyer
Hi Dimitry, On Sat, Feb 1, 2020 at 12:29 PM Conrad Meyer wrote: > Please un-disable the Makefile warnings removed in r357349 earlier, too. Apologies, I just now caught up to my r357366 in my SVN email. Thank you. Best, Conrad ___ svn-src-

svn commit: r357425 - head/sys/netinet/libalias

2020-02-02 Thread Conrad Meyer
Author: cem Date: Mon Feb 3 05:19:44 2020 New Revision: 357425 URL: https://svnweb.freebsd.org/changeset/base/357425 Log: netinet/libalias: Fix typo in debug message No functional change. PR: 243831 Submitted by: Neel Chauhan Differential Revision:https://review

Re: svn commit: r357492 - in head/sys: kern sys

2020-02-04 Thread Conrad Meyer
Hi Dmitry, This seems to trigger some panics via clock_gettime syscalls (native and 32-bit, reported by Syzkaller): panic: mutex process lock not owned at /syzkaller/managers/main/kernel/sys/kern/kern_time.c:261 cpuid = 0 time = 1580841963 KDB: stack backtrace: db_trace_self_wrapper() at db_trace

Re: svn commit: r357614 - in head/sys: kern sys

2020-02-06 Thread Conrad Meyer
Hi Pawel, I don't think the (notyet) static assertion is quite right. On Thu, Feb 6, 2020 at 4:46 AM Pawel Biernacki wrote: > > Author: kaktus > Date: Thu Feb 6 12:45:58 2020 > New Revision: 357614 > URL: https://svnweb.freebsd.org/changeset/base/357614 > > Log: > sysctl(9): add CTLFLAG_NEEDG

svn commit: r360941 - head/sys/geom/mirror

2020-05-11 Thread Conrad Meyer
Author: cem Date: Mon May 11 22:39:53 2020 New Revision: 360941 URL: https://svnweb.freebsd.org/changeset/base/360941 Log: geom(4) mirror: Do not panic on gmirror(8) insert, resize Geom_mirror initialization occurs in spurts and the present of a non-destroyed g_mirror softc does not alway

svn commit: r360943 - head/share/man/man9

2020-05-11 Thread Conrad Meyer
Author: cem Date: Mon May 11 22:48:00 2020 New Revision: 360943 URL: https://svnweb.freebsd.org/changeset/base/360943 Log: copystr(9): Move to deprecate [1/2] Unlike the other copy*() functions, it does not serve to copy from one address space to another or protect against potential fault

svn commit: r360944 - in head: sys/amd64/amd64 sys/arm/arm sys/arm64/arm64 sys/fs/fuse sys/fs/unionfs sys/i386/i386 sys/kern sys/mips/mips sys/powerpc/powerpc sys/riscv/riscv sys/sys tools/coccinelle

2020-05-11 Thread Conrad Meyer
Author: cem Date: Mon May 11 22:57:21 2020 New Revision: 360944 URL: https://svnweb.freebsd.org/changeset/base/360944 Log: copystr(9): Move to deprecate [2/2] Unlike the other copy*() functions, it does not serve to copy from one address space to another or protect against potential fault

svn commit: r360946 - head/sys/conf

2020-05-11 Thread Conrad Meyer
Author: cem Date: Tue May 12 00:42:16 2020 New Revision: 360946 URL: https://svnweb.freebsd.org/changeset/base/360946 Log: Remove deleted files from the build Fix build break introduced in r360944. Reported by: kevans Modified: head/sys/conf/files.arm64 head/sys/conf/files.powerp

Re: svn commit: r360944 - in head: sys/amd64/amd64 sys/arm/arm sys/arm64/arm64 sys/fs/fuse sys/fs/unionfs sys/i386/i386 sys/kern sys/mips/mips sys/powerpc/powerpc sys/riscv/riscv sys/sys tools/coccine

2020-05-11 Thread Conrad Meyer
Thanks Cy. I’ll revert it when I’m back at a computer. Best, Conrad On Mon, May 11, 2020 at 20:28 Cy Schubert wrote: > In message <202005112257.04bmvmx2096...@repo.freebsd.org>, Conrad Meyer > writes: > > Author: cem > > Date: Mon May 11 22:57:21 2020 > > New R

svn commit: r360955 - in head: sys/amd64/amd64 sys/arm/arm sys/arm64/arm64 sys/conf sys/fs/fuse sys/fs/unionfs sys/i386/i386 sys/kern sys/mips/mips sys/powerpc/powerpc sys/riscv/riscv sys/sys tools...

2020-05-11 Thread Conrad Meyer
Author: cem Date: Tue May 12 04:34:26 2020 New Revision: 360955 URL: https://svnweb.freebsd.org/changeset/base/360955 Log: Revert r360944 and r360946 until reported issues can be resolved Reported by: cy Added: head/sys/arm64/arm64/copystr.c - copied unchanged from r360943, head/sy

Re: svn commit: r360983 - head/include

2020-05-12 Thread Conrad Meyer
Why not just use _Bool and leave the compatibility definition only for C++ (#define _Bool bool)? On Tue, May 12, 2020 at 11:12 AM Konstantin Belousov wrote: > > Author: kib > Date: Tue May 12 18:12:20 2020 > New Revision: 360983 > URL: https://svnweb.freebsd.org/changeset/base/360983 > > Log: >

svn commit: r361021 - in head: sys/kern usr.sbin/extattr/tests

2020-05-13 Thread Conrad Meyer
Author: cem Date: Thu May 14 03:01:23 2020 New Revision: 361021 URL: https://svnweb.freebsd.org/changeset/base/361021 Log: vfs_extattr: Allow extattr names up to the full max Extattr names are allowed to be 255 bytes -- not 254 bytes plus trailing NUL. Provide a 256 buffer so that copyin

svn commit: r361071 - head

2020-05-14 Thread Conrad Meyer
Author: cem Date: Fri May 15 03:54:25 2020 New Revision: 361071 URL: https://svnweb.freebsd.org/changeset/base/361071 Log: ObsoleteFiles: pdwait4.2.gz A belated follow-up to r320058. Modified: head/ObsoleteFiles.inc Modified: head/ObsoleteFiles.inc ==

svn commit: r361082 - in head: lib/libvmmapi sys/amd64/include sys/amd64/vmm usr.sbin/bhyve

2020-05-15 Thread Conrad Meyer
); init_inout(); + kernemu_dev_init(); init_bootrom(ctx); atkbdc_init(ctx); pci_irq_init(ctx); Added: head/usr.sbin/bhyve/kernemu_dev.c ========== --- /dev/null 00:00:00 1970 (empty, bec

svn commit: r361111 - in head/sys/cam: . ata mmc nvme scsi

2020-05-16 Thread Conrad Meyer
Author: cem Date: Sat May 16 14:33:08 2020 New Revision: 36 URL: https://svnweb.freebsd.org/changeset/base/36 Log: cam: ANSIfy 0-argument function definitions No functional change. Reviewed by: imp Differential Revision:https://reviews.freebsd.org/D24854 Modified:

Re: svn commit: r361143 - head/release/tools

2020-05-17 Thread Conrad Meyer
On Sun, May 17, 2020 at 4:49 PM Oliver Pinter wrote: > On Sunday, May 17, 2020, Colin Percival wrote: >> +# Provide instructions on how to mount the requested filesystem. >> +FS=$1 >> +REGION=`fetch -qo- >> http://169.254.169.254/latest/meta-data/placement/availability-zone | sed -e >> 's/[a-z]

Re: svn commit: r361209 - head/sys/netinet

2020-05-18 Thread Conrad Meyer
Hi Michael, These changes are a bit odd. The only reason a standards-compliant snprintf() would fail to nul-terminate a buffer is if the provided buffer had length zero. Since this is not the case in any of these uses, I wonder why this revision was made? Does a SCTP downstream have a broken sn

Re: svn commit: r361209 - head/sys/netinet

2020-05-18 Thread Conrad Meyer
27;t think either case applies to these strings, although I did not read all of them thoroughly.) On Mon, May 18, 2020 at 8:38 AM Conrad Meyer wrote: > > Hi Michael, > > These changes are a bit odd. The only reason a standards-compliant > snprintf() would fail to nul-terminate a

Re: svn commit: r361209 - head/sys/netinet

2020-05-18 Thread Conrad Meyer
On Mon, May 18, 2020 at 10:35 AM Michael Tuexen wrote: > > > On 18. May 2020, at 17:38, Conrad Meyer wrote: > > > > These changes are a bit odd. The only reason a standards-compliant > > snprintf() would fail to nul-terminate a buffer is if the provided > > bu

Re: svn commit: r361209 - head/sys/netinet

2020-05-18 Thread Conrad Meyer
Hi Michael, On Mon, May 18, 2020 at 12:05 PM Michael Tuexen wrote: > > > On 18. May 2020, at 20:23, Conrad Meyer wrote: > > > If truncation is intended, the GCC warning is spurious. Given how > > often snprintf is used in this way, I wonder if it would make sense to &g

svn commit: r361284 - in head/sys/amd64: include vmm

2020-05-20 Thread Conrad Meyer
Author: cem Date: Wed May 20 17:27:54 2020 New Revision: 361284 URL: https://svnweb.freebsd.org/changeset/base/361284 Log: vmm(4): Add 12 user ABI compat after r349948 Reported by: kp Reviewed by: jhb, kp Tested by:kp Differential Revision:https://reviews.freebsd.org/D24

Re: svn commit: r361363 - in head/lib/libprocstat: . zfs

2020-05-22 Thread Conrad Meyer
Hi Andriy, Would it make sense to also export sizes of those members? Currently the code assumes the members may be relocated in the struct, but never changed in size. If they can be moved around, maybe they might be enlarged or shrunk at some time too? Maybe not; I am not very familiar with ZF

svn commit: r361385 - head/contrib/tzcode/stdtime

2020-05-22 Thread Conrad Meyer
Author: cem Date: Fri May 22 15:30:14 2020 New Revision: 361385 URL: https://svnweb.freebsd.org/changeset/base/361385 Log: ctime.3: Use ASCII asterisks for C, not special unicode math glyphs PR: 246656 Reported by: danfe Modified: head/contrib/tzcode/stdtime/ctime.3 Modifie

svn commit: r361423 - in vendor/zstd/dist: . contrib contrib/docker contrib/experimental_dict_builders/benchmarkDictBuilder contrib/experimental_dict_builders/fastCover contrib/experimental_dict_bu...

2020-05-23 Thread Conrad Meyer
Author: cem Date: Sat May 23 20:37:33 2020 New Revision: 361423 URL: https://svnweb.freebsd.org/changeset/base/361423 Log: Import Zstd 1.4.5 Added: vendor/zstd/dist/lib/compress/zstd_compress_superblock.c (contents, props changed) vendor/zstd/dist/lib/compress/zstd_compress_superblock.h

svn commit: r361424 - in vendor/zstd/1.4.5: . contrib contrib/docker contrib/experimental_dict_builders/benchmarkDictBuilder contrib/experimental_dict_builders/fastCover contrib/experimental_dict_b...

2020-05-23 Thread Conrad Meyer
Author: cem Date: Sat May 23 20:38:30 2020 New Revision: 361424 URL: https://svnweb.freebsd.org/changeset/base/361424 Log: Tag Zstd 1.4.5 Added: vendor/zstd/1.4.5/ - copied from r361422, vendor/zstd/dist/ vendor/zstd/1.4.5/lib/compress/zstd_compress_superblock.c - copied unchanged

svn commit: r361425 - head/sys/contrib/zstd

2020-05-23 Thread Conrad Meyer
Author: cem Date: Sat May 23 20:39:36 2020 New Revision: 361425 URL: https://svnweb.freebsd.org/changeset/base/361425 Log: contrib/zstd: Revise Xlist for 1.4.5 import Modified: head/sys/contrib/zstd/FREEBSD-Xlist Modified: head/sys/contrib/zstd/FREEBSD-Xlist =

svn commit: r361426 - in head: lib/libzstd sys/conf sys/contrib/zstd sys/contrib/zstd/contrib sys/contrib/zstd/contrib/docker sys/contrib/zstd/contrib/experimental_dict_builders/benchmarkDictBuilde...

2020-05-23 Thread Conrad Meyer
Author: cem Date: Sat May 23 21:23:46 2020 New Revision: 361426 URL: https://svnweb.freebsd.org/changeset/base/361426 Log: Update to Zstandard 1.4.5 As usual, the full release notes are found on Github: https://github.com/facebook/zstd/releases/tag/v1.4.5 Notable changes include

svn commit: r361427 - head/sys/contrib/zstd/lib/common

2020-05-23 Thread Conrad Meyer
Author: cem Date: Sat May 23 23:10:03 2020 New Revision: 361427 URL: https://svnweb.freebsd.org/changeset/base/361427 Log: Unbreak ARM64 kernel build after r361426 X-MFC-With: r361426 Modified: head/sys/contrib/zstd/lib/common/zstd_internal.h Modified: head/sys/contrib/zstd/lib/common

svn commit: r361466 - in head: sys/amd64/amd64 sys/arm/arm sys/arm64/arm64 sys/conf sys/fs/fuse sys/fs/unionfs sys/i386/i386 sys/kern sys/mips/mips sys/powerpc/powerpc sys/riscv/riscv sys/sys tools...

2020-05-25 Thread Conrad Meyer
Author: cem Date: Mon May 25 16:40:48 2020 New Revision: 361466 URL: https://svnweb.freebsd.org/changeset/base/361466 Log: copystr(9): Move to deprecate (attempt #2) This reapplies logical r360944 and r360946 (reverting r360955), with fixed copystr() stand-in replacement macro. Eventuall

svn commit: r361540 - in head/sys/x86: include x86

2020-05-26 Thread Conrad Meyer
Author: cem Date: Tue May 26 23:12:57 2020 New Revision: 361540 URL: https://svnweb.freebsd.org/changeset/base/361540 Log: x86: Detect new feature bits Fix an off-by-one in AVX512VPOPCNTDQ identification. That was actually the TME bit. Reported by: debdrup Modified: head/sys/x86

svn commit: r361635 - head/sys/geom/part

2020-05-29 Thread Conrad Meyer
Author: cem Date: Fri May 29 19:44:18 2020 New Revision: 361635 URL: https://svnweb.freebsd.org/changeset/base/361635 Log: geom_part: Dispatch to partitions to create providers and aliases This allows partitions to create additional aliases of their own. The default method implementation

Re: svn commit: r361783 - head/usr.bin/killall

2020-06-04 Thread Conrad Meyer
On Thu, Jun 4, 2020 at 3:43 AM Eugene Grosbein wrote: > > 04.06.2020 11:29, Benjamin Kaduk wrote: > > --- head/usr.bin/killall/killall.1Thu Jun 4 02:36:41 2020 > > (r361782) > > +++ head/usr.bin/killall/killall.1Thu Jun 4 04:29:43 2020 > > (r361783) > > @@ -145,6 +145,50

svn commit: r361791 - head/etc/mtree

2020-06-04 Thread Conrad Meyer
Author: cem Date: Thu Jun 4 16:04:19 2020 New Revision: 361791 URL: https://svnweb.freebsd.org/changeset/base/361791 Log: Restrict default /root permissions Remove world-readability from the root directory. Sensitive information may be stored in /root and we diverge here from normative

Re: svn commit: r361791 - head/etc/mtree

2020-06-04 Thread Conrad Meyer
On Thu, Jun 4, 2020 at 9:04 AM Conrad Meyer wrote: > 750 is no more restrictive than defaults for the rest of the open source > Unix-alike world. In particular, Ben Woods surveyed DragonFly, NetBSD, > OpenBSD, ArchLinux, CentOS, Debian, Fedora, Slackware, and Ubuntu. None

svn commit: r361837 - head/sys/geom

2020-06-05 Thread Conrad Meyer
Author: cem Date: Fri Jun 5 16:05:09 2020 New Revision: 361837 URL: https://svnweb.freebsd.org/changeset/base/361837 Log: geom: Don't re-add duplicate aliases Reviewed by: imp (informal +1; extracted from phab 24968) Modified: head/sys/geom/geom_subr.c Modified: head/sys/geom/geom_sub

svn commit: r361838 - in head/sys/geom: . label

2020-06-05 Thread Conrad Meyer
Author: cem Date: Fri Jun 5 16:12:21 2020 New Revision: 361838 URL: https://svnweb.freebsd.org/changeset/base/361838 Log: geom_label: Use provider aliasing to alias upstream geoms For synthetic aliases (just pseudonyms inferred from metadata like GPT or UFS labels, GPT UUIDs, etc), use t

svn commit: r361870 - in head/sys/geom: . label

2020-06-06 Thread Conrad Meyer
Author: cem Date: Sat Jun 6 14:19:16 2020 New Revision: 361870 URL: https://svnweb.freebsd.org/changeset/base/361870 Log: Revert r361838 Reported by: delphij Modified: head/sys/geom/geom_dev.c head/sys/geom/label/g_label.c Modified: head/sys/geom/geom_dev.c =

svn commit: r361900 - head/sbin/reboot

2020-06-07 Thread Conrad Meyer
Author: cem Date: Mon Jun 8 00:46:19 2020 New Revision: 361900 URL: https://svnweb.freebsd.org/changeset/base/361900 Log: x86 boot.8: Remove obsolescent non-loader x86 boot documentation x86 boot uses loader(8) and the boot2-direct-to-kernel process is not supported. Remove the document

Re: svn commit: r362126 - head/sys/vm

2020-06-12 Thread Conrad Meyer
On Fri, Jun 12, 2020 at 2:53 PM Eric van Gyzen wrote: > Honor db_pager_quit in some vm_object ddb commands > > These can be rather verbose. We also have this (?)hack in OneFS, which eliminates the need for every debug function to check the db_pager globals: https://people.freebsd.org/~cem/db

svn commit: r362138 - head/sys/net80211

2020-06-12 Thread Conrad Meyer
Author: cem Date: Sat Jun 13 00:59:36 2020 New Revision: 362138 URL: https://svnweb.freebsd.org/changeset/base/362138 Log: net80211: Add framework for debugnet(4) support Allow net80211 drivers to register a small vtable of debugnet-related methods. This is not a functional change.

svn commit: r362141 - head/sys/kern

2020-06-12 Thread Conrad Meyer
Author: cem Date: Sat Jun 13 03:04:40 2020 New Revision: 362141 URL: https://svnweb.freebsd.org/changeset/base/362141 Log: Flip kern.tty_info_kstacks on by default It's a useful debug aid for anyone using Ctrl-T today, and doesn't seem to be widely known. So, enable it out of the box to

svn commit: r362142 - head/sys/net80211

2020-06-12 Thread Conrad Meyer
Author: cem Date: Sat Jun 13 03:16:09 2020 New Revision: 362142 URL: https://svnweb.freebsd.org/changeset/base/362142 Log: Fix !DEBUGNET build after r362138 X-MFC-With: r362138 Modified: head/sys/net80211/ieee80211_freebsd.c head/sys/net80211/ieee80211_freebsd.h Modified: head/sys/n

svn commit: r362253 - head/sys/vm

2020-06-16 Thread Conrad Meyer
Author: cem Date: Tue Jun 16 22:53:56 2020 New Revision: 362253 URL: https://svnweb.freebsd.org/changeset/base/362253 Log: vm: Drop vm_map_clip_{start,end} macro wrappers No functional change. Reviewed by: dougm, markj Sponsored by: Dell EMC Isilon Differential Revision:ht

Re: svn commit: r362253 - head/sys/vm

2020-06-17 Thread Conrad Meyer
On Wed, Jun 17, 2020 at 4:04 AM Konstantin Belousov wrote: > > On Tue, Jun 16, 2020 at 10:53:56PM +, Conrad Meyer wrote: > > Author: cem > > Date: Tue Jun 16 22:53:56 2020 > > New Revision: 362253 > > URL: https://svnweb.freebsd.org/changeset/base/3622

Re: svn commit: r362126 - head/sys/vm

2020-06-17 Thread Conrad Meyer
On Wed, Jun 17, 2020 at 10:50 AM John Baldwin wrote: > > On 6/12/20 3:33 PM, Conrad Meyer wrote: > > On Fri, Jun 12, 2020 at 2:53 PM Eric van Gyzen wrote: > >> Honor db_pager_quit in some vm_object ddb commands > >> > >> These can be rather verbose. >

Re: svn commit: r362126 - head/sys/vm

2020-06-18 Thread Conrad Meyer
On Thu, Jun 18, 2020 at 10:19 AM John Baldwin wrote: > > On 6/17/20 5:48 PM, Conrad Meyer wrote: > > db_printf checks the pager, via db_putc. > > It doesn't break out of the loops for you though (e.g. via setjmp or the > like). Commands still have to check db_pager_

Re: svn commit: r365984 - head/usr.bin/calendar/calendars

2020-09-21 Thread Conrad Meyer
Big ol plus one from me. On Mon, Sep 21, 2020 at 4:16 PM Cy Schubert wrote: > > In message <202009212255.08lmtpsp078...@repo.freebsd.org>, Greg Lehey > writes: > > Author: grog > > Date: Mon Sep 21 22:55:51 2020 > > New Revision: 365984 > > URL: https://svnweb.freebsd.org/changeset/base/365984 >

svn commit: r366078 - head/sbin/reboot

2020-09-23 Thread Conrad Meyer
Author: cem Date: Wed Sep 23 17:04:27 2020 New Revision: 366078 URL: https://svnweb.freebsd.org/changeset/base/366078 Log: nextboot(8): Fix behavior on non-ZFS /boot systems Fix unquoted test for an empty value, which broke nextboot(8) on non-ZFS /boot systems after r365938. Discusse

svn commit: r366136 - in head/sys/dev: amdsmn amdtemp

2020-09-24 Thread Conrad Meyer
n/amdsmn.cFri Sep 25 04:16:28 2020 (r366136) @@ -1,5 +1,5 @@ /*- - * Copyright (c) 2017-2019 Conrad Meyer + * Copyright (c) 2017-2020 Conrad Meyer * All rights reserved. * * Redistribution and use in source and binary forms, with or without @@ -60,6 +60,7 @@ __FBSDID("$FreeB

svn commit: r366291 - head/sys/gdb

2020-09-30 Thread Conrad Meyer
Author: cem Date: Wed Sep 30 14:55:54 2020 New Revision: 366291 URL: https://svnweb.freebsd.org/changeset/base/366291 Log: gdb(4): Don't escape GDB special characters at application layer In r351368, we introduced this XML- and GDB-encoded data. The protocol 'offset' should reflex the lo

Re: svn commit: r366291 - head/sys/gdb

2020-09-30 Thread Conrad Meyer
On Wed, Sep 30, 2020 at 7:56 AM Conrad Meyer wrote: > Author: cem > Date: Wed Sep 30 14:55:54 2020 > New Revision: 366291 > URL: https://svnweb.freebsd.org/changeset/base/366291 > > Log: > gdb(4): Don't escape GDB special characters at application layer > > In

svn commit: r366521 - head/usr.sbin/bhyveload

2020-10-07 Thread Conrad Meyer
Author: cem Date: Wed Oct 7 20:31:13 2020 New Revision: 366521 URL: https://svnweb.freebsd.org/changeset/base/366521 Log: bhyveload(8): Implement loader_callbacks::diskwrite The method was optional prior to r365938, which made it mandatory but did add any test that an implementation prov

svn commit: r366620 - in head/sys: conf dev/random/fenestrasX

2020-10-10 Thread Conrad Meyer
== --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/sys/dev/random/fenestrasX/fx_brng.cSat Oct 10 21:45:59 2020 (r366620) @@ -0,0 +1,295 @@ +/*- + * SPDX-License-Identifier: BSD-2-Clause-FreeBSD + * + * Copyright (c)

svn commit: r366621 - in head/sys: dev/random dev/random/fenestrasX libkern sys

2020-10-10 Thread Conrad Meyer
dded) +++ head/sys/dev/random/fenestrasX/fx_pub.h Sat Oct 10 21:48:06 2020 (r366621) @@ -0,0 +1,53 @@ +/*- + * SPDX-License-Identifier: BSD-2-Clause-FreeBSD + * + * Copyright (c) 2019 Conrad Meyer + * + * Redistribution and use in source and binary forms, with or without + * modif

svn commit: r366622 - in head: lib/libc/gen sys/amd64/amd64 sys/arm/arm sys/arm64/arm64 sys/compat/ia32 sys/dev/random/fenestrasX sys/i386/i386 sys/kern sys/mips/mips sys/powerpc/powerpc sys/riscv/...

2020-10-10 Thread Conrad Meyer
Author: cem Date: Sat Oct 10 21:52:00 2020 New Revision: 366622 URL: https://svnweb.freebsd.org/changeset/base/366622 Log: random(4) FenestrasX: Push root seed version to arc4random(3) Push the root seed version to userspace through the VDSO page, if the RANDOM_FENESTRASX algorithm is ena

svn commit: r362439 - head/sys/dev/oce

2020-06-20 Thread Conrad Meyer
Author: cem Date: Sat Jun 20 17:22:46 2020 New Revision: 362439 URL: https://svnweb.freebsd.org/changeset/base/362439 Log: oce(4): Account and trace mbufs before handing to hw Once tx mbufs have been handed to hardware, nothing serializes the tx path against completion and potential use-a

svn commit: r362447 - head/sbin/dump

2020-06-20 Thread Conrad Meyer
Author: cem Date: Sat Jun 20 20:14:50 2020 New Revision: 362447 URL: https://svnweb.freebsd.org/changeset/base/362447 Log: dump(8): Reapply slightly modified r362422 Go ahead and replace the distasteful slave language for worker processes with the straightforward description, "worker(s)."

svn commit: r362545 - head/usr.bin/sort

2020-06-23 Thread Conrad Meyer
Author: cem Date: Tue Jun 23 16:43:48 2020 New Revision: 362545 URL: https://svnweb.freebsd.org/changeset/base/362545 Log: sort(1): Fix two wchar-related bugs in radixsort Sort(1)'s radixsort implementation was broken for multibyte LC_CTYPEs in at least two ways: * In actual radix

svn commit: r362549 - head/sys/conf

2020-06-23 Thread Conrad Meyer
Author: cem Date: Tue Jun 23 18:25:31 2020 New Revision: 362549 URL: https://svnweb.freebsd.org/changeset/base/362549 Log: kmod.mk: Don't split out debug symbols if requested Ports bsd.kmod.mk explicitly sets MK_KERNEL_SYMBOLS=no to prevent auto- splitting of debuginfo from kernel modules

svn commit: r362587 - in head: . lib/clang/libclang share/mk targets/pseudo/bootstrap-tools targets/pseudo/clang tools/build/mk tools/build/options usr.bin/clang

2020-06-24 Thread Conrad Meyer
Author: cem Date: Wed Jun 24 17:03:42 2020 New Revision: 362587 URL: https://svnweb.freebsd.org/changeset/base/362587 Log: Add WITH_CLANG_FORMAT option clang-format is enabled conditional on either WITH_CLANG_EXTRAS or WITH_CLANG_FORMAT. Some sources in libclang are build conditional on

svn commit: r362588 - head/share/man/man5

2020-06-24 Thread Conrad Meyer
Author: cem Date: Wed Jun 24 17:31:21 2020 New Revision: 362588 URL: https://svnweb.freebsd.org/changeset/base/362588 Log: Regenerate src.conf.5 after r362587 Modified: head/share/man/man5/src.conf.5 Modified: head/share/man/man5/src.conf.5 ===

svn commit: r362590 - head

2020-06-24 Thread Conrad Meyer
Author: cem Date: Wed Jun 24 18:40:43 2020 New Revision: 362590 URL: https://svnweb.freebsd.org/changeset/base/362590 Log: Update .clang-format with style(9) header-sorting Thanks to work done in the NetBSD clang-format project. No functional change. Reviewed by: markj Differential

svn commit: r362595 - head

2020-06-24 Thread Conrad Meyer
Author: cem Date: Wed Jun 24 22:42:46 2020 New Revision: 362595 URL: https://svnweb.freebsd.org/changeset/base/362595 Log: Update .clang-format type and foreach macros lists No functional change. Reviewed by: markj Differential Revision:https://reviews.freebsd.org/D25429 Mo

svn commit: r362596 - head

2020-06-24 Thread Conrad Meyer
Author: cem Date: Wed Jun 24 23:22:36 2020 New Revision: 362596 URL: https://svnweb.freebsd.org/changeset/base/362596 Log: Clang-format: Avoid hardcoded LLVM include-order style Reported by: emaste Modified: head/.clang-format Modified: head/.clang-format ==

svn commit: r362600 - in head: sys/amd64/include sys/amd64/vmm usr.sbin/bhyve

2020-06-24 Thread Conrad Meyer
Author: cem Date: Thu Jun 25 00:18:42 2020 New Revision: 362600 URL: https://svnweb.freebsd.org/changeset/base/362600 Log: bhyve(8): For prototyping, reattempt decode in userspace If userspace has a newer bhyve than the kernel, it may be able to decode and emulate some instructions vmm.ko

svn commit: r362784 - head/sys/vm

2020-06-29 Thread Conrad Meyer
Author: cem Date: Mon Jun 29 16:54:00 2020 New Revision: 362784 URL: https://svnweb.freebsd.org/changeset/base/362784 Log: vm: Add missing WITNESS warnings for M_WAITOK allocation vm_map_clip_{end,start} and lookup_clip_start allocate memory M_WAITOK for !system_map vm_maps. Add WITNESS

svn commit: r362818 - in head/secure/lib: libcrypto libssl

2020-06-30 Thread Conrad Meyer
Author: cem Date: Wed Jul 1 00:59:28 2020 New Revision: 362818 URL: https://svnweb.freebsd.org/changeset/base/362818 Log: Replace OPENSSL_NO_SSL3_METHODs with dummies SSLv3 has been deprecated since 2015 (and broken since 2014: "POODLE"); it should not have shipped in FreeBSD 11 (2016) o

svn commit: r362823 - in head/sys: amd64/conf conf geom/part i386/conf

2020-06-30 Thread Conrad Meyer
Author: cem Date: Wed Jul 1 02:16:36 2020 New Revision: 362823 URL: https://svnweb.freebsd.org/changeset/base/362823 Log: geom(4): Kill GEOM_PART_EBR_COMPAT option Take advantage of Warner's nice new real GEOM aliasing system and use it for aliased partition names that actually work.

svn commit: r362913 - in head/sys: amd64/amd64 amd64/include crypto/aesni crypto/blake2

2020-07-03 Thread Conrad Meyer
Author: cem Date: Fri Jul 3 14:54:46 2020 New Revision: 362913 URL: https://svnweb.freebsd.org/changeset/base/362913 Log: Add domain policy allocation for amd64 fpu_kern_ctx Like other types of allocation, fpu_kern_ctx are frequently allocated per-cpu. Provide the API and sketch some exa

Re: svn commit: r362936 - head/sbin/newfs_msdos

2020-07-04 Thread Conrad Meyer
Hi Xin Li, Maybe we can use C11 static_assert instead of the CTASSERT array mechanism? Best, Conrad On Sat, Jul 4, 2020 at 11:37 Xin LI wrote: > Author: delphij > Date: Sat Jul 4 18:37:04 2020 > New Revision: 362936 > URL: https://svnweb.freebsd.org/changeset/base/362936 > > Log: > Gather w

Re: svn commit: r363125 - head/sys/compat/linux

2020-07-12 Thread Conrad Meyer
Hi Alexander, On Sun, Jul 12, 2020 at 2:51 AM Alexander Leidinger wrote: > > Author: netchild > Date: Sun Jul 12 09:51:09 2020 > New Revision: 363125 > URL: https://svnweb.freebsd.org/changeset/base/363125 > > Log: > Implement CLOCK_MONOTONIC_RAW (linux >= 2.6.28). > > It is documented as a r

svn commit: r363266 - in head/sys: amd64/amd64 i386/i386 mips/mips powerpc/aim powerpc/booke

2020-07-16 Thread Conrad Meyer
Author: cem Date: Thu Jul 16 23:29:26 2020 New Revision: 363266 URL: https://svnweb.freebsd.org/changeset/base/363266 Log: Revert r240317 to prevent leaking pmap entries Subsequent to r240317, kmem_free() was replaced with kva_free() (r254025). kva_free() releases the KVA allocation for t

<    1   2   3   4   5   6   7   8   9   10   >