Re: svn commit: r356755 - in head/sys: net netinet netinet6 netpfil/ipfw/nat64 sys

2020-01-16 Thread Gleb Smirnoff
On Thu, Jan 16, 2020 at 12:06:17PM -0800, Cy Schubert wrote: C> On January 15, 2020 2:38:05 PM PST, Gleb Smirnoff wrote: C> >On Wed, Jan 15, 2020 at 09:44:53AM -1000, Jeff Roberson wrote: C> >J> On Wed, 15 Jan 2020, Gleb Smirnoff wrote: C> >J> C> >J> > Author: glebius C> >J> > Date: Wed Jan 15

Re: svn commit: r356755 - in head/sys: net netinet netinet6 netpfil/ipfw/nat64 sys

2020-01-16 Thread Cy Schubert
On January 15, 2020 2:38:05 PM PST, Gleb Smirnoff wrote: >On Wed, Jan 15, 2020 at 09:44:53AM -1000, Jeff Roberson wrote: >J> On Wed, 15 Jan 2020, Gleb Smirnoff wrote: >J> >J> > Author: glebius >J> > Date: Wed Jan 15 06:05:20 2020 >J> > New Revision: 356755 >J> > URL:

Re: svn commit: r356755 - in head/sys: net netinet netinet6 netpfil/ipfw/nat64 sys

2020-01-16 Thread John Baldwin
On 1/15/20 2:38 PM, Gleb Smirnoff wrote: > On Wed, Jan 15, 2020 at 09:44:53AM -1000, Jeff Roberson wrote: > J> On Wed, 15 Jan 2020, Gleb Smirnoff wrote: > J> > J> > Author: glebius > J> > Date: Wed Jan 15 06:05:20 2020 > J> > New Revision: 356755 > J> > URL:

Re: svn commit: r356755 - in head/sys: net netinet netinet6 netpfil/ipfw/nat64 sys

2020-01-15 Thread Conrad Meyer
On Wed, Jan 15, 2020 at 12:36 PM Warner Losh wrote: > Everywhere else in the system, it's fnp, argp for ordering the args... You'd > be hard pressed to find exceptions to this rule. Since this is a new > interface, we should fix it now while we still can :) qsort_r() is one exception (and that

Re: svn commit: r356755 - in head/sys: net netinet netinet6 netpfil/ipfw/nat64 sys

2020-01-15 Thread Gleb Smirnoff
On Wed, Jan 15, 2020 at 09:44:53AM -1000, Jeff Roberson wrote: J> On Wed, 15 Jan 2020, Gleb Smirnoff wrote: J> J> > Author: glebius J> > Date: Wed Jan 15 06:05:20 2020 J> > New Revision: 356755 J> > URL: https://svnweb.freebsd.org/changeset/base/356755 J> > J> > Log: J> > Introduce

Re: svn commit: r356755 - in head/sys: net netinet netinet6 netpfil/ipfw/nat64 sys

2020-01-15 Thread Warner Losh
On Wed, Jan 15, 2020 at 12:45 PM Jeff Roberson wrote: > On Wed, 15 Jan 2020, Gleb Smirnoff wrote: > > > Author: glebius > > Date: Wed Jan 15 06:05:20 2020 > > New Revision: 356755 > > URL: https://svnweb.freebsd.org/changeset/base/356755 > > > > Log: > > Introduce NET_EPOCH_CALL() macro and use

Re: svn commit: r356755 - in head/sys: net netinet netinet6 netpfil/ipfw/nat64 sys

2020-01-15 Thread Jeff Roberson
On Wed, 15 Jan 2020, Gleb Smirnoff wrote: Author: glebius Date: Wed Jan 15 06:05:20 2020 New Revision: 356755 URL: https://svnweb.freebsd.org/changeset/base/356755 Log: Introduce NET_EPOCH_CALL() macro and use it everywhere where we free data based on the network epoch. The macro reverses

Re: svn commit: r356755 - in head/sys: net netinet netinet6 netpfil/ipfw/nat64 sys

2020-01-15 Thread Gleb Smirnoff
On Wed, Jan 15, 2020 at 09:51:02AM +0100, Hans Petter Selasky wrote: H> On 2020-01-15 07:10, Gleb Smirnoff wrote: H> > I really want to reverse the argument order of epoch_call() as well. H> > The current order is really backwards: H> > H> > void H> > epoch_call(epoch_t epoch,

Re: svn commit: r356755 - in head/sys: net netinet netinet6 netpfil/ipfw/nat64 sys

2020-01-15 Thread Hans Petter Selasky
On 2020-01-15 07:10, Gleb Smirnoff wrote: I really want to reverse the argument order of epoch_call() as well. The current order is really backwards: void epoch_call(epoch_t epoch, epoch_context_t ctx, void (*callback)(epoch_context_t)); Suggested declaration is:

Re: svn commit: r356755 - in head/sys: net netinet netinet6 netpfil/ipfw/nat64 sys

2020-01-15 Thread Mark Linimon
On Tue, Jan 14, 2020 at 10:10:46PM -0800, Gleb Smirnoff wrote: > void > epoch_call(epoch_t epoch, epoch_context_t ctx, > void (*callback)(epoch_context_t)); > > void > epoch_call(epoch_t epoch, epoch_context_t ctx, > void (*callback)(epoch_context_t)); I'm

Re: svn commit: r356755 - in head/sys: net netinet netinet6 netpfil/ipfw/nat64 sys

2020-01-14 Thread Steven Hartland
Aren’t the current and suggested the same there or do I need more coffee this morning? On Wed, 15 Jan 2020 at 06:10, Gleb Smirnoff wrote: > Hi, > > On Wed, Jan 15, 2020 at 06:05:20AM +, Gleb Smirnoff wrote: > T> Log: > T> Introduce NET_EPOCH_CALL() macro and use it everywhere where we

Re: svn commit: r356755 - in head/sys: net netinet netinet6 netpfil/ipfw/nat64 sys

2020-01-14 Thread Gleb Smirnoff
Hi, On Wed, Jan 15, 2020 at 06:05:20AM +, Gleb Smirnoff wrote: T> Log: T> Introduce NET_EPOCH_CALL() macro and use it everywhere where we free T> data based on the network epoch. The macro reverses the argument T> order of epoch_call(9) - first function, then its argument. NFC I

svn commit: r356755 - in head/sys: net netinet netinet6 netpfil/ipfw/nat64 sys

2020-01-14 Thread Gleb Smirnoff
Author: glebius Date: Wed Jan 15 06:05:20 2020 New Revision: 356755 URL: https://svnweb.freebsd.org/changeset/base/356755 Log: Introduce NET_EPOCH_CALL() macro and use it everywhere where we free data based on the network epoch. The macro reverses the argument order of epoch_call(9) -