Re: svn commit: r344129 - head
> On Feb 14, 2019, at 19:08, Warner Losh wrote: > >> On Thu, Feb 14, 2019, 1:42 PM Rodney W. Grimes >> > > On Thu, Feb 14, 2019 at 12:00:22PM -0700, Warner Losh wrote: >> > > On Thu, Feb 14, 2019 at 11:29 AM Rodney W. Grimes < >> > > > > Differential Review: https://reviews.freebsd.org/D19193 >> > > > >> > > > You sited a differential, but not give any attribution >> > > > to the external source :-( >> > > > >> > > >> > > The differential review has that information. >> > >> > External contributors should be recognized by having their names appear >> > in the commit logs. >> >> We even bother to put a special line in the commit template >> for this. Further it has been standard operating procedure >> for at least as long as I have been back that submitters >> are infact recognized in commit messages. >> >> You have, again, summarily dismissed valid feedback. > > > The problem is that was a trivial commit. And you offered not one, but two > complaints about adding an 'e' to the updating file. That's what pissed me > off. It's advice that might be correct, but was so far over the top, in > public, for such a trivial commit. That's why I got mad: it added no value > and seemed nit picky and pretty. So I lost it. I shouldn't have, but I did. > > I'm sorry for my cool. Thank you both Rod and Warner for the reply. Thank you Rod for noting that src-committers was a public list; I thought it was private to FreeBSD src committers. I replied to this thread because while I agree with what you said, I felt that the reaction and forum were not in proportion to what happened :/. More than a handful of threads lately have become heated to a point that concerns me about inter-developer relations and perception outside of the community. I have taken part in some of the discussions, potentially contributing to the overall issue. I’m happy with the eventual outcome, but I hope that we, as a group, can do better next time to avoid these situations and be kinder to one another. Many of the recent issues (while important in aggregate) seem minor (in disaggregate). All the best, -Enji ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r344129 - head
On Thu, Feb 14, 2019, 1:42 PM Rodney W. Grimes < free...@pdx.rh.cn85.dnsmgr.net wrote: > > On Thu, Feb 14, 2019 at 12:00:22PM -0700, Warner Losh wrote: > > > On Thu, Feb 14, 2019 at 11:29 AM Rodney W. Grimes < > > > > > Differential Review: https://reviews.freebsd.org/D19193 > > > > > > > > You sited a differential, but not give any attribution > > > > to the external source :-( > > > > > > > > > > The differential review has that information. > > > > External contributors should be recognized by having their names appear > > in the commit logs. > > We even bother to put a special line in the commit template > for this. Further it has been standard operating procedure > for at least as long as I have been back that submitters > are infact recognized in commit messages. > > You have, again, summarily dismissed valid feedback. > The problem is that was a trivial commit. And you offered not one, but two complaints about adding an 'e' to the updating file. That's what pissed me off. It's advice that might be correct, but was so far over the top, in public, for such a trivial commit. That's why I got mad: it added no value and seemed nit picky and pretty. So I lost it. I shouldn't have, but I did. I'm sorry for my cool. Warner > ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r344129 - head
On Thu, Feb 14, 2019, 1:48 PM Juli Mallett On Thu, 14 Feb 2019 at 12:42, Rodney W. Grimes <
> free...@pdx.rh.cn85.dnsmgr.net> wrote:
>
>> > On Thu, Feb 14, 2019 at 12:00:22PM -0700, Warner Losh wrote:
>> > > On Thu, Feb 14, 2019 at 11:29 AM Rodney W. Grimes <
>> > > > > Differential Review: https://reviews.freebsd.org/D19193
>> > > >
>> > > > You sited a differential, but not give any attribution
>> > > > to the external source :-(
>> > > >
>> > >
>> > > The differential review has that information.
>> >
>> > External contributors should be recognized by having their names appear
>> > in the commit logs.
>>
>> We even bother to put a special line in the commit template
>> for this. Further it has been standard operating procedure
>> for at least as long as I have been back that submitters
>> are infact recognized in commit messages.
>>
>
> Yeah, Phabricator must not become a second source of truth for who
> actually did the work, which we had at least one case of recently. That's
> no good. In this case, the difference between a patch and a bug report is
> indistinguishable ("word X is misspelt at offset Y in file Z" is probably
> not really Phabricator fodder at the scale of a single instance), but it
> should plainly either be a Reported byline if not a Submitted one in the
> commit message itself.
>
This is the most pointless waste of time of the year. It was a one letter
typo. Yes, maybe I should have included the submitter's name, but I didn't.
It doesn't deserve a long thread and a snarky response. Geeze people, get
some perspective.
Warner
>
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r344129 - head
On Thu, 14 Feb 2019 at 12:42, Rodney W. Grimes <
free...@pdx.rh.cn85.dnsmgr.net> wrote:
> > On Thu, Feb 14, 2019 at 12:00:22PM -0700, Warner Losh wrote:
> > > On Thu, Feb 14, 2019 at 11:29 AM Rodney W. Grimes <
> > > > > Differential Review: https://reviews.freebsd.org/D19193
> > > >
> > > > You sited a differential, but not give any attribution
> > > > to the external source :-(
> > > >
> > >
> > > The differential review has that information.
> >
> > External contributors should be recognized by having their names appear
> > in the commit logs.
>
> We even bother to put a special line in the commit template
> for this. Further it has been standard operating procedure
> for at least as long as I have been back that submitters
> are infact recognized in commit messages.
>
Yeah, Phabricator must not become a second source of truth for who actually
did the work, which we had at least one case of recently. That's no good.
In this case, the difference between a patch and a bug report is
indistinguishable ("word X is misspelt at offset Y in file Z" is probably
not really Phabricator fodder at the scale of a single instance), but it
should plainly either be a Reported byline if not a Submitted one in the
commit message itself.
Juli.
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r344129 - head
> On Thu, Feb 14, 2019 at 12:00:22PM -0700, Warner Losh wrote: > > On Thu, Feb 14, 2019 at 11:29 AM Rodney W. Grimes < > > > > Differential Review: https://reviews.freebsd.org/D19193 > > > > > > You sited a differential, but not give any attribution > > > to the external source :-( > > > > > > > The differential review has that information. > > External contributors should be recognized by having their names appear > in the commit logs. We even bother to put a special line in the commit template for this. Further it has been standard operating procedure for at least as long as I have been back that submitters are infact recognized in commit messages. You have, again, summarily dismissed valid feedback. -- Rod Grimes rgri...@freebsd.org ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r344129 - head
On Thu, Feb 14, 2019 at 12:00:22PM -0700, Warner Losh wrote: > On Thu, Feb 14, 2019 at 11:29 AM Rodney W. Grimes < > > > Differential Review: https://reviews.freebsd.org/D19193 > > > > You sited a differential, but not give any attribution > > to the external source :-( > > > > The differential review has that information. External contributors should be recognized by having their names appear in the commit logs. ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r344129 - head
On Thu, Feb 14, 2019 at 11:29 AM Rodney W. Grimes < free...@pdx.rh.cn85.dnsmgr.net> wrote: > > Author: imp > > Date: Thu Feb 14 17:04:04 2019 > > New Revision: 344129 > > URL: https://svnweb.freebsd.org/changeset/base/344129 > > > > Log: > > Fix small typo. > > A small request, when we fix a typo could we > do: > fix typo: frambuffer -> framebuffer > No. Diff tells you that. > Thanks, > Rod > > > > Differential Review: https://reviews.freebsd.org/D19193 > > You sited a differential, but not give any attribution > to the external source :-( > The differential review has that information. Warner > > Modified: > > head/UPDATING > > > > Modified: head/UPDATING > > > == > > --- head/UPDATING Thu Feb 14 15:45:53 2019(r344128) > > +++ head/UPDATING Thu Feb 14 17:04:04 2019(r344129) > > @@ -237,7 +237,7 @@ NOTE TO PEOPLE WHO THINK THAT FreeBSD 13.x IS SLOW: > > 20180719: > > ARM64 now have efifb support, if you want to have serial console > > on your arm64 board when an screen is connected and the bootloader > > - setup a frambuffer for us to use, just add : > > + setup a framebuffer for us to use, just add : > > boot_serial=YES > > boot_multicons=YES > > in /boot/loader.conf > > -- > Rod Grimes > rgri...@freebsd.org > ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r344129 - head
> Author: imp > Date: Thu Feb 14 17:04:04 2019 > New Revision: 344129 > URL: https://svnweb.freebsd.org/changeset/base/344129 > > Log: > Fix small typo. A small request, when we fix a typo could we do: fix typo: frambuffer -> framebuffer Thanks, Rod > > Differential Review: https://reviews.freebsd.org/D19193 You sited a differential, but not give any attribution to the external source :-( > Modified: > head/UPDATING > > Modified: head/UPDATING > == > --- head/UPDATING Thu Feb 14 15:45:53 2019(r344128) > +++ head/UPDATING Thu Feb 14 17:04:04 2019(r344129) > @@ -237,7 +237,7 @@ NOTE TO PEOPLE WHO THINK THAT FreeBSD 13.x IS SLOW: > 20180719: > ARM64 now have efifb support, if you want to have serial console > on your arm64 board when an screen is connected and the bootloader > - setup a frambuffer for us to use, just add : > + setup a framebuffer for us to use, just add : > boot_serial=YES > boot_multicons=YES > in /boot/loader.conf -- Rod Grimes rgri...@freebsd.org ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
