Re: svn commit: r330782 - head/sys/x86/isa

[Ian Lepore]

On Sun, 2018-03-11 at 19:56 +, Ian Lepore wrote:
> Author: ian
> Date: Sun Mar 11 19:56:07 2018
> New Revision: 330782
> URL: https://svnweb.freebsd.org/changeset/base/330782
> 
> Log:
>   Remove MTX_NOPROFILE from atrtc_lock, it was inappropriately copy/pasted
>   from the i8254 driver when I created separate mutexes for each.  The i8254
>   driver could be the active timecounter, leading to recursion during mutex
>   profiling, but the atrtc driver cannot be a timecounter, so it isn't needed.
> 
> Modified:
>   head/sys/x86/isa/atrtc.c

Oops, should have included: Pointed out by: bde.

-- Ian
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r330782 - head/sys/x86/isa

[Ian Lepore]

Author: ian
Date: Sun Mar 11 19:56:07 2018
New Revision: 330782
URL: https://svnweb.freebsd.org/changeset/base/330782

Log:
  Remove MTX_NOPROFILE from atrtc_lock, it was inappropriately copy/pasted
  from the i8254 driver when I created separate mutexes for each.  The i8254
  driver could be the active timecounter, leading to recursion during mutex
  profiling, but the atrtc driver cannot be a timecounter, so it isn't needed.

Modified:
  head/sys/x86/isa/atrtc.c

Modified: head/sys/x86/isa/atrtc.c
==
--- head/sys/x86/isa/atrtc.cSun Mar 11 19:26:34 2018(r330781)
+++ head/sys/x86/isa/atrtc.cSun Mar 11 19:56:07 2018(r330782)
@@ -63,7 +63,7 @@ __FBSDID("$FreeBSD$");
  * on x86 platforms.
  */
 struct mtx atrtc_lock;
-MTX_SYSINIT(atrtc_lock_init, &atrtc_lock, "atrtc", MTX_SPIN | MTX_NOPROFILE);
+MTX_SYSINIT(atrtc_lock_init, &atrtc_lock, "atrtc", MTX_SPIN);
 
 intatrtcclock_disable = 0;
 
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"