svn commit: r303821 - head/sys/dev/etherswitch/arswitch

2016-08-07 Thread Sepherosa Ziehau
Author: sephe Date: Mon Aug 8 05:57:04 2016 New Revision: 303821 URL: https://svnweb.freebsd.org/changeset/base/303821 Log: etherswitch: Unbreak LINT build Sponsored by: Microsoft Modified: head/sys/dev/etherswitch/arswitch/arswitch_reg.c Modified:

Re: svn commit: r303716 - head/crypto/openssh

2016-08-07 Thread Andrey Chernov
On 08.08.2016 1:48, Xin Li wrote: > Well, despite the fact that I have to admit that I get locked out from > my own storage box too, however (even without wearing any hat) I am for > the change and would blame myself for being lazy in adopting the change > when the upstream have announced it

Re: svn commit: r303716 - head/crypto/openssh

2016-08-07 Thread Andrey Chernov
On 08.08.2016 0:28, Andrey Chernov wrote: > On 08.08.2016 0:20, Warner Losh wrote: >> >>> On Aug 7, 2016, at 3:11 PM, Andrey Chernov wrote: >>> OTOH, FreeBSD has a documented deprecation process that says things will continue working for a major release after being

Re: svn commit: r303716 - head/crypto/openssh

2016-08-07 Thread Xin Li
On 8/7/16 14:20, Warner Losh wrote: > >> On Aug 7, 2016, at 3:11 PM, Andrey Chernov wrote: >> >>> OTOH, FreeBSD has a documented deprecation process that says things will >>> continue working for a major release after being formally deprecated. >> >> FreeBSD 11 is not

Re: svn commit: r303716 - head/crypto/openssh

2016-08-07 Thread Andrey Chernov
On 08.08.2016 0:20, Warner Losh wrote: > >> On Aug 7, 2016, at 3:11 PM, Andrey Chernov wrote: >> >>> OTOH, FreeBSD has a documented deprecation process that says things will >>> continue working for a major release after being formally deprecated. >> >> FreeBSD 11 is not

Re: svn commit: r303716 - head/crypto/openssh

2016-08-07 Thread Warner Losh
> On Aug 7, 2016, at 3:11 PM, Andrey Chernov wrote: > >> OTOH, FreeBSD has a documented deprecation process that says things will >> continue working for a major release after being formally deprecated. > > FreeBSD 11 is not released yet (betas are not counted), stable-10

Re: svn commit: r303811 - in head/sys: net net80211

2016-08-07 Thread Adrian Chadd
[snip everything] uugh. Someone please solve this by writing ETHER_ADDR_COMPARE() so it can be overridden per architecture. :) I committed Ryan's work. If someone has a better thingy, please do feel free to review and commit the thingy. :-P -adrian (woo, first bikeshed in a

Re: svn commit: r303811 - in head/sys: net net80211

2016-08-07 Thread Bruce Evans
On Mon, 8 Aug 2016, Bruce Simpson wrote: On 07/08/16 20:23, Peter Jeremy wrote: On 08/07/16 05:48, Adrian Chadd wrote: +#defineETHER_IS_BROADCAST(addr) \ ... IMHO, Adrian's code is clearer and micro-optimisations like this belong in the complier, not the code. Both are unclear

Re: svn commit: r303811 - in head/sys: net net80211

2016-08-07 Thread Bruce Simpson
On 07/08/16 20:23, Peter Jeremy wrote: On 08/07/16 05:48, Adrian Chadd wrote: +#defineETHER_IS_BROADCAST(addr) \ ... IMHO, Adrian's code is clearer and micro-optimisations like this belong in the complier, not the code. *cough* *cough* 2007 wants its patch back.

svn commit: r303819 - head/sys/netinet

2016-08-07 Thread Michael Tuexen
Author: tuexen Date: Sun Aug 7 23:04:46 2016 New Revision: 303819 URL: https://svnweb.freebsd.org/changeset/base/303819 Log: Consistently check for unsent data on the stream queues. MFC after:3 days Modified: head/sys/netinet/sctp_input.c head/sys/netinet/sctp_output.c Modified:

svn commit: r303818 - head/sys/contrib/cloudabi

2016-08-07 Thread Ed Schouten
Author: ed Date: Sun Aug 7 21:23:55 2016 New Revision: 303818 URL: https://svnweb.freebsd.org/changeset/base/303818 Log: Sync in the latest CloudABI constants and data types. The only change is the addition of AT_SYSINFO_EHDR, which can be used for providing a vDSO. Obtained from:

Re: svn commit: r303716 - head/crypto/openssh

2016-08-07 Thread Andrey Chernov
On 07.08.2016 22:56, Slawa Olhovchenkov wrote: > On Sun, Aug 07, 2016 at 10:42:56PM +0300, Andrey Chernov wrote: > >> On 07.08.2016 22:10, Slawa Olhovchenkov wrote: >>> On Sun, Aug 07, 2016 at 10:02:52PM +0300, Andrey Chernov wrote: >>> On 07.08.2016 21:52, Slawa Olhovchenkov wrote: >>

Re: svn commit: r303716 - head/crypto/openssh

2016-08-07 Thread Peter Jeremy
On 2016-Aug-07 15:25:54 +0300, Andrey Chernov wrote: >You should address your complains to original openssh author instead, it >was his decision to get rid of weak algos. No. It's up to the person who imported the code into FreeBSD to understand why the change was made and to

Re: svn commit: r303716 - head/crypto/openssh

2016-08-07 Thread Slawa Olhovchenkov
On Sun, Aug 07, 2016 at 10:42:56PM +0300, Andrey Chernov wrote: > On 07.08.2016 22:10, Slawa Olhovchenkov wrote: > > On Sun, Aug 07, 2016 at 10:02:52PM +0300, Andrey Chernov wrote: > > > >> On 07.08.2016 21:52, Slawa Olhovchenkov wrote: > Why you still not > send your opinion to the

Re: svn commit: r303716 - head/crypto/openssh

2016-08-07 Thread Andrey Chernov
On 07.08.2016 22:10, Slawa Olhovchenkov wrote: > On Sun, Aug 07, 2016 at 10:02:52PM +0300, Andrey Chernov wrote: > >> On 07.08.2016 21:52, Slawa Olhovchenkov wrote: Why you still not send your opinion to the author? >>> >>> I am not sure about suitable response from autor. >>> May

Re: svn commit: r303811 - in head/sys: net net80211

2016-08-07 Thread Peter Jeremy
On 2016-Aug-07 11:03:23 +0200, Hans Petter Selasky wrote: >On 08/07/16 05:48, Adrian Chadd wrote: >> +#define ETHER_IS_BROADCAST(addr) \ >> +(((addr)[0] & (addr)[1] & (addr)[2] & \ >> + (addr)[3] & (addr)[4] & (addr)[5]) == 0xff) >> >The compiler might be able to

Re: svn commit: r303716 - head/crypto/openssh

2016-08-07 Thread Slawa Olhovchenkov
On Sun, Aug 07, 2016 at 10:02:52PM +0300, Andrey Chernov wrote: > On 07.08.2016 21:52, Slawa Olhovchenkov wrote: > >> Why you still not > >> send your opinion to the author? > >> > > > > I am not sure about suitable response from autor. > > May be project [FreeBSD] choise some compromise. > >

svn commit: r303817 - head/sys/powerpc/include

2016-08-07 Thread Justin Hibbits
Author: jhibbits Date: Sun Aug 7 19:09:56 2016 New Revision: 303817 URL: https://svnweb.freebsd.org/changeset/base/303817 Log: Set EN_MAS7_UPDATE HID0 bit for e500 core. Without enabling this bit, tlbre and tlbsx don't update the MAS7 register, resulting in garbage in the register after

Re: svn commit: r303716 - head/crypto/openssh

2016-08-07 Thread Andrey Chernov
On 07.08.2016 21:52, Slawa Olhovchenkov wrote: >> Why you still not >> send your opinion to the author? >> > > I am not sure about suitable response from autor. > May be project [FreeBSD] choise some compromise. IMHO blindly choosing some compromise without asking author's opinion first will be

Re: svn commit: r303716 - head/crypto/openssh

2016-08-07 Thread Slawa Olhovchenkov
On Sun, Aug 07, 2016 at 09:34:51PM +0300, Andrey Chernov wrote: > On 07.08.2016 21:23, Slawa Olhovchenkov wrote: > > On Sun, Aug 07, 2016 at 09:06:37PM +0300, Andrey Chernov wrote: > > > >> On 07.08.2016 20:43, Andrey Chernov wrote: > >>> On 07.08.2016 20:37, Slawa Olhovchenkov wrote: > On

Re: svn commit: r303716 - head/crypto/openssh

2016-08-07 Thread Andrey Chernov
On 07.08.2016 21:23, Slawa Olhovchenkov wrote: > On Sun, Aug 07, 2016 at 09:06:37PM +0300, Andrey Chernov wrote: > >> On 07.08.2016 20:43, Andrey Chernov wrote: >>> On 07.08.2016 20:37, Slawa Olhovchenkov wrote: On Sun, Aug 07, 2016 at 08:34:55PM +0300, Andrey Chernov wrote: > On

Re: svn commit: r303797 - head/contrib/binutils/bfd

2016-08-07 Thread Justin Hibbits
On Sat, 6 Aug 2016 23:52:58 -0700 Mark Millard wrote: > Is there to be an MFC for the below? > > > Author: jhibbits > > Date: Sat Aug 6 15:10:14 2016 > > New Revision: 303797 > > URL: > > https://svnweb.freebsd.org/changeset/base/303797 > > > > > > Log: > > Check the

svn commit: r303816 - in head/sys: conf dev/ixl modules/ixl modules/ixlv

2016-08-07 Thread Sean Bruno
Author: sbruno Date: Sun Aug 7 18:12:36 2016 New Revision: 303816 URL: https://svnweb.freebsd.org/changeset/base/303816 Log: ixl(4): Update to ixl-1.6.6-k. Submitted by: erj Reviewed by: jeffrey.e.pie...@intel.com MFC after:3 days Sponsored by: Intel Corporation Differential

Re: svn commit: r303716 - head/crypto/openssh

2016-08-07 Thread Andrey Chernov
On 07.08.2016 20:43, Andrey Chernov wrote: > On 07.08.2016 20:37, Slawa Olhovchenkov wrote: >> On Sun, Aug 07, 2016 at 08:34:55PM +0300, Andrey Chernov wrote: >> >>> On 07.08.2016 20:31, Andrey Chernov wrote: On 07.08.2016 19:14, Bruce Simpson wrote: > On 07/08/16 15:40, Warner Losh

Re: svn commit: r303716 - head/crypto/openssh

2016-08-07 Thread Andrey Chernov
On 07.08.2016 20:37, Slawa Olhovchenkov wrote: > On Sun, Aug 07, 2016 at 08:34:55PM +0300, Andrey Chernov wrote: > >> On 07.08.2016 20:31, Andrey Chernov wrote: >>> On 07.08.2016 19:14, Bruce Simpson wrote: On 07/08/16 15:40, Warner Losh wrote: > That’s a cop-out answer. We, as a

Re: svn commit: r303716 - head/crypto/openssh

2016-08-07 Thread Andrey Chernov
On 07.08.2016 20:31, Andrey Chernov wrote: > On 07.08.2016 19:14, Bruce Simpson wrote: >> On 07/08/16 15:40, Warner Losh wrote: >>> That’s a cop-out answer. We, as a project, need to articulate to our >>> users, whom we care about, why this rather obnoxious hit to usability >>> was taken. The

Re: svn commit: r303716 - head/crypto/openssh

2016-08-07 Thread Andrey Chernov
On 07.08.2016 19:14, Bruce Simpson wrote: > On 07/08/16 15:40, Warner Losh wrote: >> That’s a cop-out answer. We, as a project, need to articulate to our >> users, whom we care about, why this rather obnoxious hit to usability >> was taken. The answer must be more complete than “We just disabled

Re: svn commit: r303716 - head/crypto/openssh

2016-08-07 Thread Slawa Olhovchenkov
On Sun, Aug 07, 2016 at 08:34:55PM +0300, Andrey Chernov wrote: > On 07.08.2016 20:31, Andrey Chernov wrote: > > On 07.08.2016 19:14, Bruce Simpson wrote: > >> On 07/08/16 15:40, Warner Losh wrote: > >>> That’s a cop-out answer. We, as a project, need to articulate to our > >>> users, whom we

Re: svn commit: r303716 - head/crypto/openssh

2016-08-07 Thread Bruce Simpson
On 07/08/16 18:34, Andrey Chernov wrote: Alcatel-Lucent OmniSwitch 6800 login broken (pfSense 2.3.2 which accepted the upstream change, workaround no-go) [2.3.2-RELEASE][r...@gw.lab]/root: ssh -l admin -oKexAlgorithms=+diffie-hellman-group1-sha1 192.168.1.XXX Fssh_ssh_dispatch_run_fatal:

Re: svn commit: r303716 - head/crypto/openssh

2016-08-07 Thread Andrey Chernov
On 07.08.2016 20:31, Andrey Chernov wrote: > On 07.08.2016 19:14, Bruce Simpson wrote: >> On 07/08/16 15:40, Warner Losh wrote: >>> That’s a cop-out answer. We, as a project, need to articulate to our >>> users, whom we care about, why this rather obnoxious hit to usability >>> was taken. The

Re: svn commit: r303716 - head/crypto/openssh

2016-08-07 Thread Bruce Simpson
On 07/08/16 15:40, Warner Losh wrote: That’s a cop-out answer. We, as a project, need to articulate to our users, whom we care about, why this rather obnoxious hit to usability was taken. The answer must be more complete than “We just disabled it because upstream disabled it for reasons we’re

Re: svn commit: r303716 - head/crypto/openssh

2016-08-07 Thread Andrey Chernov
On 07.08.2016 17:40, Warner Losh wrote: > >> On Aug 7, 2016, at 7:21 AM, Andrey Chernov wrote: >>> We can't turn our security team into compatibility team, by constantly restoring removed code, such code quickly becomes outdated and may add new security holes

Re: svn commit: r303716 - head/crypto/openssh

2016-08-07 Thread Warner Losh
> On Aug 7, 2016, at 7:21 AM, Andrey Chernov wrote: >> >>> We can't turn our security >>> team into compatibility team, by constantly restoring removed code, such >>> code quickly becomes outdated and may add new security holes even being >>> inactive. >> >> What is security

Re: svn commit: r303716 - head/crypto/openssh

2016-08-07 Thread Andrey Chernov
On 07.08.2016 15:52, Slawa Olhovchenkov wrote: >> You should address your complains to original openssh author instead, it >> was his decision to get rid of weak algos. In my personal opinion, if >> your hardware is outdated, just drop it out. > > Hardware outdated by outdated main function, not

Re: svn commit: r303716 - head/crypto/openssh

2016-08-07 Thread Slawa Olhovchenkov
On Sun, Aug 07, 2016 at 03:25:54PM +0300, Andrey Chernov wrote: > On 07.08.2016 14:59, Bruce Simpson wrote: > > On 07/08/16 12:43, Oliver Pinter wrote: > >>> I was able to override this (somewhat unilateral, to my mind) > >>> deprecation of the DH key exchange by using this option: > >>>

Re: svn commit: r303716 - head/crypto/openssh

2016-08-07 Thread Ed Schouten
2016-08-07 14:25 GMT+02:00 Andrey Chernov : > You should address your complains to original openssh author instead, it > was his decision to get rid of weak algos. In my personal opinion, if > your hardware is outdated, just drop it out. We can't turn our security > team into

Re: svn commit: r303716 - head/crypto/openssh

2016-08-07 Thread Andrey Chernov
On 07.08.2016 14:59, Bruce Simpson wrote: > On 07/08/16 12:43, Oliver Pinter wrote: >>> I was able to override this (somewhat unilateral, to my mind) >>> deprecation of the DH key exchange by using this option: >>> -oKexAlgorithms=+diffie-hellman-group1-sha1 >> >> You can add this option to

Re: svn commit: r303746 - head/usr.bin/indent

2016-08-07 Thread Ed Schouten
Hi Piotr, 2016-08-07 10:19 GMT+02:00 Piotr Stefaniak : > The most important conclusion, though, is that at least the glibc > implementation imposes an arbitrary limit on how many items you can add > to the data structure: > The argument nel specifies the maximum

Re: svn commit: r303716 - head/crypto/openssh

2016-08-07 Thread Bruce Simpson
On 07/08/16 12:43, Oliver Pinter wrote: I was able to override this (somewhat unilateral, to my mind) deprecation of the DH key exchange by using this option: -oKexAlgorithms=+diffie-hellman-group1-sha1 You can add this option to /etc/ssh/ssh.conf or ~/.ssh/config too. Can this at least be

Re: svn commit: r303716 - head/crypto/openssh

2016-08-07 Thread Oliver Pinter
On 8/7/16, Bruce Simpson wrote: > On 07/08/16 11:58, Bruce Simpson wrote: >> Is there a way to revert this change, at least on an ongoing operational >> basis (e.g. configuration file) for those of us who use FreeBSD to >> connect directly to such devices? > > I was able to

Re: svn commit: r303716 - head/crypto/openssh

2016-08-07 Thread Bruce Simpson
On 07/08/16 11:58, Bruce Simpson wrote: Is there a way to revert this change, at least on an ongoing operational basis (e.g. configuration file) for those of us who use FreeBSD to connect directly to such devices? I was able to override this (somewhat unilateral, to my mind) deprecation of

Re: svn commit: r303716 - head/crypto/openssh

2016-08-07 Thread Bruce Simpson
DES, I believe this breaks logging into various embedded network devices, unfortunately. E.g. the Netonix WISP Switch, which uses an embedded Linux variant with dropbear 0.51. It is expecting to use DSA not RSA for the key exchange.g Is there a way to revert this change, at least on an

svn commit: r303812 - head/sys/mips/mips

2016-08-07 Thread Brooks Davis
Author: brooks Date: Sun Aug 7 09:02:54 2016 New Revision: 303812 URL: https://svnweb.freebsd.org/changeset/base/303812 Log: Use a more conventional spelling of "breakpoint". Modified: head/sys/mips/mips/trap.c Modified: head/sys/mips/mips/trap.c

Re: svn commit: r303811 - in head/sys: net net80211

2016-08-07 Thread Hans Petter Selasky
On 08/07/16 05:48, Adrian Chadd wrote: Author: adrian Date: Sun Aug 7 03:48:33 2016 New Revision: 303811 URL: https://svnweb.freebsd.org/changeset/base/303811 Log: Extract out the various local definitions of ETHER_IS_BROADCAST() and turn them into a shared definition. Set

Re: svn commit: r303803 - in head/sys/dev: fdt ofw

2016-08-07 Thread Brooks Davis
On Sat, Aug 06, 2016 at 06:48:47PM +, Stephen J. Kiernan wrote: > Author: stevek > Date: Sat Aug 6 18:48:47 2016 > New Revision: 303803 > URL: https://svnweb.freebsd.org/changeset/base/303803 > > Log: > Add hw.fdt sysctl node. > Make FDT blob available via opaque hw.fdt.dtb sysctl, if a

Re: svn commit: r303746 - head/usr.bin/indent

2016-08-07 Thread Piotr Stefaniak
On 2016-08-06 22:18, Pedro Giffuni wrote: > On 06/08/2016 15:13, Ed Schouten wrote: >> 2016-08-04 17:27 GMT+02:00 Pedro F. Giffuni : >>> Log: >>>indent(1): Use bsearch() for looking up type keywords. >> You're never doing any deletions, right? Would it make more sense to >>

Re: svn commit: r303797 - head/contrib/binutils/bfd

2016-08-07 Thread Mark Millard
Is there to be an MFC for the below? > Author: jhibbits > Date: Sat Aug 6 15:10:14 2016 > New Revision: 303797 > URL: > https://svnweb.freebsd.org/changeset/base/303797 > > > Log: > Check the first byte of the array for NUL, instead of the array as a NULL > pointer > > The