svn commit: r345976 - head/sbin/fsck_msdosfs

2019-04-05 Thread Xin LI
Author: delphij Date: Sat Apr 6 03:42:15 2019 New Revision: 345976 URL: https://svnweb.freebsd.org/changeset/base/345976 Log: Write string constant differently to improve readability. Reported by: rgrimes Reviewed by: rgrimes, emaste MFC after:13 days Differential Revision:

svn commit: r345975 - head/sys/powerpc/powernv

2019-04-05 Thread Justin Hibbits
Author: jhibbits Date: Sat Apr 6 02:39:56 2019 New Revision: 345975 URL: https://svnweb.freebsd.org/changeset/base/345975 Log: powerpc/powernv: Fix major bugs in opal_flash * The BIO bio_data may not be page aligned. Only the base address of each page worth of data is extracted to

svn commit: r345974 - head/sys/powerpc/powernv

2019-04-05 Thread Justin Hibbits
Author: jhibbits Date: Sat Apr 6 02:31:01 2019 New Revision: 345974 URL: https://svnweb.freebsd.org/changeset/base/345974 Log: powerpc/powernv: Fix issues in opal_async * Properly return the full opal_msg from an async completion. * Don't keep bugging OPAL, wait 100us or so. With some

Re: svn commit: r345970 - head/libexec/rc

2019-04-05 Thread Rodney W. Grimes
> Author: eugen > Date: Fri Apr 5 22:45:08 2019 > New Revision: 345970 > URL: https://svnweb.freebsd.org/changeset/base/345970 > > Log: > network.subr: improve configuration of cloned gif(4) interfaces > > ifconfig(8) syntax allows to specify only single address_family, > so we

svn commit: r345970 - head/libexec/rc

2019-04-05 Thread Eugene Grosbein
Author: eugen Date: Fri Apr 5 22:45:08 2019 New Revision: 345970 URL: https://svnweb.freebsd.org/changeset/base/345970 Log: network.subr: improve configuration of cloned gif(4) interfaces ifconfig(8) syntax allows to specify only single address_family, so we need additional invocation

Re: svn commit: r345900 - head/sbin/fsck_msdosfs

2019-04-05 Thread Conrad Meyer
On Fri, Apr 5, 2019 at 12:56 PM Hans Petter Selasky wrote: > > On 4/5/19 9:51 PM, Conrad Meyer wrote: > > static const u_char dot_name[11] = ". "; > > static const u_char dotdot_name[11] = ".. "; > > > > Seems more clear to me. > > Using this syntax will include a terminating

Re: svn commit: r345900 - head/sbin/fsck_msdosfs

2019-04-05 Thread Rodney W. Grimes
> On Apr 5, 2019, at 13:22, Rodney W. Grimes wrote: > > >>> On Fri, Apr 5, 2019 at 6:49 AM Ed Maste wrote: > >>> > On Fri, 5 Apr 2019 at 00:49, Rodney W. Grimes > wrote: > > >>> > > +static const u_char dot_name[] = { > > + '.', ' ',' ',' ',' ',' ',' ',' ',' ','

Re: svn commit: r345900 - head/sbin/fsck_msdosfs

2019-04-05 Thread Enji Cooper
On Apr 5, 2019, at 13:22, Rodney W. Grimes wrote: >>> On Fri, Apr 5, 2019 at 6:49 AM Ed Maste wrote: >>> On Fri, 5 Apr 2019 at 00:49, Rodney W. Grimes wrote: >>> > +static const u_char dot_name[] = { > + '.', ' ',' ',' ',' ',' ',' ',' ',' ',' ',' ' }; >

Re: svn commit: r345967 - head/contrib/libxo/libxo

2019-04-05 Thread Enji Cooper
> On Apr 5, 2019, at 12:42, Phil Shafer wrote: > > Author: phil > Date: Fri Apr 5 19:42:54 2019 > New Revision: 345967 > URL: https://svnweb.freebsd.org/changeset/base/345967 > > Log: > Emergency fix for NULL deref in xo_xml_leader_len Could you please add a test for this as well upstream?

Re: svn commit: r345900 - head/sbin/fsck_msdosfs

2019-04-05 Thread Konstantin Belousov
On Fri, Apr 05, 2019 at 09:55:43PM +0200, Hans Petter Selasky wrote: > On 4/5/19 9:51 PM, Conrad Meyer wrote: > > static const u_char dot_name[11] = ". "; > > static const u_char dotdot_name[11] = ".. "; > > > > Seems more clear to me. > > Using this syntax will include a

Re: svn commit: r345900 - head/sbin/fsck_msdosfs

2019-04-05 Thread Rodney W. Grimes
> On Fri, Apr 5, 2019 at 6:49 AM Ed Maste wrote: > > > > On Fri, 5 Apr 2019 at 00:49, Rodney W. Grimes > > wrote: > > > > > > > > > +static const u_char dot_name[] = { > > > > + '.', ' ',' ',' ',' ',' ',' ',' ',' ',' ',' ' }; > > > > +static const u_char dotdot_name[] = { > > > > + '.',

svn commit: r345968 - head/usr.sbin/devctl

2019-04-05 Thread Konstantin Belousov
Author: kib Date: Fri Apr 5 20:12:19 2019 New Revision: 345968 URL: https://svnweb.freebsd.org/changeset/base/345968 Log: Fix gcc warning about shadowed global. Sponsored by: Mellanox Technologies MFC after:2 weeks Modified: head/usr.sbin/devctl/devctl.c Modified:

Re: svn commit: r345900 - head/sbin/fsck_msdosfs

2019-04-05 Thread Xin LI
On Fri, Apr 5, 2019 at 12:56 PM Hans Petter Selasky wrote: > On 4/5/19 9:51 PM, Conrad Meyer wrote: > > static const u_char dot_name[11] = ". "; > > static const u_char dotdot_name[11] = ".. "; > > > > Seems more clear to me. > > Using this syntax will include a terminating

Re: svn commit: r345900 - head/sbin/fsck_msdosfs

2019-04-05 Thread Hans Petter Selasky
On 4/5/19 9:51 PM, Conrad Meyer wrote: static const u_char dot_name[11] = ". "; static const u_char dotdot_name[11] = ".. "; Seems more clear to me. Using this syntax will include a terminating zero. --HPS ___

Re: svn commit: r345900 - head/sbin/fsck_msdosfs

2019-04-05 Thread Conrad Meyer
On Fri, Apr 5, 2019 at 6:49 AM Ed Maste wrote: > > On Fri, 5 Apr 2019 at 00:49, Rodney W. Grimes > wrote: > > > > > > +static const u_char dot_name[] = { > > > + '.', ' ',' ',' ',' ',' ',' ',' ',' ',' ',' ' }; > > > +static const u_char dotdot_name[] = { > > > + '.', '.',' ',' ',' ','

svn commit: r345967 - head/contrib/libxo/libxo

2019-04-05 Thread Phil Shafer
Author: phil Date: Fri Apr 5 19:42:54 2019 New Revision: 345967 URL: https://svnweb.freebsd.org/changeset/base/345967 Log: Emergency fix for NULL deref in xo_xml_leader_len Modified: head/contrib/libxo/libxo/libxo.c Modified: head/contrib/libxo/libxo/libxo.c

svn commit: r345966 - in head: lib/libdevctl usr.sbin/devctl

2019-04-05 Thread Konstantin Belousov
Author: kib Date: Fri Apr 5 19:32:26 2019 New Revision: 345966 URL: https://svnweb.freebsd.org/changeset/base/345966 Log: Implement devctl(8) command 'reset', using DEV_RESET /dev/devctl2 ioctl. Reviewed by: imp (previous version), jhb (previous version) Sponsored by: Mellanox

svn commit: r345965 - in head/sys: kern sys

2019-04-05 Thread Konstantin Belousov
Author: kib Date: Fri Apr 5 19:31:26 2019 New Revision: 345965 URL: https://svnweb.freebsd.org/changeset/base/345965 Log: Add DEV_RESET /dev/devctl2 ioctl. It performs BUS_RESET_CHILD() on the parental bus and the specified device. Reviewed by: imp (previous version), jhb

svn commit: r345964 - head/sys/dev/smartpqi

2019-04-05 Thread Konstantin Belousov
Author: kib Date: Fri Apr 5 19:27:51 2019 New Revision: 345964 URL: https://svnweb.freebsd.org/changeset/base/345964 Log: Remove single-use DEV_RESET() macro. It conflicts with the sys/bus.h DEV_XXX namespace. Reviewed by: imp (previous version), jhb (previous version) Sponsored

svn commit: r345963 - in head/sys: amd64/vmm/io dev/pci

2019-04-05 Thread Konstantin Belousov
Author: kib Date: Fri Apr 5 19:25:26 2019 New Revision: 345963 URL: https://svnweb.freebsd.org/changeset/base/345963 Log: Implement resets for PCI buses and PCIe bridges. For PCI device (i.e. child of a PCI bus), reset tries FLR if implemented and worked, and falls to power reset

svn commit: r345960 - in head/sys: kern sys

2019-04-05 Thread Konstantin Belousov
Author: kib Date: Fri Apr 5 18:09:22 2019 New Revision: 345960 URL: https://svnweb.freebsd.org/changeset/base/345960 Log: Provide newbus infrastructure for initiating device reset. The methods BUS_RESET_PREPARE(), BUS_RESET(), and BUS_RESET_POST() should be implemented by bus which can

svn commit: r345959 - head/lib/libdevctl

2019-04-05 Thread Konstantin Belousov
Author: kib Date: Fri Apr 5 17:54:31 2019 New Revision: 345959 URL: https://svnweb.freebsd.org/changeset/base/345959 Log: Add __BEGIN_DECLS/__END_DECLS braces to libdevctl header. Reviewed by: imp (previous version), jhb (previous version) Sponsored by: Mellanox Technologies MFC

svn commit: r345956 - head/usr.sbin/bhyve

2019-04-05 Thread Chuck Tuffli
Author: chuck Date: Fri Apr 5 16:54:16 2019 New Revision: 345956 URL: https://svnweb.freebsd.org/changeset/base/345956 Log: bhyve: Fix NVMe BAR size calculation The NVMe specification defines bits 13:4 of BAR0 as Reserved (i.e. 0x0). Most drivers do not enforce this, but the Windows

svn commit: r345957 - head/usr.sbin/bhyve

2019-04-05 Thread Chuck Tuffli
Author: chuck Date: Fri Apr 5 16:54:20 2019 New Revision: 345957 URL: https://svnweb.freebsd.org/changeset/base/345957 Log: bhyve: Fix NVMe data structure copy to guest bhyve's NVMe emulation was transferring Identify data back to the guest incorrectly causing memory corruptions. These

svn commit: r345955 - head/sys/kern

2019-04-05 Thread Konstantin Belousov
Author: kib Date: Fri Apr 5 16:14:16 2019 New Revision: 345955 URL: https://svnweb.freebsd.org/changeset/base/345955 Log: vn_vmap_seekhole(): align running offset to the block boundary. Otherwise we might miss the last iteration where EOF appears below unaligned noff. Reported and

svn commit: r345954 - head/sys/vm

2019-04-05 Thread Konstantin Belousov
Author: kib Date: Fri Apr 5 16:12:35 2019 New Revision: 345954 URL: https://svnweb.freebsd.org/changeset/base/345954 Log: Fix mis-merge. Amusingly, it is nop. Noted by: trasz Sponsored by: The FreeBSD Foundation MFC after:1 week X-MFC-rev:r345702 Modified:

svn commit: r345951 - head/sys/dev/iicbus/twsi

2019-04-05 Thread Emmanuel Vadot
Author: manu Date: Fri Apr 5 15:53:27 2019 New Revision: 345951 URL: https://svnweb.freebsd.org/changeset/base/345951 Log: twsi: Use config_intrhook_oneshot instead of config_intrhook_establish Suggested by: ian MFC after:1 month X-MFC-With: 345948 Modified:

Re: svn commit: r345900 - head/sbin/fsck_msdosfs

2019-04-05 Thread Ian Lepore
On Sat, 2019-04-06 at 01:47 +1100, Bruce Evans wrote: > On Fri, 5 Apr 2019, Ed Maste wrote: > > > On Fri, 5 Apr 2019 at 00:49, Rodney W. Grimes > > wrote: > >> > > > >>> +static const u_char dot_name[] = { > >>> + '.', ' ',' ',' ',' ',' ',' ',' ',' ',' ',' ' }; > >>> +static const u_char

Re: svn commit: r345900 - head/sbin/fsck_msdosfs

2019-04-05 Thread Rodney W. Grimes
> On Fri, 5 Apr 2019, Ed Maste wrote: > > > On Fri, 5 Apr 2019 at 00:49, Rodney W. Grimes > > wrote: > >> > > > >>> +static const u_char dot_name[] = { > >>> + '.', ' ',' ',' ',' ',' ',' ',' ',' ',' ',' ' }; > >>> +static const u_char dotdot_name[] = { > >>> + '.', '.',' ',' ',' ',' ','

Re: svn commit: r345900 - head/sbin/fsck_msdosfs

2019-04-05 Thread Bruce Evans
On Fri, 5 Apr 2019, Ed Maste wrote: On Fri, 5 Apr 2019 at 00:49, Rodney W. Grimes wrote: +static const u_char dot_name[] = { + '.', ' ',' ',' ',' ',' ',' ',' ',' ',' ',' ' }; +static const u_char dotdot_name[] = { + '.', '.',' ',' ',' ',' ',' ',' ',' ',' ',' ' }; + Does it make

svn commit: r345948 - head/sys/dev/iicbus/twsi

2019-04-05 Thread Emmanuel Vadot
Author: manu Date: Fri Apr 5 14:44:23 2019 New Revision: 345948 URL: https://svnweb.freebsd.org/changeset/base/345948 Log: twsi: Add interrupt mode Add the ability to use interrupts for i2c message. We still use polling for early boot i2c transfer (for PMIC for example) but as soon as

svn commit: r345947 - head/sys/conf

2019-04-05 Thread Warner Losh
Author: imp Date: Fri Apr 5 14:27:48 2019 New Revision: 345947 URL: https://svnweb.freebsd.org/changeset/base/345947 Log: Remove another instance of All Rights Reserved. Remove the phrase from boilerplate copyright we stick on vers.c when we can't find the template file. In practice,

Re: svn commit: r345900 - head/sbin/fsck_msdosfs

2019-04-05 Thread Ed Maste
On Fri, 5 Apr 2019 at 00:49, Rodney W. Grimes wrote: > > > +static const u_char dot_name[] = { > > + '.', ' ',' ',' ',' ',' ',' ',' ',' ',' ',' ' }; > > +static const u_char dotdot_name[] = { > > + '.', '.',' ',' ',' ',' ',' ',' ',' ',' ',' ' }; > > + > > Does it make since to encode