Re: svn commit: r344960 - head/sys/powerpc/powerpc

2019-03-11 Thread Alexey Dokuchaev
On Mon, Mar 11, 2019 at 08:18:01PM +1100, Bruce Evans wrote: > ... > - poor formatting from %p. %p is guaranteed to bad for formatted output. >It is specified to give an (any) implementation-defined sequence of >printing characters. To use it except for low quality debugging >output,

Re: svn commit: r344960 - head/sys/powerpc/powerpc

2019-03-10 Thread Alexey Dokuchaev
On Sun, Mar 10, 2019 at 05:16:40PM -0500, Justin Hibbits wrote: > On Sat, 9 Mar 2019 08:50:58 + > Alexey Dokuchaev wrote: > > On Sat, Mar 09, 2019 at 03:18:38AM +, Justin Hibbits wrote: > > > New Revision: 344960 > > > URL: https://svnweb.freebsd.org/changese

Re: svn commit: r344648 - in head: . sys/kern sys/sys

2019-03-10 Thread Alexey Dokuchaev
On Thu, Feb 28, 2019 at 07:47:51AM +, Alexey Dokuchaev wrote: > On Wed, Feb 27, 2019 at 10:56:55PM +, Mateusz Guzik wrote: > > New Revision: 344648 > > URL: https://svnweb.freebsd.org/changeset/base/344648 > > > > Log: > > Rename seq to seqc to a

Re: svn commit: r344970 - head

2019-03-10 Thread Alexey Dokuchaev
On Sat, Mar 09, 2019 at 12:00:27PM -0800, Rodney W. Grimes wrote: > > New Revision: 344970 > > URL: https://svnweb.freebsd.org/changeset/base/344970 > > > > Log: > > Misc fixes based on upgrading a laptop from 11.1R to -current > > > > Add note about needing to start zfs because mount -a do

Re: svn commit: r344960 - head/sys/powerpc/powerpc

2019-03-09 Thread Alexey Dokuchaev
On Sat, Mar 09, 2019 at 03:18:38AM +, Justin Hibbits wrote: > New Revision: 344960 > URL: https://svnweb.freebsd.org/changeset/base/344960 > > Log: > powerpc: Print trap frame address for fatal traps > > MFC after: 1 week > > Modified: > head/sys/powerpc/powerpc/trap.c > > Modified

Re: svn commit: r344701 - head/sbin/camcontrol

2019-03-02 Thread Alexey Dokuchaev
uests from camcontrol. > > Submitted by: Alexey Dokuchaev Thanks, although commit message is a bit scarce. Also, for some reason, it consists of two nearly identical lines -- unnoticed copy paste error? ./danfe ___ svn-src-head@fre

Re: svn commit: r344648 - in head: . sys/kern sys/sys

2019-02-27 Thread Alexey Dokuchaev
On Wed, Feb 27, 2019 at 10:56:55PM +, Mateusz Guzik wrote: > New Revision: 344648 > URL: https://svnweb.freebsd.org/changeset/base/344648 > > Log: > Rename seq to seqc to avoid namespace clashes with Linux > > ... > Added: > head/sys/sys/seqc.h (contents, props changed) > Deleted: >

Re: svn commit: r344567 - in head: etc/mtree include sbin sbin/veriexec

2019-02-26 Thread Alexey Dokuchaev
On Tue, Feb 26, 2019 at 09:12:11AM -0800, John Baldwin wrote: > On 2/26/19 5:49 AM, Alexey Dokuchaev wrote: > > On Mon, Feb 25, 2019 at 10:19:45PM -0800, Rodney W. Grimes wrote: > >> ... > >> Just a small nit, for future reference, from the template: > >&

Re: svn commit: r344567 - in head: etc/mtree include sbin sbin/veriexec

2019-02-26 Thread Alexey Dokuchaev
On Mon, Feb 25, 2019 at 10:19:45PM -0800, Rodney W. Grimes wrote: > > Author: sjg > > Date: Tue Feb 26 06:17:23 2019 > > New Revision: 344567 > > URL: https://svnweb.freebsd.org/changeset/base/344567 > > > > Log: > > Add verifying manifest loader for mac_veriexec > > > > This tool will veri

Re: svn commit: r344316 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2019-02-19 Thread Alexey Dokuchaev
On Tue, Feb 19, 2019 at 06:43:28PM -0500, Shawn Webb wrote: > At the risk of painting a bikeshed a lovely color of neon purple, I'm > curious about if/how these types of commits get merged upstream to > (OpenZFS|Illumos|ZFS On Linux|where ever ZFS upstream is now|I'm very > confused|is anyone else

Re: svn commit: r344118 - head/sys/i386/include

2019-02-15 Thread Alexey Dokuchaev
On Sat, Feb 16, 2019 at 12:27:16AM +1100, Bruce Evans wrote: > On Fri, 15 Feb 2019, Konstantin Belousov wrote: > > On Fri, Feb 15, 2019 at 07:16:04AM +0000, Alexey Dokuchaev wrote: > >> On Thu, Feb 14, 2019 at 01:53:11PM +, Konstantin Belousov wrote: > >>> New Rev

Re: svn commit: r344118 - head/sys/i386/include

2019-02-14 Thread Alexey Dokuchaev
On Thu, Feb 14, 2019 at 01:53:11PM +, Konstantin Belousov wrote: > New Revision: 344118 > URL: https://svnweb.freebsd.org/changeset/base/344118 > > Log: > Provide userspace versions of do_cpuid() and cpuid_count() on i386. > > Some older compilers, when generating PIC code, cannot handl

Re: svn commit: r343566 - in head/lib/libthr: . thread

2019-01-30 Thread Alexey Dokuchaev
On Wed, Jan 30, 2019 at 05:37:09AM +, Alexey Dokuchaev wrote: > On Tue, Jan 29, 2019 at 10:46:45PM +, Konstantin Belousov wrote: > > New Revision: 343566 > > URL: https://svnweb.freebsd.org/changeset/base/343566 > > > > Log: > > Untangle je

Re: svn commit: r343566 - in head/lib/libthr: . thread

2019-01-29 Thread Alexey Dokuchaev
On Tue, Jan 29, 2019 at 10:46:45PM +, Konstantin Belousov wrote: > New Revision: 343566 > URL: https://svnweb.freebsd.org/changeset/base/343566 > > Log: > Untangle jemalloc and mutexes initialization. > > The need to use libc malloc(3) from some places in libthr always > caused issues

Re: svn commit: r343440 - head/bin/sh

2019-01-27 Thread Alexey Dokuchaev
On Sat, Jan 26, 2019 at 01:35:18PM -0700, Ian Lepore wrote: > ... > Wait a sec... something has been stable and working fine for 30 years, > then it gets changed to reflect one man's personal preferences, and > it's the people who object to that who have to jump through flaming > hoops to justify t

Re: svn commit: r343416 - head/bin/sh

2019-01-25 Thread Alexey Dokuchaev
On Fri, Jan 25, 2019 at 06:02:58AM +, Edward Napierala wrote: > The aliases are gone, let's continue on the remaining bits below. They are not gone, they were commented out; also, bogus double linefeeds are not gone. But most importantly, this whole file is useless and IMHO should just be rem

Re: svn commit: r343416 - head/bin/sh

2019-01-24 Thread Alexey Dokuchaev
On Thu, Jan 24, 2019 at 04:59:40PM -0700, Ian Lepore wrote: > On Thu, 2019-01-24 at 15:55 -0800, Rodney W. Grimes wrote: > > > New Revision: 343416 > > > URL: https://svnweb.freebsd.org/changeset/base/343416 > > > > > > Log: > > > Install .shrc for root, and set PS1 for the toor account. > > >

svn commit: r342550 - head/usr.sbin/acpi/acpiconf

2018-12-27 Thread Alexey Dokuchaev
Author: danfe (ports committer) Date: Thu Dec 27 08:48:54 2018 New Revision: 342550 URL: https://svnweb.freebsd.org/changeset/base/342550 Log: Amend the `-i batt' option description and explain that the battery is specified by its number (index), starting with zero. Previously, sometimes us

Re: svn commit: r342197 - head/sys/dev/usb/net

2018-12-18 Thread Alexey Dokuchaev
On Tue, Dec 18, 2018 at 07:38:13PM +, Gleb Smirnoff wrote: > New Revision: 342197 > URL: https://svnweb.freebsd.org/changeset/base/342197 > > Log: > Use mbufq instead of ifqueue to queue mbufs. > > Modified: > head/sys/dev/usb/net/uhso.c For the less aware folks reading through the code

Re: svn commit: r249115 - in head: sbin/camcontrol sys/sys

2018-12-18 Thread Alexey Dokuchaev
On Tue, Nov 27, 2018 at 01:45:14PM +, Alexey Dokuchaev wrote: > On Thu, Apr 04, 2013 at 11:19:52PM +, Steven Hartland wrote: > > New Revision: 249115 > > URL: http://svnweb.freebsd.org/changeset/base/249115 > > > > Log: > > Adds security options to cam

Re: svn commit: r342151 - head/stand/libsa/zfs

2018-12-18 Thread Alexey Dokuchaev
On Sun, Dec 16, 2018 at 08:58:15AM +, Toomas Soome wrote: > New Revision: 342151 > URL: https://svnweb.freebsd.org/changeset/base/342151 > > Log: > loader: zfs reader should not probe partitionless disks > > @@ -527,10 +527,11 @@ zfs_probe_dev(const char *devname, uint64_t *pool_guid >

Re: svn commit: r341505 - head/share/man/man5

2018-12-06 Thread Alexey Dokuchaev
On Wed, Dec 05, 2018 at 01:46:54PM -0500, Pedro Giffuni wrote: > On 05/12/2018 12:41, Conrad Meyer wrote: > > The Linux model is that the current incarnation of the ext2/3/4 driver > > is named "ext4," and that's what Linux users expect. You can mount > > any ext2/3/4 filesystem with the Linux ext

Re: svn commit: r341446 - head/release/amd64

2018-12-04 Thread Alexey Dokuchaev
On Tue, Dec 04, 2018 at 11:52:34AM +0300, Yuri Pankov wrote: > Alexey Dokuchaev wrote: > > On Mon, Dec 03, 2018 at 10:31:57PM +, Yuri Pankov wrote: > >> New Revision: 341446 > >> URL: https://svnweb.freebsd.org/changeset/base/341446 > >> > >> Log:

Re: svn commit: r341446 - head/release/amd64

2018-12-04 Thread Alexey Dokuchaev
On Mon, Dec 03, 2018 at 10:31:57PM +, Yuri Pankov wrote: > New Revision: 341446 > URL: https://svnweb.freebsd.org/changeset/base/341446 > > Log: > mkisoimages.sh: don't use -p flag when copying loader.efi to msdosfs. > > This fixes 'cdrom' target in the case when world was built by user

Re: svn: head/usr.bin: . trim

2018-11-30 Thread Alexey Dokuchaev
On Fri, Nov 30, 2018 at 07:27:46PM +0700, Eugene Grosbein wrote: > 30.11.2018 18:55, Alexey Dokuchaev wrote: > > >>> Another point: the manpage says, "It is only relevant for flash based > >>> storage devices that use wear-leveling algorithms", which is

Re: svn: head/usr.bin: . trim

2018-11-30 Thread Alexey Dokuchaev
On Fri, Nov 30, 2018 at 06:44:48PM +0700, Eugene Grosbein wrote: > 30.11.2018 18:34, Alexey Dokuchaev wrote: > > > Another point: the manpage says, "It is only relevant for flash based > > storage devices that use wear-leveling algorithms", which is an argument &g

Re: svn: head/usr.bin: . trim

2018-11-30 Thread Alexey Dokuchaev
On Fri, Nov 30, 2018 at 06:12:12PM +0700, Eugene Grosbein wrote: > 30.11.2018 17:57, Alexey Dokuchaev wrote: > > On Fri, Nov 30, 2018 at 09:49:55AM +0100, Baptiste Daroussin wrote: > >> On Fri, Nov 30, 2018 at 08:31:17AM +, Steven Hartland wrote: > >>> Personally

Re: svn: head/usr.bin: . trim

2018-11-30 Thread Alexey Dokuchaev
On Fri, Nov 30, 2018 at 09:49:55AM +0100, Baptiste Daroussin wrote: > On Fri, Nov 30, 2018 at 08:31:17AM +, Steven Hartland wrote: > > Personally I disagree, chances of people finding that option in dd > > is slim, a dedicated trim utility makes much more sense to me. Sure > > have both that's

Re: svn: head/usr.bin: . trim

2018-11-29 Thread Alexey Dokuchaev
On Thu, Nov 29, 2018 at 10:36:02AM -0800, Maxim Sobolev wrote: > Interesting. I have a similar functionality implemented as an option for > the dd utility in my pipeline (conv=erase). Which probably makes a better place rather than adding 4-letter program, commonly named ("trim" is a simple word),

Re: svn commit: r249115 - in head: sbin/camcontrol sys/sys

2018-11-27 Thread Alexey Dokuchaev
On Thu, Apr 04, 2013 at 11:19:52PM +, Steven Hartland wrote: > New Revision: 249115 > URL: http://svnweb.freebsd.org/changeset/base/249115 > > Log: > Adds security options to camcontrol this includes the ability to secure > erase disks such as SSD's > > Adds the ability to run ATA com

Re: svn commit: r340702 - in head/lib/csu: amd64 common i386

2018-11-24 Thread Alexey Dokuchaev
On Tue, Nov 20, 2018 at 09:04:20PM +, Ed Maste wrote: > New Revision: 340702 > URL: https://svnweb.freebsd.org/changeset/base/340702 > > Log: > csu: use BSD-1-clause license on csu files > > Copyright on these files is held by kib@ and/or the Foundation, > and both agree to this chang

Re: svn commit: r339784 - head/sbin/dumpon

2018-10-27 Thread Alexey Dokuchaev
On Fri, Oct 26, 2018 at 07:54:00PM +, Conrad Meyer wrote: > New Revision: 339784 > URL: https://svnweb.freebsd.org/changeset/base/339784 > > Log: > dumpon(8): Provide seatbelt against weak RSA keys > > ... > +#if OPENSSL_VERSION_NUMBER >= 0x1010L > + if (RSA_security_bits(pubkey)

Re: svn commit: r338687 - in head/sys: dev/cpuctl x86/include x86/x86

2018-09-18 Thread Alexey Dokuchaev
On Fri, Sep 14, 2018 at 05:04:36PM +, Mark Johnston wrote: > New Revision: 338687 > URL: https://svnweb.freebsd.org/changeset/base/338687 > > Log: > Log a message after a successful boot-time microcode update. Unfortunately, this had pessimized things on the unsuccessful side a bit. (See be

Re: svn commit: r338050 - in head: . stand

2018-09-14 Thread Alexey Dokuchaev
On Sun, Aug 19, 2018 at 02:26:33PM +, Kyle Evans wrote: > New Revision: 338050 > URL: https://svnweb.freebsd.org/changeset/base/338050 > > Log: > stand: Flip the default interpreter to Lua > > After years in the making, lualoader is ready to make its debut. Both > flavors of loader ar

Re: svn commit: r337773 - in head/sys/amd64: amd64 include

2018-09-06 Thread Alexey Dokuchaev
On Wed, Aug 15, 2018 at 08:45:04AM +, Alexey Dokuchaev wrote: > On Tue, Aug 14, 2018 at 04:37:15PM +, Konstantin Belousov wrote: > > New Revision: 337773 > > URL: https://svnweb.freebsd.org/changeset/base/337773 > > > > Log: > > amd64: ensure that curpr

Re: svn commit: r337773 - in head/sys/amd64: amd64 include

2018-08-15 Thread Alexey Dokuchaev
On Tue, Aug 14, 2018 at 04:37:15PM +, Konstantin Belousov wrote: > New Revision: 337773 > URL: https://svnweb.freebsd.org/changeset/base/337773 > > Log: > amd64: ensure that curproc->p_vmspace pmap always matches PCPU > curpmap. > > When performing context switch on a machine without

Re: svn commit: r337004 - head/sys/dev/ofw

2018-07-31 Thread Alexey Dokuchaev
On Tue, Jul 31, 2018 at 08:50:50PM +, Emmanuel Vadot wrote: > New Revision: 337004 > URL: https://svnweb.freebsd.org/changeset/base/337004 > > Log: > ofw_cpu: Add support for getting cpu clock via clock property > > Nominal Mhz is either expressed via the clock-frequency property > ...

Re: svn commit: r336503 - in head/sys: netinet netinet6

2018-07-19 Thread Alexey Dokuchaev
On Thu, Jul 19, 2018 at 04:23:27PM -0400, Michael Tuexen wrote: > > On 19. Jul 2018, at 16:11, Conrad Meyer wrote: > > These changes mostly seem like style regressions, rather than > > improvements. (Not to mention, largescale churn like this makes it > > more difficult for future readers to rese

Re: svn commit: r336503 - in head/sys: netinet netinet6

2018-07-19 Thread Alexey Dokuchaev
On Thu, Jul 19, 2018 at 01:12:19PM -0700, Devin Teske wrote: > > On Jul 19, 2018, at 12:59 PM, Ian Lepore wrote: > > ... > > "usually" may be true of freebsd, but most places I've worked consider > > the * (and & in c++) to be more associated with the type being declared > > than with the variable

Re: svn commit: r336503 - in head/sys: netinet netinet6

2018-07-19 Thread Alexey Dokuchaev
On Thu, Jul 19, 2018 at 07:33:43PM +, Michael Tuexen wrote: > New Revision: 336503 > URL: https://svnweb.freebsd.org/changeset/base/336503 > > Log: > Whitespace changes due to change if ident. Was it reviewed? Commit log does not answer this not does it explain why these changes are good.

Re: svn commit: r336203 - in head: contrib/wpa contrib/wpa/hostapd contrib/wpa/hs20/client contrib/wpa/patches contrib/wpa/src/ap contrib/wpa/src/common contrib/wpa/src/crypto contrib/wpa/src/drivers

2018-07-19 Thread Alexey Dokuchaev
On Thu, Jul 19, 2018 at 11:48:03AM +0300, Andrey V. Elsukov wrote: > ... > Yesterday I updated my notebook (with iwm(4)) and also noticed that > wi-fi connection periodically breaks. /etc/rc.d/wpa_supplicant restart > wlan0 helps. After your message I reinstalled wpa_supplicant from old > source an

Re: svn commit: r336046 - in head/sys: amd64/include i386/include sys

2018-07-09 Thread Alexey Dokuchaev
On Mon, Jul 09, 2018 at 09:23:27AM +, Brooks Davis wrote: > On Sat, Jul 07, 2018 at 02:18:56AM +0000, Alexey Dokuchaev wrote: > > On Fri, Jul 06, 2018 at 10:52:37PM +0300, Konstantin Belousov wrote: > > > On Fri, Jul 06, 2018 at 07:50:25PM +, Konstantin Belousov wrote: &g

Re: svn commit: r336025 - in head/sys: amd64/include i386/include

2018-07-06 Thread Alexey Dokuchaev
On Fri, Jul 06, 2018 at 05:06:03PM -0700, Don Lewis wrote: > The other machine is my Pentium-M laptop, which is mostly used for light > browsing and as a VNC client when I'm on the road. Performance is > acceptable for those uses. Both machines run stripped down UP kernels to > avoid wasting RAM

Re: svn commit: r336046 - in head/sys: amd64/include i386/include sys

2018-07-06 Thread Alexey Dokuchaev
On Fri, Jul 06, 2018 at 10:52:37PM +0300, Konstantin Belousov wrote: > On Fri, Jul 06, 2018 at 07:50:25PM +, Konstantin Belousov wrote: > > New Revision: 336046 > > URL: https://svnweb.freebsd.org/changeset/base/336046 > > > > Log: > > Revert to recommit with the proper message. > > I am so

Re: svn commit: r335629 - in head: share/man/man4 sys/dev/vt/hw/vga

2018-06-25 Thread Alexey Dokuchaev
On Mon, Jun 25, 2018 at 08:43:51AM -0700, Rodney W. Grimes wrote: > > New Revision: 335629 > > URL: https://svnweb.freebsd.org/changeset/base/335629 > > > > Log: > > vt: add option to ignore NO_VGA flag in ACPI > > > > To workaround buggy firmware that sets this flag when there's actually >

Re: svn commit: r335547 - head/usr.bin/top

2018-06-23 Thread Alexey Dokuchaev
On Fri, Jun 22, 2018 at 09:45:18AM +, Eitan Adler wrote: > New Revision: 335547 > URL: https://svnweb.freebsd.org/changeset/base/335547 > > Log: > top(1): remove special handling of load > 5 > > ... > Modified: head/usr.bin/top/screen.c > ==

Re: svn commit: r333945 - head/usr.bin/top

2018-06-14 Thread Alexey Dokuchaev
On Thu, Jun 14, 2018 at 05:12:09AM -0700, Eitan Adler wrote: > On 10 June 2018 at 09:26, Alexey Dokuchaev wrote: > > On Sun, Jun 10, 2018 at 08:56:24AM -0700, Eitan Adler wrote: > >> On 10 June 2018 at 05:28, Alexey Dokuchaev wrote: > >> > I've just tried the

Re: svn commit: r335042 - head/usr.bin/top

2018-06-13 Thread Alexey Dokuchaev
On Wed, Jun 13, 2018 at 05:01:35PM -0700, Bryan Drewery wrote: > ... > Also I really abhor rewriting anything that's not broken as it causes > merge conflict pain downstream and just adds regression risk. +1. I'm still having mixed feelings about top(1) de-contrib and rewrite. At the very least,

Re: svn commit: r334939 - head/stand/lua

2018-06-12 Thread Alexey Dokuchaev
On Mon, Jun 11, 2018 at 08:07:23AM -0600, Warner Losh wrote: > ... > The last articulated plan in arch@ was that LUA will be default in 12, and > we plan to remove FORTH in 13. Last time I said it there in February, there > was only email agreeing that I could find. This matches the in-person > con

Re: svn commit: r333945 - head/usr.bin/top

2018-06-10 Thread Alexey Dokuchaev
On Sun, Jun 10, 2018 at 08:56:24AM -0700, Eitan Adler wrote: > On 10 June 2018 at 05:28, Alexey Dokuchaev wrote: > > I've just tried the latest top(1). Now it's even worse: > > ... > > Also, it is COMMA now. Can we please do something about this? I am not >

Re: svn commit: r333945 - head/usr.bin/top

2018-06-10 Thread Alexey Dokuchaev
On Mon, May 21, 2018 at 06:39:53AM +, Alexey Dokuchaev wrote: > I [...] have to patch top(1) locally to use namelength = 8 and header > format so it neatly looks like this: > > PID USERNAME THR PRI NICE SIZERES STATE C TIMEWCPU COMMAND > 844 danfe 2

Re: svn commit: r334844 - in head: cddl/contrib/opensolaris/cmd/zdb cddl/contrib/opensolaris/cmd/zpool cddl/contrib/opensolaris/cmd/ztest cddl/contrib/opensolaris/lib/libzfs/common cddl/contrib/openso

2018-06-09 Thread Alexey Dokuchaev
On Fri, Jun 08, 2018 at 05:38:28PM +, Sean Eric Fagan wrote: > New Revision: 334844 > URL: https://svnweb.freebsd.org/changeset/base/334844 > > Log: > This originated from ZFS On Linux [...] > > During scans (scrubs or resilvers), it sorts the blocks in each > transaction group by blo

Re: svn commit: r334791 - head/share/mk

2018-06-07 Thread Alexey Dokuchaev
On Thu, Jun 07, 2018 at 03:37:50PM -0400, Bryan Drewery wrote: > On 6/7/18 1:05 PM, Alexey Dokuchaev wrote: > > ... > > Actually, `sed q' is sufficient. > > I'll stick with -n 1p as I think it is more clear. Fair enough, the latter one is indeed a

Re: svn commit: r334791 - head/share/mk

2018-06-07 Thread Alexey Dokuchaev
On Thu, Jun 07, 2018 at 04:44:20PM +, Alexey Dokuchaev wrote: > On Thu, Jun 07, 2018 at 04:16:22PM +, Bryan Drewery wrote: > > New Revision: 334791 > > URL: https://svnweb.freebsd.org/changeset/base/334791 > > > > Log: > > Stop using head(1) which

Re: svn commit: r334791 - head/share/mk

2018-06-07 Thread Alexey Dokuchaev
On Thu, Jun 07, 2018 at 04:16:22PM +, Bryan Drewery wrote: > New Revision: 334791 > URL: https://svnweb.freebsd.org/changeset/base/334791 > > Log: > Stop using head(1) which is not available in installworld. > ... > @@ -49,7 +49,7 @@ ${var}= ${${var}.${${X_}_ld_hash}} > > .if ${ld} ==

Re: svn commit: r334617 - in head: . etc

2018-06-07 Thread Alexey Dokuchaev
On Wed, Jun 06, 2018 at 11:27:20PM +0300, Konstantin Belousov wrote: > On Wed, Jun 06, 2018 at 02:06:48PM -0600, Ian Lepore wrote: > > ... > > I don't understand the drama over this. rc.d startup scripts are > > *binaries*. No, they are not, they are scripts. > I proposed to move them somewhere,

Re: svn commit: r334617 - in head: . etc

2018-06-07 Thread Alexey Dokuchaev
[ CC list trimmed, was too long ] On Thu, Jun 07, 2018 at 01:16:01PM +0200, Emmanuel Vadot wrote: > On Thu, 7 Jun 2018 07:33:29 + > Alexey Dokuchaev wrote: > > On Wed, Jun 06, 2018 at 11:27:20PM +0300, Konstantin Belousov wrote: > > > I proposed to move them somewhere,

Re: svn commit: r334617 - in head: . etc

2018-06-07 Thread Alexey Dokuchaev
On Wed, Jun 06, 2018 at 01:02:25PM -0600, Brad Davis wrote: > On Wed, Jun 6, 2018, at 12:33 PM, Rodney W. Grimes wrote: > > ... > > So each installworld would wipe over the top of any localmod /etc/rc.d/ > > and other stuff that mght exist? > > One of the reasons that etc/Makefile is detached from

Re: svn commit: r334552 - head/usr.bin/top

2018-06-04 Thread Alexey Dokuchaev
On Sun, Jun 03, 2018 at 05:07:46AM +, Eitan Adler wrote: > New Revision: 334552 > URL: https://svnweb.freebsd.org/changeset/base/334552 > > Log: > top(1): remove chdir to / > > While this came out of a conversation in IRC, it turn out that some > people don't like it. Since this was a

Re: svn commit: r334221 - head/etc

2018-05-26 Thread Alexey Dokuchaev
On Fri, May 25, 2018 at 07:36:26PM +, Mark Felder wrote: > New Revision: 334221 > URL: https://svnweb.freebsd.org/changeset/base/334221 > > Log: > rc.subr: Support loading environmental variables from a file > > + if [ -n "$_env_file" ] && [ -r "${_env_file}" ]; then Style bug: "$_en

Re: svn commit: r333388 - in head: . share/man/man4 sys/confsys/dev/nxge sys/modules sys/modules/nxge tools/kerneldoc/subsys tools/toolstools/tools/nxge usr.sbin/bsdconfig/share

2018-05-24 Thread Alexey Dokuchaev
On Wed, May 23, 2018 at 12:30:26PM -0700, Cy Schubert wrote: > Except for old computers and old software that segfaults on 64-bit, > how many people still use i386? i386 is my primary development machine at $work and home; I have one amd64 laptop and one i386, and a Mac mini G4 (powerpc32). Most

Re: svn commit: r333994 - in head/sys: dev/acpica kern sys

2018-05-22 Thread Alexey Dokuchaev
On Mon, May 21, 2018 at 08:23:04PM +, Andriy Gapon wrote: > New Revision: 333994 > URL: https://svnweb.freebsd.org/changeset/base/333994 > > Log: > stop and restart kernel event timers in the suspend / resume cycle > > I have a system that is very unstable after resuming from suspend-to

Re: svn commit: r333945 - head/usr.bin/top

2018-05-20 Thread Alexey Dokuchaev
On Mon, May 21, 2018 at 10:32:30AM +1000, Bruce Evans wrote: > ... > > if (smpmode && namelength > SMPUNAMELEN) > > namelength = SMPUNAMELEN; > > else if (namelength > UPUNAMELEN) > > But 33 is too large. It is much larger than the hard-coded maximum limits, > so it is never u

Re: svn commit: r333872 - head/cddl/contrib/opensolaris/tools/ctf/cvt

2018-05-20 Thread Alexey Dokuchaev
On Sat, May 19, 2018 at 03:44:37PM -0400, Mark Johnston wrote: > ... > I don't really think it's important. The main consideration is the > toolchain. We use illumos as an upstream, which is pretty inactive at > this point. Joyent's illumos fork has put a lot of work into the CTF > toolchain, and O

Re: svn commit: r333477 - in head: contrib/jemalloc contrib/jemalloc/doc contrib/jemalloc/include/jemalloc contrib/jemalloc/include/jemalloc/internal contrib/jemalloc/src lib/libc/stdlib/jemalloc

2018-05-10 Thread Alexey Dokuchaev
On Fri, May 11, 2018 at 12:32:32AM +, Jason Evans wrote: > New Revision: 333477 > URL: https://svnweb.freebsd.org/changeset/base/333477 > > Log: > Update jemalloc to version 5.1.0. > > [...] > + Bug fixes (most of the issues are only relevant to jemalloc 5.0): > + - Fix a few background t

Re: svn commit: r333351 - head/usr.bin/grep

2018-05-08 Thread Alexey Dokuchaev
On Tue, May 08, 2018 at 09:36:21AM -0500, Kyle Evans wrote: > On Tue, May 8, 2018 at 5:58 AM, Alexey Dokuchaev wrote: > >> > >> - if ((f = fopen(fn, "r")) == NULL) > >> + if (strcmp(fn, "-") == 0) > >> + f = stdi

Re: svn commit: r333351 - head/usr.bin/grep

2018-05-08 Thread Alexey Dokuchaev
On Tue, May 08, 2018 at 03:53:47AM +, Kyle Evans wrote: > New Revision: 51 > URL: https://svnweb.freebsd.org/changeset/base/51 > > Log: > bsdgrep: Allow "-" to be passed to -f to mean "standard input" > > A version of this patch was originally sent to me by se@, matching behavio

Re: svn commit: r333240 - in head/sys: powerpc/powerpc sys

2018-05-05 Thread Alexey Dokuchaev
On Sat, May 05, 2018 at 10:38:29AM +1000, Bruce Evans wrote: > ... > Summary: this change wouldn't have passed my review. I have used similar > changes for 15-20 years but never made them production quality since there > are too many variations to consider and testing showed insignificant > improv

Re: svn commit: r332645 - head/sbin/ifconfig

2018-04-19 Thread Alexey Dokuchaev
On Tue, Apr 17, 2018 at 12:54:59PM +, Andrew Gallatin wrote: > New Revision: 332645 > URL: https://svnweb.freebsd.org/changeset/base/332645 > > Log: > Make lagg creation more fault tolerant > > - Warn, don't exit, when SIOCSLAGGPORT returns an error. > > When we exit with an error

Re: svn commit: r332092 - in head/sys: amd64/amd64 sys x86/x86

2018-04-07 Thread Alexey Dokuchaev
On Fri, Apr 06, 2018 at 07:14:42AM -0700, Conrad Meyer wrote: > I like something like this for clarity. But I don't see any reason > for these function-like macros instead of the more general definition > of an SI prefix constant multiple. A multiple works with numeric > literals and variables al

Re: svn commit: r331209 - head

2018-03-27 Thread Alexey Dokuchaev
On Tue, Mar 27, 2018 at 09:48:43AM -0700, John Baldwin wrote: > On Tuesday, March 27, 2018 05:19:12 AM Alexey Dokuchaev wrote: > > On Thu, Mar 22, 2018 at 08:52:47AM -0700, John Baldwin wrote: > > > On Thursday, March 22, 2018 04:39:38 AM Alexey Dokuchaev wrote: > > >

Re: svn commit: r331209 - head

2018-03-26 Thread Alexey Dokuchaev
On Thu, Mar 22, 2018 at 08:52:47AM -0700, John Baldwin wrote: > On Thursday, March 22, 2018 04:39:38 AM Alexey Dokuchaev wrote: > > > ... > > Right, but John had mentioned extra reboot *between* installkernel and > > installworld, which I've never heard of before

Re: svn commit: r331209 - head

2018-03-21 Thread Alexey Dokuchaev
On Wed, Mar 21, 2018 at 10:34:15PM -0600, Warner Losh wrote: > On Wed, Mar 21, 2018 at 10:03 PM, Alexey Dokuchaev > wrote: > > On Mon, Mar 19, 2018 at 09:20:40AM -0700, John Baldwin wrote: > > > ... > > > How does this fit with the recommended installation steps of d

Re: svn commit: r331209 - head

2018-03-21 Thread Alexey Dokuchaev
On Mon, Mar 19, 2018 at 09:20:40AM -0700, John Baldwin wrote: > On Monday, March 19, 2018 03:27:53 PM Kyle Evans wrote: > > New Revision: 331209 > > URL: https://svnweb.freebsd.org/changeset/base/331209 > > > > Log: > > Add note to UPDATING about UEFI changes requiring loader(8) update > > ...

Re: svn commit: r330705 - head/sbin/mount

2018-03-10 Thread Alexey Dokuchaev
On Fri, Mar 09, 2018 at 09:32:08PM +, Warner Losh wrote: > New Revision: 330705 > URL: https://svnweb.freebsd.org/changeset/base/330705 > > Log: > Remove decade's old whine about msdos vs msdosfs. > > Retain the compatibility silently though. Shouldn't it be the other way around? That

Re: svn commit: r330236 - head/sys/compat/linuxkpi/common/src

2018-03-04 Thread Alexey Dokuchaev
On Sun, Mar 04, 2018 at 01:25:17AM +, Colin Percival wrote: > On 03/01/18 02:31, Hans Petter Selasky wrote: > > New Revision: 330236 > > Correct the return value from flush_work() and flush_delayed_work() > > in the LinuxKPI to comply more with Linux. This fixes an issue when > > these fu

Re: svn commit: r309017 - in head/sys: cddl/compat/opensolaris/sys compat/linprocfs fs/tmpfs sys vm

2018-03-03 Thread Alexey Dokuchaev
On Tue, Nov 22, 2016 at 06:13:46PM +, Alan Cox wrote: > New Revision: 309017 > URL: https://svnweb.freebsd.org/changeset/base/309017 > > Log: > Remove PG_CACHED-related fields from struct vmmeter, because they are no > longer used. More precisely, they are always zero because the code tha

Re: svn commit: r329154 - in head/etc: defaults devd

2018-02-11 Thread Alexey Dokuchaev
On Sun, Feb 11, 2018 at 10:55:48PM -0800, Cy Schubert wrote: > In message <201802120651.w1c6pkqf042...@repo.freebsd.org>, Warner Losh > writes: > > New Revision: 329154 > > URL: https://svnweb.freebsd.org/changeset/base/329154 > > > > Log: > > Turn devmatch on by default. > > > > Turn devmat

Re: svn commit: r329064 - head/share/zoneinfo

2018-02-09 Thread Alexey Dokuchaev
On Fri, Feb 09, 2018 at 11:50:35AM -0700, Warner Losh wrote: > On Fri, Feb 9, 2018 at 10:49 AM, John Baldwin wrote: > > On Friday, February 09, 2018 03:50:33 PM Warner Losh wrote: > > > New Revision: 329064 > > > URL: https://svnweb.freebsd.org/changeset/base/329064 > > > > > > Log: > > > We don

Re: svn commit: r319971 - in head: contrib/jemalloc contrib/jemalloc/doc contrib/jemalloc/include/jemalloc contrib/jemalloc/include/jemalloc/internal contrib/jemalloc/src include lib/libc/stdlib/jemal

2018-01-23 Thread Alexey Dokuchaev
On Mon, Jan 22, 2018 at 10:50:06AM -0800, John Baldwin wrote: > On Monday, January 22, 2018 06:32:10 AM Alexey Dokuchaev wrote: > > ... > > I've just found out that similar bug was already reported back in July: > > > > https://bugs.freebsd.org/bugzilla/show_bu

Re: svn commit: r328259 - in head: share/man/man4 sys/arm/broadcom/bcm2835

2018-01-21 Thread Alexey Dokuchaev
On Mon, Jan 22, 2018 at 07:43:54AM +, Poul-Henning Kamp wrote: > New Revision: 328259 > URL: https://svnweb.freebsd.org/changeset/base/328259 > > Log: > Add skeleton manual page for bcm283x_pwm > > (Feel free to improve this) > > Added: > head/share/man/man4/bcm283x_pwm.4 (contents

Re: svn commit: r319971 - in head: contrib/jemalloc contrib/jemalloc/doc contrib/jemalloc/include/jemalloc contrib/jemalloc/include/jemalloc/internal contrib/jemalloc/src include lib/libc/stdlib/jemal

2018-01-21 Thread Alexey Dokuchaev
On Thu, Jan 18, 2018 at 10:10:31AM +, Alexey Dokuchaev wrote: > On Sat, Jan 13, 2018 at 05:04:30PM +0000, Alexey Dokuchaev wrote: > > On Thu, Jun 15, 2017 at 07:15:06AM +, Jason Evans wrote: > > > New Revision: 319971 > > > URL: https://svnweb.freebs

Re: svn commit: r319971 - in head: contrib/jemalloc contrib/jemalloc/doc contrib/jemalloc/include/jemalloc contrib/jemalloc/include/jemalloc/internal contrib/jemalloc/src include lib/libc/stdlib/jemal

2018-01-18 Thread Alexey Dokuchaev
On Sat, Jan 13, 2018 at 05:04:30PM +, Alexey Dokuchaev wrote: > On Thu, Jun 15, 2017 at 07:15:06AM +, Jason Evans wrote: > > New Revision: 319971 > > URL: https://svnweb.freebsd.org/changeset/base/319971 > > > > Log: > > Update jemalloc to 5.0.0. >

Re: svn commit: r327890 - head/usr.sbin/bsdinstall/partedit

2018-01-18 Thread Alexey Dokuchaev
On Thu, Jan 18, 2018 at 10:46:20AM +0100, Gary Jennejohn wrote: > On Thu, 18 Jan 2018 07:26:11 + > Alexey Dokuchaev wrote: > > > ... > > > Thanks; I keep seeing it quite often. > > > Is it safe to disable SUJ on already populated filesystem? > > &

Re: svn commit: r327890 - head/usr.sbin/bsdinstall/partedit

2018-01-17 Thread Alexey Dokuchaev
On Sat, Jan 13, 2018 at 06:53:47AM +, Alexey Dokuchaev wrote: > On Fri, Jan 12, 2018 at 08:25:57PM +, Ed Maste wrote: > > New Revision: 327890 > > URL: https://svnweb.freebsd.org/changeset/base/327890 > > > > Log: > > bsdinstall: disable SUJ by defaul

Re: svn commit: r319971 - in head: contrib/jemalloc contrib/jemalloc/doc contrib/jemalloc/include/jemalloc contrib/jemalloc/include/jemalloc/internal contrib/jemalloc/src include lib/libc/stdlib/jemal

2018-01-13 Thread Alexey Dokuchaev
On Thu, Jun 15, 2017 at 07:15:06AM +, Jason Evans wrote: > New Revision: 319971 > URL: https://svnweb.freebsd.org/changeset/base/319971 > > Log: > Update jemalloc to 5.0.0. I've finally bisected the problem of `games/quake2lnx' failing to start (hanging) in GLX mode down to this commit. Re

Re: svn commit: r327890 - head/usr.sbin/bsdinstall/partedit

2018-01-12 Thread Alexey Dokuchaev
On Fri, Jan 12, 2018 at 08:25:57PM +, Ed Maste wrote: > New Revision: 327890 > URL: https://svnweb.freebsd.org/changeset/base/327890 > > Log: > bsdinstall: disable SUJ by default > > SUJ + cg checksums produce spurious warnings after an unclean shutdown > (e.g. a crash). For now disa

Re: svn commit: r327767 - in head/sys: conf i386/bios i386/conf i386/isa

2018-01-10 Thread Alexey Dokuchaev
On Wed, Jan 10, 2018 at 10:32:46AM -0700, Warner Losh wrote: > On Wed, Jan 10, 2018 at 10:30 AM, Alexey Dokuchaev wrote: > > On Wed, Jan 10, 2018 at 10:20:17AM -0700, Warner Losh wrote: > > > On Wed, Jan 10, 2018 at 10:14 AM, Alexey Dokuchaev wrote: > > > > ... &

Re: svn commit: r327767 - in head/sys: conf i386/bios i386/conf i386/isa

2018-01-10 Thread Alexey Dokuchaev
On Wed, Jan 10, 2018 at 10:20:17AM -0700, Warner Losh wrote: > On Wed, Jan 10, 2018 at 10:14 AM, Alexey Dokuchaev wrote: > > ... > > Not sure of now, but at least back in 2013 pmtimer was required on my > > i386 ACPI-ish laptop (it is still required now, but I just d

Re: svn commit: r327767 - in head/sys: conf i386/bios i386/conf i386/isa

2018-01-10 Thread Alexey Dokuchaev
On Wed, Jan 10, 2018 at 10:01:41AM -0700, Warner Losh wrote: > On Wed, Jan 10, 2018 at 9:58 AM, Alexey Dokuchaev wrote: > > On Wed, Jan 10, 2018 at 09:48:05AM -0700, Warner Losh wrote: > > > On Wed, Jan 10, 2018 at 9:31 AM, Rodney W. Grimes wrote: > > > > > N

Re: svn commit: r327767 - in head/sys: conf i386/bios i386/conf i386/isa

2018-01-10 Thread Alexey Dokuchaev
On Wed, Jan 10, 2018 at 09:48:05AM -0700, Warner Losh wrote: > On Wed, Jan 10, 2018 at 9:31 AM, Rodney W. Grimes wrote: > > > New Revision: 327767 > > > URL: https://svnweb.freebsd.org/changeset/base/327767 > > > > > > Log: > > > Retire pmtimer driver. Move time fixing into apm driver. Move > > >

Re: svn commit: r327209 - head/sys/netinet/libalias

2017-12-26 Thread Alexey Dokuchaev
On Tue, Dec 26, 2017 at 04:12:04PM +, Michael Tuexen wrote: > New Revision: 327209 > URL: https://svnweb.freebsd.org/changeset/base/327209 > > Log: > Clearify CID 1008197. Again, this "clarifies" nothing. I see a bunch of style(9) bugs fixed, and fail to see how/why those had upset Coverit

Re: svn commit: r327205 - head/sys/netinet/libalias

2017-12-26 Thread Alexey Dokuchaev
On Tue, Dec 26, 2017 at 03:24:42PM +, Michael Tuexen wrote: > New Revision: 327205 > URL: https://svnweb.freebsd.org/changeset/base/327205 > > Log: > Fix CID 1008936. I'm afraid this is a rather bad commit message. It should have described what was the problem and how it was approached (fi

Re: svn commit: r326809 - head/sys/dev/cardbus

2017-12-14 Thread Alexey Dokuchaev
On Thu, Dec 14, 2017 at 02:36:48AM +0700, Eugene Grosbein wrote: > 14.12.2017 1:24, Alexey Dokuchaev wrote: > ... > > One does not tweak FreeBSD, it just works. (tm) > > Hmm. Do you really think so? I do. > I can assure you this is not true. There are numerous ways to

Re: svn commit: r326809 - head/sys/dev/cardbus

2017-12-13 Thread Alexey Dokuchaev
On Thu, Dec 14, 2017 at 01:16:27AM +0700, Eugene Grosbein wrote: > 14.12.2017 1:08, Alexey Dokuchaev пишет: > > On Thu, Dec 14, 2017 at 12:48:17AM +0700, Eugene Grosbein wrote: > >> ... > >> I don't understand why you want to backout that. It changed nothing f

Re: svn commit: r326809 - head/sys/dev/cardbus

2017-12-13 Thread Alexey Dokuchaev
On Thu, Dec 14, 2017 at 12:48:17AM +0700, Eugene Grosbein wrote: > ... > I don't understand why you want to backout that. It changed nothing for > amd64. An i386 is still vulnerable to double faults just because of a > network packet processing path can overflow kstack for the GENERIC kernel. The

Re: svn commit: r326809 - head/sys/dev/cardbus

2017-12-12 Thread Alexey Dokuchaev
On Tue, Dec 12, 2017 at 12:39:38PM -0800, Rodney W. Grimes wrote: > > New Revision: 326809 > > URL: https://svnweb.freebsd.org/changeset/base/326809 > > > > Log: > > 1k objects on the stack are a bad idea. While it's likely safe in this > > context, it's also safe to allocate the memory and fr

Re: svn commit: r326773 - in head/sys: conf dev/syscon

2017-12-11 Thread Alexey Dokuchaev
On Mon, Dec 11, 2017 at 10:14:04AM -0800, Nathan Whitehorn wrote: > I think this name might confuse people looking for "syscons". Can it be > renamed? Also, if it is ARM-specific, maybe it belongs in sys/arm? +1 for rename, it's very confusing now. ./danfe

Re: svn commit: r326758 - in head/sys/i386: conf include

2017-12-11 Thread Alexey Dokuchaev
On Mon, Dec 11, 2017 at 11:21:06PM +0700, Eugene Grosbein wrote: > 11.12.2017 22:08, Konstantin Belousov пишет: > > Plain workstation use, like X11+browser+editor+some other programs easily > > allocates 1000+ threads. It was still possible to use 32bit x86 for that, > > of course in max memory co

Re: svn commit: r326758 - in head/sys/i386: conf include

2017-12-11 Thread Alexey Dokuchaev
On Mon, Dec 11, 2017 at 07:09:10AM -0800, Rodney W. Grimes wrote: > [ Charset UTF-8 unsupported, converting... ] > > New Revision: 326758 > > URL: https://svnweb.freebsd.org/changeset/base/326758 > > > > Log: > > i386: Bump KSTACK_PAGES default to match amd64 > > > > Logically, extend r2862

<    1   2   3   4   5   >