Re: svn commit: r356755 - in head/sys: net netinet netinet6 netpfil/ipfw/nat64 sys

Aren’t the current and suggested the same there or do I need more coffee this morning? On Wed, 15 Jan 2020 at 06:10, Gleb Smirnoff wrote: > Hi, > > On Wed, Jan 15, 2020 at 06:05:20AM +, Gleb Smirnoff wrote: > T> Log: > T> Introduce NET_EPOCH_CALL() macro and use it everywhere where we

Re: svn commit: r355831 - head/sys/cam/nvme

Thanks for all the feedback Warner, some more comments in line below, would be interested in your thoughts. On 17/12/2019 02:53, Warner Losh wrote: On Mon, Dec 16, 2019, 5:28 PM Steven Hartland <mailto:steven.hartl...@multiplay.co.uk>> wrote: Be aware that ZFS already does

Re: svn commit: r355837 - head/sys/cam

Sticky keyboard there Warner? On a more serious note the fact that the controllers lie about the underlying location of data, the impact of skipping the TRIM requests can have a much more serious impact than one might think depending on the drive, so this type of optimisation can

Re: svn commit: r355832 - head/sys/cam

What if any is the impact on request ordering with this new delayed TRIM? On 17/12/2019 00:13, Warner Losh wrote: Author: imp Date: Tue Dec 17 00:13:21 2019 New Revision: 355832 URL: https://svnweb.freebsd.org/changeset/base/355832 Log: Add rate limiters to TRIM. Add rate limiters to

Re: svn commit: r355831 - head/sys/cam/nvme

Be aware that ZFS already does a pretty decent job of this already, so the statement about upper layers isn't true for all. It even has different priorities for different request types so I'm a little concerned that doing it at both layers could cause issues. In addition to this if its

Re: svn commit: r355430 - head/sys/cam/scsi

If the illegal chars where removed or replaced would the result be useful, if so might that be a better approach? On Fri, 6 Dec 2019 at 00:06, Alan Somers wrote: > Author: asomers > Date: Fri Dec 6 00:06:05 2019 > New Revision: 355430 > URL: https://svnweb.freebsd.org/changeset/base/355430 > >

Re: svn commit: r354283 - in head: stand/libsa/zfs sys/cddl/boot/zfs

Pretty sure we had at least two systems using root with log just fine, so would be interested to know why this isn’t supported anymore? On Sun, 3 Nov 2019 at 13:26, Toomas Soome wrote: > Author: tsoome > Date: Sun Nov 3 13:25:47 2019 > New Revision: 354283 > URL:

svn commit: r346594 - head/sbin/camcontrol

Author: smh Date: Tue Apr 23 07:46:38 2019 New Revision: 346594 URL: https://svnweb.freebsd.org/changeset/base/346594 Log: Add ATA power mode support to camcontrol Add the ability to report ATA device power mode with the cmmand 'powermode' to compliment the existing ability to set it

Re: svn commit: r348255 - head/sys/kern

Just wanted to say I really appreciate the details in this commit message. Its often the case the message get overlooked when it comes to the time needed to write a truly useful message to others and this a great example of the quality we should all try to follow. Regards Steve On Fri, 24

svn commit: r346594 - head/sbin/camcontrol

Author: smh Date: Tue Apr 23 07:46:38 2019 New Revision: 346594 URL: https://svnweb.freebsd.org/changeset/base/346594 Log: Add ATA power mode support to camcontrol Add the ability to report ATA device power mode with the cmmand 'powermode' to compliment the existing ability to set it

Re: svn commit: r344701 - head/sbin/camcontrol

Not really much more to say that isn't explained by that and the code. Sure I could have used a different sentence structure for the body but it wouldn't add anything IMO, thoughts? On 02/03/2019 10:49, Alexey Dokuchaev wrote: On Fri, Mar 01, 2019 at 02:39:15PM +, Steven Hartland wrote

svn commit: r344701 - head/sbin/camcontrol

Author: smh Date: Fri Mar 1 14:39:15 2019 New Revision: 344701 URL: https://svnweb.freebsd.org/changeset/base/344701 Log: Fix incorrect / unused sector_count for identify requests Fix incorrect / unused sector_count for identify requests from camcontrol. Submitted by: Alexey

Re: svn commit: r343745 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

On 04/02/2019 16:13, Alexander Motin wrote: Author: mav Date: Mon Feb 4 16:13:41 2019 New Revision: 343745 URL: https://svnweb.freebsd.org/changeset/base/343745 Log: Add missed tunables/sysctls for some new vdev variables. While there, make few existing sysctls writeable, since

Re: svn: head/usr.bin: . trim

On 30/11/2018 22:09, Eugene Grosbein wrote: 01.12.2018 4:29, Steven Hartland wrote: On 30/11/2018 21:16, Eugene Grosbein wrote: 30.11.2018 21:23, Warner Losh wrote: So I'm back to my point: we should just put it into dd and move on with our lives. It's really the right place for it. Why

Re: svn: head/usr.bin: . trim

ZFS already does that no need for a separate tool On 30/11/2018 21:16, Eugene Grosbein wrote: 30.11.2018 21:23, Warner Losh wrote: So I'm back to my point: we should just put it into dd and move on with our lives. It's really the right place for it. Why can't we have two implementations?

Re: svn: head/usr.bin: . trim

Personally I disagree, chances of people finding that option in dd is slim, a dedicated trim utility makes much more sense to me. Sure have both that's cool but keep the trim would be my vote. On 30/11/2018 01:17, Cy Schubert wrote: Agreed. --- Sent using a tiny phone keyboard. Apologies for

svn commit: r336165 - head/sys/netinet

Author: smh Date: Tue Jul 10 08:05:32 2018 New Revision: 336165 URL: https://svnweb.freebsd.org/changeset/base/336165 Log: Removed pointless NULL check Removed pointless NULL check after malloc with M_WAITOK which can never return NULL. Sponsored by: Multiplay Modified:

Re: svn commit: r335856 - in head/sys: netinet sys

: [ Charset UTF-8 unsupported, converting... ] On Mon, Jul 2, 2018 at 10:44 AM Steven Hartland < steven.hartl...@multiplay.co.uk> wrote: You have M_WAITOK and a null check in this change And, that's the same as the way it was before his commits. So, he did exactly what he said he was

Re: svn commit: r335856 - in head/sys: netinet sys

You have M_WAITOK and a null check in this change On Mon, 2 Jul 2018 at 06:20, Matt Macy wrote: > Author: mmacy > Date: Mon Jul 2 05:19:44 2018 > New Revision: 335856 > URL: https://svnweb.freebsd.org/changeset/base/335856 > > Log: > inpcb: don't gratuitously defer frees > > Don't defer

Re: svn commit: r335171 - head/sys/vm

On 15/06/2018 00:07, Alan Cox wrote: On Jun 14, 2018, at 5:54 PM, Steven Hartland <mailto:steven.hartl...@multiplay.co.uk>> wrote: Out of interest, how would this exhibit itself? A panic in vm_page_insert_after(). So just to confirm this couldn't cause random memory c

Re: svn commit: r335171 - head/sys/vm

Out of interest, how would this exhibit itself? On 14/06/2018 20:41, Konstantin Belousov wrote: Author: kib Date: Thu Jun 14 19:41:02 2018 New Revision: 335171 URL: https://svnweb.freebsd.org/changeset/base/335171 Log: Handle the race between fork/vm_object_split() and faults. If

Re: svn commit: r333267 - head/sys/kern

Again why? On Fri, 4 May 2018 at 23:48, Mateusz Guzik wrote: > Author: mjg > Date: Fri May 4 22:48:10 2018 > New Revision: 333267 > URL: https://svnweb.freebsd.org/changeset/base/333267 > > Log: > tc: bcopy -> memcpy > > Modified: > head/sys/kern/kern_tc.c > > Modified:

Re: svn commit: r333266 - head/sys/amd64/amd64

Can we get the why in commit messages please? This sort of message doesnt provide anything more that can be obtained from reading the diff, which just leaves us wondering why? I’m sure there is a good reason, but without confirmation we’re just left guessing. The knock on to this is if some

Re: svn commit: r332523 - in head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs: . sys

Hey Mav, this seems like an important one to get in for 11.2 so just wanted to check if that was your intention as there's no MFC tag on the commit? On 16/04/2018 01:54, Alexander Motin wrote: Author: mav Date: Mon Apr 16 00:54:58 2018 New Revision: 332523 URL:

Re: svn commit: r332285 - head/sys/kern

Worth making the sysctls so they can be tuned the the HW / use case? On 08/04/2018 17:34, Mateusz Guzik wrote: Author: mjg Date: Sun Apr 8 16:34:10 2018 New Revision: 332285 URL: https://svnweb.freebsd.org/changeset/base/332285 Log: locks: tweak backoff a little bit Previous limits

Re: svn commit: r327559 - in head: . sys/net

On 05/01/2018 13:11, Slawa Olhovchenkov wrote: On Fri, Jan 05, 2018 at 03:50:31AM +0700, Eugene Grosbein wrote: 05.01.2018 3:05, Steven Hartland wrote: Author: smh Date: Thu Jan 4 20:05:47 2018 New Revision: 327559 URL: https://svnweb.freebsd.org/changeset/base/327559 Log: Disabled

Re: svn commit: r331209 - head

I think it would be worth specifically detailing the steps to achieve this, as its not immediately obvious how this would be done. On 19/03/2018 15:27, Kyle Evans wrote: Author: kevans Date: Mon Mar 19 15:27:53 2018 New Revision: 331209 URL: https://svnweb.freebsd.org/changeset/base/331209

svn commit: r330951 - head/sys/dev/mps

Author: smh Date: Wed Mar 14 21:32:23 2018 New Revision: 330951 URL: https://svnweb.freebsd.org/changeset/base/330951 Log: Fix mps deadlock when handling panic During shutdown mps waits for its SSU requests to complete however when performing a reboot after handling a panic the scheduler

Re: svn commit: r330950 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

Missed the differential review: https://reviews.freebsd.org/D14695 On 14/03/2018 21:21, Steven Hartland wrote: Author: smh Date: Wed Mar 14 21:21:03 2018 New Revision: 330950 URL: https://svnweb.freebsd.org/changeset/base/330950 Log: Prevent ZFS TRIM breaking VTOC8 partitions Update

svn commit: r330950 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

Author: smh Date: Wed Mar 14 21:21:03 2018 New Revision: 330950 URL: https://svnweb.freebsd.org/changeset/base/330950 Log: Prevent ZFS TRIM breaking VTOC8 partitions Update the ZFS TRIM code to ensure it respects VTOC8 partition headers as documented by the ZFS On-Disk Specification

Re: svn commit: r329812 - head/sys/cam

In our experience this is very device dependent, what lead you to this conclusion? On 22/02/2018 05:43, Warner Losh wrote: Author: imp Date: Thu Feb 22 05:43:20 2018 New Revision: 329812 URL: https://svnweb.freebsd.org/changeset/base/329812 Log: Don't sort TRIMs. While the code for

Re: svn commit: r328996 - head/sys/kern

What would be the expected behavior if this was triggered, app crash or kernel panic...? On 07/02/2018 21:52, Andriy Gapon wrote: Author: avg Date: Wed Feb 7 21:51:59 2018 New Revision: 328996 URL: https://svnweb.freebsd.org/changeset/base/328996 Log: exec_map_first_page: fix an inverse

Re: svn commit: r328625 - in head/sys: amd64/amd64 amd64/ia32 amd64/include dev/cpuctl i386/i386 x86/include x86/x86

Pretty sure I’ve seen that too On Wed, 31 Jan 2018 at 18:05, Rodney W. Grimes < free...@pdx.rh.cn85.dnsmgr.net> wrote: > > On Wed, Jan 31, 2018 at 02:56:24PM +, Bjoern A. Zeeb wrote: > > > On 31 Jan 2018, at 14:36, Konstantin Belousov wrote: > > > > > > > Author: kib > > > > Date: Wed Jan 31

svn commit: r328321 - head/sys/net

Author: smh Date: Wed Jan 24 10:13:14 2018 New Revision: 328321 URL: https://svnweb.freebsd.org/changeset/base/328321 Log: Added missing CTLFLAG_VNET to lacp default_strict_mode Added CTLFLAG_VNET to net.link.lagg.lacp.default_strict_mode which was missed in r290450. Reported by:

Re: svn commit: r328136 - in head/etc: defaults rc.d

Did you intend to add the growfs option at the same time as it wasn’t mentioned in the commit msg On Thu, 18 Jan 2018 at 20:46, Brad Davis wrote: > Author: brd (doc,ports committer) > Date: Thu Jan 18 20:45:41 2018 > New Revision: 328136 > URL:

Re: svn commit: r327559 - in head: . sys/net

On 05/01/2018 23:30, Scott Long wrote: On Jan 5, 2018, at 11:20 AM, Eugene Grosbein wrote: CC'ng scottl@ as author of the change in question. 06.01.2018 0:39, Matt Joras wrote: For what it's worth, this was the conclusion I came to, and at Isilon we've made the same

Re: svn commit: r327559 - in head: . sys/net

On 05/01/2018 17:39, Matt Joras wrote: On Fri, Jan 5, 2018 at 9:32 AM, Eugene Grosbein wrote: 06.01.2018 0:28, Matt Joras wrote: For what it's worth, this was the conclusion I came to, and at Isilon we've made the same change being discussed here. For the case of

Re: svn commit: r327559 - in head: . sys/net

On 05/01/2018 17:06, Eugene Grosbein wrote: 05.01.2018 23:11, Steven Hartland wrote: What do others think, am I missing something? You still consider only TCP case missing IP forwarning case when all IP packets are transit coming from lagg0 and going out via lagg1. Just going out via a laggX

Re: svn commit: r327559 - in head: . sys/net

On 05/01/2018 17:16, Eugene Grosbein wrote: That is, there is no guarantee of persistance of flowid of incoming packets as they can be received with distinct ports of lagg being distinct hardware computing flowid differently. Some ports may not support RSS at all. We should not use incoming

Re: svn commit: r327559 - in head: . sys/net

On 05/01/2018 17:02, Eugene Grosbein wrote: 05.01.2018 22:13, Steven Hartland wrote: I hope there's some improvements that can be made, for example if we can determine the stream was instigated remotely then flowid would always be valid hence we can use it assuming it matches the requested

Re: svn commit: r327559 - in head: . sys/net

On 05/01/2018 09:41, hiren panchasara wrote: IIRC, with 'RSS' in kernconf, most NIC drivers and stack should do the right thing. Look at drivers and also conn startup code in TCP as I recall it doing the flowid mapping correctly when stream originated from the other side and had flowid assigned

Re: svn commit: r327559 - in head: . sys/net

On 05/01/2018 14:38, Slawa Olhovchenkov wrote: On Fri, Jan 05, 2018 at 08:36:48PM +0700, Eugene Grosbein wrote: 05.01.2018 20:11, Slawa Olhovchenkov wrote: Irrelevant to RSS and etc. flowid distribution in lacp case work very bad. This is good and must be MFC (IMHO). It may work bad

Re: svn commit: r327559 - in head: . sys/net

On 05/01/2018 13:49, Eugene Grosbein wrote: 05.01.2018 16:26, Steven Hartland пишет: On 05/01/2018 02:01, Eugene Grosbein wrote: 05.01.2018 4:52, Steven Hartland wrote: RSS by definition has meaning to received stream. What is "outbound" stream in this context, why can the hash c

Re: svn commit: r327559 - in head: . sys/net

On 05/01/2018 13:41, Eugene Grosbein wrote: 05.01.2018 16:34, Steven Hartland wrote: I hope there's some improvements that can be made, for example if we can determine the stream was instigated remotely then flowid would always be valid hence we can use it assuming it matches the requested

Re: svn commit: r327559 - in head: . sys/net

/2018 02:55, Adrian Chadd wrote: does it also happen when you actually enable RSS in the kernel? Since like I went through a whole lot of pain to assign a flowid at connection setup time. -a On 4 January 2018 at 15:37, Steven Hartland <ste...@multiplay.co.uk> wrote: On 04/01/2018

Re: svn commit: r327559 - in head: . sys/net

On 05/01/2018 02:09, Eugene Grosbein wrote: 05.01.2018 6:37, Steven Hartland wrote: Our TCP stack seems fragile during setup to out of order packets which this multipath behavior causes, we've seen this on our loadbalancers which is what triggered the investigation. The concrete result is many

Re: svn commit: r327559 - in head: . sys/net

On 05/01/2018 02:01, Eugene Grosbein wrote: 05.01.2018 4:52, Steven Hartland wrote: RSS by definition has meaning to received stream. What is "outbound" stream in this context, why can the hash calculatiom method change and what exactly does it mean "a stream being incorrect

Re: svn commit: r327559 - in head: . sys/net

On 04/01/2018 22:42, hiren panchasara wrote: On 01/04/18 at 09:52P, Steven Hartland wrote: On 04/01/2018 20:50, Eugene Grosbein wrote: 05.01.2018 3:05, Steven Hartland wrote: Author: smh Date: Thu Jan 4 20:05:47 2018 New Revision: 327559 URL: https://svnweb.freebsd.org/changeset/base

Re: svn commit: r327559 - in head: . sys/net

On 04/01/2018 20:50, Eugene Grosbein wrote: 05.01.2018 3:05, Steven Hartland wrote: Author: smh Date: Thu Jan 4 20:05:47 2018 New Revision: 327559 URL: https://svnweb.freebsd.org/changeset/base/327559 Log: Disabled the use of flowid for lagg by default Disabled the use of RSS hash

svn commit: r327559 - in head: . sys/net

Author: smh Date: Thu Jan 4 20:05:47 2018 New Revision: 327559 URL: https://svnweb.freebsd.org/changeset/base/327559 Log: Disabled the use of flowid for lagg by default Disabled the use of RSS hash from the network card aka flowid for lagg(4) interfaces by default as it's currently

Re: svn commit: r325092 - head/usr.bin/fortune/datfiles

I’ve still had to use rehash on several occasions for it to detect new apps, so remove that reference might be a mistake On Sun, 29 Oct 2017 at 18:51, Cy Schubert wrote: > In message > om> > , Warner

Re: svn commit: r324983 - in head: lib/libc/sys sys/sys

Personally I would expect the fallback to be reboot as without the ability to power back on remotely e.g. IPMI this could render the machine inaccessible, which is not ideal, thoughts? On 25/10/2017 16:30, Warner Losh wrote: Author: imp Date: Wed Oct 25 15:30:20 2017 New Revision: 324983 URL:

Re: svn commit: r318751 - in head/sys: kern sys

Personally I hate that idea as like being able to see all the processes from the host. I have a similar hate of Linux containers where you have to jump though hoops just to see whats really happening on the host. On Sat, 21 Oct 2017 at 20:29, Allan Jude wrote: > On

Re: svn commit: r324449 - in head/sys/boot: arm/uboot efi/boot1 sparc64/loader

On Mon, Oct 9, 2017 at 5:56 PM, Steven Hartland <steven.hartl...@multiplay.co.uk <mailto:steven.hartl...@multiplay.co.uk>> wrote: Not sure which of these sets of changes caused the issue but a clean build from scratch is currently failing here with:

Re: svn commit: r324449 - in head/sys/boot: arm/uboot efi/boot1 sparc64/loader

Not sure which of these sets of changes caused the issue but a clean build from scratch is currently failing here with: In file included from /usr/home/smh/freebsd/base/head/sys/boot/efi/boot1/ufs_module.c:41: In file included from

Re: svn commit: r323566 - head/sys/kern

Is this something that will be MFC'ed to 11 or is this 12 / CURRENT only? On 13/09/2017 23:11, Gleb Smirnoff wrote: Author: glebius Date: Wed Sep 13 22:11:05 2017 New Revision: 323566 URL: https://svnweb.freebsd.org/changeset/base/323566 Log: Use soref() in sendfile(2) instead fhold() to

svn commit: r322881 - head/usr.bin/calendar/calendars

) @@ -333,6 +333,7 @@ 09/07 Chris Rees <cr...@freebsd.org> born in Kettering, United Kingdom, 1987 09/08 Boris Samorodov <b...@freebsd.org> born in Krasnodar, Russian Federation, 1963 09/09 Yoshio Mita <m...@freebsd.org> born in Hiroshima, Japan, 1972 +09/09 Steven Hartland <s

svn commit: r320138 - head/usr.sbin/bsdinstall/scripts

Author: smh Date: Tue Jun 20 08:03:50 2017 New Revision: 320138 URL: https://svnweb.freebsd.org/changeset/base/320138 Log: Fixed bsdinstall location of vfs.zfs.min_auto_ashift vfs.zfs.min_auto_ashift is a sysctl only not a tunable so updated bsdinstall to use the correct location

Re: svn commit: r316676 - in head/sys/netinet: . tcp_stacks

to 10 too would be nice.. thanks On 10/4/17 4:19 pm, Steven Hartland wrote: Author: smh Date: Mon Apr 10 08:19:35 2017 New Revision: 316676 URL: https://svnweb.freebsd.org/changeset/base/316676 Log: Use estimated RTT for receive buffer auto resizing instead of timestamps Switched from

svn commit: r316676 - in head/sys/netinet: . tcp_stacks

Author: smh Date: Mon Apr 10 08:19:35 2017 New Revision: 316676 URL: https://svnweb.freebsd.org/changeset/base/316676 Log: Use estimated RTT for receive buffer auto resizing instead of timestamps Switched from using timestamps to RTT estimates when performing TCP receive buffer auto

svn commit: r316460 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

Author: smh Date: Mon Apr 3 13:11:28 2017 New Revision: 316460 URL: https://svnweb.freebsd.org/changeset/base/316460 Log: Fix expandsz 16.0E vals and vdev_min_asize of RAIDZ children When a member of a RAIDZ has been replaced with a device smaller than the original, then the top level

Re: svn commit: r316311 - in head: lib/libstand sys/boot/geli sys/boot/i386/gptboot sys/boot/i386/loader sys/boot/i386/zfsboot

On 31/03/2017 16:16, Ian Lepore wrote: On Fri, 2017-03-31 at 00:04 +, Allan Jude wrote: Add explicit_bzero() to libstand, and switch GELIBoot to using it revolution > man explicit_bzero No manual entry for explicit_bzero revolution > svn log -v explicit_bzero.c ...

svn commit: r316328 - in head: . sys/netinet6

Author: smh Date: Fri Mar 31 09:10:05 2017 New Revision: 316328 URL: https://svnweb.freebsd.org/changeset/base/316328 Log: Allow explicitly assigned IPv6 loopback address to be used in jails If a jail has an explicitly assigned IPv6 loopback address then allow it to be used instead of

svn commit: r316313 - in head: . sys/netinet

Author: smh Date: Fri Mar 31 00:41:54 2017 New Revision: 316313 URL: https://svnweb.freebsd.org/changeset/base/316313 Log: Allow explicitly assigned IPv4 loopback address to be used in jails If a jail has an explicitly assigned loopback address then allow it to be used instead of

svn commit: r315449 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

Author: smh Date: Fri Mar 17 12:34:57 2017 New Revision: 315449 URL: https://svnweb.freebsd.org/changeset/base/315449 Log: Reduce ARC fragmentation threshold As ZFS can request up to SPA_MAXBLOCKSIZE memory block e.g. during zfs recv, update the threshold at which we start agressive

svn commit: r315423 - head/lib/libsysdecode

Author: smh Date: Thu Mar 16 20:55:00 2017 New Revision: 315423 URL: https://svnweb.freebsd.org/changeset/base/315423 Log: Fix libsysdecode vmprot flag decoding Fix the regex used to find vmprot table entries and add the missing include. This fixes kdumps output of PFLT arguments

Re: svn commit: r314155 - head/sys/netinet

You might also be interested in reviewing my fix for TCP buffer scaling too Michael. https://reviews.freebsd.org/D9668 This fixes slow transfers due to no receive buffer scaling if TCP timestamps aren't negotiated. Its still got debug stuff in it ATM and I'm toying with removing the

Re: svn commit: r313260 - head/sys/kern

On 07/02/2017 20:34, Ed Maste wrote: On 7 February 2017 at 10:30, Steven Hartland <steven.hartl...@multiplay.co.uk> wrote: All I'm suggesting is, while one could guess this may be a performance or possibly a compatibility thing, the reason is not obvious, so a small piece of detail

Re: svn commit: r313260 - head/sys/kern

On 07/02/2017 14:57, Mateusz Guzik wrote: On Sun, Feb 05, 2017 at 03:17:46PM +, Alexey Dokuchaev wrote: On Sun, Feb 05, 2017 at 04:00:06AM +0100, Mateusz Guzik wrote: For instance, plugging an unused variable, a memory leak, doing a lockless check first etc. are all pretty standard and

Re: svn commit: r313260 - head/sys/kern

On 05/02/2017 15:17, Alexey Dokuchaev wrote: On Sun, Feb 05, 2017 at 04:00:06AM +0100, Mateusz Guzik wrote: For instance, plugging an unused variable, a memory leak, doing a lockless check first etc. are all pretty standard and unless there is something unusual going on (e.g. complicated

Re: svn commit: r313260 - head/sys/kern

Hi Mateusz could you improve on the commit message as it currently describes what is changed, which can be obtained from the diff, but not why? I hope on one feels like I'm trying to teach them to suck eggs, as I know everyone here has a wealth of experience, but I strongly believe commit

svn commit: r311769 - head/usr.bin/netstat

Author: smh Date: Mon Jan 9 09:28:03 2017 New Revision: 311769 URL: https://svnweb.freebsd.org/changeset/base/311769 Log: Fix rstat: symbol not in namelist from netstat Load kvm symbols earlier to prevent rstat: symbol not in namelist error when running netstat -rs. Submitted by:

Re: svn commit: r311346 - in head/sys: kern sys vm

Given the use of the number of CPU's for sizing would this play nice with hot plug CPU's? Regards Steve On 05/01/2017 01:44, Mark Johnston wrote: Author: markj Date: Thu Jan 5 01:44:12 2017 New Revision: 311346 URL: https://svnweb.freebsd.org/changeset/base/311346 Log: Add a

Re: svn commit: r310112 - head/sys/conf

Thanks for doing this :) On 15/12/2016 12:57, Ed Maste wrote: Author: emaste Date: Thu Dec 15 12:57:03 2016 New Revision: 310112 URL: https://svnweb.freebsd.org/changeset/base/310112 Log: newvers.sh: add option to eliminate kernel build metadata Build metadata (username, hostname,

Re: svn commit: r308782 - in head: cddl/contrib/opensolaris/cmd/ztest sys/cddl/contrib/opensolaris/uts/common/fs/zfs sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys

Thanks, looks like the PR needs a rebase before it can be merged. On 17/11/2016 22:11, Alexander Motin wrote: It is in OpenZFS review queue now: https://github.com/openzfs/openzfs/pull/219 Welcome to comment there to speed up the process. On 17.11.2016 13:43, Steven Hartland wrote

Re: svn commit: r308782 - in head: cddl/contrib/opensolaris/cmd/ztest sys/cddl/contrib/opensolaris/uts/common/fs/zfs sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys

Is this something that should be upstreamed? On 17/11/2016 21:01, Alexander Motin wrote: Author: mav Date: Thu Nov 17 21:01:27 2016 New Revision: 308782 URL: https://svnweb.freebsd.org/changeset/base/308782 Log: After some ZIL changes 6 years ago zil_slog_limit got partially broken due

Re: svn commit: r307507 - head/sys/cam/scsi

On 17/10/2016 09:51, Alexander Motin wrote: On 17.10.2016 11:45, Steven Hartland wrote: IIRC the timeout for this was intentionally lower than the default, might be worth just checking. I did traced back the commit history, and it was hardcoded to that value since the beginning 18 years ago

Re: svn commit: r307507 - head/sys/cam/scsi

IIRC the timeout for this was intentionally lower than the default, might be worth just checking. On 17/10/2016 09:35, Alexander Motin wrote: Author: mav Date: Mon Oct 17 08:35:56 2016 New Revision: 307507 URL: https://svnweb.freebsd.org/changeset/base/307507 Log: Consider device as clean

svn commit: r303971 - head/sys/dev/virtio/network

Author: smh Date: Thu Aug 11 21:13:58 2016 New Revision: 303971 URL: https://svnweb.freebsd.org/changeset/base/303971 Log: Fix vtnet hang with max_virtqueue_pairs > VTNET_MAX_QUEUE_PAIRS Correctly limit npairs passed to vtnet_ctrl_mq_cmd. This ensures that VQ_ALLOC_INFO_INIT is called

svn commit: r302382 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

Author: smh Date: Wed Jul 6 23:49:19 2016 New Revision: 302382 URL: https://svnweb.freebsd.org/changeset/base/302382 Log: Fix ZFS ARC min / max tunable Due to ARC initial configuration not being done and kmem information not being available we need to blindly set zfs_arc_max and

svn commit: r302265 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

Author: smh Date: Wed Jun 29 07:55:45 2016 New Revision: 302265 URL: https://svnweb.freebsd.org/changeset/base/302265 Log: Allow ZFS ARC min / max to be tuned at runtime Prior to this change ZFS ARC min / max could only be changed using boot time tunables, this allows the values to be

svn commit: r301131 - head/usr.sbin/tzsetup

Author: smh Date: Wed Jun 1 15:39:11 2016 New Revision: 301131 URL: https://svnweb.freebsd.org/changeset/base/301131 Log: Fix tzsetup not installing /etc/localtime for UTC If tzsetup UTC is run then it successfully configured the system for UTC including installing /etc/localtime

Re: svn commit: r300219 - in head/sys: kern sys

I thought it was considered better to use if (var == NULL) instead of if (!var) for pointers as they aren't bools? > On 19 May 2016, at 18:14, Scott Long wrote: > > Author: scottl > Date: Thu May 19 17:14:24 2016 > New Revision: 300219 > URL:

Re: svn commit: r295707 - in head/sys: cddl/contrib/opensolaris/uts/common/fs/zfs dev/mmc dev/virtio/block geom geom/journal geom/mirror geom/raid geom/raid3 kern

On 09/05/2016 18:21, Warner Losh wrote: On May 9, 2016, at 11:14 AM, Steven Hartland <ste...@multiplay.co.uk> wrote: On 09/05/2016 18:04, Alan Somers wrote: On Wed, Feb 17, 2016 at 10:16 AM, Warner Losh <i...@freebsd.org> wrote: Author: imp Date: Wed Feb 17 17:16:02 2016

Re: svn commit: r295707 - in head/sys: cddl/contrib/opensolaris/uts/common/fs/zfs dev/mmc dev/virtio/block geom geom/journal geom/mirror geom/raid geom/raid3 kern

On 09/05/2016 18:04, Alan Somers wrote: On Wed, Feb 17, 2016 at 10:16 AM, Warner Losh > wrote: Author: imp Date: Wed Feb 17 17:16:02 2016 New Revision: 295707 URL: https://svnweb.freebsd.org/changeset/base/295707 Log:

Re: svn commit: r298244 - head/sbin/dumpon

On 19/04/2016 06:01, Marcelo Araujo wrote: 2016-04-19 12:58 GMT+08:00 Pedro Giffuni >: On 04/18/16 23:28, Marcelo Araujo wrote: Author: araujo Date: Tue Apr 19 04:28:25 2016 New Revision: 298244 URL:

Re: svn commit: r298002 - in head/sys: cam cam/ata cam/scsi conf dev/ahci

Great to see this hitting the tree Warner, I have a few questions inline below. On 14/04/2016 22:47, Warner Losh wrote: Author: imp Date: Thu Apr 14 21:47:58 2016 New Revision: 298002 URL: https://svnweb.freebsd.org/changeset/base/298002 Log: New CAM I/O scheduler for FreeBSD. The default

Re: svn commit: r297813 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

Thanks for the heads up Andriy fixed with r297819 On 11/04/2016 12:49, Andriy Gapon wrote: On 11/04/2016 11:57, Steven Hartland wrote: Author: smh Date: Mon Apr 11 08:57:54 2016 New Revision: 297813 URL: https://svnweb.freebsd.org/changeset/base/297813 Log: Only include sysctl in kernel

svn commit: r297819 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

Author: smh Date: Mon Apr 11 13:17:11 2016 New Revision: 297819 URL: https://svnweb.freebsd.org/changeset/base/297819 Log: Only include sysctl in kernel build Only include sysctl in kernel builds fixing warning about implicit declaration of function 'sysctl_handle_int'. PR:

svn commit: r297813 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

Author: smh Date: Mon Apr 11 08:57:54 2016 New Revision: 297813 URL: https://svnweb.freebsd.org/changeset/base/297813 Log: Only include sysctl in kernel build Only include sysctl in kernel builds fixing warning about implicit declaration of function 'sysctl_handle_int'. Sponsored

Re: svn commit: r297762 - head/sys/dev/ichiic

On 09/04/2016 22:00, John Baldwin wrote: On Saturday, April 09, 2016 09:29:57 PM Steven Hartland wrote: Hi John, it would be nice if the commit message clarified why the change was made, as well as what was changed. This would allow others like myself to learn about the reasons for changes like

Re: svn commit: r297762 - head/sys/dev/ichiic

Hi John, it would be nice if the commit message clarified why the change was made, as well as what was changed. This would allow others like myself to learn about the reasons for changes like this, which aren't self explanatory. On 09/04/2016 21:18, John Baldwin wrote: Author: jhb Date: Sat

svn commit: r296922 - head/sys/dev/ixgbe

Author: smh Date: Wed Mar 16 01:41:55 2016 New Revision: 296922 URL: https://svnweb.freebsd.org/changeset/base/296922 Log: Prevent invalid ixgbe advertise setting warning Prevent ixgbe outputting "Invalid advertised speed" warning on boot with no customisations by moving test from sysctl

Re: svn commit: r296610 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

When processing the MFC of this I noticed there's lots of merge info @ sys/cddl/contrib/opensolaris. I've removed this from the MFC request but wondered if we should clean up HEAD so this doesn't accidentally get merged? On 10/03/2016 09:01, Alexander Motin wrote: Author: mav Date: Thu Mar

svn commit: r296354 - head/sys/dev/ixl

Author: smh Date: Thu Mar 3 19:49:37 2016 New Revision: 296354 URL: https://svnweb.freebsd.org/changeset/base/296354 Log: Fix ixl with RSS Fix compilation of ixl when RSS option is set, broken by r295946 MFC after:3 weeks X-MFC-With: r295946 Sponsored by: Multiplay

svn commit: r296021 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

Author: smh Date: Thu Feb 25 03:01:24 2016 New Revision: 296021 URL: https://svnweb.freebsd.org/changeset/base/296021 Log: Removed unused label and fix mutex_exit order Remove unused done label from zfs_setacl fixing PVS-Studio V729. Fix mutex_exit order to mirror the mutex_enter

svn commit: r296020 - head/sys/dev/mrsas

Author: smh Date: Thu Feb 25 02:46:47 2016 New Revision: 296020 URL: https://svnweb.freebsd.org/changeset/base/296020 Log: Fix NULL pointer dereferences Fix NULL pointer dereferences identified as V522 by PVS-Studio. MFC after:1 week Sponsored by: Multiplay Modified:

svn commit: r295356 - in head/sys/boot: common efi/boot1

Author: smh Date: Sat Feb 6 22:01:25 2016 New Revision: 295356 URL: https://svnweb.freebsd.org/changeset/base/295356 Log: Fix EFI platform build failures With warnings now enabled some plaforms where failing due to warnings. * Fix st_size printed as a size_t when its actually an off_t.

svn commit: r295320 - in head/sys/boot/efi: boot1 include

Author: smh Date: Fri Feb 5 15:35:33 2016 New Revision: 295320 URL: https://svnweb.freebsd.org/changeset/base/295320 Log: Fix EFI multi device boot support Fix EFI boot support when presented with multiple valid boot partitions across multiple devices. It now prefers to boot from

Re: svn commit: r295099 - head

Nice addition Ian, could we get information on this added to build(7) please? Regards Steve On 31/01/2016 17:32, Ian Lepore wrote: Author: ian Date: Sun Jan 31 17:32:58 2016 New Revision: 295099 URL: https://svnweb.freebsd.org/changeset/base/295099 Log: Add make universe targets

  1   2   3   4   5   >